- 15 Mar, 2019 40 commits
-
-
Jazz Xu authored
Handle arrow keys for volume up/down, seek forward/backward. Bug: 942151 Change-Id: I71ba2f6d557fa824535c5fbfa4a5b87dca119239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522335Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641068}
-
Harley Li authored
The number of entries stored in an object store is an important metadata. Bug: 941197 Change-Id: I8166a106593fecb34428825787e884f51d11963b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512692 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641067}
-
Anand K. Mistry authored
The return value of MDnsClient::StartListening() changed from a bool to an int, which effectively inversed the result. BUG=942390 Change-Id: I808836086203f3500c94160784d8135b4de8926d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525254Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#641066}
-
Eugene But authored
For new navigations GetPendingItem() may not return the item associated with current navigation. So existing code incorrectly computed pending item URL when there are more than one pending navigations. This CL fixes the computation of pendingURL by using pending URL from NavigationContext for new navigations. Bug: 899827 Change-Id: Iea949ef96d64d40c28d38fdb21af127fdd0fff6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519331 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#641065}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8320e6d2b742..34e6c9d3d1b6 git log 8320e6d2b742..34e6c9d3d1b6 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 fmayer@google.com Use relaxed increment for stats in ring buffer. Created with: gclient setdep -r src/third_party/perfetto@34e6c9d3d1b6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:126724929 TBR=perfetto-bugs@google.com Change-Id: I5b740b6b752ed62d7a469fce2f7f1441baa8ce81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641064}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5625b6320279..d263d752ac35 git log 5625b6320279..d263d752ac35 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 hao.x.li@intel.com Fix scissor rect larger than render pass width/height in Metal backend Created with: gclient setdep -r src/third_party/dawn@d263d752ac35 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I29c074bf7255a3d60dffb1dc392e237461fa9f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525523Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f6dd8f7..e6ea6c00 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3463a17314e1fb321c7e4dbf291835f810d3e463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525448Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641062}
-
Austin Eng authored
This function now returns a Promise instead of getting an adapter synchronously. GPUAdapterDescriptor is renamed to GPURequestAdapterOptions. Bug: 941531 Change-Id: If8a996fe15adc6301f7378ce15f084cba1ae2601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521235 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641061}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib942d816a32db8edc45e5206cc8acea8fc3842a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525414Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641060}
-
Kenneth Russell authored
It's been upgraded to Mesa 18.3.3 from 18.0.5. Bug: 928530 Change-Id: I2cebf3cfe028ed4e3108b021fc5277c818b66943 Tbr: sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525407Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641059}
-
dpapad authored
Before/after screenshots: https://imgur.com/a/0NpIjAz Bug: None Change-Id: I0a8db2d980ae58c489e4375e2d83505eabc424b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524715Reviewed-by:
Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641058}
-
Nate Fischer authored
I added some tests to the filter in http://crrev/c/1522556. I forgot that "#" is illegal, and I should use "." instead. TBR=timvolodine@chromium.org Bug: 941856, 941858 Test: N/A Change-Id: I153abf26f9098460e2e9f2a6454978ae3682c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525413Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641057}
-
Paul Dyson authored
Disable UserActivityManagerTest.BasicTabs as it has been flagged as flaky. Also disable WindowActivityWatcherTest.Basic and WindowActivityWatcherTest.ReplaceTab which sometimes fail at the same time as UserActivityManagerTest.BasicTabs. Bug: 938055 Change-Id: Ib8c8ce28e565cd032a5d1255a6e355a449679e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504474Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641056}
-
Sergiy Belozorov authored
R=perezju@chromium.org Bug: 895891 Change-Id: I2f363662f6f9ce4da0c6c76674db94c0404fa21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523093 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#641055}
-
Darren Shen authored
Change-Id: I3a21355822ad2c8e4b59c542471e280b656e6500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520859 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#641054}
-
Nigel Tao authored
BUG=826982 Change-Id: Id697f87ffb5dc143caea60fc02fd91133cb60938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522869Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641053}
-
Becca Hughes authored
Return the ID from RequestAudioFocus which the media session can then be used to identify itself. This is for assistant so they can differentiate between the AssistantMediaSession and other sessions when controlling them. BUG=941578 Change-Id: Ie114c36b111e79125c918b9964196b3434d1294e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521472Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641052}
-
Robert Liao authored
BUG=714018,940130 TBR=sky@chromium.org Change-Id: I2dcacc52febbe0aeb72e90fe390239d1cb9ac201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525481Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641051}
-
Yupei Lin authored
While following the steps from docs/graphical_debugging_aid_chromium_views.md using gdb. Change-Id: Ic4d2193c29604bc548bdb6c84e8f0f70684366e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522560Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641050}
-
Shu Chen authored
Currently the mojom for ui::TextInputType is under ui/platform_window/mojo, and the typemap is under services/ws/public/mojom/ime. It will cause problem if some other code wants to use ui.mojom.TextInputType. ui::TextInputType is defined under ui/base/ime, where the mojom and typemap should be. Bug: 937167 Change-Id: Ie62a49e7d9f0be5d8f6b9038b581543b8d9ca0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517339Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a2749f39f47d..9b156615197d git log a2749f39f47d..9b156615197d --date=short --no-merges --format='%ad %ae %s' 2019-03-14 bclayton@google.com SpirvShader: Split instructions into blocks. 2019-03-14 capn@google.com Fix allocation of low-alignment memory Created with: gclient setdep -r src/third_party/swiftshader@9b156615197d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5385d7628f5985a5085977d08495951d0c8569a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525034Reviewed-by:
-
Christian Biesinger authored
Change-Id: I9c0c299f8aa576ea34f357ac88c2c79c0a50fb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1315669 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641047}
-
Qingsi Wang authored
Our previous implementation would destroy the connection to the mDNS responder service host when the media capture permission is granted. As a result, any mDNS candidate created before the grant would become unresolvable. This issue is particularly evident when we have multiple peer connections of the same origin, where a newly created peer connection would temporarily toggle the permission to blocked before restoring the granted status if the user did give the permission. This could cause a peer connection created earlier and in the process of ICE candidate gathering to perform unnecessary mDNS obfuscation. After this change, the connection to the mDNS responder service host keeps alive, but just becomes unavailable for registration of new names when we have permissions granted. Bug: 930339, 937992 Change-Id: I8ccdf0e6b578bc9e327337c6fbd102cdc542d15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522687 Commit-Queue: Qingsi Wang <qingsi@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641046}
-
Ben Hayden authored
Some benchmarks such as rendering.mobile produce more data than the chromeperf dashboard can handle at once. This CL passes the new --max_bytes flag to add_reserved_diagnostics to batch histograms into multiple files, then uploads them one at a time. Initial CL: https://chromium-review.googlesource.com/c/1478085 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/1486679 Reason for revert: File "...\upload_results_to_perf_dashboard.py", line 61, in _GenerateDashboardJSONs with open(options.output_json_file, 'w') as f: TypeError: coercing to Unicode: need string or buffer, file found Patchset 1 is the initial CL. Patchset 5 simplifies the initial approach and adds a test. Bug: chromium:909961 Change-Id: Ia66cff24531333ecea386785ccbae04e7386f633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515649 Commit-Queue: Ben Hayden <benjhayden@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#641045}
-
Siye Liu authored
if the block element is at selection end. This patch adds a logic in blink::StyledMarkupSerializer<Strategy>::CreateMarkup and blink::StyledMarkupTraverser<Strategy>::Traverse so that the empty block element that only contains br element can be appended to blink::StyledMarkupAccumulator if the block element is at the end of selection during copy. The logic helps in creating the right markup to put onto clipboard during serialization. For example, <i>some text</i><p><br></p>, select all and copy, clipboard content should be look like: <!--startFrament--><i>some text</i></font><p><br></p><!--EndFragment--> Bug: 856324 Change-Id: Idd55bde473d4e6b3d7bf06b62167dd227ae65672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495371 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641044}
-
Becky Zhou authored
We simplified the location bar text color logic to be mostly based on the primary color at https://chromium-review.googlesource.com/c/chromium/src/+/1489416. This becomes an issue for the search widget because the primary color was transparent all the time. Bug: 940897 Change-Id: I16db7596d9a0db0ee277a106b5b890be2045e391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525286Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641043}
-
Rohit Rao authored
https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/0146bd6e1f05..57586e721389 $ git log 0146bd6e1..57586e721 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 haowoo Move the block from the stack to the heap before assigning it to the weak pointer. Created with: roll-dep src/ios/third_party/edo/src BUG=941680 Change-Id: Id616069d5894a535839547169669d49b02648e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524653Reviewed-by:
-
Peter Boström authored
This change removes InkDropContainerView usage and overrides of: * AddInkDropLayer * RemoveInkDropLayer * CreateInkDrop * CreateInkDropRipple * CreateInkDropHighlight * CreateInkDropMask ... and replaces them with a HighlightPath already in use by the FocusRing. Bug: None Change-Id: Id347f19d32f8b38443092eedd6604c71c5d9e6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525462 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#641041}
-
John Z Wu authored
Several member variables of WebViewRequestContextGetter may attempt to access net::NetLog during destruction, but since the latter gets destructed *after* the former, it can easily lead to dangling pointer issues. The fix is to just ensure those member variables are destroyed before net::NetLog so they can still access it safely. Alternatively, we can also just reorder the member variable list. Change-Id: I768f235fc8f62835fdcab603b254a87620ab046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525446 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#641040}
-
G. Silva authored
last one was reverted. This time, a separated test binary is used to avoid dependency clashes between protobuf libs. Bug: 935711 Change-Id: I0789418f3a2c6c959845a1926f21832dcd0c389d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515206 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641039}
-
Ken Rockot authored
We were missing some goog.provide directives for generated interface types. This also removes usage of mojo.internal.exportModule when we're generating goog.provide, since only one of the two is necessary. Bug: 939680 Change-Id: I1f813fe9cebb3cac6b68c2e86cff650fcf51ed21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524331Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#641038}
-
Leon Han authored
A provider host on creation is always added into ServiceWorkerContextCore and owned there, later it'll destroy either when ServiceWorkerContextCore destroys or the Mojo connection it's bound breaks. This CL refactors code to strengthen the logic above. BUG=931092 Change-Id: I8feaebec0e1c539ad5e24bde3af7518e2f81aa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522559 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641037}
-
Becky Zhou authored
+ bar background to grey 900 + 6% white in dark mode + promo background to grey 100 in light, grey 900 to dark + icon colors for close button and arrow button Bug: 934580 Change-Id: I35ed4db9ba156c92223e4e2aa9f48c22e1e2a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521770Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641036}
-
Leon Han authored
Previously the browser-assigned provider id was a negative int going down from -2, to differentiate from the renderer-assigned provider id which has non-negative value. Now the renderer-assigned provider id has gone away with https://crrev.com/c/1520688 and we just have all provider ids created in the browser process, so we can make it be non-negative to be more like of an ID. BUG=931092 Change-Id: Icdc9933cc04e13c823e0a733d963f1f4411abf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522557 Commit-Queue: Leon Han <leon.han@intel.com> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If46e19cad054575896ac34ed44f96efc4460c58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525348Reviewed-by:
-
Karan Bhatia authored
This adds support for loading/re-indexing multiple rulesets in FileSequenceHelper. No behavior changes are made in this CL. This is in preparation of adding support for dynamic rules and possibly multiple static rulesets. BUG=930961 Change-Id: I13c99a3e5a89f7615317a04e08ecd5fc52464a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519548 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641033}
-
Alex Danilo authored
The Open button in the quickview panel was changed from an icon to text to match the main FilesApp panel. This change removes the tooltip, since it's redundant. Bug: 941956 Change-Id: I1cd38e8787a56fe9a8647a5793314dbfcb1866fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525248 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641032}
-
Vladislav Kaznacheev authored
This reverts commit fb08feb5. Reason for revert: caused a crash (http://crbug.com/939667) Original change's description: > app_list: Set AppList as parent of uninstall dialog > > Currently, when the uninstall dialog is opened from the Launcher, the Launcher > is dismissed, which is confusing to the user. By parenting the dialog to the > Launcher, the UX is much better. > > Because we cannot directly access Ash windows anymore, this fix requires us to > explicitly set the dialog's parent window via MUS properties. > > TEST=manually verified + new browser tests > BUG=814619 > > Change-Id: Ic25cb376191aaba8048f95fa5d0032b0328b8bc8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496447 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Tim Song <tengs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638016} TBR=xiyuan@chromium.org,tengs@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814619 Change-Id: I7dd1c47d2edfc19fddd4302ae0b7fb1e42d835ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525273Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#641031}
-
Michael Giuffrida authored
Make HomeScreenController responsible for determining home screen visibility instead of AppListControllerImpl, including updates based on window dragging and wallpaper preview. The app list controller now implements HomeScreenDelegate::ShowHomeScreen() to show the full-screen app list window. Also adds IsHomeScreenAvailable() which should be used to determine whether to use the home screen instead of checking tablet mode directly. Bug: 937549 Change-Id: If864614e7dcc4a818dc5368cf5e68e9475afacb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504847 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641030}
-
Luciano Pacheco authored
Fix directory tree context menu for removable partitions when they're grouped with a common root, where the "format" option wasn't shown. Directory tree has 2 context menus root and non-root menus, when partitions are grouped it's using a non-root menu which didn't have the "format" command. This CL add the "format" command to non-root menu and fix the condition to only display for removable root. Bug: 941174 Change-Id: I27ff6f8e1813f84d76341c6abd4376a0743c14d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522508Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641029}
-
