- 21 Dec, 2020 40 commits
-
-
Nico Weber authored
TBR=ellyjones Bug: 1149587 Change-Id: Id4c8e205a050ed96c77f6bbaf19edc57e711e785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599799Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#838701}
-
Joel Hockey authored
DataDevice::OnPerformDrop() has a nested RunLoop() and the current object can be destroyed inside that loop. Bug: 1160553, 1160925 Change-Id: I09872e5f88d4d5c3e582ce7b3e6e4085afed0518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598519 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima (slow: gardener) <oshima@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#838700}
-
Xiaoqian Dai authored
Bug: 1160367 Change-Id: If3ebbe49d221e41bd19f495fcadb5881a0252e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600043Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#838699}
-
Xida Chen authored
There are a few layout tests under css-backgrounds/ that are flaky and no bug is associated with them. Because they are flaky, the virtual/ version are also flaky. This CL updates the bug number associated with them. Bug: 1160916, 1148369 Change-Id: I842670c047066dd94b6a082e4645249ced8f07bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600019Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838698}
-
Frank Liberato authored
Bug: 1160922 TBR: rsesek Change-Id: I6e1e2868b8dfd3dd2079cf69ea4688b30d5ae2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600039Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#838697}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608551422-fc95b9f468d4d803d74a281f45985087ff3374a0.profdata to chrome-mac-master-1608573074-c037592ba2f8332cc5c933010a8eab8414fcad34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie227d55837e29587450f16b5f524475efb58e277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838696}
-
Erik Jensen authored
This script, if present, will always be run before the user's configured session. The user's session will start if and only if the pre-session script returns successfully. Change-Id: I1e2fcb427c72cf102bb5e8da8ccf36d8209584c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595791 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#838695}
-
Donn Denman authored
Fixes a bug that caused the SERP to show blank. This was actually due to preloading when that was inappropriate (on a literal tap) when the user had accepted the opt-in. This CL fixes the logic to make sure we have a resolving gesture before we prefetch - server access is gated on the resolve since it's the primary server request. The Cl with the bug is https://crrev.com/c/2557337. BUG=1160041 Change-Id: Ida97ffb037022b039c5d843f770edd2907716836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597886 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#838694}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd212973. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ifc01b8e667be2b8d60c1b2602d02551b652746d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599868Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838693}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608508387-093abbef3f1d2d94b454a0cdd869bb44780245e6.profdata to chrome-win64-master-1608560380-1035bf8a36b405614508f1a548443341a120ef85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0c1c6d9bd7f6453f267de8fd1da9781b407e6020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599825Reviewed-by:
-
Vincent Palatin authored
The cellular code in shill can now configure an Attach APN for the LTE connections by using the data in the Mobile Operators DB. For now, the feature is disabled by default until it is fully baked as extensive testing requires to use it on various carrier network over the world. Bug: b:160812573 b:170367556 Change-Id: I196a2ade76557369c0af6ecb46b048af4266204e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584932 Commit-Queue: Vincent Palatin <vpalatin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#838691}
-
Mario Sanchez Prada authored
As agreed on [1], media::mojom::MediaPlayer::SetMediaPlayerObserver() is not the right method to expose in that interface since it should be possible to register more than one observer for MediaPlayer related events outside of the renderer process, so this CL migrates that old method into a new AddMediaPlayerObserver() one. [1] https://crrev.com/c/2526440/21#message-2189f6a0f6328b9cb01e5be9b4fae80ec7e1f080 Bug: 1039252 Change-Id: Ifb55f6c6eb896de02608df98654bc62ff7e7ee17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595049 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#838690}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e02962c02f81..37fb5ece29fd 2020-12-21 brcui@microsoft.com Fix Pretty-Print Infobar not working If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159531 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8a8c716415e4340693419030f627554d5a187994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599487Reviewed-by:
-
Frank Liberato authored
DragAllToSeparateWindow and ...AndCancel were previously disabled for mac-arm-64, but are failing on other macs as well. This turns them off for all macs. Bug: 1160917 Change-Id: Iaba32424b597905c9a7b35a083fe14e9d4d26948 TBR: tbergquist Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600036Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id2454d351edbfc1e975a3afbc4cd6b62aa1ecb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599823Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88883c4ca259..6aea07880248 2020-12-21 reed@google.com Don't use sprite-blit if cubic sampling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Ia06e160fd0065a972f1b241d605cf6bb1c8b7898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599388Reviewed-by:
-
Tarun Bansal authored
Change-Id: Id886d3ef45eb73ca4e9b97174e0183f6fa9457e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576505 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#838685}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3974e6736435..7f541a18c4f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156847 Tbr: juanmihd@google.com Change-Id: Ie3f4235d5e680fae833f87915dcc1b4bd5d3d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838684}
-
Sam Maier authored
This reverts commit 9fc47234. Reason for revert: Stopped renaming GMS_VERSION_NUMBER - won't cause compile errors now Original change's description: > Revert "Reland "GMSCore API availability function for specific versions"" > > This reverts commit 6fb713b3. > > Reason for revert: Renamed GMS_VERSION_NUMBER > > Original change's description: > > Reland "GMSCore API availability function for specific versions" > > > > This reverts commit 0de6ec1b. > > > > Reason for reland: > > > > Original change's description: > > > Revert "GMSCore API availability function for specific versions" > > > > > > This reverts commit 6a6c700a. > > > > > > Reason for revert: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8860631130980203728/+/steps/compile__with_patch_/0/stdout > > > > > > Original change's description: > > > > GMSCore API availability function for specific versions > > > > > > > > Change-Id: Ie431852d225659e8b24bfec9c09d7c043924660f > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595929 > > > > Commit-Queue: Sam Maier <smaier@chromium.org> > > > > Reviewed-by: David Van Cleve <davidvc@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#838236} > > > > > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > > > > > Change-Id: Iac1a894b3d3adaa58c0fcfefd407cd8db82b3e56 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597817 > > > Reviewed-by: Sam Maier <smaier@chromium.org> > > > Commit-Queue: Sam Maier <smaier@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#838253} > > > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Change-Id: I5f677795de16199bf54804a60e8460ae160af4fb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597818 > > Reviewed-by: Sam Maier <smaier@chromium.org> > > Reviewed-by: David Van Cleve <davidvc@chromium.org> > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#838659} > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > Change-Id: I512c518f0c99cbd7cec497943c703d0eb0d6a554 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595844 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838668} TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org Change-Id: I3593475785926da93293fc877c2709d864fb8fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600017Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#838683}
-
Hui Yingst authored
This CL moves |paint_manager| to PdfViewPluginBase since it's used for both OutOfProcessInstance and PdfViewWebPlugin, and provides a protected accessor to it. Bug: 1099020 Change-Id: I4afcba717322116f2409dac4e4c10a45d520ae83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597759Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#838682}
-
Monica Basta authored
The 'cr-grid' has a special handling for the 'Enter' key stroke that requires the 'on-click' event to be on the focused element. This CL moves the 'on-click' event to the container of the 'cr-theme-icon'. Bug: 1158411 Change-Id: I5b417c0cf188754a9c5432d17f530d42f1ba5a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599862Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#838681}
-
Peng Huang authored
Bug: 1153156 Change-Id: I6c5353a19232f363c66bd49e8f880976655f28b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598623 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#838680}
-
Tarun Bansal authored
Change-Id: Iecd02372a3398ae623b852b0439230439b425722 Bug: 1158209 TBR: nator@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596035 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#838679}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b96d7e2a..a89143c8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia1e9da18cb79c0431e83f12b3a72f62e97ae517a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599761Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838678}
-
Christopher Cameron authored
Merge all code for creation into ImageData::ValidateAndCreate and add TODOs for behavior that is probably not intentional. TBR=fserb Bug: 1160105 Change-Id: I99d0e276b7ae3fe0984467488894b858586c4617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599236Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#838677}
-
Nohemi Fernandez authored
With the stricter restrictions due to ITP in iOS 14, Chrome can no longer be sure that it has an accurate snapshot of the cookie state based on past actions. ITP can remove cookies during the lifetime of the app, therefore we prefer to remove any false assumptions that internal cached data may provide. Bug: 1157475 Change-Id: Iade8c39cc2ea18b0e3c51483e6efab6570910f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596262 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#838676}
-
Nektarios Paisios authored
This is required in order to be able to push_back already created tree managers into standard vectors and other containers. A collection of TestAXTreeManagers needs to be created in order to effectively write tests that work with a forest of accessibility trees, as a consequence of porting Views to use an AXTree. Split out from a larger patch that makes AXPosition work with a forest of accessibility trees at: https://chromium-review.googlesource.com/c/chromium/src/+/2595454 AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: I14658cd64766a6d5d7c2b1d283dc0464d871f352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598624 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838675}
-
Frank Liberato authored
Full test name: ThreadJoinNotBlockedDuringConnectionTeardown_WatchdogNotFired Bug: 1160702 TBR: garykac Change-Id: I9f182d687bdfb056f81762a09abc42c8cde02793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599643Reviewed-by:
-
Judy Wang authored
notification. This CL adds metrics for record the user's quick action taken on screenshot notification, Including Edit, Delete and go to file. Test: manual + added Bug: 1140182 Change-Id: I616b26c66fa9986234a2863a3b494dc638f098af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553873 Commit-Queue: Judy Wang <shidi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#838673}
-
Evan Stade authored
Bug: 1152278 Change-Id: Ib789f8f424d76945b10632a078c1137d416d5dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598096Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.125. R=hans@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: I1c61f5575e1a3ffad1c6eb5041616ce72ee8e9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597647 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#838671}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.58. R=dpranke@google.com, rmhasan@google.com Bug: 1041619 Change-Id: I2ba19e237861dff57974cbd59bd8bcca9b5a34f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597648 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Mario Sanchez Prada authored
To implement media::mojom::MediaPlayer::AddMediaPlayerObserver(), as part of crrev.com/c/2595049, we need to manage a set of mojo remotes in Blink's HTMLMediaElement, which we can't do at the moment due to the lack of a HeapMojoRemoteSet class. This CL implements that class in a similar way to how the HeapMojoReceiverSet class is already implemented, including the relevant unit tests, as well as a small addition to mojo::RemoteSet so that we can pass a TaskRunner when adding a remote to the set (similar to what's already available for mojo::ReceiverSet). [1] https://crrev.com/c/2526440/21#message-2189f6a0f6328b9cb01e5be9b4fae80ec7e1f080 Bug: 1039252 Change-Id: Ic4eccecef49953cf0ba58d3e7454ed3c63f80984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599522Reviewed-by:
-
Sam Maier authored
This reverts commit 6fb713b3. Reason for revert: Renamed GMS_VERSION_NUMBER Original change's description: > Reland "GMSCore API availability function for specific versions" > > This reverts commit 0de6ec1b. > > Reason for reland: > > Original change's description: > > Revert "GMSCore API availability function for specific versions" > > > > This reverts commit 6a6c700a. > > > > Reason for revert: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8860631130980203728/+/steps/compile__with_patch_/0/stdout > > > > Original change's description: > > > GMSCore API availability function for specific versions > > > > > > Change-Id: Ie431852d225659e8b24bfec9c09d7c043924660f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595929 > > > Commit-Queue: Sam Maier <smaier@chromium.org> > > > Reviewed-by: David Van Cleve <davidvc@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#838236} > > > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > > > Change-Id: Iac1a894b3d3adaa58c0fcfefd407cd8db82b3e56 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597817 > > Reviewed-by: Sam Maier <smaier@chromium.org> > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#838253} > > TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org > > # Not skipping CQ checks because this is a reland. > > Change-Id: I5f677795de16199bf54804a60e8460ae160af4fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597818 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: David Van Cleve <davidvc@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838659} TBR=smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,davidvc@chromium.org Change-Id: I512c518f0c99cbd7cec497943c703d0eb0d6a554 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595844Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/00e1aac922ec..e02962c02f81 2020-12-21 jacktfranklin@chromium.org Fix double serving of files in component server 2020-12-21 andoli@chromium.org Change sources and profiler meta files imports to shell.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1304ddcb182e4cdefd460125f99da77581451226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599827Reviewed-by:
-
Jérôme Lebel authored
When the Google Services cell is updated, its size needs to be updated too. Switching from -[UITableViewController reconfigureCellsForItems:] to -[UITableViewController reloadCellsForItems:withRowAnimation:], when being updated. Fixed: 960871 Change-Id: I12d07eea8e8fc2ff56cdc5faeec1de2e49fa4f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596304 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#838666}
-
Javier Ernesto Flores Robles authored
Bug: 1156847 Change-Id: Ie15241942f1a22666ad2e9cf3a12927a8d18fc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597401Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#838665}
-
Robbie Gibson authored
When tapping Done on recent tabs, the tab grid shows a tab in the activePage, without changing the actual tab grid. However, when the tab grid is opened again, the tab grid still shows recent tabs. To fix this, this CL has the tab grid scroll without animation to the active page when the tab grid starts to appear. This also handles opening the tab grid after "Open in new incognito tab." The issue there was that before, the tab grid's active page was being set by the SceneController in -showTabSwitcher. However, when using the thumb strip, this method is not called. I swapped the data flow around where the tab grid now requests the page from the SceneController (via delegation) when it is about to open in the thumb strip. Fixed: 1155612 Change-Id: I791f7c0ca7fa7ada66241ab55411ac4daeb5c281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595051 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838664}
-
Thomas Lukaszewicz authored
This CL applies layer masking to fix layer hover effects of the manage extensions button clipping outside the bubble's bounds. Before: https://drive.google.com/file/d/1cmuKp4R_nVc7eAaljtIbFX2g0nwlIzKT/view?usp=sharing After: https://drive.google.com/file/d/1oa0lyapwxIGwtCpbxc61bJdPD03gfdVC/view?usp=sharing Bug: None Change-Id: Ieda2cbe46e554208e7cc2282f5b76468f36eff04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597959Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#838663}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012210600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/ArjDoksx4veFQalheiqMNhRYccNS84igngDuMSvLD-0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/175249082 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib8a592ba05a2fc900cae0ed4a759d6a158eda654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599821Reviewed-by:
-
