- 03 Jun, 2019 40 commits
-
-
Jeffrey Cohen authored
Bug: 969239 Change-Id: I90d3d7421394e8801969eda2dbc2bcce8e6832e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641367 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665684}
-
Bruno Santos authored
Bug: 927809 Change-Id: Ibd37e6fe3ec7fc43b1ae72d3d52e695b7fd865f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641991 Commit-Queue: Bruno Santos <brunoad@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#665683}
-
Peter Boström authored
Adds a syncable extension preference for pinned extensions to keep them in sync. This is used in place of the previous "visible extensions" paradigm. Notably extensions are not pinned by default, whereas before they were initially visible on the toolbar. Bug: chromium:959932 Change-Id: I23fa0d5314317c079841540e18449646f4da9076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598818 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665682}
-
Erik Chen authored
No longer used anywhere. Bug: 965663 Change-Id: I7ea45227ff810bcb6696ce6ce50063e1e5c2be26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637981Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665681}
-
Owen Min authored
If request it too large for the server, we move to the next request without retry. If there is no more request, we notifies the accomplishment to the caller as they are succeeded. Bug: 956237 Change-Id: Ie157c8b8d884d345d4212bbc86b8ceaa76428de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639238Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665680}
-
Pavel Yatsuk authored
This change removes whitespace between list items and bottom navbar. Screenshot before (with old styling): http://screen/BMAx13oRGeP Screenshot after: http://screen/4RB0K6kaYTX BUG=959317 R=mdjones@chromium.org Change-Id: I33927472dbb7c04639c80dd4314e388a92bd39a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639352Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#665679}
-
Xida Chen authored
This CL has no behavior change. Bug: None Change-Id: I0efcac8a947d15e1f7b87f00d0bea0bf385c5fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641517Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665678}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d6158eea..2c63dd53 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0dfd186b16de4be6bd222c5cd1931a96b8f263f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665677}
-
Adrienne Walker authored
This should help track down why deserialization issues are failing. Bug: 945482 Change-Id: I4fcb584eeb5d4dfcc6585236657effdc0c8fb669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642027Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#665676}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4867952e90e7..c05f3d1d130d git log 4867952e90e7..c05f3d1d130d --date=short --no-merges --format='%ad %ae %s' 2019-06-03 saklein@chromium.org Build API: Automatic copying of files into the chroot. 2019-06-03 dburger@chromium.org Remove test_vm as ignored builder during config skew check. Created with: gclient setdep -r src/third_party/chromite@c05f3d1d130d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I83f033b3f7a603c29e57c589742bcceedd5278ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665675}
-
Tibor Goldschwendt authored
This Python library will be used in Chrome's Android build system to modify Java files. Bug: 968274 Change-Id: I8d5aacf4009e6b91b276ee2967f9b454523add1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639206 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665674}
-
Liquan(Max) Gu authored
This CL added a paint phase check before FCP++ text paint hook: https://chromium-review.googlesource.com/c/chromium/src/+/1634613 But the CL missed the check in some other hooks, i.e., the one in ng text paint and svg text. This CL is to fix it. Bug:967989,969318 Change-Id: Ic9dc256e08e13dbd9657b1caa9725325e6ed0931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640331Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665673}
-
Yann Dago authored
Bug: 969889 Change-Id: I0df8a98a007691a2153b67caeaea3e22ea7ccadd TBR: pastarmovj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641988 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665672}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0c9d9fc86ee7f86267649b4326fb5aba528d3ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665671}
-
Esmael El-Moslimany authored
Change-Id: I074a7ff55bda151c56bd7ab4f971517bbd84ae73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636564Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#665670}
-
Sergey Ulanov authored
rebaseline_cl tool wasn't rebaselining test expectations for fuchsia because the fuchsia try bot wasn't listed in builders.json. Bug: 958017 Change-Id: I7968b22d3cc0a31f3e4a5083b7017af982100cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640796 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#665669}
-
Nina Satragno authored
Add a "Retry" button that lets the user start the WebAuthn flow over after tapping a key that was not registered. Bug: 920464 Change-Id: I01e5ce9219153c5c23f55399d5fcc9374cabd306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627933 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#665668}
-
Kelvin Jiang authored
Add the function skeleton for getMatchedRules along with types required for it in the .idl. Once again, skipping presubmit as the idl parser fails weirdly as seen in crbug.com/956368 NOPRESUBMIT=true Bug: 967942 Change-Id: I76c79e3de1c008d43474dec4cbec3a7b476f5374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639518 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#665667}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1c7a411305c5..72240f63d231 git log 1c7a411305c5..72240f63d231 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 benjhayden@chromium.org Migrate spa to LitElement Created with: gclient setdep -r src/third_party/catapult@72240f63d231 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:892932,chromium:953441,chromium:965442 TBR=charliea@google.com Change-Id: Iafda08047b2b989c74b2a51664ce392aed04fd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665666}
-
Mike Wasserman authored
Move the mojo interfaces to pure virtual C++ interfaces. Add a static Get() function; defined in impl w/Shell usage. Rename the implementation to *Impl; minor cleanup. Disable SpokenFeedbackTest.SpeakingTextUnderMouseForShelfItem (see Issue 921182 for more details) TBR=dtseng@chromium.org Test: No ChromeVox or other Chrome OS a11y regressions. Bug: 958199, 921182 Change-Id: I3609b83a7fc10eaa34cbe1ad3228bb42ea77909f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636857 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#665665}
-
Esmael El-Moslimany authored
The issue https://github.com/Polymer/polymer/pull/3668 was fixed in Polymer 2. We can now wrap the <style> include attribute value if the 80 character line limit has been reached. Change-Id: I77d992e260d8ce203759b9cd1015438ac427990a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639043Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#665664}
-
Christian Biesinger authored
In the block axis, we do have to do layout for {min,max,fit}-content so we can determine the intrinsic size. MainAxisLengthIsDefinite here is called from ConstructAndAppendFlexItem via ChildHasIntrinsicMainAxisSize (which needs a better name). Bug: 968940 Change-Id: If74e6098280077fefe607e2c5b1f70f133ca1032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641510Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#665663}
-
Christian Biesinger authored
Change-Id: Id653fc50ffa05b4f3e9da4415cf944c6bcbc7aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642009 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#665662}
-
Erik Chen authored
Previously, memory metrics were collected at each UMA upload interval. This timing is context dependent. The new logic samples Chrome's memory using a poisson process, with mean interval 5 minutes on Android and 30 minutes on desktop. Bug: 895474 Change-Id: I08482648996fde7c05ab8d957479c30a4e353a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637938Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665661}
-
Khushal authored
Ping the watchdog thread for Gpu_main during strike deletion to avoid hangs on mac. R=piman@chromium.org Bug: 969623 Change-Id: I36faa00db502e1b1cf0bbda262e5aaadd96f2cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641602 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#665660}
-
Jun Mukai authored
Two methods in AssistantClient interface is actually for the communication between ash and the browser (and the comment also said so). This CL replaces those two methods by C++ along with removing the comment. - OpenAssistantSettings(); this can be replaced as a single function. - SetDeviceActions(); this comes up with the idea of having an interface for holding browser-owned objects which are used by Ash. This is the superclass of AssistantClient so it's named so. Since AssistantImageDownloder and AssistantSetup are owned by AssistantClient, this CL makes the new ash::AssistantSetup own them. With that, the static GetInstance()s are removed. TBR=stevenjb@chromium.org Bug: 958193 Test: trybot Change-Id: I2d308e1d59777b952409f0c2c9bda1392d9b5154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638179 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665659}
-
Brian Sheedy authored
Ports the remaining WebXR browser tests that are currently OpenVR-only but make sense for WMR over to also run with WMR. As a result, also properly copies texture data and provides it back to the test in WMR like OpenVR does. Bug: 926048 Change-Id: I12841f4adc8876089592020493cb371e38214a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637610 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665658}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e0b92527131..4c5f9b2027a6 Created with: gclient setdep -r src-internal@4c5f9b2027a6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I2dcaebbfad73c8b532223529acd94345ef83d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641745Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665657}
-
Yuwei Huang authored
This CL fixes a few memory leak issues found in crrev.com/c/1639052 Bug: 961064 Change-Id: I3746dab3300233f2965a2784f700481250d1abd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639730 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#665656}
-
yilkal authored
Bug: 969227 Change-Id: Ide1703ae4e37a22535c6d1f4034f7d55d716e635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638963Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#665655}
-
Marina Ciocea authored
Create infobars on all tabs when sharing a tab using the desktopCapture() API, to make it easy for the user to quickly change the sharing tab. Bug: 927949 Change-Id: I929724a200cb37c81693b5d0afb82c554cbd1175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617498 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#665654}
-
Martin Kreichgauer authored
The credential IDs of the Touch ID authenticator are basically an AEAD of the associated PublicKeyCredentialUserEntity (= (id, name, display name), with the RP ID as the AD. While the user ID is bounded to 64 bytes, the user name and display name are not. Instead, CTAP authenticators are supposed to truncate them at any length larger than 64 bytes as they see fit. The spec doesn't define an upper limit for credential IDs, but I suspect some RPs will limit what they accept based on what they observe in security keys from large manufacturers. Also storing potentially unbounded IDs in attribute fields of the macOS keychain items might not be the best idea. Hence, let's impose some (arbitrary) limit. Bug: 1631393 Change-Id: I43cbbf3daa6e926baba7007ff99223b5666773e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631655 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#665653}
-
Chase Phillips authored
Following up on a drive-by from mek@ at https://crrev.com/c/1252912, this change updates our IndexedDB code to comply with Chromium's C++ dos/don'ts where it says to avoid std::pair and prefer a struct when defining an alias to the std::pair return result. Bug: 717812 Change-Id: I74755d832b1bc34c17fbdf769a54adf5cac406bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601821Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#665652}
-
Chris Harrelson authored
Bug: 935529 Change-Id: I6844597a562c761d6000d16a34cffc85ad79985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639041 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665651}
-
Joe Downing authored
BUG: 969857 Change-Id: I9ba74d64e9bc3a6400f9a504ccedb105c4b90452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606763 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#665650}
-
Avi Drissman authored
There are lots of files that pull in Aura headers on the Mac. Many have header includes that are easy to fix. The other is hosted_app_button_container.cc, which includes native_widget_aura.h in order to access GetWindowTitleFontList(). Move GetWindowTitleFontList() to custom_frame_view.h and file a bug to move it elsewhere. BUG=968860 Change-Id: I944a9c4016b65c5b10e5faead4e06aaafe71155c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636230Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665649}
-
Ben Pastene authored
This is a reland of ad780388 Fix includes moving the '!' into its proper place. And crrev.com/c/1638777 was uploaded to prevent this type of regression from slipping in again. Original change's description: > Skip 'dep:chrome_internal' Tast tests if we're not building w/ is_chrome_branded. > > So that no dep:chrome_internal tests are ran if they don't have the > needed internal bits. > > Bug: 947531 > Change-Id: I060734d2fe05c878d16f2c6a63815bd0abbb554c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637644 > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665158} Bug: 947531 Change-Id: I8acc782fb8a926a628e7531b7df73cc6029be6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637672Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665648}
-
Jared Saul authored
We've moved away from having separate IsXYZFlagEnabled() functions in favor of just having the flag-checking code at the calling points themselves. I believe these are the last three stragglers. Change-Id: I8060cacd962851dc22691ef95437b7aa72b6fbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639051Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#665647}
-
Asanka Herath authored
Use of GSSAPI libraries is gated on a complicated condition that's repeated in multiple locations. In reality it simplifies greatly since there are only two exceptions to the "Use an external POSIXish GSSAPI library if supporting Kerberos" rule. Bug: 927182 Change-Id: I6e3b514cdddb857409e90ee9fd0460d8d7836404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640782 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#665646}
-
Manas Verma authored
Bug: 969257 Change-Id: Ic24c32bc581a7a5aa2b84b3755ef313afb55c410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639821 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#665645}
-