- 06 Nov, 2018 40 commits
-
-
Kent Tamura authored
- core/event_names.json5 => core/event_interface_names.json5 - event_modules_names.json5 => modules/event_interface_modules_names.json5 This renaming changes generated *_names.{h,cc} too. This CL fixes #includes for them. Also, this CL removes unnecessary #includes for event_names.h, and add necessary #includes. This CL has no behavior changes. Change-Id: Id7b47788cde408bf81822c6e7d284683648f5854 Reviewed-on: https://chromium-review.googlesource.com/c/1317209Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605651}
-
Keishi Hattori authored
Converts Touch* class allocations from new to MakeGarbageCollected. Bug: 757708 Change-Id: I4fe095a494f7bc1756890d03b97b62dd2ed51f8d Reviewed-on: https://chromium-review.googlesource.com/c/1317077Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605650}
-
David Jean authored
Bug: 845472 Change-Id: Ifc6f448c0000d4886a15aab5b06a979bd8dc63d6 Reviewed-on: https://chromium-review.googlesource.com/c/1303730 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605649}
-
Nikita Podguzov authored
This should help to understand perfomance of ResourceCache operations. Bug: 807068 Change-Id: I58b5c0da38b46c9497a3a878327a25dca58b5995 Reviewed-on: https://chromium-review.googlesource.com/c/1296489 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#605648}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92fc277bf0f6..ef8feea70c2f Created with: gclient setdep -r src-internal@ef8feea70c2f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9d32b7a9ea85336fbfb94842122a0bae877244d1 Reviewed-on: https://chromium-review.googlesource.com/c/1319375Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605647}
-
Nikita Podguzov authored
Bug: 807068 Change-Id: I1e55bdea38b02d5fdf1d7faa9a60390af5fac7d7 Reviewed-on: https://chromium-review.googlesource.com/c/1290983Reviewed-by:
-
Gauthier Ambard authored
This CL marks the WebState's view as dirty when the preferred content size is changed. It causes the view to be laid out again. It also changes the way the Overscroll controller is getting its initialHeaderInset, by asking it to the delegate every time instead of caching it, as the value become stale after changing the preferred content size. Bug: 892145 Change-Id: I2fe0b54a107e0cfed438ea5c57efdbb65fe4c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/1307443 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605645}
-
Arthur Sonzogni authored
devtools_instrumentation::OnResetNavigationRequest is probably called with an already deleted NavigationRequest. Add instrumentation to understand what happens. Crash reports: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3Adevtools_instrumentation%3A%3AOnResetNavigationRequest%27+AND+product_name%3D%27Chrome Experiment: NetworkService. OS: Windows StackTrace: * content::devtools_instrumentation::OnResetNavigationRequest * content::FrameTreeNode::TransferNavigationRequestOwnership * content::NavigationRequest::CommitNavigation * content::NavigationRequest::OnWillProcessResponseChecksComplete * content::NavigationHandleImpl::RunCompleteCallback * content::NavigationHandleImpl::WillProcessResponse * content::NavigationRequest::OnResponseStarted * content::NavigationURLLoaderImpl::OnReceiveResponse Bug: 880741 Change-Id: Ib428283192cc3de83292f2b62c71583e2596a19f Reviewed-on: https://chromium-review.googlesource.com/c/1316734 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605644}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7db17b992e4..edfb883c85ef git log d7db17b992e4..edfb883c85ef --date=short --no-merges --format='%ad %ae %s' 2018-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 11d7305a..7841106b (605505:605607) Created with: gclient setdep -r src/third_party/webrtc@edfb883c85ef The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I633278fa78bcc0a46cc6e69d4a57c7e329f9795a Reviewed-on: https://chromium-review.googlesource.com/c/1319374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605643}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ida8672946dc60306d4269ddce06672f080953f8e Reviewed-on: https://chromium-review.googlesource.com/c/1319401Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#605642}
-
Hans Wennborg authored
implicit_weak_message.cc is part of protobuf_lite.dll, and it includes wire_format_lite.h, which includes the dllexport inline function WireFormatLite::WriteGroupToArray which will therefore be emitted. WriteGroupToArray in turn calls the inline function InternalWriteGroupToArray, however that definition is provided in the _inl file. To make sure the definition is available, the _inl file must be included. Before Clang r344987 the build worked anyway (due to luck), because InternalWriteGroupToArray was emitted into other object files (e.g. in wire_format_lite.obj). After that Clang revision, those definitions started getting inlined, and so are longer available and cause a link failure for the reference from implicit_weak_message.obj. Bug: 901776 Change-Id: I60ba265495eba6e868f0799f697c0d172e4c2fb1 Reviewed-on: https://chromium-review.googlesource.com/c/1317910 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605641}
-
rajendrant authored
This CL fixes the video.testCheckVideoHasViaHeader webdriver test. Chrome-Proxy header gets set to 'frfr' for first video requests (in resource_multibuffer_data_provider.cc). So the proxy delegate should merge the headers considering existing values. If a header already exists they should be combined with using ', '. Bug: 893728 Change-Id: Icb1eb84ef9af149b6e34e5792ca4a7d079efebed Reviewed-on: https://chromium-review.googlesource.com/c/1316096Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#605640}
-
Tsuyoshi Horo authored
According to RFC 6266, when the disposition type matches "attachment" the browser should prompt the user to save the response locally. But when NetworkService is enabled, Chrome doesn't save the signed exchange, but shows the internal content of the signed exchange even if "attachment" type Content-Disposition header is set. When NetworkService is disabled, Chrome downloads the signed exchange as a file but the loading animation doesn't stop. This is because: - In MimeSniffingResourceHandler::MaybeStartInterception(), InterceptingResourceHandler steals the response. - So NavigationURLLoaderImpl::URLLoaderRequestController::OnComplete() will not be called forever after SignedExchangeRequestHandler intercepts the response. To fix this problem, this CL adds download_utils::MustDownload() check in ShouldHandleAsSignedHTTPExchange(). So SignedExchangeRequestHandler::MaybeCreateLoaderForResponse() will not intercept the response when "attachment" type Content-Disposition header is set. Bug: 896659 Change-Id: Ic1d4756f5823383d55144b0320a06851ca8ecc3e Reviewed-on: https://chromium-review.googlesource.com/c/1293065Reviewed-by:Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
1) Remove unnecessary include for the header: content/public/common/browser_side_navigation_policy.h 2) Rename it navigation_policy.h. BrowserSideNavigation landed, but this header remains for navigation related experiments. R=nasko@chromium.org TBR=jam@chromium.org Bug: 789577 Change-Id: I5c42047470291e37df0bd3b13e7bf13ad4726205 Reviewed-on: https://chromium-review.googlesource.com/c/1317919Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Lei Zhang authored
Change-Id: I44ece9059b99217e0ed488a95b6ee3a84abdf0b0 Reviewed-on: https://chromium-review.googlesource.com/c/1316410Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b1893bd0697..92fc277bf0f6 Created with: gclient setdep -r src-internal@92fc277bf0f6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I486e952cc8cc6b10290a28a200ce9fc804c1fdcb Reviewed-on: https://chromium-review.googlesource.com/c/1319373Reviewed-by:
-
Andreas Haas authored
Design doc: https://docs.google.com/document/d/1jKmBxVg-E4ZJlpVtmhAOmdwHbByaESjMyX0NJVrXRF0 Change-Id: I1615860b0826ada49efa814d0f96a50d32a19b54 Reviewed-on: https://chromium-review.googlesource.com/c/1290952Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#605635}
-
Michael Lippautz authored
Enables unified heap garbage collection across V8 and Blink. The GC computes a single transitive closure across V8's API boundary before starting the separate sweepers. Sheriffs: This is a dry-run of the feature and will be reverted after cycling through the waterfall and performance bots. Bug: 843903 Change-Id: I0d3e9fc76fa9b116f32d92a234c45afe11120cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1290869Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL changes the height of the toolbar such as its height is now multiplied by a factor depending on the preferred font size specified by the user. Bug: 892145 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If757cf7fd7843ce1a61b3748f653c2c27347e11e Reviewed-on: https://chromium-review.googlesource.com/c/1286651 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Kent Tamura authored
Directory information is not used. This CL also adds comments about how ImplementedAs is used. Change-Id: I6223f39c2459e1f3b8efb28dac04a8ec8193db5e Reviewed-on: https://chromium-review.googlesource.com/c/1319309Reviewed-by:
-
Yuta Kitamura authored
This CL simplifies lengthy function calls via Platform::Current() that obtain the current thread and the main thread by using Thread::Current() and Thread::MainThread(). Bug: 826203 Change-Id: I36300b006e48a90c64f0a55579bfc22195da320b Reviewed-on: https://chromium-review.googlesource.com/c/1319217Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2dfab27d6957..e6c85755832b git log 2dfab27d6957..e6c85755832b --date=short --no-merges --format='%ad %ae %s' 2018-11-06 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-06 caryclark@skia.org fix paint docs 2018-11-06 brianosman@google.com Fix FP / header inconsistency Created with: gclient setdep -r src/third_party/skia@e6c85755832b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Ifa15af2251ecffe85047ebf1c5d347b54554be6a Reviewed-on: https://chromium-review.googlesource.com/c/1319372Reviewed-by:
-
Shu Chen authored
Bug: 859432 Change-Id: I09198477e9d1702191355b61d7f64b7fe2310d99 Reviewed-on: https://chromium-review.googlesource.com/c/1319226Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605629}
-
Sergio Villar Senin authored
It was using SigninManagerBase::GetAuthenticatedAccountInfo(). Migrated to IdentityManager::GetPrimaryAccountInfo(). Bug: 889868 Change-Id: I87fac4ed2e087ed7ec054607ba5faa27234bf6eb Reviewed-on: https://chromium-review.googlesource.com/c/1316733Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#605628}
-
Leon Han authored
Based on https://crrev.com/c/1317344 and https://crrev.com/c/1317348, this CL moves blink/public/platform/referrer.mojom into blink/public/mojom, as part of Onion Soup efforts. BUG=789854 Change-Id: I6832ae85d849ff5395da0b37b1cc7bfa63e1152f Reviewed-on: https://chromium-review.googlesource.com/c/1319346Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 902201 Change-Id: I55613be57c363aa9d396108826e21643006ad224 Reviewed-on: https://chromium-review.googlesource.com/c/1319221Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605626}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/228942c6f98d..7b1893bd0697 Created with: gclient setdep -r src-internal@7b1893bd0697 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If0bd8c8803d32c9b8e573f8c81ff5adee9691cdd Reviewed-on: https://chromium-review.googlesource.com/c/1319371Reviewed-by:
-
Antoine Labour authored
Instead of trying to derive GMB support from extension bits, explicitly expose the set of supported GMB formats. A compact representation (bitfield) is introduced to easily and cheaply pass the set around. In later CLs this will be used in other contexts (shared images). Bug: 870116 Change-Id: I393b98dda067dba0c41d74e6de390ae478f50520 Reviewed-on: https://chromium-review.googlesource.com/c/1313549 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605624}
-
Mike Wasserman authored
Adds a unit test split out from https://crrev.com/c/1311080 (PS9) Landing separately to make release branch merging easier. Bug: 899084 Test: Automated Change-Id: Icadd82f2490bc4f3bbbdd1c73f8cdbe584f03289 Reviewed-on: https://chromium-review.googlesource.com/c/1318363 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605623}
-
Kunihiko Sakamoto authored
This reverts commit b04ad36c. Reason for revert: Made WebViewSizeTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent flaky. crbug.com/902224 Original change's description: > viz: Throttle begin-frames to offscreen clients. > > If a surface is offscreen, then stop sending it OnBeginFrame messages. > This avoids doing unnecessary work in the client. If an OOPIF, video, > etc. are offscreen because the main-page has been scrolled too far (or > not enough, or for some other reason), then they don't need to be > submitting new frames. Not sending the begin-frame messages to the > oopif etc. stops it from continuing to generate and submit new frames. > The side effect of this is that once the oopif becomes visible again, > its first frame can still be old content. This can resolved (e.g. by > throttling the messages, instead of stopping them outright), but I > think it's worth experimenting with this approach first. I think of > this as being a bit similar to how we do not trigger rAF callbacks on > background tabs. > > One exception is that a begin-frame is always sent to a surface when > it is first embedded, even if it is offscreen. This allows the clients > to determine correctly when their embedding is complete. > > BUG=884876 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I5c58a0fc956338b470b2fbfe30079d661927c894 > Reviewed-on: https://chromium-review.googlesource.com/c/1278535 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605554} TBR=sadrul@chromium.org,kenrb@chromium.org,fsamuel@chromium.org,fserb@chromium.org,piman@chromium.org Change-Id: I383fb0ba353074db91ae0bdc3f204005d59551be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884876, 902224 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1319402Reviewed-by:
-
Alexei Filippov authored
The markers are made easily distinguishable by showing a short title on the timeline by default. It is put behind an experiment. BUG=901165 Change-Id: I9f6ecbac2ac34d45662840ba55fc32d93ffe1d2e Reviewed-on: https://chromium-review.googlesource.com/c/1313877 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#605621}
-
Mike Frysinger authored
Checking the python version on the fly doesn't add any value, so drop it. Bug: 747171 Change-Id: Ieb1a6287c365aedd25c17edba1dd06cc14505e07 Reviewed-on: https://chromium-review.googlesource.com/c/1319169 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
-
Kent Tamura authored
* Overview: Introduce blink.mojom.FileChooser, and switch to it from legacy IPC messages. content::FileChooserImpl implements blink.mojom.FileChooser. blink::FileChooser and content::PepperFileChooserHost::CompletionHandler initiate requests to blink.mojom.FileChooser, and receive their responses. * Details: ** third_party/blink/public/mojom/choosers/file_chooser.mojom Introduce FileChooser. ** content/browser/frame_host/render_frame_host_impl.cc ** content/browser/frame_host/render_frame_host_impl.h FileChooserImpl implements blink.mojom.FileChooser. Introduce FileChooserImpl::ListenerProxy for lifetime difference between FileSelectListener and FileChooserImpl. ** content/public/app/mojo/content_browser_manifest.json Expose blink.mojom.FileChooser mojo interface. ** third_party/blink/renderer/core/html/forms/file_chooser.cc ** third_party/blink/renderer/core/html/forms/file_chooser.h blink:FileChooser sends requests to blink.mojom.FileChooser, and receives their responses. ** content/renderer/pepper/pepper_file_chooser_host.cc. ** content/renderer/pepper/pepper_file_chooser_host_unittest.cc. content::PepperFileChooserHost::CompletionHandler sends requests to blink.mojom.FileChooser, and receives their responses. ** content/browser/frame_host/render_frame_host_delegate.cc ** content/browser/frame_host/render_frame_host_delegate.h Add RenderFrameHostDelegate::EnumerateDirectory. Now directory enumeration requests are received by FileChooserImpl implementing blink.mojom.FileChooser. RenderFrameHostDelegate is responsible for passing the requests to actual directory enumeration code. ** content/browser/web_contents/web_contents_impl.cc ** content/browser/web_contents/web_contents_impl.h Override RenderFrameHostDelegate::EnumerateDirectory, and remove legacy IPC code for EnumerateDirectory. Merge ViewFileSelectListener into FileChooserImpl. ** chrome/browser/ssl/security_state_tab_helper_browsertest.cc ** content/browser/cross_site_transfer_browsertest.cc ** content/browser/fileapi/fileapi_browsertest.cc ** content/browser/frame_host/render_frame_host_manager_browsertest.cc ** content/browser/navigation_browsertest.cc ** content/browser/site_per_process_browsertest.cc ** content/test/content_browser_test_utils_internal.cc ** content/test/content_browser_test_utils_internal.h Add callback arguments to mocks for FileChooser. The browser process doesn't receive a FileChooser request immediately after click() on a file control since this CL. This behavior difference breaks some tests. This CL adds a callback argument to mock FileChoosers, and it notifies the caller that a request is reached to the FileChooser. ** content/browser/security_exploit_browsertest.cc Introduce MojoBadMessageObserver to test mojo::ReportBadMessage(). Switch to mojo from legacy IPC. ** third_party/blink/renderer/core/BUILD.gn ** third_party/blink/renderer/core/html/forms/mock_file_chooser.h A mock FileChooser. This intercepts FileChooserRequest, and is helpful to test FileChooser clients. ** third_party/blink/renderer/core/page/chrome_client_impl_test.cc ** third_party/blink/renderer/core/html/forms/file_input_type_test.cc Use mock_file_chooser.h. ** third_party/blink/renderer/core/html/forms/file_input_type.cc ** third_party/blink/renderer/core/html/forms/file_input_type.h - Switch from blink::WebFileChooserParams to blink::mojom::blink:: FileChooserParams. - Change the return type of CollectAcceptTypes for FileChooserParams:: accept_types. - Change the argument of FilesChosen() mutable because we drop FilePaths which can't be converted by FilePathToString(). ** third_party/blink/renderer/core/fileapi/file_list.cc ** third_party/blink/renderer/core/fileapi/file_list.h ** third_party/blink/renderer/core/fileapi/file_list_test.cc Change the return type of PathsForUseVisibleFiles() from Vector<String> to Vector<base::FilePath> because the vector is set to FileChooserParams:: selected_files, which is Vector<base::FilePath>. ** third_party/WebKit/LayoutTests/accessibility/ ** third_party/WebKit/LayoutTests/fast/events/ ** third_party/WebKit/LayoutTests/fast/forms/file/ ** third_party/WebKit/LayoutTests/fast/forms/resources/mock-file-chooser.js Introduce mock-file-chooser.js which intercepts Mojo calls from renderer processes, and some layout tests adopt it. FileChooser stuff in content/shell/test_runner/ is now unnecessary. ** content/browser/bad_message.h ** tools/metrics/histograms/enums.xml Mark BadMessageReason::FH_FILE_CHOOSER_PATH obsolete. Now we use mojo::ReportBadMessage(). ** content/browser/renderer_host/render_view_host_impl.cc ** content/browser/renderer_host/render_view_host_impl.h ** content/common/content_param_traits.cc ** content/common/content_param_traits.h ** content/common/frame_messages.h ** content/common/view_messages.h ** content/public/browser/render_view_host.h ** content/renderer/render_frame_impl.cc ** content/renderer/render_frame_impl.h ** content/renderer/render_view_impl.cc ** content/renderer/render_view_impl.h ** content/shell/test_runner/test_runner.cc ** content/shell/test_runner/test_runner.h ** content/shell/test_runner/web_frame_test_client.cc ** content/shell/test_runner/web_frame_test_client.h ** content/shell/test_runner/web_frame_test_proxy.cc ** content/shell/test_runner/web_frame_test_proxy.h ** third_party/blink/public/BUILD.gn ** third_party/blink/public/web/web_file_chooser_completion.h ** third_party/blink/public/web/web_file_chooser_params.h ** third_party/blink/public/web/web_local_frame_client.h ** third_party/blink/public/web/web_view_client.h ** third_party/blink/renderer/core/loader/empty_clients.h ** third_party/blink/renderer/core/page/chrome_client.h ** third_party/blink/renderer/core/page/chrome_client_impl.cc ** third_party/blink/renderer/core/page/chrome_client_impl.h Just remove unnecessary code Bug: 869257 Change-Id: I573bf8c20162c3131e630ea5e4f2e0cb431a4da0 Reviewed-on: https://chromium-review.googlesource.com/c/1170454Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605619}
-
Chris Hall authored
This is to allow us to use the flag within ui/accessibility, as ui/accessibility cannot depend on chromeos/ or chrome/ BUG=889370 R=dmazzoni,aboxhall Change-Id: I90c51f123c347975d1bc4ede3ea3900dac04625c Reviewed-on: https://chromium-review.googlesource.com/c/1314072Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 902201 Change-Id: Ib9fd5a5f0e9cc49cf653b6af768d00912c008deb Reviewed-on: https://chromium-review.googlesource.com/c/1319392 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa27a834ba5d..2dfab27d6957 git log aa27a834ba5d..2dfab27d6957 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 brianosman@google.com Revert "Fix div-by-zero loophole in gradient factory func" 2018-11-05 brianosman@google.com Revert "Revert "Use float colors for blend constant"" 2018-11-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 20622c0194bd..4169b31090db (1 commits) 2018-11-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-05 reed@google.com add alternative setters for hinting 2018-11-05 brianosman@google.com Revert "Use float colors for blend constant" 2018-11-05 jvanverth@google.com Fix persp_images with DDL correctly 2018-11-05 michaelludwig@google.com Fix div-by-zero loophole in gradient factory func 2018-11-05 brianosman@google.com Use float colors for blend constant 2018-11-05 brianosman@google.com Use SkPMColor4f throughout clear APIs 2018-11-05 jvanverth@google.com Temporarily disable support of mipmapped flattened YUVA image 2018-11-05 herb@google.com Move Painter implementations into Painter 2018-11-05 mtklein@chromium.org lookup sent types using factory pointer 2018-11-05 csmartdalton@google.com Revert "ccpr: Unblacklist Sandy Bridge/Bay Trail on Mesa" 2018-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 37297a4f1440..3d86e89bce7a (1 commits) 2018-11-05 herb@google.com Reorganize to extract GPU main drawing code Created with: gclient setdep -r src/third_party/skia@2dfab27d6957 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I2f2e00a3eace7048c0a2ef603ecbe5a13da700be Reviewed-on: https://chromium-review.googlesource.com/c/1318159Reviewed-by:
-
Wez authored
Change-Id: I18b6fb62596e00cb8315c5eabd0360cdbe48f59a Reviewed-on: https://chromium-review.googlesource.com/c/1318803 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605615}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/459aaba03456..6d6e0a8009f2 git log 459aaba03456..6d6e0a8009f2 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6d6e0a8009f2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib11bd44effbf0e8478e60ee2a9c2b545533a151f Reviewed-on: https://chromium-review.googlesource.com/c/1318160Reviewed-by:
-
Joe DeBlasio authored
This CL removes a now-erroneous overwrite of a valid SSLStatus when a user performs a same-document navigation that does not result in a network request. Bug: 877618 Change-Id: I495b9e43fe11d2dc6650e7f2a4d776d5cf804c5d Reviewed-on: https://chromium-review.googlesource.com/c/1311126 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#605613}
-
Zhuoyu Qian authored
Since ui/base/touch/touch_device.h and it's implementations (touch_device*.cc) now cover more than just touch inputs, the CL rename these files to pointer_device.*. Bug: 438794 Change-Id: Iea744612f1e4bf7d3e4c6b9e875c9385508f6d10 Reviewed-on: https://chromium-review.googlesource.com/c/1303324Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
