- 02 Jan, 2020 40 commits
-
-
Philipp Hancke authored
adds a test to assert that RTCPeerConnection.onconnectionstatechange is not fired when RTCPeerConnection.close() is called. BUG=699036,1023736 Change-Id: I623deeb4f0948cf213ff8913c33610ef0e7315e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959969Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#727996}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I2ac74aa8ee774ecf95a0a249b0aaab32abd46c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985767 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#727995}
-
Harald Alvestrand authored
Spec link: https://w3c.github.io/webrtc-pc/#announcing-a-data-channel-as-closed Bug: chromium:1030631 Change-Id: I6634773bfc217883affb0a9ac4dafd8d271129d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978677Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#727994}
-
Rakesh Soma authored
serial number [1] in SaveAccountInfo is returning empty. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/credential_provider/gaiacp/gem_device_details_manager.cc;l=81 Change-Id: I941cfe0afcd0130fcd972620780a2975bff8268e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981863Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#727993}
-
Caleb Rouleau authored
It is believed that this test suite is somehow causing the bot that it is run on to die the next time it gets run. Bug: 1036846 Change-Id: Ib18512cfe6636f7b879416ee617ec7b4642233e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984637 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727992}
-
Jan Scheffler authored
This cl reenables and fixes a test to refactor how Cookies are handled in devtools frontend. Cl with the actual changes: crrev.com/c/1959984 Cl disabling the test: crrev.com/c/1960350 Bug: chromium:1030258 Change-Id: I8f8bf9f4b0a6956dbbd019a5ced88fa2db066648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960279 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#727991}
-
Manu Cornet authored
This is a pure cleanup with no expected behavior change. Change-Id: I843327b4881f3321de0a12f9aa391ef1bb15b4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978181Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#727990}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: I08e3f59e0a3d03ce77b6f669e1cfa1a72fae2ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985760Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#727989}
-
Aaron Gable authored
This updates the windows build instructions to indicate that Visual Studio 2019 is the preferred VS IDE version, and to align with the default changing in https://gn-review.googlesource.com/c/gn/+/6900 Bug: 1038361 No-Try: true Change-Id: I2a9908f02d7a8dc42e94d330550035554968b4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984701 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#727988}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/bb8e777557dd..f71aaa0be84a $ git log bb8e77755..f71aaa0be --date=short --no-merges --format='%ad %ae %s' 2019-12-29 junyer Make DFA use hints. 2019-12-13 junyer std::is_pod<> was deprecated in C++20. 2019-12-09 junyer Simplify the bytecode for the 80-10FFFF rune range. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I47de205ccacde2054daf2b6b81cb09ccf4a1a375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983509Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727987}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d81bc733ae0c..4ee635638fc1 git log d81bc733ae0c..4ee635638fc1 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 brianosman@google.com Add SkRuntimeEffect::makeColorFilter 2020-01-02 bsalomon@google.com Fix GrColorMatrixFragmentProcessor handling of premul transparent black. 2020-01-02 benjaminwagner@google.com Fix asan_device_setup path 2020-01-02 kjlubick@google.com [canvaskit] Update compile.sh with initial code size findings 2020-01-02 benjaminwagner@google.com [infra] Handle failure from addr2line 2020-01-02 bryct@amazon.com Add instructions for compiling CanvasKit and viewing example page. Created with: gclient setdep -r src/third_party/skia@4ee635638fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024935 Tbr: nifong@google.com Change-Id: I36b756bcffbcc91673aaaaf37ffcfab809355f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727986}
-
Rodney Ding authored
- plumbing ExecutionContext through various callsites to isWebExposed() - add stopgap override for cssPropertyID passing nullptr in place of actual ExecutionContext - Use nullptr in place of actual ExecutionContext for PropertySetStyleDeclaration constructor - Design doc https://docs.google.com/document/d/1Lc3U2WV38GZ3ShTAm3-p6fbZeGJGkxL-KZfWIQ-p8GU/edit?usp=sharing Bug: 775189 Change-Id: Ia4e1c5b1dd363bb7f5b22436c144eb709f867f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960472Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#727985}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f7eaa155d09..b0e11f6c807f git log 1f7eaa155d09..b0e11f6c807f --date=short --first-parent --format='%ad %ae %s' 2020-01-02 lalitm@google.com trace_processor: add Id wrapper type returned by Insert in all db tables Created with: gclient setdep -r src/third_party/perfetto@b0e11f6c807f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I629275b86e518c781a3d95ed482653761331c8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985697Reviewed-by:
-
Dave Tapuska authored
When a mouse wheel event was acked the two queues compared whether it matched an outstanding one it had. For more correctness and to avoid the comparison we can use callbacks. That way the correct consumer is notified when the event gets processed. This change is necessary to remove a compare on WebMouseWheelEvent. BUG=836826 Change-Id: I2985216b681e02799bea12a30162726915867b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979147Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#727983}
-
Jérôme Lebel authored
Updating the expiration date from M81 to 2020-11-01. Bug: 1037293 Change-Id: I9b07d9a0fe4081342d7e48886c983f34a5d4c2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984303Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#727982}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ef86f4793da..45ab65a9bfcc git log 6ef86f4793da..45ab65a9bfcc --date=short --first-parent --format='%ad %ae %s' 2020-01-02 leese@chromium.org Add wasmparser library to front end 2020-01-02 leese@chromium.org Do not lint third party code Created with: gclient setdep -r src/third_party/devtools-frontend/src@45ab65a9bfcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1013527 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7ebb0e3a7d5f84a1fffa615af61f39f0ecb4a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985692Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/34b8e4d6..77faebf0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d64d2cac277064157f5d7c0953f567a30e2880f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985604Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99be05ca5b0b..79df1292b2aa Created with: gclient setdep -r src-internal@79df1292b2aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic47a6727d42c59f3d1d4f8b134308d696f6caa83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985694Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727979}
-
Gauthier Ambard authored
This CL resizes the frame of the NTP instead of adjusting its content inset. It allows the content of the NTP to not be displayed below the toolbar, avoid issues with VoiceOver reading the item behind it. It also allows to fix the content insets for the safe area. Fixed: 1034509, 1030422 Change-Id: I306ecf5b771fa3a7b0b88fb6d99425154695c6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969580Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#727978}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f454b72. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." e8e1bf91 "rtcpeerconnection: dont fire signalingstatechange from close()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iddcdc5519be1aeb7b7f267c54ed04b39b2aa43f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985603Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727977}
-
Jan Scheffler authored
This cl disables a test to land crrev.com/c/19671359. Tbr: yangguo@chromium.org Bug: chromium:1019723 Change-Id: I458397c58d1b8fe96d7e13054ee9f813ef64559b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985772 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#727976}
-
Christian Dullweber authored
Notification channels persist across tests. Reset them to avoid test failures. Bug: 981972 Change-Id: Ica37d2d0a8f3e746a38b8e8a1d6aa74202cec231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985763 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#727975}
-
Balazs Engedy authored
The tests attempt to a start the EmbeddedTestServer on a fixed port, but this will fail if the bot is simultaneously running multiple test cases from this test suite, which happens routinely for `content_browsertests`. Bug: 1038346 Change-Id: Ice7264ef5b811ef3c7d8a194627f7b77fec33a59 TBR: horo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985774Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727974}
-
Robbie Gibson authored
This makes things much cleaner because ContainedPresenter automatically comes with ContainedPresenterDelegate. This does require the addition of FindBarViewController to wrap FindBarView as ContainedPresenter only works with view controllers. This can also remove the |selectText| parameter from |-showFindBarWithAnimation| because it is only called with |selectText| as YES. Bug: 1028938 Change-Id: Ieadd8c24d8d55455a3d07aa91c4ab1f3d8742718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960275Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#727973}
-
Philip Rogers authored
After collecting data on Android canary/dev, we are going to fold this project into "reducing compositing under memory pressure" so we only stop compositing trivial 3D transforms when under memory pressure. This achieves the majority of the OOM benefits with minimal user impact. This experiment resulted in interesting data about the effects of memory savings on OOM crash rates. On canary/dev Android, the experiment showed a decrease in GPU tile memory (-2.4% @ 50th, -4.4% @ 99th) resulted in a decrease in peak GPU memory usage (-1.95% during scroll), a decrease in memory pressure signals (-6% critical), and a decrease in crashes (-8.25% visible renderer foreground OOM). These benefits came at a cost of additional raster which could be seen in Scheduling.Renderer.DrawIntervalWithMainThreadAnimations2 which increased 4.66% at the 99th. More information can be found in: https://docs.google.com/document/d/1yFSWUhHjneEnjx_vf9SBpYAQOoce8JMbtTvAiHhGD-o Bug: 1012775 Change-Id: I9ce1c4f47860d9ab0dbd7cbae68662cf4d657885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981804 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727972}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7449dc8a7f22..1f7eaa155d09 git log 7449dc8a7f22..1f7eaa155d09 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 eseckler@google.com Merge "proto: Fix field ID inconsistency in TrackEvent/TrackEventDefaults" Created with: gclient setdep -r src/third_party/perfetto@1f7eaa155d09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I18181f9efbcb219369c907a3cc379233aa782dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985686Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2ead15308b0..6ef86f4793da git log c2ead15308b0..6ef86f4793da --date=short --first-parent --format='%ad %ae %s' 2020-01-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@6ef86f4793da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6b2acb30af632413b4b42f4d4554b9b7a5d90977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985688Reviewed-by:
-
Omer Katz authored
Bug: 986235 Change-Id: I0880c784e61d5978ebc8c3a7de57c04b1a8a08c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984309Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#727969}
-
Balazs Engedy authored
Bug: 1038656 Change-Id: Id2cfb02d6ccaaddab0e641b48b9d7e2857014f0c No-Try: true TBR: janscheffler@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985764Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4b2a7867. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3194c11231767b8505fe21a4d9a10d20774ff00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985602Reviewed-by:
-
Alice Wang authored
This CL added tests to the class ConfirmSyncDataStateMachine and refactored its ctor. Bug: 1028583 Change-Id: I143a5d05181f063bec89f5fb4835b8d296bcc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982539 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727966}
-
Philipp Hancke authored
RTCPeerConnection.close() shall not fire events. It doesn't already for iceconnectionstate/connectionstate BUG=699036 Change-Id: I771cdd81c3bbdb4312a623e96f8150be8471d906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959042 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
Some stories that produced large traces were timing out or failing because trace conversion happened on the device. Now that trace conversion was moved to the host, we can re-enable them. TBR: crouleau@chromium.org Bug: 1029465 Change-Id: I27e1196a12b9a9b5341544d5467de0c10ffa9531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985017 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#727964}
-
Oriol Brufau authored
The marker-font-variant-numeric-default.html test is supposedly passing in Chromium according to Chromium, but not according to wpt.fyi. The reason is that in certain configurations, the test may look slightly different than the reference due to font anti-aliasing. The marker-font-variant-numeric-normal.html fails in all browsers due to lack of support for nested ::marker selectors, but there are also some differences in the parts that should actually match the reference. This patch fixes both issues. Bug: 457718 Change-Id: Id646b7810aed18441e1c7b37ad7bb1a37877be2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980174Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#727963}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/7e1b39f6cd1f..10d8de7541ab git log 7e1b39f6cd1f..10d8de7541ab --date=short --first-parent --format='%ad %ae %s' 2020-01-02 drott@chromium.org [truetype] Fix UBSan warning on offset to nullptr (#57501). 2019-12-31 ramakrishnan.nikhil@gmail.com [woff2] Allow bitmap-only fonts (#57394). 2019-12-21 hugh.mcmaster@outlook.com [docs] (2/2) Fix generation of API documentation (#56745). 2019-12-21 hugh.mcmaster@outlook.com [docs] (1/2) Move static web assets (#56745). 2019-12-21 drott@chromium.org Fix more UBSan warnings on adding offset to nullptr (#57432). Created with: gclient setdep -r src/third_party/freetype/src@10d8de7541ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: 1036154, 1032387, 1034075 Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: If0edcc48ac1b8a9ca4d0848137d1d17d90cf91ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985685 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#727962}
-
Omer Katz authored
Adding tests for remaining heap collection types. Also refactor existing tests to use a template that gets the collection type. This reduces most of the boilerplate. Since interfaces of existing collection slightly differ, using *Adapter classes to wrap missing methods. Bug: 986235 Change-Id: I2717fbebe9396caf7e25309b8b285f698347c9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962855 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83461f034ab7..99be05ca5b0b Created with: gclient setdep -r src-internal@99be05ca5b0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I399d90c57f69e384f4ad6b9cebc76a9c637fadfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985687Reviewed-by:
-
Alex Ilin authored
This reverts commit 6adf67f0. Reason for revert: causes crashes in the SharedImageBackingFactoryAHBTest test suite https://crbug.com/1038640 Original change's description: > Prevent access to uninitialized SharedImages > > This CL prevents read access to uninitialized SharedImages. For cases > where read/write access is reqeusted, the CL requires that the caller > specifically request uninitialized access if required. > > Bug: 1003686 > Change-Id: I52230217cd7f17e0cd9d4a82036ae6c72d3b1ea2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974630 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727827} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1003686, 1038640 Change-Id: I303089135726e3bb99918744c08019cfc43d68fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985015Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2844b390..34b8e4d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie01b75f457e1f68fcccc97b420f4fbbfeebaa769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985601Reviewed-by:
-
Balazs Engedy authored
This reverts commit c07acb2e. Reason for revert: The test http/tests/devtools/a11y-axe-core/search/search-a11y-test.js deterministically times out on Linux MSAN builders. Original change's description: > DevTools [Search]: adding search accessibility tests > > Bug: 963183 > Change-Id: Iac3c3101babfb7285ff7b9905d94303120a2b982 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818470 > Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com> > Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#727893} TBR=lomitch@microsoft.com,Rob.Paveza@microsoft.com,ambake@microsoft.com,John.Emau@microsoft.com,michael.liao@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963183 Change-Id: I2394267653ca13107a2c28d3410a316ce606bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985016Reviewed-by:
-
