- 18 Jun, 2018 17 commits
-
-
Giovanni Ortuño Urquidi authored
This reverts commit b0278053. Reason for revert: UserAddingScreenTest.ScreenVisibility has been flaky since this landed: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=UserAddingScreenTest.ScreenVisibility [28936:28936:0617/213745.316026:FATAL:accelerator_manager.cc(32)] Check failed: !base::ContainsValue(targets, target). Registering the same target multiple times #0 0x000004980f5c base::debug::StackTrace::StackTrace() #1 0x000004902b4b logging::LogMessage::~LogMessage() #2 0x000005857d49 ui::AcceleratorManager::Register() #3 0x000001ca3442 chromeos::WebUILoginView::WebUILoginView() #4 0x000001c9a51c chromeos::LoginDisplayHostWebUI::InitLoginWindowAndView() #5 0x000001c98cc5 chromeos::LoginDisplayHostWebUI::OnStartUserAdding() #6 0x000001ca20c7 chromeos::(anonymous namespace)::UserAddingScreenImpl::Start() #7 0x0000015dfd1c chromeos::UserAddingScreenTest_ScreenVisibility_Test::RunTestOnMainThread() #8 0x000004f449b7 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() Original change's description: > Support feedback keyboard shortcut in views login screen. > > This CL supports alt+shift+i to open the feedback dialog in views login > screen. > > Bug: 852242 > Change-Id: I9a285c6929fd2302d22f90fbefbb32bcd814359d > Reviewed-on: https://chromium-review.googlesource.com/1102035 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567829} TBR=xiyuan@chromium.org,tsepez@chromium.org,jdufault@chromium.org,xiaoyinh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852242, 853445 Change-Id: I21afadf31af3c9ae8e04a30f6021b928efde43f8 Reviewed-on: https://chromium-review.googlesource.com/1103957 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#567935}
-
François Beaufort authored
This make sures requestPictureInPicture is resolved with existing Picture-in-Picture window when video is already pictureInPictureElement. Bug: 806249 Change-Id: I16e3fc2e8e19c2b623e8d2518fe4672a2a16b756 Reviewed-on: https://chromium-review.googlesource.com/1101686 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#567934}
-
Dirk Pranke authored
This sets the gpu=none flag explicitly to get the browser_tests to run on the VMs in the Chrome-quarantine pool on Mac10.12, to avoid any confusion with the default gpu values for the other test suites. This also temporarily turns off the browser_tests on 10.10, since it looks like we're probably too low on capacity there to handle this easily. We'll add more tomorrow and try again. TBR=jbudorick@chromium.org BUG=828031 NOTRY=true Change-Id: Ib948ba17c2bb3b4fb56912a9c612e72fa5e08f11 Reviewed-on: https://chromium-review.googlesource.com/1103938 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567933}
-
Giovanni Ortuño Urquidi authored
This reverts commit f34bba7c. Reason for revert: A lot of tests are failing on Mac10.10 and Mac10.12. Looking at both blame[1][2] lists when the tests started failing, this seems like the most likely culprit. [1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33158 [2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13801 Original change's description: > Simplify in-process URLRequestContext creation with the NetworkService. > > The old code hooked up things to the URLRequestContext that hadn't been > ported over to work with the NetworkService yet, when the NetworkService > was enabled. This CL just does the minimum setup that's needed to not > crash. It also makes requests made with the in-process URLRequestContext > fail when the network service is enabled. These changes will help > identify code that still depends on the legacy path, and allow for some > cleanup of URLRequestContextBuilderMojo and NetworkContext. > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I4c3f40e6dc3c235844846bff7d1d43d0b1c986d0 > Bug: 825242 > Reviewed-on: https://chromium-review.googlesource.com/1096075 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567879} TBR=jam@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825242 Change-Id: I36da9fb06fa89296e031c88d7c75c16e63f3b725 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1103818 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Joel Hockey authored
* Defer call of setupCrostini_ until after |setupAndWaitUntilReady| to ensure UI has been created. * Stopped sending 'onDirectoryChanged' events for downloads and drive after adding new items and instead click Downloads entry to select it, or click Refresh button if downloads is already selected to ensure new items are refreshed and shown. Bug: 853594 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I47a7e062f8d9cbce44b68ee5203f545c9635a195 Reviewed-on: https://chromium-review.googlesource.com/1103428Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#567931}
-
Koji Ishii authored
Following bot results are included. 6871 6875 6881 6883 6884 6885 6888 6890 6895 6896 6897 6898 6901 6902 6903 6904 6905 6 lines were removed and 3 lines were deflaked by consecutive results since 6885. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I83cd32b138ea61591a8a853ce2040d6f1c5bab97 Reviewed-on: https://chromium-review.googlesource.com/1102220 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567930}
-
Julie Jeongeun Kim authored
Each Ozone platform creates its own NativeDisplayDelegate to get display information. Otherwise, 'display::FakeDisplayDelegate' is used for NativeDisplayDelegate. Per bug, ozone headless is crashing because it uses FakeDisplayDelegate and it doesn't invoke OnConfigurationChanged before initialization completes so ScreenBase can't add the display. Once NativeDisplayDelegate is initialized, DesktopScreenOzone requires DisplayMode from DisplaySnapshot but FakeDisplayDelegate has FakeDisplaySnapshot and it doesn't have DisplayMode. This CL creates HeadlessNativeDisplayDelegate which owns DisplaySnapshot and DisplayMode for ozone/headless. DesktopScreenOzone keeps it in delegate_ and communicates with it. To try this, compile with the following gn args use_ozone = true ozone_platform_headless = true TEST=./out/Debug/chrome --ozone-platform=headless Bug: 851375 Change-Id: Ib0d6dc66e6d9c538db38e1c6f04c35b149f9b6e6 Reviewed-on: https://chromium-review.googlesource.com/1094851Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#567929}
-
Yingbing Wu authored
[VK] Expose enable-virtual-keyboard-md-ui flag value to the keyboard configuration of API "chrome.virtualKeyboardPrivate.getConfig". Change-Id: I7c8832c8d7a259774a2377eab60227f93b291c0a Reviewed-on: https://chromium-review.googlesource.com/1103421Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yingbing Wu <wuyingbing@chromium.org> Cr-Commit-Position: refs/heads/master@{#567928}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: Ibc55a90da18855ef34dae046823f83c6992ce41d Reviewed-on: https://chromium-review.googlesource.com/1102281Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567927}
-
Christopher Cameron authored
Running a full nested NSRunLoop appears to cause problems wherein CATransactions are created from within a CATransaction's commit handlers. Bug: 853438 Change-Id: I37e9d3f92025c8b45201e23109a87e02afd6085c Reviewed-on: https://chromium-review.googlesource.com/1100239 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567926}
-
Tetsui Ohkubo authored
ash_view_ids.h will be used frequently in browser tests under chrome/browser, so it should be in ash/public/cpp. TEST=trybots pass BUG=none Change-Id: I1df387234969908e6659c1596583b6d46ad01185 Reviewed-on: https://chromium-review.googlesource.com/1102278 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#567925}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ife202f3a80590b2c2538c5edf6ef8bf0a4e9dedc Reviewed-on: https://chromium-review.googlesource.com/1103774Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567924}
-
Blake O'Hare authored
If you adjust the volume while the virtual keyboard is loaded, the slider will be hidden underneath the keyboard. Bug: 836155 Change-Id: Ia4f4c116906f80058772decc8420c8021f463aa6 Reviewed-on: https://chromium-review.googlesource.com/1096585Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Dirk Pranke authored
This re-enables just the browser_tests suite on the chromium.mac bots and the matching trybots. The tests on Mac10.13 Tests are still marked as experimental, so failures there won't block the CQ. The re-enabled tests will run in the 'Chrome-quarantine' pool, which means that if the tests kill the machines, it should only affect the machines in that pool, and not the machines in the main 'Chrome' pool. The tests are still disabled on chromium.clang, chromium.fyi, and chromium.memory, and viz_browser_tests and surface_sync_browser_tests are still disabled everywhere. If it looks like this approach is working, we can reenable those as well as long as they go into the quarantine pool. R=jbudorick@chromium.org BUG=828031 NOTRY=true Change-Id: I2e914b68584fd4d718aba246906f38b0724a08f1 Reviewed-on: https://chromium-review.googlesource.com/1103796 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567922}
-
Dirk Pranke authored
With the creation of the new 'Chrome-quarantine' pool we accidentally left the 10.12 'Chrome' pool with no 'gpu: none' machines (i.e., no VMs) to run tasks. This CL shifts all of the tests to physical machines where we should have capacity. TBR=jbudorick@chromium.org BUG=828031 NOTRY=true Change-Id: I1624d86887e65913330bc11b0cb1b05ddc05e1f9 Reviewed-on: https://chromium-review.googlesource.com/1103846 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Penny MacNeil authored
This does not "turn on" full blocking. The new hook will be in place, ready to block, but behavior will be determined by chrome/browser/conflicts/* in future CLs. The hook will default allow load. Tests: chrome_elf_unittests.exe, ThirdParty* Bug: 769590 Change-Id: I97b1f1d368a160e0f9856dfb55a0242af350328d Reviewed-on: https://chromium-review.googlesource.com/1076972Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#567920}
-
Ben Wagner authored
The Skia change has landed, so remove this compile flag and rebaseline. BUG=chromium:698492 Change-Id: I9446021ae0ccd908abee40226e81bf6c99819af8 Reviewed-on: https://chromium-review.googlesource.com/1102730Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567919}
-
- 17 Jun, 2018 17 commits
-
-
Darren Shen authored
Some classes listen to ShellObserver::OnVirtualKeyboardStateChanged in order to add/remove KeyboardController observer when the keyboard is enabled/disabled. However, with the simplified KeyboardController lifetimes, we can add/remove observers whenever. So we just add an observer in the constructor and remove it in the destructor. After this change, there will be no more observers of OnVirtualKeyboardStateChanged. Bug: 731537 Change-Id: I7274484229ff5f64ac973806e565f178a271094f Reviewed-on: https://chromium-review.googlesource.com/1101598Reviewed-by:
-
Dirk Pranke authored
TBR=robertma@chromium.org BUG=853360 NOTRY=true Change-Id: Ic5dac923094175223964c999b74f41f82273f63f Reviewed-on: https://chromium-review.googlesource.com/1103839 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Dirk Pranke authored
Something in one of the browser_tests suites seems to be killing machines across all Mac versions. This CL disables browser_tests, viz_browser_tests, and surface_sync_browser_tests across all Mac versions until we can better figure out which tests are safe and which aren't. Ideally we'd split some of the bots into a different pool and just run the browser_tests in that pool so that they don't take out the rest of the fleet, and I'll work on that next. TBR=jbudorick@chromium.org BUG=828051 NOTRY=true Change-Id: I133fb9e4a3db85fce2231d0e3f906ceecece122d Reviewed-on: https://chromium-review.googlesource.com/1103793 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Dirk Pranke authored
As part of cleaning up tryserver.blink and chromium.webkit I need to green up all of the Mac builders. I think most of these failures are either flakes or need rebaselines, but I'll suppress them first and then work through them. TBR=robertma@chromium.org NOTRY=true BUG=853360 Change-Id: Ib15695a2c7e6f0e077fe5de08b2802713e51d6d3 Reviewed-on: https://chromium-review.googlesource.com/1103714 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Abhishek Arya authored
This reverts commit 2394d0ac. Reason for revert: Caused ClusterFuzz regressions - 853522, 853537, 853538, 853540. Original change's description: > Floats and out-of-flow objects may not be adjacent to anonymous blocks. > > Floats and out-of-flow objects need to be true layout siblings of the > inlines, or rendering will be wrong. This means that such objects should > never be siblings of anonymous blocks, but rather inside them. This > already works correctly for initial layout tree building, and also for > many DOM manipulations. However, code was missing to satisfy this > requirement if we removed a regular block that was a sibling of an > anonymous block and either a float or out-of-flow positioned object. > > This even caused a crash triggered by ruby code, which ended up mixing > inline and block children within the same container. That is not > allowed. This happened in the MoveAllChildrenIncludingFloatsTo() call > inside LayoutRubyBase::MoveBlockChildren(). Added a DCHECK to > MoveAllChildrenIncludingFloatsTo() (which could fail prior to this fix); > When moving children from one container to another, either both or none > of the containers must have inline children. > > Bug: 852640 > Change-Id: I51d3de12c73ddd07d6b4c1aa55221b4f92359ca7 > Reviewed-on: https://chromium-review.googlesource.com/1102690 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567882} TBR=eae@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852640 Change-Id: I0af60d9eac770f21b6a0fbeccf88bb43d5efd6fb Reviewed-on: https://chromium-review.googlesource.com/1103503Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#567914}
-
Aleksei Loshkarev authored
Now ModelTypeController:Stop uses preferences to determine if data type will be disable completely. This CL introduce adds metadata_fate parameter which will be used as signal for clearing metadata. This is second CL in sequence. Bug: 823721 Change-Id: Idfe4a70864e2f05aba9fc1ede3b0ccc2a108287a Reviewed-on: https://chromium-review.googlesource.com/1093318 Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567913}
-
Dirk Pranke authored
This last set of tweaks fixes the swarming configs for a couple of builders. It looks like things should be back to working now. TBR=hinoka@chromium.org NOTRY=true BUG=853040 Change-Id: Id485754a30a8a22cef5e39e5ea601c78e23cd7d8 Reviewed-on: https://chromium-review.googlesource.com/1103781Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7675b369322e..0242b59c0aaf git log 7675b369322e..0242b59c0aaf --date=short --no-merges --format='%ad %ae %s' 2018-06-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@0242b59c0aaf The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ic89101457e08ff607f3c9ab37210d664d51aee86 Reviewed-on: https://chromium-review.googlesource.com/1103797Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567911}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: Idc4910a620ea1f7a5ebbe89b94668f9c570ea64b Reviewed-on: https://chromium-review.googlesource.com/1103769Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567910}
-
Aleks Totic authored
Reland of 1101826. Was reverted in 1102517 because of WebKit Win10 test failure. Cause of failure is that Win10 expectations were not there. This test has Win7 specific expectations, and no Win10 expectations. non-virtual version is skipped on Win10. Bug: 849751 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I57b74eab41848db28fa0b19b0e2f3fcfc210d8fa Reviewed-on: https://chromium-review.googlesource.com/1102889Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#567909}
-
Han Leon authored
To follow the spec, this CL lets ServiceWorkerRegistration#update() resolve to a registration object (actually the ServiceWorkerRegistration object itself) rather than undefined before. Entry on the feature dashboard: https://www.chromestatus.com/feature/5436747060084736 BUG=836217 Change-Id: I090d896e541e76143baa29d0b9d175a54e04ef2e Reviewed-on: https://chromium-review.googlesource.com/1100736Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#567908}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ia276782a03e233698c3cd82d8d0b03b447dc9ac1 Reviewed-on: https://chromium-review.googlesource.com/1103765Reviewed-by:
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/281c390193ec..9a518d097dca $ git log 281c39019..9a518d097 --date=short --no-merges --format='%ad %ae %s' 2018-06-16 maruel [swarming] Implement NamedCache.cleanup() 2018-06-16 maruel [client] Fix 3 issues for the cost of one CL 2018-06-15 maruel [client] Fix cache LRU coherency 2018-06-15 maruel [client] Fix Memory CAC to be LRU, internal cleanups 2018-06-14 maruel [client] cache the named cache size; stop keeping empty caches 2018-06-14 maruel [client] Update lru.py and test 2018-06-13 maruel [client] Refactor the caches to stop using context manager 2018-06-13 iannucci [swarming] Actually apply pool based TaskTemplates. Created with: roll-dep src/tools/swarming_client TBR=qyearsley@chromium.org Bug: 801046, 824832 Change-Id: Id2dd2bc2b0295d96726eb200f6e9a0cc8aea1eb7 Reviewed-on: https://chromium-review.googlesource.com/1103534Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#567906}
-
Chris Harrelson authored
For CPU traces of intersection-observer/deep-layers.html, this avoids > 4% of runtime. Bug: 831762 Change-Id: If7e3cf6b37b7e9e724856c2c2e0b0f7ec33739e1 Reviewed-on: https://chromium-review.googlesource.com/1102024 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567905}
-
Dirk Pranke authored
Revert "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element" This reverts commit a65d8a04. Reason for revert: I think this broken the layout tests on 32-bit Win10, see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36552 Original change's description: > Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element > > R=nektar@chromium.org,dmazzoni@chromium.org > > Bug: 844149 > Change-Id: I7e92097761057c8fb795582098f54daeb00ef204 > Reviewed-on: https://chromium-review.googlesource.com/1099434 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567899} TBR=dmazzoni@chromium.org,nektar@chromium.org,suproteem@chromium.org Change-Id: I0efca59b219cc9432d14e68f340c3dff12f4ef76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844149 Reviewed-on: https://chromium-review.googlesource.com/1103502Reviewed-by:
-
Dirk Pranke authored
This removes three more entries I missed in my last two go-rounds. TBR=hinoka@chromium.org NOTRY=true BUG=853040 Change-Id: I89e2397d8f0ce8b307281b0eccfae826611a8676 Reviewed-on: https://chromium-review.googlesource.com/1103715 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Dirk Pranke authored
I missed these in the previous cleanup, and I apparently also missed one entry for one of the compile-only trybots that I removed. TBR=hinoka@chromium.org BUG=853040 NOTRY=true Change-Id: I10b5f968fab5c4f065df921eabb68ceec73feb94 Reviewed-on: https://chromium-review.googlesource.com/1103713Reviewed-by:
-
- 16 Jun, 2018 6 commits
-
-
David Bokan authored
This patch implements basic functionality for the visual viewport in blink-gen-property-trees mode. This patch does several related things: - Create PaintPropertyNodes in the VisualViewport during Blink's PrePaint walk. - Ensure PaintArtifactCompositor propagates these new nodes to CC - Setup and add viewport layers to PaintArtifactCompositor's foreign layers so they get correctly hooked into the layer tree in CC Bug: 840017 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idcba9cdf90a9cde7534e5bff4ff37fe55bdc16e7 Reviewed-on: https://chromium-review.googlesource.com/1083012 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Dirk Pranke authored
The following builders are redundant with builders on the chromium.mac and chromium.win waterfalls, and so we can remove them instead of migrating them to LUCI: - linux_trusty_blink_compile_dbg - linux_trusty_blink_compile_rel - linux_trusty_blink_dbg - win7_blink_compile_dbg - win7_blink_compile_rel - win7_blink_dbg - WebKit Linux Trusty - WebKit Linux Trusty (dbg) - WebKit Mac Builder (dbg) - WebKit Mac10.10 - WebKit Mac10.11 - WebKit Mac10.11 (dbg) - WebKit Mac10.12 - WebKit Win Builder (dbg) - WebKit Win7 - WebKit Win7 (dbg) - WebKit Win x64 Builder - WebKit Win x64 Builder (dbg) They were all either already just placeholder bots that were basically not doing anything interesting or trybots that basically weren't needed. BUG=853040 NOTRY=true Change-Id: Ifca05f1a570d660bb573cfffe124f2128a84623c Reviewed-on: https://chromium-review.googlesource.com/1096548 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#567900}
-
Suproteem Sarkar authored
Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element R=nektar@chromium.org,dmazzoni@chromium.org Bug: 844149 Change-Id: I7e92097761057c8fb795582098f54daeb00ef204 Reviewed-on: https://chromium-review.googlesource.com/1099434 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567899}
-
Dirk Pranke authored
This reverts commit 083b6f26. Reason for revert: I think this is causing crashes on Mac 10.13 (dbg). See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/3362. Original change's description: > Roll SwiftShader 88482c3..700a1a6 > > https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..700a1a6 > > BUG=chromium:845700, chromium:852641, chromium:851707 > > TBR=kbr@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel > > Change-Id: Ic36ddc1988cd83970a4a53b52a1ce1b229d17137 > Reviewed-on: https://chromium-review.googlesource.com/1102886 > Commit-Queue: Nicolas Capens <capn@chromium.org> > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567894} TBR=sugoi@chromium.org,capn@chromium.org Change-Id: I96e96329f4de1581ca11fca443fa943e58ce8f4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845700, chromium:852641, chromium:851707 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1103398Reviewed-by:
-
Chris Harrelson authored
Now that RLS exists, the LayoutView has a different ClipPaintPropertyNode than every other node. Therefore PLC::CalculateRects will need to calculate a clip across this node difference for every PaintLayer. We don't need this clip at all, since the IOv1 parts of IO already handle such clipping. For CPU traces of intersection-observer/deep-layers.html, this avoids about 4% of runtime. Bug: 831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2faa6761edc15854d35cd4a18a466383b6c9d5d8 Reviewed-on: https://chromium-review.googlesource.com/1101970Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad910ae2. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 1db32e09 "OffscreenCanvas Text rendering tests" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19736 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes TBR=robertma No-Export: true Change-Id: I0591819530aa6198f37f4244cded0f714bf9cee4 Reviewed-on: https://chromium-review.googlesource.com/1103702 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#567896}
-
