GitLab

Fix a potential crash when we have an active user, but its profile
is not ready yet.

BUG=713934

Review-Url: https://codereview.chromium.org/2864453003
Cr-Commit-Position: refs/heads/master@{#469386}

This CL adds a test for a feature added in CL 2839653002, merged to M59.
The test has been implemented along with the original CL but is uploaded
separately to speed up the process (avoiding deps changes).

BUG=705572

Review-Url: https://codereview.chromium.org/2852383002
Cr-Commit-Position: refs/heads/master@{#469385}

Re-disables WebVrTest#testScreenTapsRegisteredOnCardboard, but only on L
instead of of everything.

TBR=dtrainor@chromium.org
BUG=713781

Review-Url: https://codereview.chromium.org/2855123006
Cr-Commit-Position: refs/heads/master@{#469384}

Change compile targets for Linux Clang Analyzer from "all" to "chrome".

R=dpranke@chromium.org
BUG=689095

Review-Url: https://codereview.chromium.org/2850853002
Cr-Commit-Position: refs/heads/master@{#469383}

This is somewhat catastrophic (it results in blank contents or black
tiles), so be sure that it is captured in about:gpu.

BUG=574014

Review-Url: https://codereview.chromium.org/2858683004
Cr-Commit-Position: refs/heads/master@{#469382}

Extends PromoDialog to support vector drawables, and replaces
the large search_sogou.png asset with a vector drawable.

Replaces 131,070 bytes with 4,834.

BUG=666062

Review-Url: https://codereview.chromium.org/2857893003
Cr-Commit-Position: refs/heads/master@{#469381}

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL24_part1.

Goal of CL24:
The interface content::VideoCaptureProvider currently has one implementation
called InProcessVideoCaptureProvider, which is essentially a factory for the
legacy in-process video capture stack. This CL adds a second implementation
called MojoServiceVideoCaptureProvider which is essentially a wrapper for
connecting to and communicating with the new video capture service.

Changes in part1:
* Add class MojoServiceVideoCaptureProvider
* Add skeletons for classes MojoServiceVideoCaptureDeviceLauncher and
  MojoServiceLaunchedVideoCaptureDevice
* Introduce a build flag enable_mojo_video_capture to prevent the new and
  incomplete code from going into builds.

BUG=584797
TEST=
  service_unittests --gtest_filter="*Video*"
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2848973002
Cr-Commit-Position: refs/heads/master@{#469380}

In the JUnit4 conversion CL (https://codereview.chromium.org/2815453003)
super.tearDown() call was mistakenly removed.

BUG=718454

Review-Url: https://codereview.chromium.org/2861433006
Cr-Commit-Position: refs/heads/master@{#469379}

Hard-code TEMPDIR/TMPDIR for "Xvfb" to "/tmp" in webkitpy's Linux layout
test port. The Xvfb tool's "xkb" library compiles in "/tmp" in several
places, and hard-linking expectations get violated if TEMPDIR and "/tmp"
are on different filesystems.

BUG=chromium:715848
TEST=local
  - Ran without patch and TEMPDIR/TMPDIR overrides, verified hardlink
    failure from bug.
  - Ran with patch, no more hardlink failure!

Review-Url: https://codereview.chromium.org/2859703002
Cr-Commit-Position: refs/heads/master@{#469378}

- Consolidate callback factories in OutOfProcessInstance.
- Make PDFEngine::Create() return a unique_ptr.
- Unify LoadUrl methods.

Review-Url: https://codereview.chromium.org/2837663002
Cr-Commit-Position: refs/heads/master@{#469377}

https://pdfium.googlesource.com/pdfium.git/+log/8384757b2b00..df673c28191c

$ git log 8384757b2..df673c281 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 dsinclair Cleanup more null IFX_Pause parameters
2017-05-04 dsinclair Remove some unused IFX_Pause params

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I6195944d1434725871e800f62e1097275e84f5f7
Reviewed-on: https://chromium-review.googlesource.com/495411
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469376}

On Mac, //base/threading uses CoreFoundation, which causes forked child
processes to violate the framework's requirement that CF may not be used
after-fork-before-exec.

BUG=717490
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2865453002
Cr-Commit-Position: refs/heads/master@{#469375}

Seems the option isn't ready to click on immediately.
Wait until the option is non-null before moving forward.

BUG=718461

Review-Url: https://codereview.chromium.org/2861003002
Cr-Commit-Position: refs/heads/master@{#469374}

Review-Url: https://codereview.chromium.org/2854263004
Cr-Commit-Position: refs/heads/master@{#469373}

Bugs causing split-project and use-gradle-resources to not work
correctly. Also fix the jinja template.

BUG=620034

Review-Url: https://codereview.chromium.org/2858233002
Cr-Commit-Position: refs/heads/master@{#469372}

- Add the BackgroundDownloadService interface and associated files.  Set
up the test hooks and tie it into the proper Chrome and
component_unittest targets.

BUG=717180

Review-Url: https://codereview.chromium.org/2851303003
Cr-Commit-Position: refs/heads/master@{#469371}

The existing logic for checking whether the compositor has a scroll
corner layer is insufficient.  When the compositor runs
UpdateOverflowControlsLayers, it will delete its scroll corner layer
if the scroll corner isn't visible.  In this case, the paint code
should not try to paint the scroll corner.

The existing code causes a number of crashes in compositing tests
when this patch is applied:

https://codereview.chromium.org/2860433002

BUG=701575
R=pdr@chromium.org,chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2857333004
Cr-Commit-Position: refs/heads/master@{#469370}

This patch adds web platform tests that verify behavior of
PaymentRequest constructor. To match the spec, PaymentRequest
constructor in this patch has been changed to:
- Check for secure context before validating any parameters.
- Check the amount value first before checking the rest of the fields in
  each line item.
- Determine the selected shipping option even if requestShipping is
  false.
- Validate shipping options even if requestShipping is false.
- Validate shipping options before checking for duplicate shipping
  option IDs.
- Allow empty line item labels (but discourage via a console warning).
- Allow empty shipping option ID (but discourage via a console warning).
- Allow empty list of modifiers.

Because of changes in the WebIDL, certain conditions are not possible,
so they are ensured via DCHECK() in this patch instead of if statements
before this patch:
- Total is always present.
- Every line item has a label and amount.
- Every amount has value and currency.
- Every shipping option has an ID.
- Shipping type is always valid.

Invalid shipping type ("delivery", "shipping", or "pickup") is now
impossible because the WebIDL specifies it as an enum. Therefore,
there's no need for additional validation there.

To help developers better decipher the behavior of the API, error
messages have been improved in this patch. For example:
  "'-1/3' is not a valid amount for total."

Spec:
https://w3c.github.io/browser-payment-api/#constructor

BUG=705252

Review-Url: https://codereview.chromium.org/2851383002
Cr-Commit-Position: refs/heads/master@{#469369}

Previously only overflow shelf to main shelf, now bidirectional.

TEST=ash_unittests --gtest_filter="ShelfViewTest.*"
BUG=710228

Review-Url: https://codereview.chromium.org/2820693004
Cr-Commit-Position: refs/heads/master@{#469368}

Also removes obsolete config for
UMA_EnableCellularLogUpload.

BUG=none

Review-Url: https://codereview.chromium.org/2860103002
Cr-Commit-Position: refs/heads/master@{#469367}

The delay not fix the bug on Rialto, so I'm removing it.

BUG=chromium:710716
TEST=unit test

Review-Url: https://codereview.chromium.org/2854393003
Cr-Commit-Position: refs/heads/master@{#469366}

JumpList

Currently there're lots of redundant of favicon loading calls in
JumpList update. The total time cost of one favicon loading process
consists of the runtime of one StartLoadingFavicon call, one
asynchronous GetFaviconImageForPageURL call and one
OnFaviconDataAvailable call.

UMA currently knows the total amount of GetFaviconImageForPageURL
function calls and their runtime distribution. However, UMA doesn't
know its exact contribution from the JumpList update. It would be nice
to log some information from the JumpList class so that we know how
much we can possibly improve.

BUG=40407, 179576, 717236

Review-Url: https://codereview.chromium.org/2860573005
Cr-Commit-Position: refs/heads/master@{#469365}

https://skia.googlesource.com/skia.git/+log/40c0f249e60d..342a9fa8e1c0

$ git log 40c0f249e..342a9fa8e --date=short --no-merges --format='%ad %ae %s'
2017-05-03 reed add virtual to support CTFontRef
2017-05-04 jvanverth Combine the ambient and spot alphas into the base color for geometric shadows.
2017-05-03 mtklein move dither after the transfer function
2017-05-04 jvanverth Fix spot shadow inset.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I2780f89bfa9ceb98595691be9caf8c4b0d44706a
Reviewed-on: https://chromium-review.googlesource.com/495571Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469364}

This CL was generated mechanically with:

$ git grep -l m_scriptState -- third_party/WebKit/Source | \
      xargs -n 1 sed -i -e 's/\bm_scriptState\b/script_state_/g'

No intended behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2857853007
Cr-Commit-Position: refs/heads/master@{#469363}

This still can't be removed until secondary MD is on by default (and it
can't be protected for now either since Translate is still using it).
Rename to SetStyleDeprecated to discourage further use.

BUG=642920

Review-Url: https://codereview.chromium.org/2855093002
Cr-Commit-Position: refs/heads/master@{#469362}

The tested settings have a button just at the bottom end of the screen on small devices. Tapping the button results in showing a snackbar, which covers the button on small devices. testCopyPasswordToast in particular needs to tap the copy button twice. The second tap was impossible on small devices because the snackbar was still around, blocking the button.

This CL adds two actions to prevent this issue:

(1) While checking for the snackbar, the test also taps it, causing it to close. The test waits for the fade-out animation to finish.

(2) The test also uses usingSearchAction:grey_scrollInDirection to ask EarlGrey to scroll until the control is clickable.

Even though either single option from the above would fix the current issue, the CL contains both: (2) because it will also be useful on smaller devices, e.g., should we start testing in landscape mode (see https://crbug.com/717548 and also https://crbug.com/717163 for another blocker for landscape mode), where the buttons will be off the screen instead of just being covered. It also includes (1), because cleaning up the snackbar explicitly seems like a reasonable thing to do. Speaking of cleaning up, the CL also:

(3) Forcibly closes all passwords-related snackbars on teardown. This will be useful when the test fails in the middle, leaving a snackbar up. If not foce-closed, such snackbar would remain visible for (currently) 4 seconds, which might be enough to interfere with the next test.

The CL also applied (1) and (2) to two other tests in the same suite as well. Those deal with similar buttons, which are currently high enough not to experience the problem with being blocked. This secures them in case that, e.g., the layout changes in the future.

Note that while (2) is clearly beneficial, it also has a drawback: the search action takes a considerable amount of time (about 2 seconds per one scrolling step on my computer). With it, the tests are more likely to time out. If there is an issue with timing out in the future, we should increase kScrollAmount to speed up the scrolling, or split long tests (testCopyPasswordToast is a particular candidate).

BUG=718043

Review-Url: https://codereview.chromium.org/2860453004
Cr-Commit-Position: refs/heads/master@{#469361}

This allows them to be on for the continuous official Win builders.

BUG=629964,717947

Review-Url: https://codereview.chromium.org/2860093002
Cr-Commit-Position: refs/heads/master@{#469360}

No one seems to care about the RedirectInfo. Leave it alone.

BUG=

Review-Url: https://codereview.chromium.org/2855343002
Cr-Commit-Position: refs/heads/master@{#469359}

Combine the 8 keyUsage generator scripts into a single one.
(And delete the redundant keys).

Review-Url: https://codereview.chromium.org/2859053002
Cr-Commit-Position: refs/heads/master@{#469358}

This patch changes the draw dash rect to use SkDashPathEffect instead
of a bitmap shader to produce a dash effect. The visual result is
different, but I think it's still acceptable. Please take a look
at the referenced bug for the list of comparison.

R=danakj@chromium.org, enne@chromium.org
BUG=718084

Review-Url: https://codereview.chromium.org/2863453002
Cr-Commit-Position: refs/heads/master@{#469357}

FirstRunIntegrationTest.testDefaultSearchEngine_ShowExisting was
recently added by https://codereview.chromium.org/2844323003.

However it's been consistently failing on Lollipop Phone Tester, and
flakily failing on other Android bots, so this patch disables it.

BUG=718461
TBR=dfalcantara
NOTRY=true
SKIPTREECHECKS=true

Review-Url: https://codereview.chromium.org/2863653002
Cr-Commit-Position: refs/heads/master@{#469356}

On desktop platforms, this lets you quickly reveal the log file in the shell
after logging has completed.

BUG=718062

Review-Url: https://codereview.chromium.org/2857973003
Cr-Commit-Position: refs/heads/master@{#469355}

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- V8DOMWrapper.h
- V8GlobalValueMap.h
- V8ObjectConstructor.h
- V0CustomElementBinding.h
- V8Binding.h
- V8BindingMacros.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856743002
Cr-Commit-Position: refs/heads/master@{#469354}

Move the network quality estimator (NQE) config params from
n_q_e.cc to n_q_e_params class. This is a refactor change with no
functional change. Long term, this would make it easier for net
embedders (Chrome and Cronet embedders) to configure NQE.

BUG=638308
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2858743002
Cr-Commit-Position: refs/heads/master@{#469353}

BUG=663085
R=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2863533002 .
Cr-Commit-Position: refs/heads/master@{#469352}

Some preparatory work for introducing new internal IPC protocol. Cleans
up how Mojo is initialized, deletes some dead code, reoganizes embedder
API surface and extends existing documentation, establishes the basic
concepts of broker and broker client processes, and introduces a nominal
unified API for managing physical process connections.

BUG=696031
TBR=alokp@chromium.org
TBR=tsepez@chromium.org

Change-Id: Ibb8750218dc672e73ecf46aa5c3cb540769d46a0
Reviewed-on: https://chromium-review.googlesource.com/495371Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469351}

String parameters were being passed by value instead of by const
reference by mistake.

BUG=718242

Review-Url: https://codereview.chromium.org/2862843002
Cr-Commit-Position: refs/heads/master@{#469350}

Downloads, history and bookmarks all have utility methods that open
their UIs. When Chrome Home is enabled, opening these UIs should
open the bottom sheet and show the corresponding BottomSheetContent.
Typed urls (e.g. chrome://history) will still open as native pages
rather than in the sheet.

Also adds tests for the BottomSheetContentController.

BUG=716250

Review-Url: https://codereview.chromium.org/2861453002
Cr-Commit-Position: refs/heads/master@{#469349}

BUG=717483
R=sczs@chromium.org
TEST=See steps in bug.

Review-Url: https://codereview.chromium.org/2862583005
Cr-Commit-Position: refs/heads/master@{#469348}

https://pdfium.googlesource.com/pdfium.git/+log/cbdf926884c4..8384757b2b00

$ git log cbdf92688..8384757b2 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 npm More cleanup in CFX_ScanlineCompositor
2017-05-03 tsepez CPDF_DataAvail: avoid reads into stack buffers.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If9eaedc5b536a85a9647e9b88d453a113444268b
Reviewed-on: https://chromium-review.googlesource.com/495869
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469347}