- 28 Jun, 2018 40 commits
-
-
Farah Charab authored
Set priority of ad frames to low or best effort depending on the feature list enabled. Bug: 856150 Change-Id: Ia76d55e1fc4b8617d5db9bca26b79ac25b5856c9 Reviewed-on: https://chromium-review.googlesource.com/1112251Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#571103}
-
Greg Kraynov authored
Depot tools download the GN here now. Bug: 855791 Change-Id: Id2d60230331b90ff97018493892189deed5bbb77 Reviewed-on: https://chromium-review.googlesource.com/1118269Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571102}
-
Elad Alon authored
Some functions ended up having more overloaded versions than is reasonable; templates to the rescue. 1. Move MaybeReply from .h to .cc, made it into a template, and used it in a few additional cases. 2. Made MaybeReply take a base::Location&, rather than hard-code the location of the helper function itself. 3. Created a template for Reply and ReplyClosure in the unit test suite. Bug: 775415 Change-Id: Ie2c9e31defd045535845d198c658f0859ef99228 Reviewed-on: https://chromium-review.googlesource.com/1114615 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571101}
-
Yi Gu authored
This reverts commit 30184c71. Reason for revert: <suspecting that this patch caused unit test SSLErrorHandlerDateInvalidTest.TimeQueryHangs flaky, crbug.com/857446> Original change's description: > Add a test helper method in services/network to get the body from a ResourceRequest. > > Also remove the custom URLLoaderFactory in content_hash_fetcher_unittest. This isn't needed anymore as TestURLLoaderFactory now supports Clone. > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Id70ec605886a6b0f2cb9bf7392fac4eff85fc1b3 > Reviewed-on: https://chromium-review.googlesource.com/1115346 > Reviewed-by: Doug Turner <dougt@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570813} TBR=jam@chromium.org,dougt@chromium.org Change-Id: I2bd852fbf746203e325e6a859ad2b5cc2919b7e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1117521Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571100}
-
Fredrik Söderquist authored
While the underlying SVGResource should be unique (or nullptr - for invalid cases), the StyleSVGResource wrapper usually isn't. Hence we need to use DataEquivalent(...) to properly determine equality. Bug: 769774, 855914 Change-Id: I333bc7a737d0635aabe35e39bb066edbc4282790 Reviewed-on: https://chromium-review.googlesource.com/1118219Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#571099}
-
Jeremy Roman authored
Whitelist the one place which wants to query malloc usage, which is a memory reduction histogram on Android. Change-Id: I03a821aeec7b3b0524b02b432d2cea196b7a1f83 Reviewed-on: https://chromium-review.googlesource.com/1117634Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571098}
-
Antonio Gomes authored
URLFetcher et al will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. CL migrates SendProtocolRequest to the new API. Major remarks: * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs of the former is kept (are almost the same) in the later. This allows the extensive set of unit tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use. * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on. This is needed because of the nature of the tests: some tests manipulate the TestConfigurator directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it, eg PingManagerTest, UpdateCheckerTest and RequestSenderTest. Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates using EmbeddedTestServer in order to intercept URL loads. Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader), so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter. It will be done in a follow up CL. BUG=773295,844973 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04 Reviewed-on: https://chromium-review.googlesource.com/1097337 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571097}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56b60a2e..d3714bb8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I93ec403a2c990e082e806b037f1293553b35ef13 Reviewed-on: https://chromium-review.googlesource.com/1118007Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571096}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/64b17c2aca96..77cc8182aef6 git log 64b17c2aca96..77cc8182aef6 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 mbonadei@webrtc.org Pull GN via CIPD package. 2018-06-28 alexnarest@webrtc.org Adding ABWENoTWCC field trial 2018-06-28 terelius@webrtc.org Add return after NOT_REACHED() in eventlog unittest. Created with: gclient setdep -r src/third_party/webrtc@77cc8182aef6 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib9844e6d7c25671ddbdb96fe1ba12a8846a3bf81 Reviewed-on: https://chromium-review.googlesource.com/1117944Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571095}
-
John Delaney authored
The DelayUnsafeAds field trial parameters should only be queried if the client has AdTagging enabled. Bug: 856271 Change-Id: Ie4c19bb735c8b20c2454da21f12c3c7ce7cd4e02 Reviewed-on: https://chromium-review.googlesource.com/1117326Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#571094}
-
Hajime Hoshi authored
There is no usage of the constructor. Change-Id: I23cfe086745d2d6b395ee4a6e29c64304504a1d4 Reviewed-on: https://chromium-review.googlesource.com/1118075Reviewed-by:
-
Elad Alon authored
When a tab is closed, if other tabs do not have active peer connections, remote event logs collected on the first tab become eligible for upload. Bug: 775415 Change-Id: Id14b880753d90e0a4693bd5f966e1d674d4d850a Reviewed-on: https://chromium-review.googlesource.com/1116548 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#571092}
-
Hans Wennborg authored
A new Clang version caught these two cases. (While fixing localized_error.cc, switch the bitfields to unsigned and tweak a comment.) TBR=edwardjung,khushalsagar Bug: 857393 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I88bf4bfb2f3cf7874c308c9b3453e9d01c7c16ee Reviewed-on: https://chromium-review.googlesource.com/1118165Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#571091}
-
Arthur Hemery authored
Prepares moving DocumentState creation outside of DidCreateDocumentLoader. It does a few things: - Separates the paths between using pending_navigation_params_ and not using them to build DocumentState. - Removes the dependencies on navigation_state in DidCreateDocumentLoader. Instead we use the pending_navigation_params_ directly. Also removes reliance on default constructed values of CommonNavigationParams and RequestNavigationParams members. - Moved as much things as possible out of the main class into utilities in the anonymous namespace. - Stripped UpdateNavigationState that is now only used to update same document navigation states. Bug: 789577 Change-Id: I18d12d24827c3289ef909d9253fe8bbf6ca5080f Reviewed-on: https://chromium-review.googlesource.com/1109831Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Florin Malita authored
[1] updated web_url_request_util.cc:GetRequestBodyForWebHTTPBody() to use a WebData chunk iterator and push data to network::ResourceRequestBody one segment at a time. This introduced an issue downstream, in WebRequest's form data parser, where data was assumed to be contiguous. The issue was addressed in [2], by adding a non-trivial buffering mechanism in ParsedDataPresenter. Unfortunately, the incremental buffering seems to be problematic with large data payloads (blamed in the linked bug). Circling back to the original change, I noticed ResourceRequestBody::AppendBytes() does not perform any internal data consolidation, but in turn allocates and copies one segment at a time. Since the data is being copied anyway, there is no benefit to preserving segmentation: we might as well make a consolidating copy on the spot, and pass that to ResourceRequestBody. I propose the following in this change: - update SharedBuffer::Copy (currently only used in tests) to support both WTF::Vector and std::vector specializations (in order to be usable outside Blink) - expose Copy on WebData - add std::vector-moving variants of ResourceRequestBody::AppendBytes() and DataElement::SetToBytes() - (*) change GetRequestBodyForWebHTTPBody() to make an upfront/consolidating copy, and pass (move) the data to ResourceRequestBody as a single chunk - revert the ParsedDataPresenter buffering workaround introduced in [2] Essentially, this reverts the ResourceRequestBody segmentation changes introduced in [1] & [2], by making the data copy explicit. (*) <- this is the gist of the change, everything else is supporting or revert. [1] https://chromium-review.googlesource.com/c/chromium/src/+/581748 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1011322 Bug: 853500 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_mojo;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5f8d4bbaf7cc4b6372e868b4e62f6077bdf7d5a1 Reviewed-on: https://chromium-review.googlesource.com/1114258Reviewed-by:Ken Rockot <rockot@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#571089}
-
Alexander Timin authored
Fix a crash when queue was readded to RemoveFromIncomingImmediateWorkList during unregistration process when a different thread tried to post a task to it, leaving a dangling pointer. R=alexclarke@chromium.org Change-Id: Iac8c207699e3a08a4f792f705841bdfa1839b30c Reviewed-on: https://chromium-review.googlesource.com/1112239 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 310b4ff4. With Chromium commits locally applied on WPT: ab4fb5ca "Update links to feature policy documentation." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20296 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes kpaulhamus@chromium.org: external/wpt/webauthn mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity TBR=markdittmer No-Export: true Change-Id: Idbfe43f05f92b19ec150132cfd34d2f92996de61 Reviewed-on: https://chromium-review.googlesource.com/1118013 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571087}
-
Adam Rice authored
Also remove the unsafe version of IsReadableStream(). Remove BooleanOperation() helper from readable_stream_operations.cc as it is no longer used. Modify the tests to pass an ExceptionState& argument to IsReadableStream() and IsReadableStreamDefaultReader(). Bug: 853189 Change-Id: I26393861760e3bdab6991e522565067aabae5fb4 Reviewed-on: https://chromium-review.googlesource.com/1118089Reviewed-by:
-
Henrik Grunell authored
virtual/outofblink-cors/external/wpt/service-workers/service-worker/about-blank-replacement.https.html http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio.js TBR=tkent@chromium.org Bug: 857410, 857414 Change-Id: I422301df885098ca66b440d01b0fc5bd54a4a8a9 Reviewed-on: https://chromium-review.googlesource.com/1118167Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571085}
-
Michael van Ouwerkerk authored
Bug: 853732 Change-Id: I82029d1dd7067ab6d615b8cb77797f6edd5fe65a Reviewed-on: https://chromium-review.googlesource.com/1113752 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571084}
-
Ned Nguyen authored
This reverts commit 71b865f4. Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) Original change's description: > gtest perf tests: Output well formed test results json > > This CL changes the run_gtest_perf_test.py script to output well formed > test results json. > > Bug: 855234 > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > Reviewed-on: https://chromium-review.googlesource.com/1112635 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570943} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1118238Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571083}
-
Henrik Grunell authored
TBR=fdoray@chromium.org Bug: 857418 Change-Id: I70afce6260e3510fda0707cf36c5c5c21e07bc7b Reviewed-on: https://chromium-review.googlesource.com/1118173Reviewed-by:
-
Max Morin authored
The callback thread thread check may trigger if the SilentSinkSuspender sets in. Drive-by update the other thread check of this class to use a macro and add missing includes. Bug: 854774 Change-Id: I79f7c56886acd7f1ad56c466eb0c2825d1d8ec16 Reviewed-on: https://chromium-review.googlesource.com/1114973Reviewed-by:
-
Aleks Totic authored
This bug occurs when painting NG child inside non-inline vertical-rl parent with scrollbars. Root cause is extra scrollbar offset that Paint applies to Legacy painting that is not needed for NG. The fix is hacky: NG applies reverse offset. This fix does not make any additional tests pass or fail. Bug: 852395 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7dda2cdbf682485ab30c048987ae683981731886 Reviewed-on: https://chromium-review.googlesource.com/1115863 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#571080}
-
Jan Wilken Doerrie authored
This change implement adding new entry points for the new Autofill Home. Also it adds the required icons. Both of these changes are gated behind a flag. Bug: 854562 Change-Id: Iee5b029045b59875ad4d98bffb856ddc9945171a Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1111853 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571079}
-
Raphael Kubo da Costa authored
Move the test from TestExpectations to NeverFixTests, where all other clearkey-mp4-playback-* tests are. TBR=robertma, jrummell Bug: 857271 Change-Id: Id1931c5049d297b2dd70c6388e9369f4aa5ae94f Reviewed-on: https://chromium-review.googlesource.com/1118166Reviewed-by:
Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#571078}
-
Benoit Lize authored
Adds a simple tool writing random data to a file, then reading it. The file is optionally evicted from the OS page cache between the read and write. This is used to assess device IO performance locally. From an Android Go device (Gobo) running O MR1 with 360MB free on /data: Without the OS page cache: $ adb shell /data/local/tmp/io_benchmark /data/local/tmp/test 1 Size = 4096 Write 4096 = 50.0us (81.92MB/s) Read 4096 = 1489.0us (2.75MB/s) Size = 8192 Write 8192 = 61.0us (134.30MB/s) Read 8192 = 1486.0us (5.51MB/s) Size = 16384 Write 16384 = 81.0us (202.27MB/s) Read 16384 = 1602.0us (10.23MB/s) Size = 32768 Write 32768 = 145.0us (225.99MB/s) Read 32768 = 1877.0us (17.46MB/s) Size = 65536 Write 65536 = 215.0us (304.82MB/s) Read 65536 = 2656.0us (24.67MB/s) Size = 131072 Write 131072 = 468.0us (280.07MB/s) Read 131072 = 4531.0us (28.93MB/s) Size = 262144 Write 262144 = 642.0us (408.32MB/s) Read 262144 = 5041.0us (52.00MB/s) Size = 524288 Write 524288 = 1219.0us (430.10MB/s) Read 524288 = 8949.0us (58.59MB/s) Size = 1048576 Write 1048576 = 2466.0us (425.21MB/s) Read 1048576 = 13606.0us (77.07MB/s) Size = 2097152 Write 2097152 = 4908.0us (427.29MB/s) Read 2097152 = 25840.0us (81.16MB/s) Size = 4194304 Write 4194304 = 9502.0us (441.41MB/s) Read 4194304 = 76867.0us (54.57MB/s) Size = 8388608 Write 8388608 = 20814.0us (403.03MB/s) Read 8388608 = 119062.0us (70.46MB/s) With it: $ adb shell /data/local/tmp/io_benchmark /data/local/tmp/test 0 Size = 4096 Write 4096 = 56.0us (73.14MB/s) Read 4096 = 172.0us (23.81MB/s) Size = 8192 Write 8192 = 65.0us (126.03MB/s) Read 8192 = 23.0us (356.17MB/s) Size = 16384 Write 16384 = 101.0us (162.22MB/s) Read 16384 = 35.0us (468.11MB/s) Size = 32768 Write 32768 = 134.0us (244.54MB/s) Read 32768 = 57.0us (574.88MB/s) Size = 65536 Write 65536 = 229.0us (286.18MB/s) Read 65536 = 109.0us (601.25MB/s) Size = 131072 Write 131072 = 348.0us (376.64MB/s) Read 131072 = 170.0us (771.01MB/s) Size = 262144 Write 262144 = 721.0us (363.58MB/s) Read 262144 = 354.0us (740.52MB/s) Size = 524288 Write 524288 = 1895.0us (276.67MB/s) Read 524288 = 783.0us (669.59MB/s) Size = 1048576 Write 1048576 = 2405.0us (436.00MB/s) Read 1048576 = 2872.0us (365.10MB/s) Size = 2097152 Write 2097152 = 4688.0us (447.34MB/s) Read 2097152 = 3398.0us (617.17MB/s) Size = 4194304 Write 4194304 = 10358.0us (404.93MB/s) Read 4194304 = 6556.0us (639.77MB/s) Size = 8388608 Write 8388608 = 19040.0us (440.58MB/s) Read 8388608 = 17753.0us (472.52MB/s) TBR=digit@chromium.org # per tools/OWNERS Bug: 837659, 857070 Change-Id: I33fe4aeb287a5c5910c941a580093d9fecf8f758 Reviewed-on: https://chromium-review.googlesource.com/1116700 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#571077}
-
Yoichi Osato authored
This reverts commit deb6bb60. Reason for revert: This causes much crash on clusterfuzz. Original change's description: > Let SelectionPaintRange iterator iterate on a flat tree. > > SelectionPaintRange::Iterator iterated LayoutObjects using layout order > but we marks SelectionStatus on flat tree order. > This causes invalidation leak if they are not same order. > Ruby element is a reported example for that. > > This patch changes SelectionPaintRange::Iterator iterate on a flat tree > considering first-letter. > > Bug: 843144 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I02cbad86e64d0a7781f8fb37e2d13c7aa00228fb > Reviewed-on: https://chromium-review.googlesource.com/1063521 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569168} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843144, 855026 Change-Id: I745ab57ed70bd10e59bac20cf4f6fd591e170abd Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1118098Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#571076}
-
Sharon Yang authored
DCHECK_EQ now supports enum classes. Change-Id: I1b53aa3e2398bcc46b388448a73e700a74cd8602 Reviewed-on: https://chromium-review.googlesource.com/1116961 Commit-Queue: Sharon Yang <yangsharon@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571075}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/968b1dd0d7b4..64b17c2aca96 git log 968b1dd0d7b4..64b17c2aca96 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 danilchap@webrtc.org Remove StreamStatistician::IsPacketInOrder Created with: gclient setdep -r src/third_party/webrtc@64b17c2aca96 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I06c2861a657c6663f77eca48bf7d699361eb59d5 Reviewed-on: https://chromium-review.googlesource.com/1117943Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c03de9ae4eef..3511a8352adf git log c03de9ae4eef..3511a8352adf --date=short --no-merges --format='%ad %ae %s' 2018-06-28 ayatane@chromium.org sysmon: Count gs_offloader processes Created with: gclient setdep -r src/third_party/chromite@3511a8352adf The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853842 TBR=chrome-os-gardeners@chromium.org Change-Id: Id9712d304039ae9816dd6a7f134e566e130663cd Reviewed-on: https://chromium-review.googlesource.com/1117939Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571073}
-
Konstantin Ganenko authored
from the text. Previously RemoveSpellingMarkersUnderWords could clean markers totally. After this action RepaintMarkers did not triggeren on text nodes that had empty markers list, or there were no possible markers of spellcheck type at all. Now we invalidate each node we remove marker from. R=yosin@chromium.org Change-Id: I57b86134198b2cb40ab04c52859db4164d6e8555 Reviewed-on: https://chromium-review.googlesource.com/1114961Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3f423e75215c..bd16a937023d git log 3f423e75215c..bd16a937023d --date=short --no-merges --format='%ad %ae %s' 2018-06-28 hjd@google.com Merge "Create the directory structure" 2018-06-27 michaschwab@google.com Create the directory structure Created with: gclient setdep -r src/third_party/perfetto@bd16a937023d The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If13219d24a257652aae1e1022dcaf5e13d2e8489 Reviewed-on: https://chromium-review.googlesource.com/1117942 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571071}
-
Colin Blundell authored
IdentityProvider currently has baked-in knowledge of OAuth2TokenService for functionality that is shared between ProfileIdentityProvider and DeviceIdentityProvider. However, as we will be converting ProfileIdentityProvider to talk to IdentityManager rather than OAuth2TokenService, this baked-in knowledge needs to be moved out of IdentityProvider; ultimately, it will end up only in DeviceIdentityProvider. This CL takes the first step along that path by moving ActiveAccountAccessTokenFetcherImpl, which fetches access tokens via OAuth2TokenService, out of identity_provider.cc into its own file. The next CL will have ProfileIdentityProvider and DeviceIdentityProvider each implement FetchAccessToken() rather than having IdentityProvider do so directly. Bug: 809452 Change-Id: I664c4da998cf90d0a398dc2c9e309425f95515a3 Reviewed-on: https://chromium-review.googlesource.com/1114604Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571070}
-
Eric Noyau authored
There are a number of ways for selecting an element in a tested html page, and those involve injecting javascript. This class is intended to be used for abstracting this js generation to diminish the proliferation of ad-hoc code. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifbe1ba8be509dfe3ab02ff8b7ddca6cefc3761ff Reviewed-on: https://chromium-review.googlesource.com/1118160 Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#571069}
-
Peng Huang authored
GLSurfacePresentationHelper::CheckPendingFrames could be called by PostTask. In that case, the context_ may not be the current, so we need call MakeCurrent. Bug: 853600 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I39a8b9b82a66b9fabe4c06ed67d0f90c8e78599b Reviewed-on: https://chromium-review.googlesource.com/1117118Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571068}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: I0e0473385c38d15d8f62b5283a965801773977d6 Reviewed-on: https://chromium-review.googlesource.com/1117909Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571067}
-
Elad Alon authored
Bug: 775415 Change-Id: Ic00cbdcf4b1ecd2f616dae59dc40d7e4127a7081 Reviewed-on: https://chromium-review.googlesource.com/1115127Reviewed-by:
-
Yuki Shiino authored
In order to avoid confusion between DOMException and ES Error object, this patch uses enum classes for DOMExceptionCode and ESErrorType. DOMExceptionCode and ESErrorType are now incompatible with each other or type int (including ExceptionCode). This patch includes a lot of fixes on call sites, too. Change-Id: I832f7ffc45c2cfbc922443bcf50a171bfc9fa828 Reviewed-on: https://chromium-review.googlesource.com/1117158Reviewed-by:
-
Alexander Hendrich authored
Setting the tooltip on a HoverHighlightView also sets the tooltip on all its children. Otherwise, the tooltip won't show on hovering above the HoverHighlightView. Bug: 845842 Change-Id: I2f3cb31a7b3053eaa42d677e9c967f67781472eb Reviewed-on: https://chromium-review.googlesource.com/1113437Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#571064}
-
