- 29 May, 2019 40 commits
-
-
Pavel Yatsuk authored
In this change: - Added "User" category to Sync and Services preference. The category is gated by identity-disc flag. Mocks: http://slides/1dckRy0Dm5-fOQebZvZyL6CBm2DWCKYppkuOinEORDR4#slide=id.g5615bd983f_0_157 Screenshot: http://screen/d0uaYAhJ016 - Implemented workaround for crbug.com/963077. The effect of the bug is following: - Visiting settings causes download of larger profile image. - Toolbar's ProfileDataCache receives notification and caches this larger image. - When user returns to NTP, larger profile image is displayed in identity disc. The workaround is to remember image size that was requested for Identity disc and only update toolbar when image with correct size is received. BUG=958982 R=twellington@chromium.org Change-Id: I564f51958bfd473cba30a44baa94f58af1e420d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612856 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#664351}
-
Rayan Kanso authored
Persist the number of sync attempts in the registration metadata. This is needed because the number of attempts are determined on browser start-up (if a finch trial is running), and it needs to be consistently applied across browser restarts. This CL also introduces a new max attempt parameter, which is applied if the registration's origin has granted notification permission. This will allow us to increase the number of retries for the registration, without affecting a user's privacy. The max attempts is not immediately increased because according to the privacy team this will significantly extend the capabilities of a malicious website, since they could just fail the sync event and get a bunch more retries to execute their code, potentially without the user's knowledge. The notification permission is used as a proxy, since if the notification permission is present, having more sync attempts would not increase the ability of a malicious website to randomly execute code. This can be achieved by sending push messages, which would wake up the browser / Service Worker. Bug: 963487 Change-Id: Ia061ec30e5bcba893a9e7cc0209296ba5d7ce713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635649 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#664350}
-
Marijn Kruisselbrink authored
In preparation for implementing permission prompts we'll need to keep track of which frame any particular handle is associated with. Also adds a common base class to the file/directory handle implementations, as there is going to be more functionality shared between the two. Bug: 878585 Change-Id: I07cd8273f1ae41a8f1eb95fc7d8fbfeb3311cf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625809Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#664349}
-
wutao authored
Currently when Launcher with Embedded Assistant Ui is closing, some time (clicking outside the Launcher), the Ui will go back to previous state page, e.g. search result page. This will cause flashing of the ui. Bug: 966642 Test: Manual Change-Id: I28f7f2575f678b26be6cf269032348519367543c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625843Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664348}
-
Ian Clelland authored
This disables all client hints for third parties by default, except for the simplified UA hint. Feature Policy can then be used to delegate specific hints. Currently, only the hints which were previously being sent to third parties on Android are available for delagation. A follow- up CL adds the remaining ones. Bug: 968201 Change-Id: Idea42e814078592f3bdaec67bd931a99cfaea046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567927 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#664347}
-
Pavel Shmakov authored
RemoteViews#apply doesn't use the overriden configuration of the Context passed into it. It instead creates a Context of remote app with default Configuration. Because of this Custom Tabs bottom bar always follows system settings. If COLOR_SCHEME_DARK or COLOR_SCHEME_LIGHT is set in the intent, the bottom bar should instead follow this setting along with the rest of the UI. To fix this I suggest doing RemoteViews#apply manually: first inflate the View just like RemoteViews#apply does, but with overridden Configuration, then use RemoteViews#reapply to apply the Actions. Bug: 966402 Change-Id: I8a89a4ee21baf5a759c4aabf0c7725430d609dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626864Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#664346}
-
Kyle Milka authored
Hashes for search suggestions should be exactly 4 alphanumeric bytes, this is explicitly enforced in searchbox_extension but in search_suggest_service the byte array must be truncated to a length of 4 as the length is lost when passed through via IPC. Previously the check was that they were *up to* 4 bytes, but this isn't strict enough. Also remove usage of the banned std::to_string. Bug: 965715 Change-Id: I687496ccaf225118a8f7b07bbaa2913bba19e6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632716 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#664345}
-
Dave Tapuska authored
In change https://crrev.com/0daefdcf34ba9a8c21ab907b2159c5652169a45b caused a dcheck failure occasionally because of an implicit open of a document inside an implicit close while running the wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window.html wpt test. See: https://chromium-swarm.appspot.com/task?id=44fb7387f8411e10 for the failure. https://chromium-review.googlesource.com/c/chromium/src/+/1628499 reverted the original code so this is a reland of some of that code. Because of the complexity of that value use a simpler approach and use the Frame::IsLoading attribute instead which doesn't exhibit these cycles. BUG=907125 Change-Id: Ifb805cf8ab90b6a228f47d88cb2ee872d9a21239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626956 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664344}
-
Balazs Engedy authored
Bug: 932078 Change-Id: I0fc05317b42cc305b0836d27458211c611e8a10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632164 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#664343}
-
Joshua Peraza authored
Using the CrashReportDatabase interface is more robust against changing database implementations than accessing crash reports directly. Change-Id: I6ef699a4a98d772364ff2c5f2de118a5fecc978a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633315Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#664342}
-
Saman Sami authored
This CL enables all Vulkan viz_unittests except for video tests but excludes configuration that failed in my previous attempt. As the fixes roll in, I will enable more configurations. Bug: 960795 Change-Id: Iddb7b7728a65622f4669672eff90d242d7f378f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635550Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#664341}
-
Peng Huang authored
On Linux, create semaphore and get fd from it are expensive, so this CL will not do it, if it is not necessary. Bug: 968103 Change-Id: I8c80d55c42145fb424e83482bf17969fdfc270d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634712Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#664340}
-
James Cook authored
check_includes is disabled for this target. I couldn't enable it (there are issues to resolve in //chrome/test/BUILD.gn) but this improves the situation. Bug: none Change-Id: I84a5c2fe9ca7ffa35114c2a0fd2ce0be750103a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632551Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#664339}
-
mark a. foltz authored
This patch updates chrome://inspect#devices to use the friendly (user-given) name of the Cast device, which will allow developers to distinguish multiple devices of the same model/type. Bug: 658204 Change-Id: I34d1e31a2203f58ae948687f991ac68e5d14bb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606183Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664338}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/29e013deb476..d0d66fb8be4b git log 29e013deb476..d0d66fb8be4b --date=short --no-merges --format='%ad %ae %s' 2019-05-29 egdaniel@google.com Remove call to copy in GrcontextPriv read/write pixel calls. Created with: gclient setdep -r src/third_party/skia@d0d66fb8be4b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: Ib379faa8820d7dbc8c16599fa621fdec89e41736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664337}
-
Avi Drissman authored
Fix bug introduced in crrev.com/c/1451843 BUG=966822 Change-Id: I6c71fa45d953baf769f86678c225a02d2a860478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629724 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#664336}
-
Alexei Filippov authored
Change-Id: I89f90fc6b8942afde5121b13fecc8f351691000c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629335 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664335}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dc0353f46e1f..d15049dacabe git log dc0353f46e1f..d15049dacabe --date=short --no-merges --format='%ad %ae %s' 2019-05-29 derat@chromium.org chromeos_config: Drop chrome_login Tast test attribute. Created with: gclient setdep -r src/third_party/chromite@d15049dacabe The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1d362044c566ff487c6ff47622c0326afc47722b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664334}
-
Clark DuVall authored
These tests use MockCertVerifier, but due to the way WebApk activities are launched, the setup is done before the network process is created, and it would be very complicated to try to insert the MockCertVerifier setup between when the network process is created and when the WebApk is launched. Allowing the default_result for the MockCertVerifier to be set with a flag lets the network process pick up the value when it gets created. Bug: 917467 Change-Id: I694247a189eacb5b4a290b9f78c9b6d60b689441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635198Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#664333}
-
Yoav Weiss authored
Bug: 967996 Change-Id: Ia672a9a80d01ca061585dc8c1cd9f2632b8d0788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635670Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#664332}
-
Khushal authored
Creating the transfer cache entry for an image may fail if we fail to upload the image at entry creation time. This may happen in some context loss situations, and the GPU raster path in GpuImageDecodeCache already handles this safely by aborting the draw using that image. Do the same for OOP raster. R=enne@chromium.org Bug: 948245 Change-Id: I4760b17e8451153b29d53e1eaaef2aed5eab8543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634612 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#664331}
-
Richard Townsend authored
The existing code relied on Clang not evaluating constant arguments unless they were used, which affected UpdateContainerPolicy in DOMFeaturePolicy. This was fixed in LLVM/Clang r361670[1]. [1] https://github.com/llvm/llvm-project/commit/de47d66191e50e8a741ed551c25d60bbf86da5e4? Change-Id: Ie97d33f4cb98bd627ac4271c9a4d3d904d686883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635489Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#664330}
-
Ben Pastene authored
R=achuith Bug: 968155, 947531 Change-Id: I97d2efaf7a04c4c31994929f987baa919a732dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635197 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#664329}
-
Evan Stade authored
TBR=tsepez@chromium.org Bug: 958206, 967109 Change-Id: Iffdac0ef21c284aea4ea331ba1d514cf77cb5687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633211Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#664328}
-
Roman Sorokin authored
TBR=antrim@chromium.org Bug: none Change-Id: Ie48175b9a90d393c6758fd0bb36efd61b0bf19ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634739Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664327}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da94a1109604..3afdede03f34 Created with: gclient setdep -r src-internal@3afdede03f34 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:867592 TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: If40b533f5aeb53e0f72adab89cf6db0121ca588a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635729Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664326}
-
Dale Curtis authored
Per AMD this functionality was subsumed by the Microsoft MFT and was removed from their own software. Since we no longer have an AMD (or Intel) MFT, remove the enum GpuPreference value too. The workaround for disabling vpx decode is left as is and is now the only gate on whether VP9 decode support is enabled. BUG=none TEST=builds. Change-Id: Iee9d76fb9d8073eed207061c45f8d01e4051ac28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633192Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#664325}
-
Antoine Labour authored
Previous CL introduced a local TestContextProvider for PaintCanvasVideoRendererTest. Turns out, for the purpose of the tests that use it, we can simply use a "standard" viz::TestContextProvider, which in turns also gives us a test SharedImageInterface, needed for future CLs. Bug: 882547 Change-Id: I5a4f39904f4dcb4b722415ce1cf1b3482c564ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633470 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664324}
-
Xida Chen authored
This CL adds a histogram to measure how often a CSS transition is cancelled by removing the transition style. Bug: 934700 Change-Id: I53f608f0e4cf2ec07adaecb879cffbb557ce2753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632714Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664323}
-
Raphael Kubo da Costa authored
C_Cpp.clang_format_formatOnSave was removed in release 0.14.1 of Microsoft's C/C++ extension, and users should switch to editor.formatOnSave instead. While here, provide a link to the Annotator extension so people know where to find it. Change-Id: I6c9ed9d95dbe2a660a096244643bc5dd3d601250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634733 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#664322}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/262e28248477..e0956a16b22d git log 262e28248477..e0956a16b22d --date=short --no-merges --format='%ad %ae %s' 2019-05-29 geofflang@chromium.org Vulkan: Rename getSubmitFence to getNextSubmitFence. Created with: gclient setdep -r src/third_party/angle@e0956a16b22d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I5a1846c065224a0fc9bfc5a1de2d284c2b2feb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664321}
-
Robert Ogden authored
Bug: 964540 Change-Id: Ia7d792a909139a5cfc9db2117d7d1267bc2fbb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631137Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#664320}
-
Maksim Ivanov authored
* Fix extra/missing @private annotations and extra/missing trailing underscores; * Use const/let instead of var; * Remove getter and setter properties; * Add missing and fix existing JSDoc @param annotations. Bug: 964069 Change-Id: I3455da0ff43342cd2a95c26c2445543837bbd7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626424 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664319}
-
Matt Mueller authored
Add unittests too. Bug: 749276 Change-Id: Ic11c01dee7b24440fc0c8dd2b3a15e09fac8956c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628162 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664318}
-
Lambros Lambrou authored
This updates the Python script to run the upgrade tool each time it is started. Bug: 954427 Change-Id: If4fc566698ecc443ef06840385c90ff0be43808f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629489Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#664317}
-
Robert Liao authored
No code appears to reference these. BUG=522168 Change-Id: I3918da57a28e1175997df7bc5b9588808177dbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632732Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664316}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/e01dd7043f7b..0220865bffc1 $ git log e01dd7043..0220865bf --date=short --no-merges --format='%ad %ae %s' 2019-05-28 dschinazi Fix threading in EndToEndTestWithTls.NoUndecryptablePackets 2019-05-24 renjietang Support HTTP/3 style of Server push. 2019-05-23 wub gfe-relnote: (n/a) Remove a stateless reject test from crypto_handshake_message_test. Test only. 2019-05-23 dschinazi Add more debug logs that were useful during interop 2019-05-23 dschinazi Add QUIC_BUG_IF on empty opportunistic ACKs 2019-05-23 dschinazi Add QuicFramerTest.CoalescedPacketWithZeroesRoundTrip 2019-05-23 dschinazi Add quic_simplify_stop_waiting to QuicVersionInitializeSupportForIetfDraft 2019-05-22 fayang gfe-relnote: In QUIC, do not send STOP_WAITING if no_stop_waiting_frame_ is true. Protected by gfe2_reloadable_flag_quic_simplify_stop_waiting. 2019-05-22 dschinazi Ensure we can decrypt the first packet 2019-05-22 wub gfe-relnote: (n/a) Remove stateless reject support from quic::test::CreateClientSessionForTest(). Test only. 2019-05-21 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_faster_interval_add_in_sequence_buffer. 2019-05-21 fayang gfe-relnote: In GFE, export number of QUIC packets written per write operation. Protected by FLAGS_quic_export_server_num_packets_per_write_histogram. 2019-05-21 nharper gfe-relnote: Test-only change to enable quic_tolerate_reneging when using IETF draft version 2019-05-21 wub gfe-relnote: (n/a) Remove stateless reject from some unit tests. Test only. 2019-05-21 nharper Fix integer overflow when computing outgoing_max_streams_ 2019-05-21 dschinazi Enable quic_eliminate_static_stream_map_3 for IETF interop Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: I23b98dc828083d3501f1f46d3a6ff72e6c4dcd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635411 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#664315}
-
Eric Stevenson authored
Change-Id: I1992fc666afee7181ae98210ec356e48c764c890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632117 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#664314}
-
Peter Wen authored
PrefServiceBridge is not intrinsically coupled with TemplateUrlService. Add comment that this was load-bearing at one point but should be moved during TemplateUrlService refactor. Bug: 967695 Change-Id: I3c76cc77335246d16ddb2ce3528f0e2a06006aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632412 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664313}
-
kylechar authored
Drop the "Compositor" prefix since CompositorOverlayCandidateValidator has been deleted. Bug: 963597 Change-Id: I818fc550ab42626781a20db9ea7c8e50120e5086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635569Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#664312}
-