GitLab

BUG=418684

Review URL: https://codereview.chromium.org/615613002

Cr-Commit-Position: refs/heads/master@{#297277}

This is no longer used after removing in-process GPU service support
for CHROMIUM_image.

BUG=418553

Review URL: https://codereview.chromium.org/604833005

Cr-Commit-Position: refs/heads/master@{#297276}

Seems to happen in Debug mode. Turn these off until we can find a fix.

BUG=417824,416594

Review URL: https://codereview.chromium.org/604983002

Cr-Commit-Position: refs/heads/master@{#297275}

After crrev.com/295851 the PipeMessagingChannel verifies that incoming
messages are dictionaries and then passes them as base::Value to
OnMessage() and then OnMessage() implementation static_cast<> them to
base::DictionaryValue. This is fragile, and also it shouldn't be
PipeMessagingChannel's responsibility to verify format of the messages
it reads. Moved the check to OnMessage() implementations.

Review URL: https://codereview.chromium.org/615543004

Cr-Commit-Position: refs/heads/master@{#297274}

Revert of [Android] Disable enhanced bookmark opt-in flag. (patchset #1 id:1 of https://codereview.chromium.org/610443002/)

Reason for revert:
M39 branched, so re-enable the flag on trunk.

Original issue's description:
> [Android] Disable enhanced bookmark opt-in flag.
>
> We won't launch this feature for M39, so disable public opt-in flag.
>
> BUG=416664
>
> Committed: https://crrev.com/5da932e693169900a4a4be346446788aa1944eeb
> Cr-Commit-Position: refs/heads/master@{#296825}

TBR=yfriedman@google.com,tedchoc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=416664

Review URL: https://codereview.chromium.org/612203002

Cr-Commit-Position: refs/heads/master@{#297273}

BUG=404771

Review URL: https://codereview.chromium.org/595213003

Cr-Commit-Position: refs/heads/master@{#297272}

If a previous mojo_shell run exited uncleanly, there may
be a unix domain socket sitting at the path that
IncomingConnectionListener wants to own and listen at.
This change destroys it, if possible, and creates a new
one.

BUG=407782
TEST=new unit test, run mojo_shell multiple times in a row with --enable-external-applications

Review URL: https://codereview.chromium.org/611833005

Cr-Commit-Position: refs/heads/master@{#297271}

Pure HTML/CSS changes. No tests affected.

BUG=413337,416228

Review URL: https://codereview.chromium.org/612823005

Cr-Commit-Position: refs/heads/master@{#297270}

Save the client base JID for authentication in case it differs from the email (for accounts non-Google email). Keep a separate email field for use in user-facing UIs, logs, etc. Using the existing host_owner field for the base JID guarantees the correct *functional* behavior (i.e. authentication-wise) if the new config is used with an older host (the only difference is aesthetic - in that older host some UI/logs may show an uglier address instead of the user email).

BUG=224742

Review URL: https://codereview.chromium.org/595063005

Cr-Commit-Position: refs/heads/master@{#297269}

clang's auto-vectorized C version performs better according to the
Chrome Performance Dashboard.  Searching back through the logs, this
occurred when we switched over to clang by default.

We could try to microoptimize further, but it's less of a maintenance
burden to just let the compiler do its thing!

The main reason the clang version is faster is it does 2x 128bit
operations per loop. Simply copying these optimization yields ~97%
similar performance, but  the SIMD code a bit gnarlier. As such I
choose to simply use the C variant when clang is present.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/599693002

Cr-Commit-Position: refs/heads/master@{#297268}

Remove page_set argument from benchmark.CreateExpectations to limit the access to page_set (user_story)

BUG=418278

Review URL: https://codereview.chromium.org/614783002

Cr-Commit-Position: refs/heads/master@{#297267}

(This is a stopgap until the zipping mentioned in the bug can happen.)

BUG=33920
TEST=<input type=file multiple />, ensure packages can't be selected

Review URL: https://codereview.chromium.org/612143002

Cr-Commit-Position: refs/heads/master@{#297266}

EnhancedBookmarkBridge was previously initialized by a native pointer of
the native BookmarkModel, which was a hack to make it to component
folder.  Now since it has been moved to chrome/browser, it should be
initialized by profile.

BUG=415817

Review URL: https://codereview.chromium.org/598593007

Cr-Commit-Position: refs/heads/master@{#297265}

This adds microbenchmarks to measure the cost of posting a task to
a message loop running different pump types. This measures the wall and
(where supported) thread time that elapses from different numbers of
threads posting to one target. This is not designed to measure the time
taken by the target thread or fairness of posting threads.

Each test is set up with one target thread and 1-4 posting threads. The
posting threads each run one task that posts batches of tasks to the
target thread until they have been working for at least 5 seconds of
wall time. The tasks on the target thread simply increment a counter.
The test runner starts each posting thread, posts a start task to each
then joins them and then joins the target thread and aggregates stats.

BUG=412137

Review URL: https://codereview.chromium.org/551183002

Cr-Commit-Position: refs/heads/master@{#297264}

This is likely to crash, and so has debugging statements.

BUG=407376
TEST=no crashing, we hope

Review URL: https://codereview.chromium.org/609943002

Cr-Commit-Position: refs/heads/master@{#297263}

This patch updates the app info dialog and the extensions install prompt
dialog user interfaces to show, for each extension, the devices that are
recorded in the SavedDevicesService. Along with retained files, access
to these devices can be revoked by clicking a button in these dialog
boxes. Devices not written to ExtensionPrefs (devices that are ephemeral
because the do not have a serial number) are not shown here. Permission
to access them is dropped when they are disconnected or Chrome exits.

BUG=346953

Review URL: https://codereview.chromium.org/580363002

Cr-Commit-Position: refs/heads/master@{#297262}

If we install and open CronetTest app without CronetTestInstrumentation app,
CronetTest app will crash and complain that it cannot find
MockUrlRequestJobTest class. The reason is that this class is in
test/javatests/src/ and not in test/src/, so it does not get loaded to device
if we choose to only install and open CronetTest app.

BUG=415781

Review URL: https://codereview.chromium.org/612433002

Cr-Commit-Position: refs/heads/master@{#297261}

Revert of exclude failing test BrowserOptionsOverlayWebUITest.testNavigationInBackground on drmemory bot (patchset #1 of https://codereview.chromium.org/470813002/)

Reason for revert:
Test has been patched.

Original issue's description:
> exclude failing test BrowserOptionsOverlayWebUITest.testNavigationInBackground on drmemory bot
>
> BUG=403627
> TBR=michaelpg@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289441

BUG=403627

Review URL: https://codereview.chromium.org/495803002

Cr-Commit-Position: refs/heads/master@{#297260}

Often, when looking at histograms using these, it's
much easier to go by the code than the name, so
show both.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/617533002

Cr-Commit-Position: refs/heads/master@{#297259}

Adds new webview.loadDataWithBaseUrl API to allow data URLs to be loaded with a specified base URL as well as an optionally specified virtual URL via NavigationController::LoadURLWithParams.

The signature is loadDataWithBaseUrl(dataUrl, baseUrl [, virtualUrl]).

BUG=399790

Review URL: https://codereview.chromium.org/610643003

Cr-Commit-Position: refs/heads/master@{#297258}

Revert of Enabling audio quality test on mac. (patchset #1 id:1 of https://codereview.chromium.org/599103006/)

Reason for revert:
There is one stubborn bot that is unreachable from VNC; reverting until we can sort that out.

Original issue's description:
> Enabling audio quality test on mac.
>
> Note: will land on Monday; need to watch bots so that they execute the
> test right.
>
> TBR=vrk@chromium.org
> BUG=418034
>
> Committed: https://crrev.com/c4e4aaaf43c0da2a01c0f32be737dcbbd5f13e92
> Cr-Commit-Position: refs/heads/master@{#297166}

TBR=vrk@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418034

Review URL: https://codereview.chromium.org/613833002

Cr-Commit-Position: refs/heads/master@{#297257}

This CL adds the following tests to app_shell_browsertests:
WebViewAPITest.testAssignSrcAfterCrash
WebViewAPITest.testCannotMutateEventName
WebViewAPITest.testContentLoadEvent
WebViewAPITest.tDestroyOnEventListener
WebViewAPITest.testDisplayNoneWebviewLoad
WebViewAPITest.testDisplayNoneWebviewRemoveChild
WebViewAPITest.testExecuteScript
WebViewAPITest.testExecuteScriptFail

BUG=352293

Review URL: https://codereview.chromium.org/607913005

Cr-Commit-Position: refs/heads/master@{#297256}

Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMRXpYbGJ6emtlX0U&authuser=1

TL; DR:
- never show a drop down arrow in the button.
- this means that we no longer need to do the auth error drawing magic, as we can use the
button's image. Also cleaned up ALL of that insane code.
- if there is one local, non-signed in profile, show a tiny button with a generic avatar
- in all other cases, show the avatar button with the profile name
- increased the button height by 1px so that it's perfectly aligned with the new tab button

BUG=410946

Review URL: https://codereview.chromium.org/605803002

Cr-Commit-Position: refs/heads/master@{#297255}

This makes it easier for downstream clients of the
component to add new product types without needing
to update the component source.

Also, adds a client method to return the product, so
that different MetricsService clients can provide
different values.

Also cleans up some unnecessary metrics:: namespace
prefixes.

BUG=415581

Review URL: https://codereview.chromium.org/573403002

Cr-Commit-Position: refs/heads/master@{#297254}

Revert of GetUILanguageList should correctly handle locale aliases. (patchset #2 id:20001 of https://codereview.chromium.org/608903003/)

Reason for revert:
22366:22366:0929/155200:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.
#0 0x7fffeb18b02e base::debug::StackTrace::StackTrace()
#1 0x7fffeb216e02 logging::LogMessage::~LogMessage()
#2 0x7fffeb309b9f base::ThreadRestrictions::AssertIOAllowed()
#3 0x7fffeb1fef31 base::PathExists()
#4 0x7fffebbf5837 ui::ResourceBundle::GetLocaleFilePath()
#5 0x7fffebbf5689 ui::ResourceBundle::LocaleDataPakExists()
#6 0x7fffebbc770a (anonymous namespace)::IsLocaleAvailable()
#7 0x7fffebbc723c l10n_util::CheckAndResolveLocale()
#8 0x55555782fe45 chromeos::(anonymous namespace)::GetLanguageList()
#9 0x55555782f0d5 chromeos::GetUILanguageList()
#10 0x55555783d07f chromeos::NetworkScreenHandler::GetAdditionalParameters()
#11 0x55555783d74f chromeos::NetworkScreenHandler::GetAdditionalParameters()
#12 0x55555780d38d chromeos::BaseScreenHandler::GetLocalizedStrings()
#13 0x555557430d0c chromeos::OobeUI::GetLocalizedStrings()
#14 0x55555743035d chromeos::OobeUI::OobeUI()
#15 0x555557464d13 (anonymous namespace)::NewWebUI<>()
#16 0x55555746318f ChromeWebUIControllerFactory::CreateWebUIControllerForURL()
#17 0x7ffff3bb04c7 content::WebUIControllerFactoryRegistry::CreateWebUIControllerForURL()
#18 0x7ffff3b58acb content::WebContentsImpl::CreateWebUI()
#19 0x7ffff3b681c2 content::WebContentsImpl::CreateWebUIForRenderManager()
#20 0x7ffff3b681ff content::WebContentsImpl::CreateWebUIForRenderManager()
#21 0x7ffff3517724 content::RenderFrameHostManager::SetPendingWebUI()
#22 0x7ffff35180dc content::RenderFrameHostManager::UpdateStateForNavigate()
#23 0x7ffff3517952 content::RenderFrameHostManager::Navigate()
#24 0x7ffff34f7715 content::NavigatorImpl::NavigateToEntry()
#25 0x7ffff34f7cce content::NavigatorImpl::NavigateToPendingEntry()
#26 0x7ffff3b5ef21 content::WebContentsImpl::NavigateToPendingEntry()
#27 0x7ffff3b5ef52 content::WebContentsImpl::NavigateToPendingEntry()
#28 0x7ffff34dd7b5 content::NavigationControllerImpl::NavigateToPendingEntry()
#29 0x7ffff34ddbda content::NavigationControllerImpl::LoadEntry()
#30 0x7ffff34df6c4 content::NavigationControllerImpl::LoadURLWithParams()
#31 0x7ffff34dee3f content::NavigationControllerImpl::LoadURL()
#32 0x7ffff2b051ee views::WebView::LoadInitialURL()
#33 0x55555813ce7b chromeos::WebUILoginView::LoadURL()
#34 0x555558126f0f chromeos::LoginDisplayHostImpl::LoadURL()
#35 0x555558126b25 chromeos::LoginDisplayHostImpl::StartWizard()
#36 0x5555581292da chromeos::LoginDisplayHostImpl::StartPostponedWebUI()
#37 0x555558128a18 chromeos::LoginDisplayHostImpl::Observe()
#38 0x55555812940d chromeos::LoginDisplayHostImpl::Observe()
#39 0x7ffff37da39b content::NotificationServiceImpl::Notify()
#40 0x555557f3a994 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished()
#41 0x7fffea807a07 ash::RootWindowController::OnWallpaperAnimationFinished()
#42 0x7fffea75802a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted()
#43 0x7fffeae72e40 ui::ImplicitAnimationObserver::CheckCompleted()
#44 0x7fffeae72de5 ui::ImplicitAnimationObserver::SetActive()
#45 0x7fffeae937b5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings()
#46 0x7fffea757bb4 ash::DesktopBackgroundWidgetController::StartAnimating()
#47 0x7fffea74e2c6 ash::DesktopBackgroundController::InstallDesktopController()
#48 0x7fffea74e3b3 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows()
#49 0x7fffea74db8c ash::DesktopBackgroundController::SetDesktopBackgroundImageMode()
#50 0x7fffea74d854 ash::DesktopBackgroundController::SetWallpaperImage()
#51 0x55555816ad4e chromeos::WallpaperManager::DoSetDefaultWallpaper()
#52 0x55555816a26d chromeos::WallpaperManager::PendingWallpaper::ProcessRequest()
#53 0x555558188f12 base::internal::RunnableAdapter<>::Run()
#54 0x555558188e89 base::internal::InvokeHelper<>::MakeItSo()
#55 0x555558188e45 base::internal::Invoker<>::Run()
#56 0x7fffeb17303e base::Callback<>::Run()
#57 0x7fffeb3100d6 base::Timer::RunScheduledTask()
#58 0x7fffeb3101ec base::BaseTimerTaskInternal::Run()
#59 0x7fffeb3104b2 base::internal::RunnableAdapter<>::Run()
#60 0x7fffeb31041c base::internal::InvokeHelper<>::MakeItSo()
#61 0x7fffeb3103c5 base::internal::Invoker<>::Run()

Original issue's description:
> GetUILanguageList should correctly handle locale aliases.
>
> GetUILanguageList didn't check for locale aliases when resolving input
> method languages. This patch fixes it.
>
> BUG=418220
> TEST=manual
>
> Committed: https://crrev.com/b1c6a6e8fc6b4368cf63dfc00e8a4fec691fed1d
> Cr-Commit-Position: refs/heads/master@{#297086}

TBR=dzhioev@chromium.org,alemate@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418220

Review URL: https://codereview.chromium.org/614773003

Cr-Commit-Position: refs/heads/master@{#297253}

Keep MOJO_OVERRIDE around very temporarily, since there are a few users
of it outside of mojo/.

(The change was clang-format'ed.)

R=sky@chromium.org

Review URL: https://codereview.chromium.org/617503003

Cr-Commit-Position: refs/heads/master@{#297252}

Also fixes an apparent (and inconsequential) leak in GDIBitmapAllocFailure().  (We're going to die anyway so it doesn't really matter.)

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/594423002

Cr-Commit-Position: refs/heads/master@{#297251}

I moved all tests to Win Tests (1) in preparation for removing 2 & 3.

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/616623002

Cr-Commit-Position: refs/heads/master@{#297250}

BUG=410411
TEST=no visible change
TBR=bengr@chromium.org

Review URL: https://codereview.chromium.org/610023003

Cr-Commit-Position: refs/heads/master@{#297249}

BUG=399473,413855

Review URL: https://codereview.chromium.org/598203004

Cr-Commit-Position: refs/heads/master@{#297248}

When enabling externally-running applications, allow the
user to specify a path for the listening socket. This makes
development easier while still allowing for a default
to be used in production.

BUG=None
TEST=run mojo_shell with --enable-external-applications=path/to/socket, without the flag, and with the flag but passing no value.

Review URL: https://codereview.chromium.org/599733007

Cr-Commit-Position: refs/heads/master@{#297247}

Move flag for touch feedback experiments to ui_base_switches from ash_switches. Update the classes currently using the ash switch.

This will allow for the experiments which are on components under ui/

BUG=398398

Review URL: https://codereview.chromium.org/580903003

Cr-Commit-Position: refs/heads/master@{#297246}

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/599213002

Cr-Commit-Position: refs/heads/master@{#297245}

* Polymer framework was used in the implementation
* Created custom element <oobe-screen>.
* HostPairingScreen was converted to <host-paring-screen> which extends <oobe-screen>.
* Several <core-*> Polymer elements were used.
* Roboto font used.

Polymer elements and fonts are imported to the page in a runtime, in contrast with a current implementation, where almost all resources are unlined. Can't say how runtime imports affect a performance.

BUG=375191
TEST=manually

Review URL: https://codereview.chromium.org/599273004

Cr-Commit-Position: refs/heads/master@{#297244}

This allows CastService implementers to provide the user option for
controlling whether metrics is enabled/disabled.

R=lcwu@chromium.org
BUG=400925

Review URL: https://codereview.chromium.org/608093002

Cr-Commit-Position: refs/heads/master@{#297243}

R=lcwu@chromium.org
BUG=400914

Review URL: https://codereview.chromium.org/605923002

Cr-Commit-Position: refs/heads/master@{#297242}

(I.e., add a "-l 100" to the ninja command.)

R=sky@chromium.org

Review URL: https://codereview.chromium.org/608313003

Cr-Commit-Position: refs/heads/master@{#297241}

Move the ChevronMenuButton class into its own file, and move the logic to show
the legacy (drop-down) extension action overflow menu from the
BrowserActionsContainer into there.

This is mainly because:
1. We'll eventually be getting rid of this legacy behavior, and this way, the
   removal is all concentrated in one area (ChevronMenuButton).
2. BrowserActionsContainer is already doing a ton (since it has both new
   overflow and normal logic). It doesn't need this, too.

As a bonus, refactored the lifetime of the overflow menu to be more
deterministic, and got rid of the back-and-forth between it and the
BrowserActionsContainer.

And all with a negative line count! Woohoo!

BUG=417085

Review URL: https://codereview.chromium.org/597783002

Cr-Commit-Position: refs/heads/master@{#297240}

With the NSWorkspaceLaunchWithErrorPresentation option, Finder no longer
silently fails opening the file.

BUG=32921
R=avi@chromium.org
TEST=Download a DMG file. Click the download shelf button to open/mount it. Finder activates the new disk image window as the topmost.
TEST=Download a file with an unassociated file extension type (e.g.  "test.foobar"). Click the download shelf button to open it. Finder presents the unknown file type dialog.

Review URL: https://codereview.chromium.org/613673003

Cr-Commit-Position: refs/heads/master@{#297239}

BUG=414595

Review URL: https://codereview.chromium.org/608923002

Cr-Commit-Position: refs/heads/master@{#297238}