- 19 Jun, 2018 40 commits
-
-
Mike Dougherty authored
This reverts commit 0928665a. Reason for revert: This behavior is causing more confusion for users than it is helping. See crbug.com/854274 for details. Original change's description: > Do not recover incognito tabs if user deliberately terminates Chrome. > > Previously incognito tabs were always recovered no matter how the app > was last shutdown. > > Instead, do not restore the incognito tabs if the user explicitly closes > Chrome. If the system terminates the app, the tabs should be restored. > (This can happen at any time and without user notice, so such > terminations should not lead to a loss of the user's incognito tabs.) > > Bug: 653248 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I018cdf5cda2004e32e1010c4d9bab4bd10c0ae99 > Reviewed-on: https://chromium-review.googlesource.com/835532 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526099} TBR=marq@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 653248, 854274 Change-Id: I952db05d6364d0944c3e46b9fa78b1432e889830 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1106777 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568603}
-
Danil Chapovalov authored
Stop including webrtc/api/optional.h In files that need to set optionals in webrtc structs use absl::optional Bug: webrtc:9078 Change-Id: I21e8561152cac722b182e1aa72224fcb308cff68 Reviewed-on: https://chromium-review.googlesource.com/1105820Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#568602}
-
Fabio Tirelo authored
Sets the style for explanation, footer disclaimer, and expiration dates to secondary, in order to match the new spec. Also sets style for credit card number as primary. Sets context for labels as CONTEXT_BODY_TEXT_LARGE, so that they get the correct font size (13dp). Also changes the disclaimer test in the DialogBrowserTest to make it easier to inspect link changes. Bug: 852094 Test: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Server --test-launcher-interactive Change-Id: Ib9b7ef57119c1314848e079122f3677d5db80901 Reviewed-on: https://chromium-review.googlesource.com/1099486Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568601}
-
Danil Chapovalov authored
Bug: webrtc:9078 Change-Id: I6cce5b13e6178834bcd2c5287f840e10d9f183b2 Reviewed-on: https://chromium-review.googlesource.com/1104463Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#568600}
-
Shimi Zhang authored
This CL converts delete-across-editable-content-boundaries-2 to utilize |selection_test()|. In preparing for http://crrev/c/1102157, make it easier for us to handle the behavior change. Bug: 847192 Change-Id: I85ace72d163656fed187b679f287fed2c053d227 Reviewed-on: https://chromium-review.googlesource.com/1106547Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#568599}
-
Shimi Zhang authored
In preparing for http://crrev/c/1102157, make it easier for us to handle the behavior change. Bug: 847192 Change-Id: I5b4053056e96b7c2ecec879b3fea722b3d68d511 Reviewed-on: https://chromium-review.googlesource.com/1105575Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#568598}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96aa535b782f..80452bee11eb git log 96aa535b782f..80452bee11eb --date=short --no-merges --format='%ad %ae %s' 2018-06-19 fmalita@chromium.org Fold SkJSON into Skia/utils Created with: gclient setdep -r src/third_party/skia@80452bee11eb The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ia64b7049ba052d31311abbead1897e2543b11cf2 Reviewed-on: https://chromium-review.googlesource.com/1106561Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568597}
-
Andrew Grieve authored
Test is very flakey. On many bots, it fails at least once per run. Bug: 756550 Change-Id: I8eac5aa374999a20382e30c689761bedb6f23c65 Reviewed-on: https://chromium-review.googlesource.com/1106760 Commit-Queue: agrieve <agrieve@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568596}
-
David Black authored
See bug for specs, details, and demo. In order to implement the new spec, this CL: - Adds concept of committed/pending query to AssistantInteractionModel. - Adds AssistantHeaderView. - Adds AssistantMainStage. - Modifies AssistantQueryView to observe committed or pending query. - Modifies AssistantTextElementView UI. - Moves SuggestionContainerView into AssistantMainStage. - Modifies AssistantController so that the stage is only cleared on query commit and UI dismiss. Note: - AssistantInteractionModel is becoming convoluted. I will do a follow up to create an AssistantMainStageModel so that the interaction model can focus on more purely interaction related state (e.g. mic open/close, input modality, etc.) and less on the UI elements that will be rendered in the main stage. That state will be maintained by AssistantMainStageModel. - This CL does NOT implement motion specs which are still to be delivered. Bug: b:110228421 Change-Id: Ia15917844133ccf7eb60d1fead05f69cfac3d9ed Reviewed-on: https://chromium-review.googlesource.com/1101973 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568595}
-
James Cook authored
It's up to 7 parameters and I'm about to add an 8th. Bug: 851578 Test: existing tests Change-Id: I5dbfb98c90861a334ef9046cec4d69fb756879a1 Reviewed-on: https://chromium-review.googlesource.com/1106431Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#568594}
-
rbpotter authored
Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I516abef88d784a8936667b3c8b42a1ee4bda7efd Reviewed-on: https://chromium-review.googlesource.com/1105285 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568593}
-
Philip Rogers authored
Bug: 836886 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees Change-Id: I58b1faa953fbc3b584306aa6f461eccce28e0069 Reviewed-on: https://chromium-review.googlesource.com/1104958Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568592}
-
Dominick Ng authored
This CL passes the name of the package which registered a particular intent filter to the Mojo call from ARC to Chrome. The package name is added as a field on the Chrome-side IntentFilter struct. The package name is necessary to help migrate the intent picker persistence from within the ARC container to Chrome, where it can be synced across devices and be used by other app platforms. BUG=853604 Change-Id: Ie35b89bd3bf1ecfd51565d7c449287e336ae6dbc Reviewed-on: https://chromium-review.googlesource.com/1103988Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#568591}
-
Fady Samuel authored
LocalSurfaceId allocations are expensive because they force a commit and draw and could increase memory usage. On Android, we were allocating a new parent LocalSurfaceId every time the child LocalSurfaceId changed and blocking UI on the new parent LocalSurfaceId which does not make any sense. Instead, we accept the LocalSurfaceId provided by the child and embed it in the parent. This improves Surface synchronization performance on Android substantially. Before: https://pinpoint-dot-chromeperf.appspot.com/job/14c43963240000 After: https://pinpoint-dot-chromeperf.appspot.com/job/14e7a563240000 Change-Id: I46a85c6d718b97163c371adb169bc4a9d896c68a Reviewed-on: https://chromium-review.googlesource.com/1105019Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568590}
-
Steven Holte authored
Bug: 854206 TBR=rdevlin.cronin NOTRY=true Change-Id: I7788b389478f47bbd37e8336ae1379c6dbad88df Reviewed-on: https://chromium-review.googlesource.com/1106776Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568589}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c765d2ac8676..e005dc33c31a git log c765d2ac8676..e005dc33c31a --date=short --no-merges --format='%ad %ae %s' 2018-06-19 tsepez@chromium.org Move fxcrt::{Byte,Wide}Strings with std::move(). 2018-06-19 tsepez@chromium.org Speculative fix for segv destroying CPDF_PageObjectHolder::m_GraphicsMap Created with: gclient setdep -r src/third_party/pdfium@e005dc33c31a The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852273 TBR=dsinclair@chromium.org Change-Id: Ibc6333c972cc6e3ad4048c6fbd36ef975df32b36 Reviewed-on: https://chromium-review.googlesource.com/1106560Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568588}
-
Tatiana Gornak authored
Mirrors the InvalidationClientCore from cahceinvalidation library. This CL is one of the spilt-CL for https://chromium-review.googlesource.com/c/chromium/src/+/1090722 Bug: 801985 Change-Id: Ibea970772b4292116fcc4ae4947ce9f3dca9427a Reviewed-on: https://chromium-review.googlesource.com/1100471 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568587}
-
Gabriel Charette authored
This count only matters when reaching MessageLoop::DoIdleWork() at which point the TriageQueue is empty by definition (and tasks in the DeferredQueue do not matter). This CL is therefore a no-op behavior wise. In an upcoming change, the thread-safe |incoming_queue_| will move to MessageLoopTaskRunner and dropping unecessary hi-res counts now will make this transition simpler. This also allows disconnecting DelayedQueue and DeferredQueue from their outer class. R=danakj@chromium.org, kylechar@chromium.org Bug: 708584, 854237 Change-Id: Icf36f1e425a8320fb14a4c561c529a9ea2389e0f Reviewed-on: https://chromium-review.googlesource.com/1103120 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#568586}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4ce4cb826374..0ff6498e4181 git log 4ce4cb826374..0ff6498e4181 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 lalitm@google.com trace_processor: don't add swapper slices to trace storage Created with: gclient setdep -r src/third_party/perfetto@0ff6498e4181 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:110195632 TBR=perfetto-bugs@google.com Change-Id: I375d0c8228bd7f45ea1884c6fb305f292aa69ac1 Reviewed-on: https://chromium-review.googlesource.com/1106558 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568585}
-
Eric Stevenson authored
Was caused by the task finding the total size of the downloads directory taking too long on some devices. To avoid this, we update the ui after each task finishes so that there are no dependencies between tasks. This means that if one of the tasks takes a long time, the user could see an incorrect value (0.0 KB), but we don't hit an ANR. Bug: 828033 Change-Id: I57ab7df3c058373424a0ed2525ee80695e1cf6cf Reviewed-on: https://chromium-review.googlesource.com/1091532Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568584}
-
Xianzhu Wang authored
For SPv175, LocationInBacking is just PaintOffset, so remove LocationInBacking() and let callers use PaintOffset instead. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id776902e6b378b5414330df06f1fec6898d0cf96 Reviewed-on: https://chromium-review.googlesource.com/1081469 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568583}
-
Mark Pilgrim authored
TBR=sky@chromium.org Bug: 714018 Change-Id: Iae2eaaf9c313d25f0f434265148126ba5098a623 Reviewed-on: https://chromium-review.googlesource.com/1104390 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568582}
-
Luna Lu authored
Bug: 804645 Change-Id: I9e433bcbdd2ca63ac38777469da093f035f44fca Reviewed-on: https://chromium-review.googlesource.com/1102351Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#568581}
-
mark a. foltz authored
This CL changes the presentation URL for Media Router integration tests to https:, so we can implement proper scheme handling in Blink in a future patch. This is patch #3 in a five-patch change: Patch #1 (google3): Deprecate test: in mr.TestProvider Patch #2 (Chromium): Roll DEPS in Chromium Patch #3 (Chromium): This patch Patch #4 (google3): Remove test: from mr.TestProvider Patch #5 (Chromium): Roll DEPS again Bug: 825927 Change-Id: I8574be618a8005c52567750c62b1945ee9d413f7 Reviewed-on: https://chromium-review.googlesource.com/1106555Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568580}
-
Matthew Jones authored
Since the scrim is now created programmatically, it takes a bit of extra time after chrome starts to be able to get access to it. In the case of the location bar, its design allows users to focus it prior to the rest of chrome being loaded. Because of this, it is possible to get the omnibox focused without the scrim, locking up the page under it. This change explicitly sets the scrim when it becomes available in ChromeActivity and then calls the scrim update method in case it is needed. Bug: 850848 Change-Id: Ia0a25a0c6e8f9c2d64c914ebca5bbcf9e14601ad Reviewed-on: https://chromium-review.googlesource.com/1101963 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568579}
-
Kevin Bailey authored
We used to highlight the tab switch button when focused. The spec now asks for a focus ring instead of highlighting. This change allows the background to return to following the mouse state. Bug: 780835 Change-Id: Ie2a3c4b7bbe4c357855f19956f880c5cef01da21 Reviewed-on: https://chromium-review.googlesource.com/1106282Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568578}
-
John Budorick authored
Bug: 854114 Change-Id: Ic42770080e733e976c213c52cbcb47b226a54998 Reviewed-on: https://chromium-review.googlesource.com/1106708Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568577}
-
glevin authored
Enables Harmony dialog styling by default on Chrome OS dialogs. Also see launch bug crbug.com/839559. Bug: 783540 Test: Summon any dialog (blockers of 783540) that has been Harmonized. Verify that it has the Harmonious styling. Change-Id: I2c9340d33d0d404edec2b110fe4dd9d6727bc645 Reviewed-on: https://chromium-review.googlesource.com/1072727Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568576}
-
James Darpinian authored
This reverts commit 5a49da30. 2nd try due to http://crbug.com/853194 1st try was here: https://chromium-review.googlesource.com/c/chromium/src/+/1093580 Destroying a transfer buffer now requires only an ordering barrier, not a full flush. This removes a source of unnecessary flushes and makes resizing the transfer buffer more efficient. Bug: 850271, 835353, 828363, 853194 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibc5e72fcf4538a3f10022a613e9d0f15e4e7a95a Reviewed-on: https://chromium-review.googlesource.com/1105466Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#568575}
-
Francois Doray authored
Previously, "zero" was used as the last active time for tabs open in the background, which made them immediately eligible for proactive freeze and discard. With this CL, their creation time is used as the last active time, which will prevent them from being proactively frozen or discarded for at least 10 minutes after creation (note: except when the number of tabs is considered excessive, see tab_manager_features.cc). Bug: 854272 Change-Id: I5398b24fadbd073bd224e2a9e98c8ae610b26e92 Reviewed-on: https://chromium-review.googlesource.com/1106612Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#568574}
-
Thomas Tangl authored
Change-Id: I3df8e8dce2c62f623db78e7278390802f363aa5d Reviewed-on: https://chromium-review.googlesource.com/1106381Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#568573}
-
Krzysztof Olczyk authored
The content::ScopedWebCallbacks class is a helper for blink::WebCallbacks and does not do anything strictly related to //content. Moving it to //third_party/blink/public/platform makes it possible to use it in all blink platform consumer, also the ones outside of //content, such as //media/blink. One example is //media/blink/webmediacapabilitiesclient_impl.cc which before had to use specialized local copy of it. This also adds two modifications to ScopedWebCallbacks: * Make make_scoped_web_callbacks take a unique_ptr to WebCallbacks, instead of raw pointer that gets silently WrapUnique'ed inside, to make ownership passing more explicit, * Modernize it to operate on OnceCallback, instead of Callback, * Use default move constructor and move assignment. Bug: 847211 Change-Id: I3d9b8a660dbfd66cf8721331777f36ea42c04bc8 Reviewed-on: https://chromium-review.googlesource.com/1104356 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568572}
-
Yafei Duan authored
This doesn't decode the JSON, just grabs it from the appropriate endpoint. The CL was originally uploaded by dewittj@. This CL is fixing the test failure and re-uploading to land since dewittj@ is out of office. Bug: 852075 Change-Id: Ib8adc7cad661665c884a2d058c27c99f40ac0a58 Reviewed-on: https://chromium-review.googlesource.com/1105018 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#568571}
-
Robbie McElrath authored
RegisterIOHandler calls CreateIoCompletionPort and will currently fail silently. This adds a return code and propagates it up. Bug: 845612 Change-Id: Ie0685cb7fb6d21a5e23489337158ee0ba0b75154 Reviewed-on: https://chromium-review.googlesource.com/1101644 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568570}
-
Paul Miller authored
Chrome turns on the studies specified in fieldtrial_testing_config.json for testing purposes. It doesn't respect the difference between android and android_webview platforms, so WebView gets all of Android Chrome's studies enabled, including UseSurfaceLayerForVideo which breaks WebView. As a workaround, disable the test config. BUG=853832 Change-Id: Ib8453ac163c7ce71419d25fc5433d3b31b89e894 Reviewed-on: https://chromium-review.googlesource.com/1105608Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568569}
-
Kyle Horimoto authored
Initialization of the service is asynchronous due to the need to fetch the Bluetooth adapter asynchronously. This class allows clients to make requests of the service before it is fully initializes; queued requests are then passed on to the rest of the service once initialization completes. Bug: 824568, 752273 Change-Id: I79b5940070b7c3ff6e0a9ed3f7ef4dff8f260038 Reviewed-on: https://chromium-review.googlesource.com/1105616Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568568}
-
jonross authored
Currently all viz and surface sync tests on the Mojo Android FYI bot are hitting shard timeouts. This updates the tests to use filter lists, to remove tests that were causing the shards to timeout. This also remove viz_content_unittests as I'm currently seeing infra failures from it. It will require local debugging. TEST=surface_sync_content_browsertest, viz_content_browsertests Bug: 849746 Change-Id: I237aab39e1c4a016584940fa0362a39db4be3434 Reviewed-on: https://chromium-review.googlesource.com/1102699Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568567}
-
Nate Fischer authored
No change to logic. This creates an AndroidManifest.xml file with only a minSdkVersion, which we use to configure lint to correctly verify the boundary interfaces compile down to the support library's minSdkVersion. This code will continue to only be called on >= 21 (Lollipop). R=torne@chromium.org Bug: 828184 Test: code compiles and passes lint Test: code doesn't compile with @TargetApi annotations in BoundaryInterfaceReflectionUtil Change-Id: I270f0f5732c1134ba77b912ece31cf188ee6cb5f Reviewed-on: https://chromium-review.googlesource.com/1105697Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568566}
-
Nate Fischer authored
No change to production logic. This adds a test for shouldInterceptRequest with server-side redirects because this was previously untested. R=boliu@chromium.org Bug: 768631 Test: run_webview_instrumentation_test_apk -f AwContentsClientShouldInterceptRequestTest#testNotCalledForHttpRedirect Change-Id: I3eccada1e249269a4f66395a8d10a107001e1231 Reviewed-on: https://chromium-review.googlesource.com/1105630Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568565}
-
David Valleau authored
Change-Id: Ie400a16a7d6c91850245dfe1ada290d03697a7cd Reviewed-on: https://chromium-review.googlesource.com/1106640Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#568564}
-