- 28 Apr, 2017 40 commits
-
-
skobes authored
These tests are failing due to scrollbars in the image diff, likely triggered by changes on http://crbug.com/606395. Mark them failing for now to get the bot green again. BUG=716569 TBR=rogerta Review-Url: https://codereview.chromium.org/2849953002 Cr-Commit-Position: refs/heads/master@{#468144}
-
bnc authored
Review-Url: https://codereview.chromium.org/2846983003 Cr-Commit-Position: refs/heads/master@{#468143}
-
fayang authored
Flip FLAGS_quic_reloadable_flag_quic_remove_multipath_bit to true. https://codereview.chromium.org/2849543003/ Rename FLAGS_quic_enable_version_39 to FLAGS_quic_reloadable_flag_quic_enable_version_39. Merge internal change: 154330328 https://codereview.chromium.org/2848633003/ Include "base/macros.h" in quic_mutex.h Merge internal change: 154304557 https://codereview.chromium.org/2841283003/ Part of QUIC v39 change: 1) do not ack acks. 2) Send a WINDOW_UPDATE frame every 20 packets which do not have retransmittble frames. Merge internal change: 154290226 https://codereview.chromium.org/2846033002/ In QUIC v39, read and write integers and floating numbers in big endian. Merge internal change: 154287990 https://codereview.chromium.org/2842373003/ Make QuicSession::OnFinalByteOffsetReceived virtual. Merge internal change: 154212957 https://codereview.chromium.org/2840423003/ Fix packet conservation logic in QUIC BBR. Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation. Merge internal change: 154129181 https://codereview.chromium.org/2848633002/ QUIC: correctly update local stream state on receipt of trailers after sending RST. Protected by FLAGS_quic_reloadable_flag_quic_final_offset_from_trailers Rename UpdateFlowControlOnFinalReceivedByteOffset to OnFinalByteOffsetReceived as it is not limited to updating flow control (also removes streams from locally_closed_streams_highest_offset). Merge internal change: 154081704 https://codereview.chromium.org/2850523002/ Delete QUIC/SPDY utility methods for parsing headers/trailers. Merge internal change: 154068097 https://codereview.chromium.org/2850513002/ Remove unused packet parameter from QuicTimeWaitListManager::ProcessPacket. Merge internal change: 153857099 https://codereview.chromium.org/2849543002/ Remove unused packet_number parameter from multiple functions in QUIC. Merge internal change: 153847178 https://codereview.chromium.org/2846013002/ Deprecate FLAGS_quic_reloadable_flag_quic_remove_packet_number_from_public_reset. Merge internal change: 153829126 https://codereview.chromium.org/2846003002/ Some changes to prepare for endian change for QUIC: 1) Make data reader/write be able to read/write integers and floating numbers in big endian. 2) Make data reader/write be able to read/write 24/40/48/56-bit integers. 3) Add functions to read/write QuicPacketNumber, QuicStreamId, QuicStreamOffset in QuicFramer. Merge internal change: 153820887 https://codereview.chromium.org/2847753002/ Remove std::move from return statements. Merge internal change: 153819488 https://codereview.chromium.org/2851503002/ BUG= Review-Url: https://codereview.chromium.org/2850573002 Cr-Commit-Position: refs/heads/master@{#468142}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5fa840e82c50..fa1d11d0530d $ git log 5fa840e82..fa1d11d05 --date=short --no-merges --format='%ad %ae %s' 2017-04-28 bpastene devil: Increase timeout of TIME_SET intent in provision_devices Created with: roll-dep src/third_party/catapult BUG=716441 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib22b476709fab0f58ed7f1bafcb10372be08b4dd Reviewed-on: https://chromium-review.googlesource.com/490535 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#468141}
-
klausw authored
If the WebVR document loses focus, check if the new focused element is an embedding local parent frame. If that's the case, continue presenting. This fixes issues with Cardboard-style touch events that are reported as a click at viewport (0, 0) where the resulting focus loss stopped presentation. BUG=710863 Review-Url: https://codereview.chromium.org/2847233002 Cr-Commit-Position: refs/heads/master@{#468140}
-
rtoy authored
Manually convert to use new Audit. BUG=704967 TEST=constructor/mediastreamaudiodestination.html Review-Url: https://codereview.chromium.org/2835943004 Cr-Commit-Position: refs/heads/master@{#468139}
-
rch authored
old: FLAG_##flag: 1 new: FLAG_quic_reloadable_flag_quic_flow_control_faster_autotune: 1 Review-Url: https://codereview.chromium.org/2846673007 Cr-Commit-Position: refs/heads/master@{#468138}
-
johnme authored
Adds an experimental gesture on Android, which automatically enters/exits fullscreen when the user rotates their device to/from the natural orientation of the video. Disabled by default; see video-rotate-to-fullscreen in chrome://flags BUG=713225 Review-Url: https://codereview.chromium.org/2830713003 Cr-Commit-Position: refs/heads/master@{#468137}
-
vasilii authored
Currently AutofillAgent::DidAssociateFormControlsDynamically ignores the notification if the frame isn't loaded. That makes no sense because the page may never be loaded due to some slow resource. Even if it will, password autofill shouldn't wait for the page load event. It's needed primarily for the successful submission detection. BUG=713645 Review-Url: https://codereview.chromium.org/2849653003 Cr-Commit-Position: refs/heads/master@{#468136}
-
robliao authored
Most task latencies were between 0 and 1 ms. Recording task latencies in microseconds will provide better data BUG=715777 Review-Url: https://codereview.chromium.org/2839333002 Cr-Commit-Position: refs/heads/master@{#468135}
-
rtoy authored
Manually convert to use new Audit. BUG=704967 TEST=constructor/mediastreamaudiosource.html Review-Url: https://codereview.chromium.org/2842573003 Cr-Commit-Position: refs/heads/master@{#468134}
-
rtoy authored
Manually converted to use new Audit. BUG=704967 TEST=constructor/waveshaper.html Review-Url: https://codereview.chromium.org/2833863002 Cr-Commit-Position: refs/heads/master@{#468133}
-
dvallet authored
This fixes an issue on closing Web contents on headless Mac, since it makes think Web contents that the current view is still handling UI events. See https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_view.h?rcl=e0bef062337921727eb9b670b417ebd0b6d86fd6&l=131 BUG=713268 Review-Url: https://codereview.chromium.org/2853473002 Cr-Commit-Position: refs/heads/master@{#468132}
-
rdsmith authored
BUG=None R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2844323002 Cr-Commit-Position: refs/heads/master@{#468131}
-
mthiesse authored
This removes the info icon from the transient warning, and adjusts the element sizes and font sizes to more closely align with M58. BUG= Review-Url: https://codereview.chromium.org/2841333003 Cr-Commit-Position: refs/heads/master@{#468130}
-
dtapuska authored
The test was originally disabled beacuse of a failing DCHECK in the pointer event code. That is issue 694742 which other tests were failing as well. Since that DCHECK is removed there is no need for this test to actually be disabled. BUG=692864 Review-Url: https://codereview.chromium.org/2847243002 Cr-Commit-Position: refs/heads/master@{#468129}
-
avi authored
The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2848703004 Cr-Commit-Position: refs/heads/master@{#468128}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2fcd4a480dee..dc87c95382d5 $ git log 2fcd4a480..dc87c9538 --date=short --no-merges --format='%ad %ae %s' 2017-04-28 brianosman Combine GPU flush with semaphore API 2017-04-28 reed remove unused yuv methods 2017-04-28 reed change drawAtlas to behave like drawVertices Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I9c3de9d586760183d1bff973d2b30cb204bd89ed Reviewed-on: https://chromium-review.googlesource.com/490515Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#468127}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/66568bcd683d..60cd033adf6c $ git log 66568bcd6..60cd033ad --date=short --no-merges --format='%ad %ae %s' 2017-04-27 thestig Remove dead dimensions code in fxbarcode. 2017-04-28 thestig Fix stack overflow in CFieldTree::Node::GetFieldInternal(). Created with: roll-dep src/third_party/pdfium BUG=716523 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I0e8b85c630a34df3178043e4a5fd729201d45858 Reviewed-on: https://chromium-review.googlesource.com/490806 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#468126}
-
thakis authored
It has been missing from .gn files for a while. The test looks very similar to chrome/browser/content_settings/content_settings_usages_state_unittest.cc and it looks like we just forgot to delete it in https://chromiumcodereview.appspot.com/19375002 BUG=661774 Review-Url: https://codereview.chromium.org/2852483002 Cr-Commit-Position: refs/heads/master@{#468125}
-
gambard authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2827253003 Cr-Commit-Position: refs/heads/master@{#468124}
-
sky authored
This also adds a stanalone_ash target that is the equivalent of ash_shell_with_content but running in mushrome mode and without content. BUG=708287,706589 TEST=covered by tests R=kylechar@chromium.org Review-Url: https://codereview.chromium.org/2840043003 Cr-Commit-Position: refs/heads/master@{#468123}
-
yigu authored
There is another common main thread scrolling reason that needs to be added. A scrollable area with an opaque background is not a stacking context therefore we don't composite it for now. BUG=660907 TEST=ScrollingCoordinatorTest.StackingContextTest CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2841603003 Cr-Commit-Position: refs/heads/master@{#468122}
-
acondor authored
This change implements the creation of textures from a base texture and a patch, in order to reduce the size of assets necessary for rendering the controller in VRShell. BUG=644562 Review-Url: https://codereview.chromium.org/2837973002 Cr-Commit-Position: refs/heads/master@{#468121}
-
wkorman authored
For SPv2 we always paint effectively invisible content, but during layerization we scrutinize effect node and skip chunks that would be effectively invisible. This simplifies code in SPv2 while still avoiding the resource and processing overhead of creating, managing and rastering a layer for that chunk. BUG=713403 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2833883003 Cr-Commit-Position: refs/heads/master@{#468120}
-
alph authored
Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ ) Reason for revert: The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html Original issue's description: > Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ ) > > Reason for revert: > Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644 > > Original issue's description: > > DevTools: fix aggregated donut chart cache population > > > > The check for stats cache availablity was made on the first task in the main thread > > tasks list. If the first task happens to be filtered out, it never gets cache built for > > it. Later the cache presence check would look for a cache on the first task, never find > > it and forces recaching. > > > > BUG=714934 > > > > Review-Url: https://codereview.chromium.org/2840463003 > > Cr-Commit-Position: refs/heads/master@{#467114} > > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2 > > TBR=pfeldman@chromium.org,alph@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=714934 > > Review-Url: https://codereview.chromium.org/2839083002 > Cr-Commit-Position: refs/heads/master@{#467223} > Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f TBR=pfeldman@chromium.org,sashab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=714934 Review-Url: https://codereview.chromium.org/2851823002 Cr-Commit-Position: refs/heads/master@{#468119}
-
ssid authored
The blacklist was introduced by crrev.com/2592233002 to make thread checks stricter. The blacklist was to throttle the number of build bot failures. There are only few providers left and it causes a need for having |is_enabled_| in MDM. So, remove this check. BUG=643438 Review-Url: https://codereview.chromium.org/2844373002 Cr-Commit-Position: refs/heads/master@{#468118}
-
brucedawson authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/fc02cc3806a3..3b583396bf13 $ git log fc02cc380..3b583396b --date=short --no-merges --format='%ad %ae %s' 2017-04-24 fbarchard Disable CopyRow_MIPS 2017-04-18 brucedawson Avoid double compiles of libjpeg 2017-04-18 fbarchard Roll chromium_revision da7cc8ca..ce95e5d8 (465147:465389) 2017-04-18 kjellander Roll chromium_revision 7950721f..da7cc8ca (454907:465147) Created with: roll-dep src\third_party\libyuv The "Avoid double compiles of libjpeg" change will slightly reduce the number of build steps and will also avoid hundreds of duplicate symbol warnings when linking. Details in the bug. BUG=706627 Review-Url: https://codereview.chromium.org/2841273003 Cr-Commit-Position: refs/heads/master@{#468117}
-
alph authored
Revert of DevTools: Show screenshots on the main flamechart (patchset #3 id:40001 of https://codereview.chromium.org/2830343004/ ) Reason for revert: Panning does not work, as well as HiDPI. Original issue's description: > DevTools: Show screenshots on the main flamechart > > The patch puts the screenshots on the frame bar and makes it expandable. > > BUG=705054 > > Review-Url: https://codereview.chromium.org/2830343004 > Cr-Commit-Position: refs/heads/master@{#466821} > Committed: https://chromium.googlesource.com/chromium/src/+/575cce8631ed083645523d47a35090d6ca6ccdfd TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=705054 Review-Url: https://codereview.chromium.org/2854473002 Cr-Commit-Position: refs/heads/master@{#468116}
-
lgrey authored
BUG=715627 Review-Url: https://codereview.chromium.org/2848953002 Cr-Commit-Position: refs/heads/master@{#468115}
-
nasko authored
This CL adds a few more layout tests that are failing on the Site Isolation FYI bots. BUG=716085 Review-Url: https://codereview.chromium.org/2845973006 Cr-Commit-Position: refs/heads/master@{#468114}
-
krasin authored
Right now, we are transitioning to LLD, and LLD has a different map format (so, the analysis tool will need to be updated), as well as suboptimal implementation that adds 60 minutes to the Chrome link time. This will be reenabled when both of the blockers above are resolved. BUG=716209,607968 Review-Url: https://codereview.chromium.org/2849583005 Cr-Commit-Position: refs/heads/master@{#468113}
-
jdonnelly authored
BUG=716493 Review-Url: https://codereview.chromium.org/2847813004 Cr-Commit-Position: refs/heads/master@{#468112}
-
ntfschr authored
No change in production logic. Visibility of elements must be checked by recursively checking the visibility of parent elements, since any element inside an invisible element will also be invisible. This issue does not present itself in the Desktop layout, because .hidden is defined differently (with display: none). Since the mobile layout defines it with opacity, we need to recursively check parents. It's not sufficient to check the opacity value itself, because CSS transitions may not have finished by the time we check. Instead, we simply check the CSS class and trust it to hide things properly. BUG=716542 Review-Url: https://codereview.chromium.org/2845423002 Cr-Commit-Position: refs/heads/master@{#468111}
-
thomasanderson authored
Now that [1] has been fixed and libgtk-3-0 has been installed in clusterfuzz's 32-bit configuration, it's safe to enable gtk3 for all platforms. [1] https://crbug.com/699669 BUG=79722 TBR=dpranke@chromium.org CC=erg@chromium.org,inferno@chromium.org Review-Url: https://codereview.chromium.org/2847863002 Cr-Commit-Position: refs/heads/master@{#468110}
-
chrishtr authored
NOPRESUBMIT=true BUG=713190 Review-Url: https://codereview.chromium.org/2844593002 Cr-Commit-Position: refs/heads/master@{#468109}
-
dgozman authored
This ensures proper capability check. BUG=none Review-Url: https://codereview.chromium.org/2845813003 Cr-Commit-Position: refs/heads/master@{#468108}
-
megjablon authored
Specifically, add menu option displays and track site breakdown displays, sorting, and expansion. BUG=716111 Review-Url: https://codereview.chromium.org/2846953002 Cr-Commit-Position: refs/heads/master@{#468107}
-
robertogden authored
Using a local proxy instance with the associated bug, the failed response gave a 404 status. This check differentiates between the bug and not. BUG=715644 Review-Url: https://codereview.chromium.org/2844403002 Cr-Commit-Position: refs/heads/master@{#468106}
-
jrummell authored
As suggested in a previous CL, the status for each keyId should have it's own status value rather than relying on all the KeyIds to have the same status. No longer passing |unexpected|, as the size check verifies that the correct number of expected KeyIds matches. BUG=616166 TEST=modified tests pass Review-Url: https://codereview.chromium.org/2847803005 Cr-Commit-Position: refs/heads/master@{#468105}
-