GitLab

https://chromium.googlesource.com/catapult.git/+log/6fc719e87628..b8e60f98418e


git log 6fc719e87628..b8e60f98418e --date=short --no-merges --format='%ad %ae %s'
2018-08-31 dtu@chromium.org [pinpoint] Tighten chart bounds.


Created with:
  gclient setdep -r src/third_party/catapult@b8e60f98418e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I7b31f1a89a9c6b0e7423d53c3f17832aa0c91bcf
Reviewed-on: https://chromium-review.googlesource.com/1199870Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588209}

Bug: 879704
No-Try: True
Change-Id: I454192e7c0cde3883bfe43e76029727b4924bfc1
Reviewed-on: https://chromium-review.googlesource.com/1200312
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588208}

The ScenicSession class underwent a breaking name change on the
functions OnError, OnEvent -> OnScenicError, OnScenicEvent, and
so this change modifies the names in the impl to get it building
again.

Change-Id: I5ebad87fa16c002344ecd232da05157c0871890f
Bug: 707030
Reviewed-on: https://chromium-review.googlesource.com/1200406Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588207}

especially on CQ bots (which has DCHECK enabled):
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=inspector-protocol%2Fheap-profiler%2Fheap-snapshot-with-no-detached-iframe.js

TBR=wangxianzhu@chromium.org

Bug: 878650
Change-Id: Ibdcaa931c8820e9dfcf2f6c3e88922aa7345dc5b
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1199720Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588206}

r581008 added a call to SetNeedsCompositingInputsUpdate in LayoutView
whenever overflow needed to be recomputed. It actually only
needs to do that when overflow actually changes. This regresses
any site which causes LayoutView overflow recomputation during
animations.

The call to SetNeedsCompositingInputsUpdate already exists
in LayoutBlock::ComputeOverflow, and correctly only does it
when overflow changes.

An example is tools/perf/page_sets/key_silk_cases/pushState.html,
which was one of the key silk sites that regressed in issue 872172.
In that case, main frame times approximately doubled, because
of the extra work to compute compositing inputs.

crbug.com/872172

Change-Id: Iaf4780c0e3ed4d8df67d16d836486df6df0d2f43
Reviewed-on: https://chromium-review.googlesource.com/1200315Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588205}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/d636a4fae3c1..cb6ec4b1f91a


git log d636a4fae3c1..cb6ec4b1f91a --date=short --no-merges --format='%ad %ae %s'
2018-08-31 hinoka@chromium.org Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""


Created with:
  gclient setdep -r src/native_client@cb6ec4b1f91a

The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mseaborn@chromium.org

Change-Id: Ibb7a64bb3f5994bcb922a3175584c10485707eda
Reviewed-on: https://chromium-review.googlesource.com/1200325Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588204}

Bug: 731363
Change-Id: I9506337b62d6a98eba462520cdf545a6d58f62b5
Reviewed-on: https://chromium-review.googlesource.com/1199821Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588203}

This adds translation screenshots for the regular dino page on
Android/iOS and for one branch of the offline content experiment.

This is based on the translation screenshot process described here:
https://docs.google.com/document/d/1nwYWDny20icMSpLUuV_LgrlbWKrYpbXOERUIZNH636o

Bug: 852872
Change-Id: I7363609fa8d53ef3ad28b9101a30d618455f084c
Reviewed-on: https://chromium-review.googlesource.com/1199849Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588202}

This CL tries to correct the box model when there are scrollbars,
especially in vertical-rl mode. According to
https://www.w3.org/TR/css-overflow-3/#scrollbar-layout, scrollbars
"should be inserted between the inner border edge and the outer
padding edge".

Changes to the previous code:

- Padding|client box now excludes scrollbars, with the help of
  (Top|Left|Bottom|Right)ScrollbarWidth methods which can get the
  scrollbar widths in physical directions in various writing modes.

- Content box is now based on the new padding box by excluding the
  paddings.

- Layout of contents is now based on the correct box model. In
  vertical-rl mode, layout of contents in blocks direction starts
  from the inner edge of the new content box which has been properly
  adjusted for the scrollbar.

- Now LayoutBox::Location() and Location::PhysicalLocation() in the
  initial scroll state are correct in all writing-modes. Previously
  when they were incorrect in vertical-rl mode and some flex box
  directions, requiring an artificial scroll offset to paint the
  content at correct place.

- With the correct padding box, content box, Location(),
  PhysicalLocation(), we no longer need the band-aid code to create the
  correct painted result.

The changed code is mostly in LegacyLayout code. Some changed code is
in LayoutNG that previously converted correct LayoutNG geometries into
the problematic geometries that were previously expected by
LegacyLayout.

The correct box model is required by blink-gen-property-trees because
we can't band-aid the incorrect results in paint properties after
painting.

Bug: 833167,853945,858843,878809,876266

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I41faf1ca0bfb95cb287c72703f08c8bd44e9e752
Reviewed-on: https://chromium-review.googlesource.com/1185901Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588201}

These APIs are used by the central cache. Their absence in the exported API
of the singly linked list implementation was not noticed because doubly
linked lists are enabled for all Chromium builds.

BUG=724399,b:70905156

Change-Id: I0187789eb416ce751aa1a369ea96c0d317d3702a
Reviewed-on: https://chromium-review.googlesource.com/1195093Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588200}

This CL adds the implementation to connect to the mirroring service
when requested to start a mirroring session.

Bug: 734672
Change-Id: I232ad4bda8b409a90af3d37662f1a21296103dda
Reviewed-on: https://chromium-review.googlesource.com/1184153
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588199}

Bug: 875088
Change-Id: Ie43c9e30e3a60d2097bc82009f3f29e07a4dff42
Reviewed-on: https://chromium-review.googlesource.com/1198103Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588198}

Using wpt-import in Chromium ec3d142c.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23753

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I17823e4bbf726748d0403e74dc676f07e64d5851
Reviewed-on: https://chromium-review.googlesource.com/1199936
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588197}

.. in frame_sink_video_capturer_impl.cc

Bug: 754986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I70b9cd3acf5dc7f40f4f3fc0a5a78a2cd9f63505
Reviewed-on: https://chromium-review.googlesource.com/1195043Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588196}

Route the per resource request is_ad_resource flag to the
SubresourceFilterAgent so it can be used in creating per-page ad
metrics. The request ids are necessary to associate the
network PLM updates with the resource.

Requires that the subresource request id be returned from the
WebUrLoader in blink::ResourceResponse.

Bug: 851543
Change-Id: I2ca0ed887cfa8a2c8dddf99613a29f8654bf9ed5
Reviewed-on: https://chromium-review.googlesource.com/1165823
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588195}

https://chromium.googlesource.com/angle/angle.git/+log/89e829793028..253038d8d13b


git log 89e829793028..253038d8d13b --date=short --no-merges --format='%ad %ae %s'
2018-08-31 jmadill@chromium.org Vulkan: Refactor VertexArrayVk::streamIndexData.
2018-08-31 ynovikov@chromium.org Fix EGLImage pixel format validation
2018-08-31 ianelliott@google.com Add stubs for A4A opt-in library.
2018-08-31 yunchao.he@intel.com Add specification for ANGLE_texture_multisample.
2018-08-31 tobine@google.com Roll VK deps forward as of 8/31/2018


Created with:
  gclient setdep -r src/third_party/angle@253038d8d13b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: If04b4adb8fc865286d7f9b5b5b76f1f61686adb2
Reviewed-on: https://chromium-review.googlesource.com/1200322Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588194}

After fetching objects from a span, reset the previous field of the first
remaining object in the span.
Debug builds perform extra sanity checks on the state of the tcmalloc
metadata, which is causing them to fail without this fix.

BUG=724399,b:70905156

Change-Id: I33ad3097d13756d36032edde538ee87b09a1a4ee
Reviewed-on: https://chromium-review.googlesource.com/1195092Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588193}

Bug: 878529
Change-Id: I01f8c6cb8fab2785f6eaf258c91edd6f3ef58736
Reviewed-on: https://chromium-review.googlesource.com/1195160
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588192}

Chrome v70 is branched.
Adding support for Chrome v70 and dropping support for Chrome v67.

Change-Id: Ic26fc2e011f38cfc0ae34f9f19770a5d15b22f05
Reviewed-on: https://chromium-review.googlesource.com/1199776Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588191}

We were moving onto to checking ContextGL if binding failed. This is bad,
because we should not touch ContextGL if we haven't been bound.

Bug: 879438
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7898adf7af963216c388adaa35c5c2c287802fed
Reviewed-on: https://chromium-review.googlesource.com/1200363Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588190}

This reverts commit 069a1be1.

Reason for revert: Clang roll with the upstream bug fix has landed.

Original change's description:
> android: Disable thinLTO for 32-bit ARM builds.
> 
> This is done to avoid a runtime crash at startup when
> Chrome starts up on devices with a very old Linux kernel.
> 
> This is only one way to address the problem, but probably
> the simplest patch to fix it. See bug entry for all details
> and alternatives considered.
> 
> BUG=871722
> R=​agrieve@chromium.org, pcc@chromium.org, thakis@chromium.org
> 
> Change-Id: I9a197a347538ae9cf9ce6de7b243f522cb425043
> Reviewed-on: https://chromium-review.googlesource.com/1167502
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: David Turner <digit@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581627}

TBR=digit@chromium.org,thakis@chromium.org,pcc@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 871722, 872611
Change-Id: I02d8b5519b978fd61b8cd2ead8718ff77846b402
Reviewed-on: https://chromium-review.googlesource.com/1199937Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588189}

As requested by UI review.

TBR=rockot@chromium.org

Bug: 862419
Change-Id: I10091941b92113f747b4969265ebcd212efe12ad
Reviewed-on: https://chromium-review.googlesource.com/1199861Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588188}

https://pdfium.googlesource.com/pdfium.git/+log/a6325f8ab7ec..ca3a100e7dcf


git log a6325f8ab7ec..ca3a100e7dcf --date=short --no-merges --format='%ad %ae %s'
2018-08-31 hnakashima@chromium.org Simplify radial shading.
2018-08-31 thestig@chromium.org Use more UnownedPtrs in CFXJSE_Engine.
2018-08-31 npm@chromium.org Roll third_party/freetype/src/ 96b5e5009..2c8e6279a7b (38 commits)


Created with:
  gclient setdep -r src/third_party/pdfium@ca3a100e7dcf

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If384b85777f8f0e8cb5a98c41917c3ad563b150a
Reviewed-on: https://chromium-review.googlesource.com/1199695Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588187}

This CL adds the user's e-mail address and profile photo to the password
prompt page at the beginning of the setup flow. This is a security
requirement as it makes it clear to users what password that they should
enter.

Additionally, this CL adds a "cancel" button to this page.

Note that there are various styling/CSS changes which still need to be
made so that this page matches the mocks.

Bug: 878643, 824568
Change-Id: I59e75f73c310ea5f275b844268b70fa2e47af72f
Reviewed-on: https://chromium-review.googlesource.com/1198564Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588186}

This reverts commit 16cca0d5.

Reason for revert: Branch has happened, bring back Feed.

Original change's description:
> [Feed] Temporarily compile out Feed for branching.
> 
> Feed component adds a significant amount of code that's not used yet
> for users. See Feed DEPS rolls for current size impact.
> 
> Change-Id: I2c77f9f8d640b46c58602b29a3f79357f7cb1140
> Reviewed-on: https://chromium-review.googlesource.com/1188596
> Reviewed-by: Filip Gorski <fgorski@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587620}

TBR=fgorski@chromium.org,skym@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icf2d1b8f2501a71436efd47d296deb0a072e9db0
Reviewed-on: https://chromium-review.googlesource.com/1199701Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588185}

These baselines are unused and only serve to confuse.

Found with this script:
find * -name '*.any*-expected.txt' | while read baseline; do
  file="$(echo $baseline | sed 's/\.any.*/.any.js/')";
  [[ -f $file ]] || git rm $baseline;
done

Change-Id: Ibee6505895e91c68e43a452a002af9601a9adbfc
Reviewed-on: https://chromium-review.googlesource.com/1200022Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588184}

Previously we did not consider the possibility of a typographic unit
containing multiple surrogate pairs, and could as an effect "lose" part
of the width.

Distribute the width evenly among code points instead to at least get
some sort of consistency.

Bug: 879361
Change-Id: I51a4e6c574926215a087b0bc824ac90d580ff169
Reviewed-on: https://chromium-review.googlesource.com/1199423Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588183}

gyp is no longer needed on sys.path after
https://chromium-review.googlesource.com/c/chromium/src/+/1063611

Bug: 826218
Change-Id: I5ee268cab2f75b4fd6bddd62685f14dee4669626
Reviewed-on: https://chromium-review.googlesource.com/1199572Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588182}

TBR=dullweber@chromium.org (for tools/traffic_annotation/summary/annotations.xml)

BUG=773295

Change-Id: I5ee6e7ea8cd48c18f7e51487f974a7cde1ec49d2
Reviewed-on: https://chromium-review.googlesource.com/1199484
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588181}

TBR=foolip@chromium.org,robertma@chromium.org

Bug: 879728
Change-Id: I961914c7ccffa3842d2a27ee489611278e88f01c
Reviewed-on: https://chromium-review.googlesource.com/1199968Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588180}

This CL is turning on the CPU sampler category.
  see: https://chromium-review.googlesource.com/c/chromium/src/+/1191745/

It's also turning on the task scheduler info. Which is adding the
task_priority to the trace and will ease finding priority inversion.

  Title          TaskTracker::RunTask
  Category       task_scheduler
  Args
    task_info    {execution_mode: "parallel", task_priority: "USER_BLOCKING"}


R=etiennep@chromium.org, oysteine@chromium.org

Bug: 867931
Change-Id: I8f6e4772816cc446a25c04ce0cda4b9d45c44232
Reviewed-on: https://chromium-review.googlesource.com/1199567
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588179}

These keyboard shortcuts trigger focus changes that cause
InputMethodMus to ack all in-flight keystrokes as unhandled.
This causes ash to try to process the keystroke as an
accelerator, resulting in the new-tab command running
twice.

Instead, ack the key events as handled during focus change.

Bug: 874098
Test: updated aura_unittests
Change-Id: Idda91cbcc7f5d9ad328f7bfb7d6dc0367d85817d
Reviewed-on: https://chromium-review.googlesource.com/1195085Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588178}

. Add ExternalMediaMetadata to the external input source and state.
. Add ExternalMediaMetadataChangeObserver for the external pipeline to report media state change.
. Report external pipeline state to the Assistant Server via MediaParams.

Design doc: internal http://go/voice-control-for-external-audio-pipeline

Bug: internal b/80156336
Change-Id: I68ec11cc6fe4f368c34fe705c05a0f50ee9011cc
Reviewed-on: https://chromium-review.googlesource.com/1192116Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588177}

This CL changes the behavior of the splash icon for WebAPKs to match that of
non-WebAPK homescreen shortcuts. The splash icon for
non-WebAPK-homescreen-shortcuts is downsampled to 128x128dp by
ManifestIconDownloader::OnIconFetched()

The WebAPK Minting server generates a single WebAPK per start URL. That single
WebAPK needs to work with all screen densities, thus the downsampling needs to
occur on the client side.

BUG=879255

Change-Id: I5822e1c8bf3cf02d7d3935989ae4d786cc9d9bb8
Reviewed-on: https://chromium-review.googlesource.com/1197623Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588176}

Normal task window shouldn't be in the system modal container,
but can happen due to a bug in Android side. (ex. b/111767668)

This is a safe guard not to show the frame even if it happens.

Bug: 878426
Test: Covered by unittest
Change-Id: Ib6344acf0ff9ec86b1e40238a8c8e60828948cee
Reviewed-on: https://chromium-review.googlesource.com/1194287Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588175}

Change-Id: I64832492a8019a24a4420d1a2dfdd65d69b503ee
Reviewed-on: https://chromium-review.googlesource.com/1199769Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588174}

Bug: 875088
Change-Id: I5c09daa610bba32c8be8b411e1a9e333697e64f9
Reviewed-on: https://chromium-review.googlesource.com/1196163
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588173}

TEST=N/A
BUG=879413

Change-Id: I6e55415d41e8833a972a29e92ae26882d5c94912
Reviewed-on: https://chromium-review.googlesource.com/1199859Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588172}

WebDialogDelegate should mirror DialogDelegate and provide an
implementation of WidgetDelegate::GetAccessibleWindowTitle. This also
adds an accessible title to the Print dialog.

Bug: 868179
Change-Id: I8e1c4b7262130b1a68f861bae9822ee191b0a06c
Reviewed-on: https://chromium-review.googlesource.com/1187623
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588171}

For context, when a change occurs in the a phone to which the
Chromebook is tethered, the MultiDevice tethering item is alerted and
updates accordingly. The bug was caused by the fact that the default
value for the deviceState property was null when there is an update and
no phone is found. In particular, this is exactly the situation that
occurs immediately following a successful request to forget the
tethering phone. Because the network-summary-item (the element directly
responsible for deplaying the tethering data) has an A11y string that
depends on a property (i.e. deviceState.Type) of deviceState, this
triggers the error described in the bug when the binding is updated.

The solutions was simply to change the default value for deviceState on
updates where no device is found from null to
{Type: 'Tether', State: 'Disabled'}
(this is the minimal definition satisfying the TypeDef so that the
binding can update safely.

Bug: 878972
Change-Id: I1850e5c613a935b2fade129a1466638756d4af13
Reviewed-on: https://chromium-review.googlesource.com/1197350Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588170}