- 21 Oct, 2020 40 commits
-
-
Alice Wang authored
TBR=sandromaggi@google.com Bug: 1140957 Change-Id: Ibc27ca9632d9bba356fc4c628a49bd51034b3a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489623Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819349}
-
Sylvain Defresne authored
The parameters of a script invocation needs to be relative to the directory where the script is invoked which is available as the `root_build_dir` variable. Using `root_out_dir` is incorrect as it has a different value for secondary toolchains (i.e. current_toolchain != default_toolchain). Bug: none Change-Id: I573af8eb46c001fbedc641f5e47022f0424284c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489622 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819348}
-
Andrew Shulaev authored
Bug: 1138893 Change-Id: I9bb9f1c0115d7081795dfd69dee24cd93640392c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485069 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#819347}
-
Colin Blundell authored
Note explicitly contexts in which KeyedService shutdown will *not* run. Bug: 1140296 Change-Id: I389d1be66a22fa3203e49f10d3c4e43721ccd24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485267 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#819346}
-
Maksim Moskvitin authored
The only remained function of SyncBackendRegistrar was keeping track of enabled datatypes. These enabled datatypes were used to determine invalidation topics to subscribe. This CL changes the source of enabled datatypes to ModelTypeRegistry (determined by datatypes that have ModelTypeWorker, i.e. connected datatypes) and removes SyncBackendRegistrar. Bug: 1138132 Change-Id: I0f7c2a17050da5249be7a5aec00b15a28642a835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476155 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819345}
-
shivanigithub authored
Since the RedirectMode needs to be used for other decisions than just deciding the behavior on redirect e.g. https://chromium-review.googlesource.com/c/chromium/src/+/2487704/1 it makes sense to rename it to RequestType. This CL only renames the type and enum values and their usages but has no functional change Bug: 1135149 Change-Id: Ib0856c83a9cfdcb925cdcfbacd9003895bbacace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463332Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#819344}
-
Fabian Sommer authored
Change "remvoe" to "remove". Bug: 1131450 Change-Id: Icbd37d815b19d658b2dfbf004e3116632f786cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489900Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819343}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/f3f785ab59..4b915e7092 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/f3f785ab59..4b915e7092 Bug: None Change-Id: Ie433d9b81b087dd8d98242382a2fae9a66cedc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489427Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#819342}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cd48ca0493ce..2d615e49c1cb 2020-10-21 landrey@webrtc.org Update uploads api documentation comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114056 Tbr: skyostil@google.com Change-Id: I36b157669352dbafa484f71018accd151a090df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489748Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819341}
-
Stephen McGruer authored
This test can flake if the iframe is loaded OOP and the child script runs before the parent script. Bug: 1137228 Change-Id: I13b8d2d85cae6d0eb5ab00029a388ea321c86150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481347 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#819340}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be6747613d78..d139f2661939 2020-10-21 fmayer@google.com Merge "Add classloader to heap graph proto." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4b83eef5320466ddb2d69f755d436cbe13df6c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489174Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3a2aa62cc74fa3dd774897e8dcc2500f24e9bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490220Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819338}
-
sauski authored
Creates entry in fieldtrial_testing_config.json which enables the access context auditing feature. Bug: 1101675 Change-Id: I8a1435a9554a8fea2d2022bced88b32d18796441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487322 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#819337}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ef36cec5b92e..7854287f1b6c 2020-10-21 sigurds@chromium.org Update browser_protocol.pdl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I13b8f9ad7ece7cf6d159d75d0b4b00e74fff23d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489173Reviewed-by:
-
Guido Urdaneta authored
This ensures that the actual WebContents is used to track desktop capture in MediaCaptureIndicator. Prior to this CL a null WebContents was used. Bug: 1140487 Change-Id: I3078dc3d071ca1dc34716de491996a275026f793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488160Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#819335}
-
sauski authored
A large refactoring of logic on the security page occurred after the CrSettingsSecurityPageV3 tests were disabled on MacOS. This CL re-enables the test on disabled platform in the expectation that previous changes have fixed MacOS platform specific flakes. Bug: 1081908 Change-Id: I79f8fcd1f408913b0d99d0fe2a8efe697ea86ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463608Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#819334}
-
Mohamed Amir Yosef authored
This is preparation for adding the functionality of moving multiple passwords from settings view. Mocks are in the linked bug. Bug: 1139263 Change-Id: I883e39bbab9bd20cdbfb67b43883886dea71badb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479462Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#819333}
-
sauski authored
Increase minimum height for radio buttons on redesigned content settings pages to the standard two-line height if they have a sub label. Bug: 1113642 Change-Id: I7ed293a967f21c332a86aa292bb741e4ab149f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487289 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77e70cfcbb1a..f176182440e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1140394 Tbr: apotapchuk@google.com Change-Id: I5bab7f2a201187a7ba37f014652ea4921f96be70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489661Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819331}
-
Henrique Ferreiro authored
This is a reland of dcee7502 after fixing https://crbug.com/1139157. The hidden cursor needs to be obtained from the CursorFactory, even if platform cursors are disabled and the Chromium assets are used instead (i.e. Chrome OS). This reland also fixes the original CL in that it accidentally reverted https://crrev.com/c/2443610. Original change's description: > Fix loading of animated cursors on Ozone/Wayland > > Animated cursor assets were not being loaded because GetCursorDataFor > was used for all cursors, instead of using GetAnimatedCursorDataFor when > the cursor was animated. > > With this CL, both set of cursors are merged so they can be retrieved > with a single call. > > To ease these changes, ImageCursor, which was a very thin layer over > CursorLoader, was merged into the latter. This change has the benefit of > unifying the cursor loading code path of Ash with the one of the other > Aura platforms and changing Ash on Linux to use the Chromium assets > instead of the platform cursors, as when running on Chrome OS devices. > > The only behavior change with respect to ImageCursors is that the cached > cursors will be removed on display changes, instead of reloaded. > > Bug: 1135515 > Change-Id: Iedf84290bf3792c3ce06cfad0be1b5c0e2d96946 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440760 > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815678} Bug: 1135515, 1139157 Change-Id: I2bfff067936b1ec8e828c5efdfb0a9c24caf7afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478977 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
sebsg authored
This reverts commit e95f1520. Reason for revert: Suspect for tree closure on mac-archive-rel https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16413? Original change's description: > Update V8 to version 8.8.149. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d82ff002..d9ccb94f > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ic433b4fc8287a7d664817f18b5d81bada20bb87a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489002 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#819313} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I314ad1a663be5e9ff15441bdfb9a5e0bbf0551a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489724Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819329}
-
Anatoliy Potapchuk authored
This reverts commit fe94c89a. Reason for revert:tree is red Original change's description: > Roll Chrome Mac PGO Profile > > Roll Chrome Mac PGO profile from chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata to chrome-mac-master-1603259905-71f19f253a8b5311fb57e85e7e87c615112024a2.profdata > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/pgo-mac-chromium > Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:mac-chrome > Tbr: pgo-profile-sheriffs@google.com > Change-Id: I7247c4994debae0d519f3b60b5e3bc9b811a3f07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489660 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#819318} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,pgo-profile-sheriffs@google.com Change-Id: Ic0fbf8d36691df86e01e4855d4e4c70add801bb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chrome.try:mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490102Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819328}
-
Marc Treib authored
ModelAssociationDone() was always called synchronously from StartAssociationAsync(). Inlining it there uncovers some more dead code: * The status passed back to DataTypeManagerImpl was in fact always OK, so no need to pass a status at all. * requested_types_ was unused. Bug: 1102837 Change-Id: I4d66c926189280e029630c68f58ab05ec7971844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479425 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Aya ElAttar authored
EndpointType::kClipboardHistory was added in crrev.com/c/2362289, so that ClipboardHistory will have access to any clipboard data, but the logic of EnterpriseClipboardDlpController:: IsReadAllowed didn't include kClipboardHistory when it got implemented. Bug: 1139835 Change-Id: I5f7fcd9e05a2a2f424b7ff1932edec557d23180f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487288Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819326}
-
Alexander Bolodurin authored
Add a special case for ARC DocumentsProvider URLs to the image loader to fetch thumbnails using a dedicated fileManagerPrivate function. The function checks document metadata for a thumbnail support flag, and, if set, fetches the actual thumbnail via a mojo call to ARC. If the document does not have a thumbnail, no thumbnail is rendered, rather than falling back to download the original file and resizing it into thumbnail. Mojo struct Size was moved from video_common.mojom to gfx.mojom as it's now used by the filesystem API as well. Bug: 1049966 Change-Id: I758c7558ede42b01ad877b6f14781d51f6e1f0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473857 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#819325}
-
Stepan Khapugin authored
Creates a new feature flag. Bug: 1138886 Change-Id: I74d3308e668bffdcce43fed8aacffb778c4fbe2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475697 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#819324}
-
Anatoliy Potapchuk authored
This test has been previously failing on Linux, now it fails on Windows, see https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/109192 Change-Id: I6b7d3ac20280c7bd264aee8091443e6f023434b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490120Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cca03ca6bfe9..e2cbcc956588 2020-10-21 hao.x.li@intel.com Query API: Record used query index in command encoder 2020-10-21 dsinclair@chromium.org Update WGSL struct syntax. 2020-10-21 jiawei.shao@intel.com Add the entry point of CreateReadyRenderPipeline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I790ce40a11c5509cf75689acd2635131f6d52591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489560Reviewed-by:
-
Christian Dullweber authored
Flash is going to be removed in M88, so mark related extension APIs as deprecated and make them a no-op. Bug: 1135788, 1135791 Change-Id: Idd2ceefcbe8eb6baeb31f44a4f3b12283253939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466236 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819321}
-
Anatoliy Potapchuk authored
This reverts commit f7e31c9d. Reason for revert: this seems to cause breakages in mac builders https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9647 Original change's description: > Set fallback focus to the accounts and sync dialog. > > Set the first container as initial focus, so focus manager will search > the first focusable item in case no other view is explicitly focused > (e.g. with Ctrl+Shift+M, focus is set to the profile list for quick > profile change). Setting focus inside the dialog is important for > accessibility: when focus changes to a view inside the dialog, screen > readers will announce the dialog to give context to the focus change. > > We don't need to override GetAccessibleWindowRole() any more because > the implementation in DialogDelegateView will set the 'dialog' role for > bubbles which have an initially focused view. > > Tests are altered to make up for the default focus change. Before, > default focus was set outside the dialog and you had to advance once > to reach the first element. Now, it's already placed on the first > element. > > Bug: 1098304 > Change-Id: Ie0db18193cb224497d311c8ae864ec4e532572b6 > AX-relnotes: set focus into, and read accounts and sync dialog when open > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475056 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> > Cr-Commit-Position: refs/heads/master@{#819287} TBR=pbos@chromium.org,jkrcal@chromium.org,rhalavati@chromium.org,jaragunde@igalia.com Change-Id: I8ad7448148905434910bd1178594e6542935ed85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489882Reviewed-by:
-
Koji Ishii authored
This patch: 1. Makes sure |ShapingLineBreaker| computes |is_hyphenated| for when it returns early. Before this change, it only when the given string wraps. Since |NGLineBreaker| pass one |NGInlineItem| at a time, it is not computed when a soft hyphen or hyphenation point appears at the end of a text node or |NGInlineItem| after segmentations. 2. Recovers the hyphen when |NGLineBreaker| rewinds to a hyphenated break opportunity. This patch fixes 6 tests, but `hyphens-out-of-flow-00[12]` now fail for other reason (crbug.com/1024331). They are relabled. Bug: 639223 Change-Id: Id510b53c64bf02a6b72299ffcd8ed551a52ed2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476354 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819319}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata to chrome-mac-master-1603259905-71f19f253a8b5311fb57e85e7e87c615112024a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7247c4994debae0d519f3b60b5e3bc9b811a3f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489660Reviewed-by:
-
Christian Biesinger authored
In particular, this opts us into filing bugs for failures. R=ikilpatrick@chromium.org, mstensho@chromium.org Change-Id: I3b1eba3dd5b71f8eeb1fbf5fa49bba739fd7d7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489720 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#819317}
-
Henrique Ferreiro authored
The cursor type mojom::CursorType::kNone is used to hide the cursor. Therefore, CursorLoader::SetPlatformCursor() should create an invisible platform cursor for that type. This CL adds a test that checks that that's the case for the different implementations of platform cursors. Bug: 1139157 Change-Id: If9cde827f820e6420d0298dcdf6df3b1dbaafd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485101Reviewed-by:
-
Stephen Chenney authored
These are all font related histograms so I should own them as metrics lead for the Blink Rendering Core team. Change-Id: If7a2ab7fcf5d34810ca8dc5e6f155d3d93a28795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485302 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#819315}
-
Anton Bikineev authored
This is to make it less error prone if checks are augmented in one place but not in the other. Bug: 11297512 Change-Id: Id5518f703bf7240f8634570996eb5ec4eda10f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471332 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819314}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d82ff002..d9ccb94f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic433b4fc8287a7d664817f18b5d81bada20bb87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819313}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7a0246ff177e..cd48ca0493ce 2020-10-21 sadrul@chromium.org [uma metric] Restrict check for linear bins. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1139460 Tbr: skyostil@google.com Change-Id: Ia147c8d841c350afdaf1f5dd9ac54eeaa2d88f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489228Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2147a58a233..553726a4c5c8 2020-10-21 m.maiya@samsung.com Vulkan: Add OES_shader_multisample_interpolation extension 2020-10-21 cnorthrop@google.com Tests: Add Free Fire trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_perftests --gtest_filter="*free_fire*" Change-Id: Ica4cba1a2b331d96d56754eb9ad4862a0501f457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489166Reviewed-by:
-
Yunke Zhou authored
Bug: 1128051 Change-Id: Id6396804860ba7685e2df0ed1e1dbbe65302ff03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474493Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#819310}
-
