- 23 Nov, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib1bff47182a59e52a3eaa5f96a497b11261d060e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830251}
-
Bo Liu authored
When vulkan is used for composite and raster, there are still code paths that needs GL. SharedContextState::IsCurrent always return true if vulkan (or some other non-gl gr_context_type) is used. For the code paths that always needs GL, IsCurrent is returning the wrong value, leading to some no-context-current errors. Fix this by adding a bool needs_gl parameter that defaults to false (similar to MakeCurrent), and set it to true for the two cases that I ran into. Bug: 1151376 Change-Id: Idec4a231579b067d5aa9b60ae21d6a2a11e794ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553285Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830250}
-
Janusz Majnert authored
Prerendering causes creation of additional RenderProcessHostImpl objects, which hold it's own blink instance. In single-process mode this causes blink to be initialized multiple times, which in turn triggers a DCHECK "FATAL:platform.cc(180)] Check failed: !did_initialize_blink_." This change disables prerendering in single-process mode. Test: load http://jmajnert.github.io/tests/prerender_landing.html in debug single-process build Bug: 1151372 Change-Id: I23992afbf681089b4b25e084eeccf470484b2320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550560Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#830249}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/79348b55df90..4b5d323d2fee 2020-11-23 tommi@webrtc.org Remove dependency on AsyncInvoker from BasicRegatheringController 2020-11-23 nisse@webrtc.org Delete internal getter methods from RtpRtcpInterface 2020-11-23 danilchap@webrtc.org Restructure format of the video layers allocaton rtp header extension 2020-11-23 mbonadei@webrtc.org Reland "Introduce RTC_NO_UNIQUE_ADDRESS." 2020-11-23 danilchap@webrtc.org Ignore frame type when calculating generic frame dependencies. 2020-11-23 nisse@webrtc.org modules/bitrate_controller/include is no longer a legacy api directory 2020-11-23 nisse@webrtc.org Delete unused class CaptureResultDesktopCapturerWrapper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:764258 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I309bbd798235398902be5531703db8c6a6f75a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554960Reviewed-by:
-
Elly Fong-Jones authored
When a screenreader or other assistive technology is enabled, this change allows traversing even disabled menu items using the arrow keys. This seemingly odd behavior is how platform menus work on both Windows and Mac. One note: toggling assistive technology off while a menu is open causes the accessible arrow key behavior to remain for the lifetime of that menu, but toggling it on while a menu is open enables accessible behavior for the menu immediately. This too is seemingly odd but matches how the Mac system behaves. Bug: 1067760 Change-Id: Id5630fa69cd3d9cce76c89e123db8bbccb6ce5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551799Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#830247}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46823b0ba3d6..6f6504c9ad60 2020-11-23 jmadill@chromium.org Suppress WebGL Mac end2end failures. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I74a1c152717f08558d93a9ed5c47a61f7b16abb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554961Reviewed-by:
-
Nate Chapin authored
For userAgent(), all the necessary state can be ready off of the ExecutionContext already. For GetUserAgentMetadata(), it's already available on WorkerGlobalScope and can be easily reached from LocalDOMWindow, so add a GetUserAgentMetadata() to ExecutionContext. Change-Id: I03f1f83f589a1d4334efb58e2725ff00c7bd0414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552720 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#830245}
-
Roman Aleksandrov authored
Fixed: 1136386 Change-Id: I9f6bf45c94fb8b26e05ecff5a5304e9eef857e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552396 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830244}
-
Elly Fong-Jones authored
This change renames all remaining variables & updates all remaining strings describing the master_preferences file except for strings/ variables/comments that are describing the filename on disk, which remains unchanged. The next step in this work is to add support for a new "initial_preferences" file, then deprecate support for the old "master_preferences" file. Bug: 1097209 Change-Id: I98ab16002669346239e9b7642302ad832429c3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551281Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#830243}
-
Clark DuVall authored
This is a reland of 86c3def7 Changed this to use a field on BuildConfig.java so it wouldn't change the native lib. Original change's description: > Add synthetic field trial for isolated splits > > This should make analysis easier for a binary experiment, since the > Finch dashboard can be used. > > Bug: 1150162 > Change-Id: Id90204398234938c441982d5c2bc5c6f7c63d575 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545874 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829494} Bug: 1150162 Change-Id: I9447c7f5e1303f036545287738028443c67551d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554032Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#830242}
-
Francois Doray authored
R=bbudge@chromium.org TBR=bbudge@chromium.org Bug: 1003252 Change-Id: I4504720a40f4335bbf45bcc997ed4598c9b3b721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554788 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#830241}
-
Mohamed Heikal authored
Bug: 1151352 Change-Id: I2a117e5f6cb3bf1b08f7f9f68cea7e4a893db6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553852 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
This patch disables the following tests on iOS device, since they are flaky: RepeatableQueriesServiceTest.SignedIn_ErrorResponse RepeatableQueriesServiceTest.SignedIn_DefaultSearchProviderChanged Bug: 1151909 Change-Id: Id3ad9614adc1fe2a03e6980624895b1172cff8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552915 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830239}
-
Alexander Hendrich authored
This CL is part of a larger refactoring/clean-up of policy_test_cases.json. The "test_policy" field used to be read by the code, but the value is not used anywhere. Bug: 1151251 Change-Id: I472e4daa552e1f276c4d1ec6b4da04c8670cb507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552582 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830238}
-
Illia Klimov authored
This CL prevents abusive origin permission revocation for profiles with disabled Safe Browsing. Bug: 1151900 Change-Id: I87d117073363177d16b8957791ebf2badb307fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552599 Commit-Queue: Illia Klimov <elklm@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830237}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c0dc3026eed..260eb0f662b4 2020-11-23 nodir@chromium.org [tryserver] Report affected files via property If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1151655 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I700efd778dea11245a8bc8c3b2a86a49597160f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553701Reviewed-by:
-
Alexander Hendrich authored
This CL is part of a larger refactoring/clean-up of policy_test_cases.json. The field only exists as part of the "indicator_tests" so it is ignored here. Bug: 1151251 Change-Id: I6ff4ff8b88c4befaa7b340000fd149c5ea206f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550819Reviewed-by:
-
Fabio Rocha authored
This CL adds the ProtocolHandlerManager class and its interface to handle protocol handler registration operations. It also ties it to the OSIntegrationManager, which handles app events that interact with the OS (e.g.: app install, update, uninstall, profile deletion, etc..). This CL does not, at this point, add any OS hooks for protocols -- that will come as we add the implementation for ProtocolHandlerManager. This CL is mostly conceptual and therefore should not cause product changes. Future CLs will hook handler registration APIs into ProtocolHandlerManager/OSIntegrationManager. Bug: 1019239 Change-Id: I0c5a26499c000a31067887d42b93d18d0f6c3f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243335Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#830234}
-
Yue Zhang authored
Some of the test flakiness in tab_ui are caused by tab switcher button being invisible in NTP when we try to click it. This is likely due to unexpected scrolling in NTP which hides the top tool bar. Before landing the actual fix which could introduce some other flakiness, this CL lands a workaround first to see how many flakiness could be fixed by resolving this issue. Bug: 1145271 Change-Id: Iae74425cdc66f41dbfc8eca0d91129c67e9bca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536385Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830233}
-
Alex Ilin authored
TBR: twellington@chromium.org Bug: 1142979 Change-Id: I87c143a25d4d6cfde29947a91f099d49561c89d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555002Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830232}
-
Sigurdur Asgeirsson authored
This makes the class simpler to use in the common case. Bug: 1145565 Change-Id: Ib6aab62eebf4e402e364687d4224d0f8d7077e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549534Reviewed-by:
-
GioVAX authored
by introducing base classes for LogCollector and Logger BUG=chromium:10734365 TEST=unit_tests --gtest_filter=ExtensionInstallEventLoggerTest.*:ExtensionInstallEventLogCollectorTest.*:AppInstallEventLogCollectorTest.*:AppInstallEventLoggerTest.* Change-Id: I32743bee419682b942b4867b8705d071b48da9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485102 Commit-Queue: Giovanni Pezzino <giovax@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Vasiliy Telezhnikov authored
This reverts commit db7626d6. Reason for revert: Causes crash on windows Original change's description: > Use GrShaderCache with Vulkan > > VulkanContextProvider is created before GrShaderCache and so cache > wasn't pass to Skia via GrContextOptions. > > This CL defers init of GrContext in VulkanInProcessContextProvider to > SharedContextState::InitializeGrContext to mitigate this. > > Use of cache itself is under feature flag for metrics comparison and > a kill switch purpose. > > Bug: 1151031 > Change-Id: Idc410b9b557f7ca67164eb80d6a37a27ceb0f6d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551245 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829651} TBR=penghuang@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1151031, 1151645 Change-Id: Ic6712d111d234f72fd799a4c48a90a4426aa1a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553698Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830229}
-
Nick Burris authored
This patch refactors SslValidityChecker from chrome into components, so that it can be used in WebLayerPaymentRequestFactory to implement getInvalidSslCertificateErrorMessage(). SslValidityChecker is modified to check the certificate without using chrome's security_state_tab_helper, instead using security_state directly. Bug: 1144850 Change-Id: I5964d43e97b66ed5c3470ca6d331b34303bc8bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551798Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#830228}
-
Alex Ilin authored
MediaCaptureTest#twoStreams and MediaCaptureTest#twoStreamsNotification are still flaky on Lollipop Tablet Tester and Marshmallow Tablet Tester TBR=sky@chromium.org,estade@chromium.org Bug: 1107380 Change-Id: I4f875f32d4d3de74ab99b225e4ee78a2637a955f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555337 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL is part of a larger refactoring/clean-up of policy_test_cases.json. Some test cases incorrectly defined the test as a single object instead of a list of objects, which caused them to be skipped entirely. Bug: 1151251 Change-Id: I10c2354dc0f4545b072af2f6b75f6871a36cf402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552581 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Johannes Kron authored
The initial implementation of the low-latency renderer assumed that the display rate was fixed at 60Hz. This CL adds support for generic frame rates as well as missed render intervals. The low-latency renderer algorithm is enabled from WebRTC by setting the metadata field maximum_composition_delay_in_frames. This is an experimental feature that is active if and only if the RTP header extension playout-delay is set to min=0ms and max>0ms. The feature can be completely disabled by specifying the field trial WebRTC-LowLatencyRenderer/enabled:false/ Bug: 1138888 Change-Id: Ic64b26331d31aaf8fb8ed4fb8f1056b227cb6eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527424Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#830225}
-
Sinan Sahin authored
If a navigation occurs while the context menu is showing, the RenderFrameHost becomes invalidated and causes a seg-fault if the user tries to share the image. This CL dismisses the menu on navigation to prevent this. Bug: 1150622 Change-Id: I3aba40a2fae69715454ed753b4af623aca02006d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553191Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830224}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 454e5714. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I461419487c26a60bbbe172ca415262e4458b1769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554783Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830223}
-
Amr Aboelkher authored
Enable PSM protocol by default during the initial enrollment. BUG=chromium:1130590 Change-Id: Iab0adabc30e5e47eb8bde814751f135627161f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552382Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Bo Liu authored
//media/gpu is depending directly on ipc_common_sources which ends up compiling a separate copy of ipc_common_sources into media_gpu in component builds. Fix this by depending on the group instead. This fixes any crashes related to CheckFeatureIdentity failing on AImageReader in component build. Fixed: 1144945 Change-Id: Ice2758de77f704103e792242449b985b3937e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553969 Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#830221}
-
Connie Wan authored
This reverts commit 27401214. Reason for revert: Suspected cause for test failures: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/10771 Original change's description: > Fixes erroneous focus placement on Mac > > When using VoiceOver, focus is often erroneously placed in Chrome's toolbar instead of the web contents > as soon as the user navigates to a new page and after the page has loaded. > If the page includes logic that moves the focus to a specific item as soon as it loads, > that logic often has no effect on the location of the VoiceOver cursor. > For example, after visiting a user's Gmail inbox, VoiceOver often > neglects to automatically move to the list of emails, even though the page has logic to do that after load. > > The same problem often occurs when an iframe is inserted in the page and focus programmatically moves > to somewhere inside it. > For example if the user presses "h" and then "c" to focus the list of chat conversations in Gmail > and then selects and opens one of the conversations, the VoiceOver cursor might not move to the edit field in that conversation. > > This patch: > 1. Removes the logic that prevents the firing of a focus event if the page has not loaded, or has no content. > A) The page is marked as loaded as soon as the HTML is parsed, i.e. extremely quickly, so in 99% of cases this condition has no effect. > B) Even if the page is empty, user confusion does not occur, because everything happens too fast. > I tested with Jaws and NVDA, which were the AT for which this second condition was added in the first place. > C) This logic of preventing some focus events has caused bugs in the past, so I think simplifying it should > improve the health of our codebase, given that it doesn't cause any regressions. > 2. Adds accessibilityFocusedUIElement to BrowserAccessibilityCocoa. > It was implemented in Views, but was missing from Web. > > I suspect that the reason that this patch seems to fix the bug is because > VoiceOver monitors the load progress on the web contents, and expects a focus event to arrive as soon as the page has loaded. > > AX-Relnotes: VoiceOver focus should be in sync with browser focus, if the user has chosen this setting. > > R=dmazzoni@chromium.org, abigailbklein@chromium.org > > Change-Id: I9ae7b69fc3c7872bbbb39ffdd13562c97b8d1174 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551814 > Auto-Submit: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Abigail Klein <abigailbklein@google.com> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830186} TBR=nektar@chromium.org,abigailbklein@google.com Change-Id: I21b95965a0bfd0c3186b1e8f14e38612ee7583cb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554903Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#830220}
-
arthursonzogni authored
This was a TODO(https://crbug.com/1136678). The associated bug has been fixed. TBR=mkwst@chromium.org Fixed: 1151647 Bug: 1136678,1151647 Change-Id: I74e73d83be87a063b7a5266f64d6a5abba7e1dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552411 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830219}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/546a7c98c897..3cd31e647c7d 2020-11-23 cwallez@chromium.org Metal: Prevent data race on mLastSubmittedCommands If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1142024 Tbr: enga@google.com Change-Id: I86c44dd04c34e82a470bacd8ae216a0c40382930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554958Reviewed-by:
-
Andy Paicu authored
DD: go/permissions-suggestions-client-doc Since the URL has changed again and it's still not set in stone we should proactively set it up in such a way where we can control it without needing to update the code. This CL adds a new feature with a feature param that will be used as an override for the default URL, that way we can temporarily write a finch config to set the URL for M88 clients if it changes again. Bug: 1138595 Change-Id: I61e92577f95e87cf6fd79a225e18d69b34becc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545626 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Illia Klimov <elklm@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#830217}
-
Francois Doray authored
Affected tests: MemoryTracingBrowserTest.TestMemoryInfra MemoryTracingBrowserTest.TestBackgroundMemoryInfra TBR=thakis@chromium.org,ssid@chromium.org Bug: 806988, 808152 Change-Id: Ibaea22b3bd99596763d062a6853a99494c1af6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553111Reviewed-by:
-
Mark Cogan authored
Because BVC's -keyCommands method is a UIResponder API, it can be called in response to many events outside of Chrome's direct control; UIKit calls it (for example) after a child view controller is removed from the BVC. This can happen while the BVC is shutting down. KeyCommands needs to access BVC's |self.browser| method to fetch a browser agent. If the BVC has shut down, |self.browser| is nullptr. This CL changes -shouldRegisterKeyboardCommands to return NO when the BVC is shutting down, or when |self.browser| is null. Bug: 1151894 Change-Id: Iba8f5e7fa4bf2a2b6a85815ad030935c86c1bfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553427Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830215}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6ca1b95..7950639f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a64e89e5eb44f5551fa3d3d7020d3e1af621274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554898Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830214}
-
Liviu Tinta authored
Check pointerId, pointerType are the same as for the pointer event stream that generated the click/auxclick event. Bug: 1150441 Change-Id: Ic3c7bc05efad1b4024edbe3fc83cdbd812111c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549464 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830213}
-
Morten Stenshorne authored
The test assumed that block fragmentation takes place after relative positioning, but it's the other way around: https://www.w3.org/TR/css-break-3/#transforms Bug: 829028 Change-Id: I297bf572354216188b5a8c8d007f7a137c36e773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554543Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830212}
-
