GitLab

> Blink roll 157169:157224
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157170:157224&mode=html
> TBR=
> BUG=
> 
> Review URL: https://chromiumcodereview.appspot.com/23960002

Blink commit r157177 broke builds for ChromeOS, because of a missing include:
third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope

See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/23458024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221389 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221388 0039d316-1c4b-4281-b951-d872f2087c98

> Blink roll 157224:157244
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157225:157244&mode=html
> TBR=
> BUG=
> 
> Review URL: https://chromiumcodereview.appspot.com/23681008

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/23530037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221387 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221386 0039d316-1c4b-4281-b951-d872f2087c98

> Blink roll 157250:157284
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157251:157284&mode=html
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/23536027

Blink commit r157177 broke builds for ChromeOS, because of a missing include:
third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope

See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio

TBR=eustas@chromium.org

Review URL: https://codereview.chromium.org/23749005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221385 0039d316-1c4b-4281-b951-d872f2087c98

- Re-post callbacks only if they are called synchronously
- Always return a valid operation ID (even if it's finished immediately)
- Fix cancel callbacks ordering

BUG=279288
TEST=existing tests
TBR=hidehiko@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/23898002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165

Review URL: https://chromiumcodereview.appspot.com/23618029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221383 0039d316-1c4b-4281-b951-d872f2087c98

Enable the exit observer for NOTIFICATION_APP_TERMINATING.

Review URL: https://chromiumcodereview.appspot.com/23483014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221382 0039d316-1c4b-4281-b951-d872f2087c98

[SystemInfo API] Implement DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform method for Linux GTK.

Also rename display_info_provider_x11 to display_info_provider_linux for
better understand.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22891026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221381 0039d316-1c4b-4281-b951-d872f2087c98

Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used.

By this CL, each platform will have the below status:

Linux:    Use both CLD1 and CLD2 (and use Finch).
Mac OS X: Use both CLD1 and CLD2 (and use Finch).
Windows:  Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap.
iOS:      Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.)
Android:  Still use only CLD1. (The same reason as iOS)

So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.)

BUG=240647

Review URL: https://chromiumcodereview.appspot.com/22867032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221380 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221378 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157251:157284&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/23536027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221377 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221375 0039d316-1c4b-4281-b951-d872f2087c98

> Blink roll 157244:157250
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157245:157250&mode=html
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/23499009
Blink commit r157177 broke builds for ChromeOS, because of a missing include:
third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope

See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio

TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/23956005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221374 0039d316-1c4b-4281-b951-d872f2087c98

Replace directly use of DriveIntegrationService to drive::util::Get{DriveService,FileSystem}ByProfile.

As preparation to start returning DriveIntegrationService instance always by
DriveIntegrationServiceFactory::GetForProfile, this reduces its direct
usage.

BUG=284972
TEST=Ran unit_tests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/23531027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221367 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to disable extension garbage collection for the kiosk mode screensaver extension.

See associated bug for details.

R=asargent@chromium.org
BUG=280363
TEST=Screensaver plays through and loops in retail kiosk mode.

Review URL: https://chromiumcodereview.appspot.com/23629027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221366 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was waiting for the full Drive tree to load,
which takes unnecessarily long time.

BUG=283901
R=hidehiko@chromium.org

Review URL: https://codereview.chromium.org/23861006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221365 0039d316-1c4b-4281-b951-d872f2087c98

The bug we were working around has been fixed, so we can safely revert this workaround.

BUG=285051

> Worked around bug with gtest filters on Linux.
> 
> We have temporarily disabled all WebRTC content_browsertests on Linux. This causes our custom build steps to hang because they no longer select any test cases on Linux, triggering bug 285051. This works around that bug so we don't have to disable the step and restart all our masters.
> 
> BUG=285051
> TBR=tommi@chromium.org
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/23513014

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/23601014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221364 0039d316-1c4b-4281-b951-d872f2087c98

- Remove unused ContinueGetFileListRequest.
- Remove unused Parse functions from drive_api_service.
- Rename remaining "Parse" functions in drive_api_service to "Convert"
  functions to adapt its behavior more.

BUG=277253, 275233
TEST=Ran unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23477038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221363 0039d316-1c4b-4281-b951-d872f2087c98

When the framework tried to uninstall Chrome, it would prompt the user with a dialog box saying that "Are you sure you want to uninstall Google Chrome? [ ] Also delete your browsing data?". This required a user action. Make it uninstall Chrome silently by using the --force-uninstall option.

NOTRY=True 
BUG=264859
1) Uninstall Chrome (if it's installed.) 
2) Build Chrome with Release mode and make sure that mini_installer.exe is created. 
3) Go to src\chrome\test\mini_installer 
4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass without requiring you to click anything.

Review URL: https://chromiumcodereview.appspot.com/23950004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221362 0039d316-1c4b-4281-b951-d872f2087c98

The framework ran commands from the current working directory. Make it run commands from the framework's directory.

NOTRY=True 
BUG=264859
1) Uninstall Chrome (if it's installed.)
2) Build Chrome with Release mode and make sure that mini_installer.exe is created.
3) Go to src\chrome\test\mini_installer
4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass.
5) Go to src\chrome\test
6) Run "python mini_installer\test_installer.py mini_installer\config\config.config --build-dir=<build-dir> --target=Release". The test should pass.

Review URL: https://chromiumcodereview.appspot.com/23557009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131612

Review URL: https://chromiumcodereview.appspot.com/23523019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221360 0039d316-1c4b-4281-b951-d872f2087c98

The --fake-cloud-policy-type flag has also been enabled for iOS, for testing
purposes.

BUG=285084

Review URL: https://chromiumcodereview.appspot.com/23475018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221359 0039d316-1c4b-4281-b951-d872f2087c98

 - remove the suppressions that won't be needed after https://codereview.chromium.org/23602005/ is landed
 - add a suppression for race in base::HistogramSamples::IncreaseSum
Suppress a race in media::TestInputCallback::OnData (issue 239359)

BUG=46840,239359
TBR=jar@chromium.org,timurrrr@chromium.org

Review URL: https://codereview.chromium.org/23477019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221357 0039d316-1c4b-4281-b951-d872f2087c98

This is preparation to start returning DriveIntegrationService always from
DriveIntegrationServiceFactory::{Get,Find}ForProfile.

BUG=284972
TEST=Ran unit_tests
R=kinaba@chromium.org, satorux@chromium.org

Review URL: https://codereview.chromium.org/23523022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221356 0039d316-1c4b-4281-b951-d872f2087c98

The user deserves a chance to override. Now that we've made the UI subtle,
it's not like users are going to hit the button by accident.

BUG=285376
R=thestig@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/23971005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221355 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=danakj@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23944006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221354 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to move them in crrev.com/221334.

BUG=273386
TEST=none
R=hidehiko@chromium.org

Review URL: https://codereview.chromium.org/23723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221353 0039d316-1c4b-4281-b951-d872f2087c98

Changing the histogram names since the definition of the histogram changed in
https://codereview.chromium.org/23720005

BUG=246492
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23511012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221352 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 2a0ff283.

Reason: BuildBot Vista fails TokenServiceUpdateClearsCache test.

BUG=
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/23767004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221350 0039d316-1c4b-4281-b951-d872f2087c98

This is copied from chrome/browser/chromeos/extensions/file_manager.

Along the way, remove zork from chrome/browser/chromeos/drive/OWNERS,
as he's no longer working on this code.

BUG=none
TEST=none
R=hidehiko@chromium.org, kinaba@chromium.org

Review URL: https://codereview.chromium.org/23719011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221344 0039d316-1c4b-4281-b951-d872f2087c98

The old behavior was to delete all the shortcuts, which is rather user-hostile. With this change, the user-created shortcuts will be made to target the new system-level Chrome, to form a better transition experience.

- To determine whether or not a shortcut (to the user-level chrome.exe) is user-created, the heuristic we use is to test that the arguments of the shortcut are empty.
- The default shortcut to user-level chrome.exe is NOT retargeted, so it would get deleted (thus avoiding duplicate shortcut to the system-level Chrome).

Right now the "Chrome Apps" is not handled. This is a similar issue as http://crbug.com/238895 , and should be handled in a different CL.

BUG=235857

Review URL: https://chromiumcodereview.appspot.com/22382007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82582,170921
TEST=no functional change
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23947003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221342 0039d316-1c4b-4281-b951-d872f2087c98

During the fullscreen transition, on some sites Flash destroys and recreates its
context, which causes the RenderWidgetFullscreenPepper to switch back and forth
between composited and non-composited modes, recreating its compositor. That
causes it to send 2 successive frames with resources that have the same id (1)
but from different compositors (and different mailboxes).
Make sure we disambiguate those by recreating the DelegatedRendererLayer.

BUG=284821

Review URL: https://chromiumcodereview.appspot.com/23513012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221341 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221339 0039d316-1c4b-4281-b951-d872f2087c98

Problem scenario happened because destroying a tab was triggering
updating another tab. When the other tab updated various BrowserWindow
methods were called when BrowserView was in a bad state (part way
through destruction).

In theory if detaching tried to update state we would end up in the
same situation as this fixes, but that seems less likely.

BUG=236389
TEST=covered by test now
R=avi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23800003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221337 0039d316-1c4b-4281-b951-d872f2087c98

Previously, open_util.cc and file_tasks.cc had two separate
implementations of file task selection logic. The one in open_util.cc
was unclean had an issue with the download shelf (issue 279771).
Not to mention, having two separate implementations for doing the
same thing is not good for code health.

This patch replaces the unclean logic in open_util.cc with the one
in file_tasks.cc (FindAllTypesOfTasks()).

BUG=279771,278037,284194
TEST=See steps described in issue 279771
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23857004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221336 0039d316-1c4b-4281-b951-d872f2087c98

SpecialStoragePolicy is not required, so no need to log about it.

NOTRY=true
BUG=285570

Review URL: https://chromiumcodereview.appspot.com/23579008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221335 0039d316-1c4b-4281-b951-d872f2087c98

To separate binding code and non-binding code:

- chrome/browser/chromeos/extensions/file_manager: JS API bindings
- chrome/browser/chromeos/file_manager: The gut

Note that volume_manager* files are excluded as these are
now actively being changed.

BUG=273386
TEST=none
R=hidehiko@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/23945002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=./tools/perf/run_measurement --browser=release page_cycler tools/perf/page_sets/tough_layout_cases.json --page-filter=amar --pageset-repeat=2 --profiler=vtune

Review URL: https://chromiumcodereview.appspot.com/23536025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221333 0039d316-1c4b-4281-b951-d872f2087c98