- 02 Aug, 2017 40 commits
-
-
yucliu authored
Use base::UnguessableToken for random origin id. MediaDrmStorage will persist the origin id in the origin map. BUG=493521 TEST=shaka player demo Change-Id: I01690c9f1985c5346306b1b19e60fb5d434a867e Reviewed-on: https://chromium-review.googlesource.com/582212 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491474}
-
erikchen authored
This CL hooks up the plumbing from chrome://memory-internals, so that pressing "dump" causes a message to be sent to the profiling process, with the pid of the process to dump, and a file ScopedHandle ready for writing. For now, the file is always at {USER_DATA_DIR}/memlog_dump, and any existing file is overwitten. Bug: 751302 Change-Id: I1c120aef5c19b67b652aadf2e90c198d577beb7a Reviewed-on: https://chromium-review.googlesource.com/595113Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
-
Robert Ma authored
Bug: 740175 Change-Id: Id391cbd1e60b34a5ef4cc4ac988f04d3a343e224 Reviewed-on: https://chromium-review.googlesource.com/587270 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491472}
-
Vladislav Kaznacheev authored
The 2x icon had incorrect values in the PATH_COLOR_ARGB command. Copied the correct values (30% opacity white) from the 1x version. TBR=oshima@chromium.org Bug: 751725 Change-Id: I582d393c22201678c16c9ba9a819850e5add01de Reviewed-on: https://chromium-review.googlesource.com/598807Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#491471}
-
Kevin Marshall authored
This adds code to query the process' debug symbol maps for offsets and produces an externally symbolizable backtrace using that data. R: thakis@chromium.org,wez@chromium.org CC: jamesr@chromium.org Bug: 706592 Change-Id: I7b3257ff154671b2eb1c90f7ab91947f55cfa873 Reviewed-on: https://chromium-review.googlesource.com/575290 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491470}
-
Fady Samuel authored
In order to clarify this requirement, this CL switches the callback to use base::OnceCallback. Bug: 722935 Change-Id: I9fb96cfa794e0aa3d5765e533c5a0f9ac34d995f Reviewed-on: https://chromium-review.googlesource.com/598543Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491469}
-
Vladislav Kaznacheev authored
The previous implementation only used the device scale to convert from DIP to the screenshot bitmap coordinate space, which did not take into account the scaling applied when the user presses Ctrl+Shift+Plus or Minus. The new implementation deduces the correct scale from the window's transform. Added unit tests for gesture recognition, with regular, rotated and scaled displays. Bounding boxes are now computed and kept as gfx::RectF and rounded to gfx::Rect just once at the last possible moment. This ensures predictable rounding and makes it possible to write readable that do not have to work around quirky implementation details. Bug: 750816 Change-Id: I0ef3fb258917c72220c31b8c0cf37ddb43037958 Reviewed-on: https://chromium-review.googlesource.com/595069 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491468}
-
Ben Goodger authored
R=rockot@chromium.org Change-Id: I151aa6ce13d9c3e60c96864b416af52dea2deb81 Reviewed-on: https://chromium-review.googlesource.com/587034Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ben Goodger <ben@chromium.org> Cr-Commit-Position: refs/heads/master@{#491467}
-
Brian White authored
All of the corrupted histograms are from subprocesses so adding checks where subprocess histograms are merged into the browser (called by SubprocessMetricsProvider::MergeHistogramDeltasFromAllocator). Bug: 744734 Change-Id: Ie6593f2d2ad5fa2e957307b153248bc882174458 Reviewed-on: https://chromium-review.googlesource.com/598189Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#491466}
-
Devdeep Ray authored
Change kMaxNumDelayableRequestsPerClient to kDefaultMaxNumDelayableRequestsPerClient to be consistent with the naming in cc. Bug: 746640 Change-Id: I5d85e93099e92c437c61e87038a81d6296d327bd Reviewed-on: https://chromium-review.googlesource.com/598493Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Devdeep Ray <devdeepray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491465}
-
sebsg authored
This handles the types for which autofill won't offer validation, e.g. Names. Bug: 748223 Change-Id: I7bbee81d8eebfd843d962cf5eaa446e0f0b6e334 Reviewed-on: https://chromium-review.googlesource.com/598456Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491464}
-
Brian White authored
The passed counts used to be a separate field inside the parent class and so could theoretically diverge from the bucket-count. Now, however, the passed counts _is_ the bucket-count so only a coding mistake can cause the CHECK to fire and thus should be DCHECK. Change-Id: I754e67f9c9684197fced94695a6ffa9d88552e1a Reviewed-on: https://chromium-review.googlesource.com/596272Reviewed-by:
-
Takeshi Yoshino authored
Based on tkent@'s comment at https://chromium-review.googlesource.com/c/593515#message-691de0a91dadbd213f5e762b32917f796c3e4aae BLINK_IMPLEMENTATION is a macro for controlling symbol for component build. See https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md Most of BLINK_IMPLEMENTATION occurrences should be replaced with INSIDE_BLINK As a bonus: - Let BUILD.gn in Source/platform/heap/ and Source/platform/loader/ use the GN config rule Source/platform:blink_platform_implementation as recommended by https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md Bug: Change-Id: I8e1b53b9dbb7e524282ceffcd82db1abf5e53a70 Reviewed-on: https://chromium-review.googlesource.com/597035 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491462}
-
mark a. foltz authored
There are no plans (or time) to re-enable the chrome.cast.streaming API tests on debug builds. TBR=miu Bug: 396413 Change-Id: If1ad1ca9a0a75dc2c72273872e4bd60198e79378 Reviewed-on: https://chromium-review.googlesource.com/598647Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491461}
-
Yves Arrouye authored
Allows control of whether the Cast Receiver is enabled or not, and what it is named. Policies allow the administrators to force these preferences. Bug: 749436 Test: browser_tests Change-Id: Ia4f200a7ae3269258b10f5545d812c90de30ca3c Reviewed-on: https://chromium-review.googlesource.com/590490 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#491460}
-
Steven Bennetts authored
This CL is in preparation for converting the bluetooth pairing dialog (BluetoothPairingUI) to use the MD Settings UI. This CL: * Eliminate Settings dependencies from the bluetooth dialog element and moves some dialog related error parsing into the dialog element. * Moves some 'options' strings to settings_strings.grd in anticipation of removal of all options strings. * Adds a new shared location for higher level shared chromeos elements: ui/webui/resources/chromeos. These elements are allowed to use I18nBehavior to simplify localization. * Moves the bluetooth dialog element to the new shared location. Bug: 748193 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I861730aa9cbbe5cb37a8df3d26f62d9f20429672 Reviewed-on: https://chromium-review.googlesource.com/592461 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491459}
-
Yuke Liao authored
testTopSitesTileAfterRedirect fails on "Plus" devices, and this CL disables it on iOS to unblock running the test case on iPhone 6 Plus, iOS 11. Bug: 751224 Change-Id: Iebfac0c16c9f01a68169a19f439e04e828ba8de0 Reviewed-on: https://chromium-review.googlesource.com/598490Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491458}
-
Boris Yusupov authored
This to fix application menu Close Window for mac views like -- save info to restore closed window -- check onbeforeunload event Bug: 751018 Change-Id: I7a99def820f066fc1f47c3c2bae3a2abb49106ff Reviewed-on: https://chromium-review.googlesource.com/591848 Commit-Queue: Boris Yusupov <boriay@yandex-team.ru> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#491457}
-
Lucas Furukawa Gadani authored
The original CL was reverted because it caused some bots to become flaky. This was tracked on bug 747125 and should be fixed. This is a reland of 8a8b48bb Original change's description: > Enable field trial testing config for GuestViewCrossProcessFrames. > > Bug: 655753 > Change-Id: I756aada2893846878657fe33b405bdb70b23df54 > Reviewed-on: https://chromium-review.googlesource.com/576207 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487966} Bug: 655753 Change-Id: I59b128cf163be9cc565973f804811e5993ca01be TBR=asvitkine@chromium.org,wjmaclean@chromium.org Change-Id: I59b128cf163be9cc565973f804811e5993ca01be Reviewed-on: https://chromium-review.googlesource.com/591628Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491456}
-
Chris Harrelson authored
PaintLayerScrollableArea. Bug: 748955 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I838699c551ff56ad287e5f1759196c17cf8b698e Reviewed-on: https://chromium-review.googlesource.com/597016Reviewed-by:
Walter Korman <wkorman@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491455}
-
jdoerrie authored
This change adds a show password button directly in chrome://settings/passwords to reduce the number of clicks necessary to view a given password. Bug: 670986 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If54c92d2ee6c2e64f90a5280e59a4c59af182740 Reviewed-on: https://chromium-review.googlesource.com/575143 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#491454}
-
Ella Ge authored
Clean up PointerEventManager:: ProcessCaptureAndPositionOfPointerEvent to replace the last two parameters by a single WebMouseEvent pointer which defaults to null. Bug: 727333 Change-Id: I0af2277b0ecae48ade70d54fdaad4fac16ee23e3 Reviewed-on: https://chromium-review.googlesource.com/598113Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#491453}
-
James Cook authored
When an external display is attached a new RootWindowController and new shelf are created for that display. Shelf alignment is loaded from prefs. However, if the external display is marked as primary then the internal and external displays are swapped. This means that the (new) shelf now on the internal display never reloads its alignment from prefs. Since the screen was locked at attach time, the shelf stays in the bottom_locked state and never becomes visible. Fix this by reloaded shelf alignment from prefs on display swap. Bug: 748291 Test: added to ash_unittests Change-Id: I5780dd3ca3b796b6f46fea9bc46fe875d123701e Reviewed-on: https://chromium-review.googlesource.com/597410 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#491452}
-
Allen Bauer authored
Fix disabled stroke color processing to ensure the non-Harmony disabled color is properly lightened. Bug: 737271 Change-Id: Ie6bb767b8138472037ffb685091cab8c8986b662 Reviewed-on: https://chromium-review.googlesource.com/581630 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#491451}
-
Scott Graham authored
Fuchsia is initially trying to get a headless build up and running so idle detection is unnecessary. Bug: 743296 Change-Id: I497f42d533e853ce397eeae3ced19a490742c0ee Reviewed-on: https://chromium-review.googlesource.com/596505 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Scott Graham authored
Fuchsia is initially trying to get a headless build up and running so cursors are unnecessary. Bug: 743296 Change-Id: Ia2093400215a00f8dabfbd1365baa4b5f58a556b Reviewed-on: https://chromium-review.googlesource.com/596950 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Julien Brianceau authored
Bug: 750830 Change-Id: Ifb5ced5c4dd314b17c0bd1466a5d6bd740753da8 Reviewed-on: https://chromium-review.googlesource.com/598092Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491448}
-
dpapad authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icab535f6157bd313cb2fe95ad0a54dd11e6e2da9 Reviewed-on: https://chromium-review.googlesource.com/596682Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491447}
-
Victor Miura authored
avoid_stencil_buffers blocks MSAA support in Skia. If the compositor requests MSAA surfaces, rendering will fail. R=ericrk@chromium.org BUG=749438,713854 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I887888845a2c1ee18dbccff6e96aa6cd1eac3df2 Reviewed-on: https://chromium-review.googlesource.com/597321Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#491446}
-
Yuwei Huang authored
GlDisplayHandlerCore::Initialize is posted before the Core's construction is done, so the app may crash at some point due to race condition. It crashed once in my phone when calling renderer_proxy_->Initialize() while renderer_proxy_ is not ready. Change-Id: If711b56efce2de5f7e4d0a7a883f19b2181ee31e Reviewed-on: https://chromium-review.googlesource.com/597317Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#491445}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c85b29c..1dc40944 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I338b78ba745906e8ce6a15c9191d70aca73eb4e3 Reviewed-on: https://chromium-review.googlesource.com/598248Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491444}
-
Adrienne Walker authored
Also, consolidate all PaintOp validation into new IsValid functions. Reland of https://chromium-review.googlesource.com/c/590749/. TBR=vmpstr@chromium.org,khushal@chromium.org Bug: 749023, 750010 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifd784e327ddde877e376b5441d88fe4d35cf627a Reviewed-on: https://chromium-review.googlesource.com/596926Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491443}
-
Luna Lu authored
This reverts commit 6829a5b8. Reason for revert: Seems to cause failure in browser_tests SettingsAccessibilityTest.All. See http://crbug.com/749943 Original change's description: > Add accessibility tests for passwords section of Chrome Settings. > > Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI > by defining an accessibility_browsertest.js file for a11y test fixtures > and including this file in the BUILD.gn. > > The passwords section now fires an event when the settings section has > expanded--an event that is responded to in the added a11y test. > > The tests are disabled in debug mode and memory sanitizer mode due to > timeout. > > Bug: 737739 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8715e83778409802849db38d90fef387db203f9b > Reviewed-on: https://chromium-review.googlesource.com/592156 > Commit-Queue: Tina Quach <quacht@google.com> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491409} TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com Change-Id: I3c96c164e1872946897084a8713317e9d12c0aa5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737739, 749943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/598607 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491442}
-
Walter Korman authored
Bug: 709137 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5afe52f29511fbb9cd93b086602c48d28eb9f301 Reviewed-on: https://chromium-review.googlesource.com/592291 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491441}
-
Raphael Kubo da Costa authored
Sync our IDL file with https://github.com/w3c/gamepad/pull/62 ("Switch from WebIDL arrays to FrozenArray<>s in the IDLs"). WebIDL has not had array types since 2015, so finally make our IDL files compliant with modern WebIDL following the spec fix. It is important to note that this change modifies the existing behavior slightly. - |axes| and |buttons| are now frozen objects with all the related consequences for its properties and prototype. - Those two attributes now return the same _object_ until their values change instead of always returning a new object on access. Doing so aligns our code with both the spec as well as Gecko, which has done the above ever since it implemented the Gamepad spec. Bug: 740875 Change-Id: Ifb618c9d4f8860eb55efc882e701dae7390808a5 Reviewed-on: https://chromium-review.googlesource.com/595979Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#491440}
-
John Abd-El-Malek authored
BUG=598073 Change-Id: I575dec98b3b0145a7fd953de5821f10524a4b8e6 Reviewed-on: https://chromium-review.googlesource.com/588086 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch replaces a call site of the deprecated function by the proper version (which requires clean layout), which is safe because the layout is: - Either updated by the call site (ExternalRepresentation) - Or intentionally kept dirty due to kLayoutAsTextDontUpdateLayout flag Bug: 698633 Change-Id: I09c3be97ac43e5327cb1175999c83454a15c40f1 Reviewed-on: https://chromium-review.googlesource.com/596709Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491438}
-
Scott Graham authored
The Fuchsia build is initially trying to get a headless build up and running, so ui/gfx/font is unnecessary currently, other than to link. Bug: 750946 Change-Id: I39607a4dd78d73049d1c33c53e907fdfb7f3cf9c Reviewed-on: https://chromium-review.googlesource.com/596838 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Scott Graham authored
Fuchsia is initially trying to get a headless build up and running so a full Screen implementation is unnecessary, other than to be able to link. Bug: 750946, 743296 Change-Id: Ib6333a304deacbd22d3f1b1f3af8fc9ca063bb15 Reviewed-on: https://chromium-review.googlesource.com/596949 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Robert Ma authored
Change-Id: Ibe8ccc0be09764fe4aca158dd9fec026bd7b4ce2 Reviewed-on: https://chromium-review.googlesource.com/592414Reviewed-by:
-
