GitLab

This change switches the Shape Detection Mojo interface JS bindings to
the new style and updates the LayoutTests accordingly. The Skia Mojo
interfaces are also switched to generating the new binding style while
the ui/gfx/geometry interfaces must still generated both as a
temporary step while some code has not yet been updated.

These tests demonstrate how the DCHECK in ~MojoWatcher is invalid and
so it is removed.

Bug: 699569
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Change-Id: Ic83ac9bd50072eae8461edc0b85cd4bcae147358
Reviewed-on: https://chromium-review.googlesource.com/560646
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485049}

This reverts commit b3c9a824.

Reason for revert:
Dependent CL https://chromium-review.googlesource.com/c/562917 is causing failures in services_unittests. I'm reverting both.

Original change's description:
> [GRC] Add Tab-level CPU Usage Attribution Tests
> 
> This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies.
> 
> A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. 
> 
> Bug: 691886
> Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f
> Reviewed-on: https://chromium-review.googlesource.com/562549
> Commit-Queue: Matthew Halpern <matthalp@google.com>
> Reviewed-by: Zhen Wang <zhenw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485024}

TBR=zhenw@chromium.org,oysteine@chromium.org,lpy@chromium.org,matthalp@google.com

Change-Id: Ic498713510edfe2ce741b37b101444f221d990e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 691886
Reviewed-on: https://chromium-review.googlesource.com/564096Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485048}

This CL teaches GN to generate the right PBXTarget in Xcode project for
XCUITest.

Bug: 709289
Change-Id: I6d0de9b660b69f558a8dcd6d394237d94131a4ba
Reviewed-on: https://chromium-review.googlesource.com/562530Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485047}

SurfaceManager should not know about frame sinks. FrameSinkManager owns a
SurfaceManager and delegate function calls to it. Any classes that are on or
above the frame sink layer should use FrameSinkManager instead.

RecursivelyAttach/DetachBeginFrameSource now take FrameSinkId by value
instead of const ref because some of the FrameSinkId are from
|frame_sink_source_map_|. |frame_sink_source_map_| is a base::flat_map
and it can allocate new memory, and move data between buffers making
the reference in the parameter invalid.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I291cdad7f2785c1a0662e3d07953ec40a24aa02f
Reviewed-on: https://chromium-review.googlesource.com/534114Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485046}

This script had an incorrect exception (RunTimError -> RuntimeError)
and also was erroring on an enum-to-string function check. Fix the
naming of the exception error and allow for the same enum with a
different suffix to pick the first one arbitrarily, since they should
have the same value.

This also regenerates the generated files which were not up-to-date.

BUG=740153
R=piman@chromium.org

Change-Id: I2f6b982064bbedc8b7f4c12092ca1be5ea18e4df
Reviewed-on: https://chromium-review.googlesource.com/563503Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485045}

BUG=738476

Change-Id: I3e2c7d179c4baa5c7862555b8111bc1e3d4cd8da
Reviewed-on: https://chromium-review.googlesource.com/558147Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alex Vallee <avallee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485044}

Currently media remoting communicates with extension by text strings
through Media Router mojo API. This CL adds mojo interfaces to allow
CastRemotingConnector in browser talk directly to MediaRemoter in
extension after connected through the Media Router mojo API. These
changes also enable passing the receiver's capablities to remoting
control logic in renderer, which will be done in a follow up CL.

BUG=734672

Review-Url: https://codereview.chromium.org/2951523002
Cr-Commit-Position: refs/heads/master@{#485043}

The message text in the Reader Mode infobar cannot fit into the
current space if the screen is small, font is large, or the string
in the locale is long. From now on, it would wrap into multiple
lines in that case.

The infobar would become taller if more than one line is needed.

BUG=560118

Review-Url: https://codereview.chromium.org/2955053003
Cr-Commit-Position: refs/heads/master@{#485042}

Gets rid of cases in which the application locale was being queried from
the global ApplicationContext instance.

BUG=602666

Review-Url: https://codereview.chromium.org/2971003002
Cr-Commit-Position: refs/heads/master@{#485041}

Enable composited border-radius scrolling as mask tiling is implemented.
We'll revert this CL if anything breaks.

Bug: 567293, 567296
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I70bea4c542e00d244a597d1a36857dd120fc96cd
Reviewed-on: https://chromium-review.googlesource.com/543397
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485040}

This patch adds the ability for HAR to show better results for h2 and
quic requests in the httpVersion field.

R=caseq
BUG=374557

Change-Id: I17a7f28be01882fb6685a0ba3ba96296a38462af
Reviewed-on: https://chromium-review.googlesource.com/557285
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485039}

I'm cleaning up two things here:

- Adding a check to PossiblyHasMarkers() (probably doesn't save us very much
  time, but we can at least avoid a hashmap lookup in the "no markers" case)
- Fixing the loop to just loop over the passed-in set of MarkerTypes vs. looping
  over all types and skipping over some of them

BUG=707867

Review-Url: https://codereview.chromium.org/2956453002
Cr-Commit-Position: refs/heads/master@{#485038}

We are implementing new UMA and UKM metric collection for local network requests by public and private pages.

This CL creates a new subclass of page_load_metrics::PageLoadMetricsObserver, LocalNetworkRequestsMetricsPageLoadObserver, to monitor pages for local network requests and report them to UMA and UKM. It also includes unit tests for the new metric collection classes.

Additionally, this CL adds the ability to specify the socket address for a navigation to content::NavigationSimulator, which is needed for LocalNetworkRequestsPageLoadMetricsObserver's unit tests, which require manipulation of the address of committed page loads to test the observer's functionality. (Note that this change is included in this CL because content/ policy requires that changes to the public API must have a caller outside content/.)

Concretely, this CL does the following:
(1) Creates the LocalNetworkRequestsPageLoadMetricsObserver class, which implements local network request UKM and UMA metric collection.
(2) Registers the LocalNetworkRequestsPageLoadMetricsObserver in PageLoadMetricsEmbedder to enable metric and histogram collection.
(3) Adds unit tests for LocalNetworkRequestsPageLoadMetricsObserver.
(4) Updates the Chrome browser and unit test BUILD files to build the LocalNetworkRequestsPageLoadMetricsObserver and its unit tests.
(5) Registers the new local network requests UMA histograms and UKM metrics in histograms.xml and ukm.xml, respectively.
(6) Adds the |SetSocketAddress| method to NavigationSimulator to support specification of the socket address of a navigation.

BUG=735085,728707

Change-Id: Ie176881a326ca7a856c1813bfc2d031c5ae4261b
Reviewed-on: https://chromium-review.googlesource.com/532254
Commit-Queue: U Thakore <uthakore@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485037}

These each set individual fields of HttpNetworkSession::Params, but
there's another method to set all of the Params, so they were
redundant.

These methods were all used only by Cronet, so they offered no
reduction in complexity, either.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2970423002
Cr-Commit-Position: refs/heads/master@{#485036}

reconnect. Also removes the "you are signed in" message each time you view the
host list.

Review-Url: https://codereview.chromium.org/2966243003
Cr-Commit-Position: refs/heads/master@{#485035}

BUG=732795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2974583002
Cr-Commit-Position: refs/heads/master@{#485034}

We've had flac support for a while now, so this should go through the
normal playback pipeline. To see if the rest are actually used anywhere
lets add a UMA to figure out if we really need this code.

BUG=739914
TEST=none

Change-Id: I18ddbc724b82d34a0174692b46a0a154e1d4cbf3
Reviewed-on: https://chromium-review.googlesource.com/562621Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485033}

BUG=731309
TEST=manual. Start chrome with --force-device-scale-factor=1.6 and make sure javascript dialog is crisp.

Review-Url: https://codereview.chromium.org/2934883003
Cr-Commit-Position: refs/heads/master@{#485032}

These archives contain the definition of _IsOSVersionAtLeast, which
we will need in order to use the @available function.

BUG=735328
R=thakis@chromium.org

Change-Id: Ifa3b419493da2361cbd7df4ba993c0d7fe9d5cbd
Reviewed-on: https://chromium-review.googlesource.com/563157Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485031}

Bug: 731763
Change-Id: Idbc8ffd20deb4d84b24d08787d63886778fc3fe8
Reviewed-on: https://chromium-review.googlesource.com/563552
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485030}

https://pdfium.googlesource.com/pdfium.git/+log/c3d3bb2a036b..f6f68c75ce54

$ git log c3d3bb2a0..f6f68c75c --date=short --no-merges --format='%ad %ae %s'
2017-07-07 rharrison Check that there is enough data remaining in source BMP before reading

Created with:
  roll-dep src/third_party/pdfium
BUG=738635


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ifbb658f4beac53166e569be5eb973c9d0308c042
Reviewed-on: https://chromium-review.googlesource.com/563819
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485029}

Instead of using the intent's URL to determine if the app launching Chrome
is Facebook, we use the referrer URL instead and ensure it's
android-app://m.facebook.com.

BUG=733086

Review-Url: https://codereview.chromium.org/2953103002
Cr-Commit-Position: refs/heads/master@{#485028}

BUG=internal/62571379
BUG=internal/63080799
TEST=On Device

Change-Id: Ied56d594db00bee5eb9c407c80d9befd8fbd7210
Review-Url: https://codereview.chromium.org/2958393002
Cr-Commit-Position: refs/heads/master@{#485027}

This patch adds some safety to when setting responseReceivedTime to
use the headersReceivedTime or startTime depending on which one is
later.

When exporting HAR we need these to be more accurate.

R=caseq
BUG=374557

Change-Id: I57b8a46ba525c506cbe9d4f9bd5ad09b4861ba65
Reviewed-on: https://chromium-review.googlesource.com/556240
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485026}

Strings from USB devices are in UTF-16 so this avoids conversions that
were added to the type converters in a time when UTF-16 strings were not
supported by Mojo.

Change-Id: Ia57c0f315529370d95cd288bb4f8f7fd7af8e78e
Reviewed-on: https://chromium-review.googlesource.com/530036
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485025}

This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies.

A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. 

Bug: 691886
Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f
Reviewed-on: https://chromium-review.googlesource.com/562549
Commit-Queue: Matthew Halpern <matthalp@google.com>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485024}

This CL removes extensions::util::HasIsolatedStorage, which is unused. The last
usage seems to have been removed in r277972.

BUG=None

Change-Id: I6905ca9f09c1f9047c1978a73af139196a0c4a45
Reviewed-on: https://chromium-review.googlesource.com/562675Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485023}

Also added check to prevent pie chart from constantly redrawing
every second on doUpdate().

Bug: 738800
Change-Id: I5f04680011d33a431d86ab4d99907a34cc3a06a3
Reviewed-on: https://chromium-review.googlesource.com/560541
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485022}

TBR=sky
R=mmoss, agable

Bug: 739994
Change-Id: I40683efcf3608077db17c27dabf3c507e6254e7c
Reviewed-on: https://chromium-review.googlesource.com/563465
Commit-Queue: Di Mu <dimu@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485021}

Bug: 144943
Change-Id: I853906bbc9be8774e154e6454cf4166ae08daa3b
Reviewed-on: https://chromium-review.googlesource.com/562321Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485020}

In order to make the decision for when to trigger the OOBE display
chooser less confusing for end users I'm removing the keyboard check.
Instead an explicit remora requisition check is used to limit the
effects.

BUG=738885

Review-Url: https://codereview.chromium.org/2964823002
Cr-Commit-Position: refs/heads/master@{#485019}

Plumbs video frame duration from media video rendering up to
WebMediaPlayerImpl. WebMediaPlayerImpl will later use the stat to
start/stop reporting of MediaCapabilities plabyack stats.

Bug: 695264
Change-Id: I44c44498d2a68406b9e7259a81866b25db1ae430
Reviewed-on: https://chromium-review.googlesource.com/558016Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485018}

https://skia.googlesource.com/skia.git/+log/aa6c777f7d7c..ec045b431211

$ git log aa6c777f7..ec045b431 --date=short --no-merges --format='%ad %ae %s'
2017-07-07 bsalomon Add SK_API to GrBackendTexture and GrBackendRenderTarget
2017-07-07 brianosman Tweak GLPrograms random seed to "fix" ANGLE bots

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: I3eb4fc7e7d924a11d2c270581b47115796a44953
Reviewed-on: https://chromium-review.googlesource.com/563506Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485017}

Updates the list of keywords to cover the latest version of GN.

Change-Id: I32bad59603515e88db1687c12b7696db6ef4ebce
Reviewed-on: https://chromium-review.googlesource.com/549234
Commit-Queue: Kevin Peng <kevpeng@google.com>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485016}

Bug: 736978
Change-Id: If94b8dfcdf244fa53002694bd41e97c9c6269049
Reviewed-on: https://chromium-review.googlesource.com/560519Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485015}

Some previews can cause problems for offlining. We should disable
those previews.  This approach uses a NavigationDelegate and a
WebContentsDelegate to allow the background offliner to disable
previews that could cause problems for offlining.

Bug: 703875
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I519fae1b6f98da99c89ff97cb4b201c60a92b176
Reviewed-on: https://chromium-review.googlesource.com/544586
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485014}

The CL crrev.com/2969573002 moved the constructor and destructor for
SystemLogsSource to a different file - except it failed to delete the
old ones, leading to duplicate symbol warnings. I'm surprised that the
warnings weren't errors but hey, that's ODR for you.

Warnings were:
system_logs_fetcher.obj : warning LNK4006: "...
system_logs::SystemLogsSource::SystemLogsSource(...)" ...
already defined in system_logs_source.obj; second definition ignored
system_logs_fetcher.obj : warning LNK4006: "...
system_logs::SystemLogsSource::~SystemLogsSource(void)" ...
already defined in system_logs_source.obj; second definition ignored

Bug: 710168
Change-Id: Ifc336149cd7f0f4e58b5bd0183b34d86164dc325
Reviewed-on: https://chromium-review.googlesource.com/563762Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485013}

Bug: 739409
TBR: mcasas@chromium.org
Change-Id: I46c9073ca62badef7b22c78f8060c6570d008438
Reviewed-on: https://chromium-review.googlesource.com/563760Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485012}

Remove the top level directory DEPS file, and move cc/ gpu/ and mojo/
deps into each subdir with C++ files including only the parts that
are used and make sense.

- Remove cc/blink and cc/test from viz/client.
- Allow GLES2, CommandBuffer client (and common) from viz/common.
  This is for GLHelper which is going to move/split up but is there
  for now.
- Allow GLInProcessContext in viz/common tests.
- Allow CommamdBuffer and Gpu-IPC client (and common) in viz/host.
- Allow Gpu-IPC host in viz/host.
- Allow InProcessCommandBuffer in viz/service/display_embedder.
- Allow Gpu-IPC common in viz/service/frame_sinks.

R=piman@chromium.org

Bug: 722935
Change-Id: Ia3aafa9af4ac919c7c3a8ed7e1a0ec53b51bb3aa
Reviewed-on: https://chromium-review.googlesource.com/563522Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485011}

Mailbox resource sync token semantics were recently changed so that an
empty sync token means no synchronization needed. VideoResourceUpdater
creates resources with empty sync tokens and sync tokens are
generated by VideoLayerImpl. That code checks the needs_sync_token state
and does not generate sync tokens.

This CL makes explicitly sets sync tokens for such mailbox resources. It
also includes some cleanup of redundant needs_sync_token state.

R=piman
BUG=738928

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5ca66ab689fdee2b1b78eaf2e77bfd2ef1cebe53
Reviewed-on: https://chromium-review.googlesource.com/560736Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485010}