- 30 Jan, 2018 40 commits
-
-
Nico Weber authored
Fixes a missing break that was accidentally deleted in https://codereview.chromium.org/2701003002/diff/140001/components/sync/syncable/model_type.cc which caused each SUPERVISED_USER_SHARED_SETTINGS to also receive an ARTICLES default value. This CL was uploaded by git cl split. R=zea@chromium.org Bug: 177475,806921 Change-Id: Iaa5b42a8d2ac5787b787b6163adb2f3f7407e6c8 Reviewed-on: https://chromium-review.googlesource.com/891746 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#533017}
-
Liquan (Max) Gu authored
The original test is flaky in both virtual test and nonvirtual test. For the non-virtual test, it was expected to fail for one reason but it's reasonable to fail for other reasons as well. We should include those failures. For the virtual test, the test failed since long tasks could be present in a slow environment. We fix it by ignoring those longtasks & attributions that are not generated by us. Also, we allow waiting for multiple entry lists until we find the interesting one. Bug: 775626 Change-Id: Ief2a3bc4016dc3f808cb17be0122e35f75b58f9a Reviewed-on: https://chromium-review.googlesource.com/891571 Commit-Queue: Liquan Gu <maxlg@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#533016}
-
Alexander Timin authored
Set input task queue to always be high priority when field trial is enabled. Add testing trial config for this experiment. R=rkaplow@chromium.org,dtapuska@chromium.org BUG=806271 Change-Id: If299590b2e3d023af493975c98c71853d04604c0 Reviewed-on: https://chromium-review.googlesource.com/890523Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533015}
-
Nico Weber authored
For Range objects where min or max value can't be queried (due to the node being detached), we currently fall through to the splitter code which then returns a value of 50 for the range. This Cl makes it explicit that this behavior is intended. This CL was uploaded by git cl split. R=dmazzoni@chromium.org Bug: 177475 Change-Id: Ife0beab1bc377ca17998601934f4dd38c2349159 Reviewed-on: https://chromium-review.googlesource.com/890074Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533014}
-
Bret Sepulveda authored
TBR=mlamouri@chromium.org Bug: 807356 Change-Id: I3b0c2389090b44128b1ccfd283973737ce856cc4 Reviewed-on: https://chromium-review.googlesource.com/894122Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533013}
-
Chris Harrelson authored
Only PaintChunks need ref-counted PropertyTreeState objects, because they are the only ones that store the objects in a persistent manner. Further the performance overhead of RefPtr for other use-cases is too big to justify. Bug:798378 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iac4d4e1bcf0e377033ab9c129f290e0745830343 Reviewed-on: https://chromium-review.googlesource.com/892561Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533012}
-
Nick Harper authored
net::CookieStore::ChangeCause and net::CookieMonster::DeletionCause contained extra values that were added for debugging crbug.com/548423 and are no longer used, thus they are being removed. Bug: 736978 Change-Id: I7b16526f0029222d166e09726954e0695123c4bd Reviewed-on: https://chromium-review.googlesource.com/877515Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#533011}
-
Yaron Friedman authored
If you have too many open, we'd crash from exhausing all JNI references. Shouldn't be an issue in practice but saw it from 726426 BUG=726426 Change-Id: I30ac884275154068a0232b62dae7b22e00d9e5e3 Reviewed-on: https://chromium-review.googlesource.com/893532Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533010}
-
Dmitry Gozman authored
Change-Id: Ifb7fa05f95509b4f573dbb1a045d64ee0d9e40d8 Reviewed-on: https://chromium-review.googlesource.com/893707Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533009}
-
https://skia.googlesource.com/skia.git/+log/c4e31092b13e..4e95956f117f $ git log c4e31092b..4e95956f1 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 6969132c1..13fd988cf (1 commit) 2018-01-30 jvanverth Revert "Reduce the amount of padding needed for SDFs." 2018-01-30 reed handle paths with degenerate verbs Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I5f3af94fd36fb6d17fffbea3013e7744d7c636d9 Reviewed-on: https://chromium-review.googlesource.com/893883Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533008}
-
Artur Khachatryan authored
Test testGoBackAndGoForward fails on Waterfall for Chrome v65. Disabling test execution in Waterfall build. Bug: 803678 Change-Id: I0e084797f727dbd911cb16032fbb642040a1de3a Reviewed-on: https://chromium-review.googlesource.com/893420Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533007}
-
Gayane Petrosyan authored
Remove WebRTC-SystemUDPSendSocketSize which is long expired and not useful anymore. Also removing an unused include from ipc_socket_factory.cc which I missed in https://chromium-review.googlesource.com/c/chromium/src/+/854947 Bug: 799180 Change-Id: Iaa733fff48e7334ceafb3b212866c83822f369d1 Reviewed-on: https://chromium-review.googlesource.com/857884Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#533006}
-
Steven Bennetts authored
An unintended side effect of: https://chromium-review.googlesource.com/875002 is that NetworkingPrivateDelegate::HandleConnectFailed no longer behaves as expected. Instead we need to: * Set check_error_state = true when calling ConnectToNetwork in the networkingPrivate implementation. * Clear any error state when Shill properties are set to ensure that a connnection attempt after configuration does not fail when check_error_state is true. * Move configuration handling on error to the UI that calls startConnect. ALso: * Show the details dialog when connected networks are selected in OOBE. This should provide a more robust / consistent experience in both oobe and the Settings UI. Bug: 805357 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0030fe5f6f6d054213cec812297829996a73bcfd Reviewed-on: https://chromium-review.googlesource.com/884846 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#533005}
-
Mustaq Ahmed authored
The check is needed to avoid password prompt when a user clicks a link instead of submitting a filled form. The original condition was a weak signal to detect click-on-link, and fails with UserActivationV2 which changes the scope of a user activation. For records, only one test relied on the original activation check is PasswordManagerBrowserTestBase.NoPromptIfLinkClicked . Bug: 803193, 772432 Change-Id: I33545d9550f7bd125ff8eb739c998ee1f1a48c52 Reviewed-on: https://chromium-review.googlesource.com/884368 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#533004}
-
Fredrik Söderquist authored
Update the computation of the scale factor to match what the spec [1] has to say about a value of zero: i.e yield (near) infinity rather than zero. Also update the case where the computed path length is zero. [1] https://svgwg.org/svg2-draft/paths.html#PathLengthAttribute Bug: 803127 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6816b6bdd47cbaee90e8ad22e16d1dcf44498c7d Reviewed-on: https://chromium-review.googlesource.com/893184Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533003}
-
Sahel Sharify authored
https://chromium-review.googlesource.com/865558 fixes this flaky tests on win7_chromium_rel_ng, but it only waits for dispatching of the first wheel event before sending the others. This cl makes sure that each wheel event gets dispatched before sending the next one. I haven't been able to reproduce the bug on my local windows official build but I suspect that after using async wheel targeting for wheel events some of the wheel events in RunTest get coalesced to each other before getting dispatched. Bug: 800822 Change-Id: Id693ef3beff19daf08c3e11c2119b2bf90ef6737 Reviewed-on: https://chromium-review.googlesource.com/893803Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533002}
-
Fredrik Söderquist authored
The: template<typename T> bool IsSVG*Element(const T*) overload is a remnant after RawPtr<T>, but in its current form it would only produce infinite recursion. Also update some nearby documentation and rewrite the const Node& overload to use the same form of condition as the other ones. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iecbc75423010bf26383dfd7504831bf1768a722d Reviewed-on: https://chromium-review.googlesource.com/893270Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533001}
-
Bret Sepulveda authored
This reverts commit 91310914. Reason for revert: Multiple failures on Linux, for example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/39500 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/9251 Original change's description: > Port another set of sticky tests to JS rather than reftests > > Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3 > Reviewed-on: https://chromium-review.googlesource.com/882002 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532966} TBR=flackr@chromium.org,smcgruer@chromium.org Change-Id: I7a773131066157e0d4216d7fa7c228bd8bff2021 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/893536Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533000}
-
Theresa authored
BUG=805976 Change-Id: Icdaf76079b16f7664c5dde3b63f429ae5473532f Reviewed-on: https://chromium-review.googlesource.com/893647Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532999}
-
Friedrich Horschig authored
When under memory pressure, the activity is destroyed and the search result lost. By explicitly saving the query in the instance state bundle, the search results can be recovered even though the activity is recreated. Bug: 807306 Change-Id: Ice12994cdeefc7ee293114207b5faa93cebda5a5 Reviewed-on: https://chromium-review.googlesource.com/893187Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532998}
-
Steven Bennetts authored
Previously tpm_firmware_update_requested might be undefined. This makes the argument required and ensures that it is passed. Bug: 800103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia5263d011a58f5f444b64df2e7109083c70b3daf Reviewed-on: https://chromium-review.googlesource.com/887631 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#532997}
-
Yoland Yan authored
Bug: 807251 Change-Id: I49de4e1668fe851ced12fa335e54e5078b81434f Reviewed-on: https://chromium-review.googlesource.com/887792 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532996}
-
Victor Costan authored
This CL shrinks the Linux binary by 34KB (138,266,816 to 138,232,320). Code savings aside, this makes sure we don't unintentionally start depending on these features. The following compile-time options are recommended in the SQLite documentation [1]: * SQLITE_LIKE_DOESNT_MATCH_BLOBS - The LIKE and GLOB operators don't work on BLOB columns. This access pattern would be a performance wrench, so it's nice to fail hard here. * SQLITE_OMIT_DEPRECATED - This removes support for deprecated SQLite APIs. Note that SQLite promises to maintain indefinite backwards compatbility for SQL queries (modulo features disabled via compile-time options), so this only applies to the SQLite API. We should never be using deprecated APIs. * SQLITE_OMIT_PROGRESS_CALLBACK - Remove sqlite3_progress_handler(). We don't use this feature, and the documentation says it comes with a small performance penalty. * SQLITE_OMIT_SHARED_CACHE - Using a shared cache sounds nice from a memory consumption standpoint, and we already do that for LevelDB. Unfortunately, Chromium's SQLite databases use a variety of page sizes, which makes cache sharing impossible. * SQLITE_USE_ALLOCA - Use alloca() instead of malloc() for allocating temporary spaces in functions. All of Chrome's platforms support this option, and it results in a slightly smaller binary and less heap churn. The following compile-time options disable features that happen not to be used. * SQLITE_OMIT_AUTOINIT: We initialize SQLite manually in //sql/connection.cc. * SQLITE_OMIT_AUTORESET: We calls sqlite3_reset() correctly to reset prepared statements. * SQLITE_OMIT_GET_TABLE: We don't use sqlite3_{get,free}_table(). * SQLITE_OMIT_LOAD_EXTENSION: We don't use sqlite3_{enable_}load_extension(). Asides from the code savings, there's a tiny security benefit to knowing that extension loading code is definitely not reachable from WebSQL. * SQLITE_OMIT_TCL_VARIABLE: We don't use TCL variables. * SQLITE_OMIT_TRACE: We don't use sqlite3_{profile,trace}(). Bug: 807093 Change-Id: Ie5e59e55dd9b2ed52f7c27682a809c9f7c36d4a3 Reviewed-on: https://chromium-review.googlesource.com/882961 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#532995}
-
https://chromium.googlesource.com/catapult.git/+log/9ce4426b187b..3f8c43b79487 $ git log 9ce4426b1..3f8c43b79 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 perezju [Devil] Use ListProcesses to count processes in device_monitor Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I03b4c527610e82b303c44b4e7eced40a855f53d9 Reviewed-on: https://chromium-review.googlesource.com/893646 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532994}
-
https://chromium.googlesource.com/angle/angle.git/+log/6969132c134f..13fd988cf71d $ git log 6969132c1..13fd988cf --date=short --no-merges --format='%ad %ae %s' 2018-01-29 geofflang Vulkan: Add the Vulkan API to gpu_test_expectations. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I1b794d0c516617b2ca8da6b1badeb7c5a7247132 Reviewed-on: https://chromium-review.googlesource.com/893641 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532993}
-
Réda Housni Alaoui authored
Image capture tests were disabled since issue 633242. We think this was caused by the fact that bots were running webcam tests concurrently. Now that concurrency has been disabled for these tests on Windows, they should pass. Bug: 806431 Change-Id: Ic836752abef240d622f13cc7c44883540e033cf7 Reviewed-on: https://chromium-review.googlesource.com/890518Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#532992}
-
Nico Weber authored
Bug: 177475 R=rogerm@chromium.org Change-Id: I4c5c56af1d9ed85a4df6ec9651a189d232180036 Reviewed-on: https://chromium-review.googlesource.com/889761Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#532991}
-
Justin Cohen authored
Bug: 805634 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id3433625e9c8da612431181aeff11abbea6247aa Reviewed-on: https://chromium-review.googlesource.com/893824Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532990}
-
Scott Graham authored
Causing extra long compiles, and is currently of limited utility on Fuchsia. We might want to investigate the runtime performance delta for this feature once more complex JS is running on Fuchsia. Bug: 764576, 807320 Change-Id: Iefee81a7e9078b42b68766f6891bbed2233a6599 Reviewed-on: https://chromium-review.googlesource.com/893427Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532989}
-
Troy Hildebrandt authored
This change removes the VoiceSearchTabHelper, and instead allows voice searches to trigger a user activation on the frame. This allows the search results audio to autoplay under the new autoplay policy guidelines. This is achieved by adding an IPC from the RenderFrameHost to the RenderFrame to allow us to call Frame::NotifyUserActivation when a voice search is performed. Bug: 715588 Change-Id: I3440d5482712c21377914a4ccda028b42161bd8f Reviewed-on: https://chromium-review.googlesource.com/820601Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532988}
-
Anna Offenwanger authored
Detached the xr test folder from the vr test folder by creating its own set of helper classes. Converted all tests to promise tests where it made sense. As much as possible detached chrome specific code for when we convert tests to WPTs. Bug: 777567 Change-Id: I90e7800cbf86b09f72937033e4a840d1f5719b61 Reviewed-on: https://chromium-review.googlesource.com/889652 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#532987}
-
Fredrik Hubinette authored
Bug: 754986 Change-Id: Id9b981552b78c59629d2b720717c1ec6e8e4b8a4 Reviewed-on: https://chromium-review.googlesource.com/891650Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#532986}
-
Ken Rockot authored
Gets rid of the ThrottlingURLLoader::CreateLoaderAndStart override which takes a callback instead of a SharedURLLoaderFactory. Moves LoaderCallback into URLLoaderRequestHandler to clarify its relation to implementations of that class. Introduces SingleRequestURLLoaderFactory as an implementation of SharedURLLoaderFactory that handles a single loader request using a OnceCallback provided at construction time. Adapts NavigationURLLoaderNetworkService to use the new API. Bug: 721414 Change-Id: I1030aef2096edeb4fe525999e6b7d1a626a4110c Reviewed-on: https://chromium-review.googlesource.com/889650 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532985}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c62a1ec..adcf8626 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib596ed4a556f44b753050fbf2518b3d55ad05d2a Reviewed-on: https://chromium-review.googlesource.com/893280Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532984}
-
Charles Zhao authored
Change-Id: I2bef2e12d3a5fa5ac42535da709bfe9d337fdaa1 Reviewed-on: https://chromium-review.googlesource.com/892181Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#532983}
-
Steve Kobes authored
These weren't caught in http://crrev.com/532638, but they are failing on win7_chromium_rel_ng: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/91452 Bug: 711468 Change-Id: Iae4b8a5e5a56e96bc835556fe6cc5fcdf11dedac Reviewed-on: https://chromium-review.googlesource.com/893214Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#532982}
-
gogerald authored
Bug: 763417 Change-Id: Ia02e2e00f2e6a315ae16ee8de852e756a79c0de6 Reviewed-on: https://chromium-review.googlesource.com/891978Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#532981}
-
Daniel Blakemore authored
A new mailto handler provider is being added to Chrome for iOS. This flag will wrap all invocations of the new provider during development. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9e24a5f256fc5e220120e173080a67301084b506 Reviewed-on: https://chromium-review.googlesource.com/876729Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Daniel Blakemore <danblakemore@google.com> Cr-Commit-Position: refs/heads/master@{#532980}
-
Nico Weber authored
Follow-up to https://chromium-review.googlesource.com/c/889942/ Also update a very old comment that I believe tries to say that the fallthrough is intentional: In https://websvn.kde.org/trunk/kdelibs/khtml/rendering/bidi.cpp?r1=56133&r2=56134&pathrev=65933 the code and comment looked like so: switch(dirCurrent) { ... case QChar::DirEN: if(status.lastStrong != QChar::DirAL) { // if last strong was AL change EN to AN ... } case QChar::DirAN: dirCurrent = QChar::DirAN; ... All the constants have been renamed several times, but the comment was touched just once after being added in https://websvn.kde.org/trunk/kdelibs/khtml/rendering/bidi.cpp?limit_changes=0&view=markup&pathrev=42417 in Mar 2000 (in a commit saying "merge of the new_rendering branch." -- I couldn't find where the new_rendering branch is. Probably in some CVS repo, but I didn't manage to find it) and that's in 56134 linked above, which changed it from // if last strong was AL change EN to AL to // if last strong was AL change EN to AN which looks like a typo fix. This CL was uploaded by git cl split. R=fmalita@chromium.org Bug: 177475 Change-Id: I55de0202f9a67436a4abb630291d1280ee489d4d Reviewed-on: https://chromium-review.googlesource.com/890430 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#532979}
-
Dominick Ng authored
This CL removes several different app banner testing files, and replaces them by calling the necessary JavaScript setup code in one test file. For instance, all tests will no longer have the "appinstalled" title overwriting, as that will only be active when the appropriate setup JavaScript is run. This allows future tests to be more easily added, and reduces collisions when manipulating the page title. BUG=806923 Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 Reviewed-on: https://chromium-review.googlesource.com/892182 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#532978}
-