- 14 Oct, 2020 40 commits
-
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ios/web. R=eugenebut@chromium.org Bug: 1113033 Change-Id: Ic701aa0a0f4a4209317aaf3ab1fcfd7bbb06b8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472498 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817126}
-
Ken Rockot authored
In preparation for the experiment going to 100% on stable, this enables OOP Storage Service by default on ToT. Bug: 994911 Change-Id: I235ff43a24d0bf3449816936fe7545742c386a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463965 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817125}
-
Mustafa Emre Acer authored
Bug: 400380 Change-Id: I8abd27ae269bd0040f12c038a14223c5989a43f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460875Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817124}
-
Mike Wasserman authored
See https://crbug.com/945193#c13 TBR=aboxhall@chromium.org Bug: 945193 Change-Id: Ia0db3f40992a95707f38170fb5f9823305c73b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472158Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817123}
-
Xianzhu Wang authored
Also do compositing update when we need compositing update when not compositing, to clear the stale GraphicsLayers. This fixes crash when SetAcceleratedCompositingEnabled(false) is called after the frame is composited. Not sure if this happens in real world but this fixes clusterfuzz crashes. Bug: 1137609, 1137650 Change-Id: I059876725758c95490644eeebae7e0c94d5caa65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469362Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817122}
-
Prashant Nevase authored
This patch modifies watchlists to include files with dark_mode anywhere in the filename and to include dark_mode files from cc/*. Bug: None Change-Id: I99ac814e4e79bd1a4ad1cadf380d20c677cfae85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472677Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#817121}
-
Fredrik Söderqvist authored
The kPaintInvalidation flag performs both paint invalidation paint property invalidation and clip-path cache invalidation. Split out the two latter so that they can be used in a more targeted way and avoid unnecessarily "wide" invalidations. For example we don't need to invalidate neither the paint properties nor the clip-path cache when a paint server changes. Take this opportunity to change the invalidation flags for masks, clips and filters to not invalidate bounds and trigger layout since they should no longer have any effect on a clients bounds (and thus also don't need to trigger a layout). Add an additional kFilterCacheInvalidation flag for the invalidation of a filter, and make that invalidation conditional. Bug: 1028061, 1028063 Change-Id: If96237ec2b5f7a08fd41fb51e1eb3f245b809b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467997Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#817120}
-
Morten Stenshorne authored
I'm working on getting rid of as many renderer/core/*/BUILD.gn files as possible, and this one was getting in the way. Bug: 800764 Change-Id: Ie29c2e750aec9459cb17c9aa2da32219e03d3068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470659Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#817119}
-
Wez authored
Temporarily allow the default permissions granted to each Frame to be configured by passing a wildcard origin to SetPermissionState(). Bug: b/170198665, 1136994 Change-Id: I653622a5bbe8d8f7d08bc4f1c0fa6da94dc207cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452633 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817118}
-
Bartek Nowierski authored
Currently all metadata is stored in PartitionPage, which is confusing because the most commonly used metadata is related to slot spans, and is stored only in the PartitionPage object that corresponds to the first partition page of the slot span. This CL introduces SlotSpanMetadata to clarify that confusion. Change-Id: Id8873dba1c9e3018a8643f4f9c93e694f2edb9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466007 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#817117}
-
Steven Bingler authored
API_OWNERS LGTM not required: https://groups.google.com/a/chromium.org/g/blink-dev/c/qB7DKqxkiaA/m/EjiOUq5HAAAJ Received launch approval: crbug.com/1126175 Bug: 1030938 Change-Id: Ib35895ded9edcd382611b432a5d711cfe3724e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468920 Auto-Submit: Steven Bingler <bingler@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#817116}
-
Scott Violet authored
It's not used, this is just support for the property. I put the property at the end of CSSSampleId as it will not have any usage at this point. BUG=1087667 TEST=none Change-Id: Ib467fa1658464d17b8813ffaba18e9c92b5e7e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464024 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817115}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602644333-c5d02301d4a6428e8ec60219d0e73c3fd904c678.profdata to chrome-win64-master-1602665973-82a3b15c2fe4da417cf5b287fae1d2a3020f8e39.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38008b2ea100421267b3d271dcbc7637dda8a93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470741Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817114}
-
spdonghao authored
Bug: 1092642 Change-Id: Ie13c405ffc7b730b61ced2cb5ff3e61d3d5c33c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468356 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#817113}
-
Tommy Li authored
Updates the Flash deprecation infobar message to match the placeholder: Adobe Flash Player is no longer supported Bug: 1069833 Change-Id: Ia34c079c52bcb24ea006fda8540de7c3dc7774eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472177Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#817112}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //net. R=jochen@chromium.org, rsleevi@chromium.org Bug: 1113033 Change-Id: I6173a164f2ec855d83ca71b545ee0d71bffa0145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454407Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817111}
-
Nico Weber authored
This test needs otool, and otool needs 10.14+ to run after the recent Xcode bump. We still run the test elsewhere, so not running it on the older bots seems fine -- the test isn't very OS-version-dependent. Bug: 1138050 Change-Id: I37c085fcf5c2850b42a21792fdcb28c9930005a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471798 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#817110}
-
Anupam Snigdha authored
This reverts commit 5d66d264. TBR=yukawa@chromium.org,siliu@microsoft.com Bug: 1137267 Change-Id: Iba8a3cb59a12ddd4310849ee1cf877cb7ea8a019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471881 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#817109}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ios/web_view. R=jzw@chromium.org Bug: 1113033 Change-Id: I3c518ead1448caeb41a86814b87b06d18ae2a2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472480 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817108}
-
Gabriel Marin authored
We see a large fraction of unmapped samples with cycles precise. Disable sampling on cycles precise while we investigate the root cause of unmapped samples. BUG=b:170558957,b:168312716 Change-Id: Ie566e8e870e0bebc8db8355222f4cbf8cc61e055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471579Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#817107}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a6efa6be2ca..27f283f2507f 2020-10-14 robertphillips@google.com Update error handling in DDL-averse GMs 2020-10-14 mtklein@google.com refine SkPath::approximateBytesUsed() 2020-10-14 adlai@google.com Migrate GrContextPriv & ivars to GrDirectContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ice2c30a3f5d52cf42768b231a0d717e8ba21cb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817106}
-
Peter Boström authored
Removes a few CalculatePreferredSize overrides that try to end up with the same fixed width. Bug: 1128500 Change-Id: If0fbc457aac34fe0dc64e548bf75573553573393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469839Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#817105}
-
Alex Gough authored
Mojo serialization should not be blocking, but this CHECK included a blocking call to Fstat. This prevents DisallowScopedBlocking consumers from using this type. We now call fstat directly and while this could block in practice this should be quick for already opened physical files. The remaining CHECK calls fcntl with F_GETFL which essentially just copies an int from the kernel back to the process, so can be considered non-blocking, and so left in place. Bug: 1130762 Change-Id: Iced551675d5e8c74ac62b8bcbffc240dbde1aa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466203Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817104}
-
Victor Hugo Vianna Silva authored
Please see crbug.com/1137896#c1 for context. This CL introduces a new util function which achieves the same UMA-recording functionality of DataTypeDebugInfoEmitter. All users of the DataTypeDebugInfoEmitter API are migrated to the new function. In particular, for CommitContributionImpl this means the histogram will be recorded earlier: it used to be recorded after the server responded (in CleanUp), whereas now it's recorded before sending the commit request (in AddToCommitMessage). This is an acceptable solution because the commit is not aborted between these two events (Init can't return nullptr after this [1]). It may still slightly influence the metrics around shutdown, since the engine is synchronous and some steps are slow. Removing the class itself together with some clean up is left to crrev.com/c/2470528. [1] https://source.chromium.org/chromium/chromium/src/+/a450ab794839b63f9c2ba982f738945f90e9fee2:components/sync/engine_impl/commit.cc;l=135 Bug: 1137896 Change-Id: I9f3ba96d4aad9a434e9b326458de8c392d4946b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470877 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817103}
-
Cammie Smith Barnes authored
This makes the histogram obsolete and removes the lines that record and test it. Bug: 1135308 Change-Id: Ib7704d2a739bee3ff5d65705ec3145055e8cc6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468468Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#817102}
-
Kramer Ge authored
This reverts commit c2d62d36. Reason for revert: suspect for crbug.com/1138522 Original change's description: > [Longtasks] Fix buffering before observer > > When we shipped longtasks with buffered flag, we forgot to remove a > check that would prevent longtask creation when there's no observer. > This CL fixes this and adds a test for this case. It also moves the > UseCounter to the observe() method. > > Bug: 1131385 > Change-Id: I2911b9ab044db7394bcf64f64b1e599959cbdc37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463594 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816664} TBR=skobes@chromium.org,npm@chromium.org Change-Id: I03483b9cc1e8ce03b518d90df16e54e4503f5ffc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472258Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#817101}
-
Austin Eng authored
Bug: chromium:951558 Change-Id: I68fcba0541f48bcb492b23ad34ec8c8b21dd1fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463865 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817100}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bf2339dc0f8..1410c33130bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie1eebb2fb8af08b58e24b86e953332547619cdc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471800Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817099}
-
Mike Wasserman authored
Post the task to restore bounds after the exit transition completes. (as opposed to when the fullscreen exit transition starts) See crrev.com/c/1990137 for the original fix. Plumb *Start and *Complete signals through NativeWidgetMac. Plumb as *Changing and *Changed signals to BrowserView. Continue running other BrowserView logic in *Start/*Changing. Update ImmersiveModeControllerAsh to call the intended function. TODO: Refine naming and/or move all BrowserView logic to *Changed. Bug: 1134705 Test: jsfiddle.net/cterefinko/rwo08as4 Enter->Swap->Exit WAI Change-Id: If81438181dd4454a975fcc9198d57136b9137044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468345Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817098}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bf2339dc0f8..1410c33130bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic9554a5c6983e159b8c277b179ea5cd47c625bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471877Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817097}
-
Joon Ahn authored
https://screenshot.googleplex.com/Bg8CHZ4H3aBxa54 Bug: 1125150 Change-Id: Ib28cba76d512ea40367f1906cba098fc931a531e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461485 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817096}
-
Mohamed Amir Yosef authored
This CL is doing the follow changes: 1- Change the avatar size to be 48 instead of 40. 40 was the size of profile photo in the old (deprecated) profile menu. 2- Add a border and a background to the favicon badge to protect against favicons with transparent background. 3- Add 2 pixels paddings around the whole badge not to avoid having the border very close to the favicon. (border is an extra 1 pixel) 4- Make the border color a softer version of the icon color.s Screenshots: - Favicon with solid background -- Light mode: https://screenshot.googleplex.com/BuBQtRtznjE8Hmh -- Dark mode: https://screenshot.googleplex.com/3qSaFau5Zmb3eok - Favicon with transparent background -- Light mode: https://screenshot.googleplex.com/6qeXwuk3vZDpiJA -- Dark mode: https://screenshot.googleplex.com/47ruimEcaZ3HYbC Bug: 1100814 Change-Id: I6f3284bc5f1fe0e3b1cb09cf4c2677d9edc10b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470524 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#817095}
-
Nico Weber authored
This is now set to the right value automatically. No behavior change. Bug: 1132930 Change-Id: I54228279af02cf05a095c5bd013386e76249e861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469540 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#817094}
-
Nicolas Ouellet-Payeur authored
With the recently-added DestroyProfileOnBrowserClose flag, the Profile object is not guaranteed to exist throughout an extension's install process. There was one missing guard clause in CrxInstaller, which caused it to crash if the Profile was deleted too early. This patch adds the missing clause. Bug: 88586 Change-Id: I61cfa73ab5a1543263b3fdc72809694ac3dd0870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462175 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#817093}
-
ckitagawa authored
Frames can't have transparent backgrounds so omit the alpha channel to simplify things. Change-Id: Ic9d1de433144123d5572a9557c03598fc82de635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463601Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#817092}
-
Mikel Astiz authored
The two implementations of the interface, also deleted in this patch, do nothing actually, and the whole class hierarchy plays no role in the modern post-Directory sync codepath (USS). Most of the code can be deleted trivially without behavioral differences. To avoid behavioral differences, the less trivial parts are now encapsulated inside SyncBackendRegistrar, namely the enum ModelSafeGroup. Future patches should clean up this enum too, or possibly the whole SyncBackendRegistrar class. Bug: 1102835 Change-Id: Idea6981b96b165c25f9f404aaee393fa6fd9f573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469559Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817091}
-
Francois Doray authored
This CL updates the IntensiveWakeUpThrottling testing config to reflect the configuration that that we intend to experiment with on M87 Beta. Since WebSocket event handlers are never throttled, we intend to remove the WebSocket aggressive throttling opt-out at the same time as we enable IntensiveWakeUpThrottling. Bug: 1121725, 1075553 Change-Id: I90b9e6c0ab5da7988f0d5e14ebdfcdc0e4678fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468504 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#817090}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/4311dd05c883..f2b8b6e87396 2020-10-14 dsinclair@chromium.org Emit validation errors after outputing result. 2020-10-14 dsinclair@chromium.org [spirv-writer] Fixes to constant constructor determination. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: enga@google.com Change-Id: I7a0bc5951cca552085131e0eab0e1b8f0f50a0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471146Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817089}
-
Etienne Bergeron authored
Remove code that was used to debug font fallback. Change-Id: I65c04b1dd7167b5b2a9204bb7f2d7a7d70773cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470460Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#817088}
-
Clark DuVall authored
This allows a client to block signin in incognito. Bug: 1138458 Change-Id: I724a4dace1cdb6fc1c38f0640c344a12d4482021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470467 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#817087}
-