- 05 Oct, 2017 40 commits
-
-
Shanfeng Zhang authored
Bug: 769018 Change-Id: I5bdaf2ebfc8998f77d5c8ffaa3bded58facedb2a Reviewed-on: https://chromium-review.googlesource.com/688660 Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#506920}
-
Theresa Wellington authored
:( BUG=769611 Change-Id: I6d455b6bba646a27f81f47c4d1058a80778712fd Reviewed-on: https://chromium-review.googlesource.com/703994Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506919}
-
khmel authored
This CL makes it possible to safely change one app item launcher to another. Normally this should not happen, however in some edge cases this still may happen during the ARC failure boot. provided simulation of conditions that may lead to showing the Play Store while ARC OptIn UI is active. No crash observed. Test: Manually on device. Could not find the reproduction stage and Test: Extended unit tests by adding different scenarios. Bug: 770005 Change-Id: I0eb1b571e239af6f8dea3906836852b2d6035c32 Reviewed-on: https://chromium-review.googlesource.com/698350 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506918}
-
Khushal authored
Add a finch flag for enabling image animations in the compositor. Its currently disabled by default. R=piman@chromium.org Bug: 735662 Change-Id: I171d05b9411e3b3fa72b4df1be612deb0bd289b2 Reviewed-on: https://chromium-review.googlesource.com/703507Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506917}
-
Yoland Yan authored
HistoryActivityTest is refactored in the following ways: - test class use espresso IntentTestRule for a couple of tests that ensure intent is sent after activity launch (ActivityMonitor does NOT track or block intent in Android JUnit4 now) - Add test helper method to HistoryAdapter for testSupervisedUser. For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116 Change-Id: I58f84f296226e97d56b9b152d4173122df5a2475 Reviewed-on: https://chromium-review.googlesource.com/696033 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506916}
-
Eric Willigers authored
virtual/threaded/animations/play-state-initially-paused.html was failing, and had platform-specific (failure) expectations. The test has been redesigned to not rely on precise sample timing. BUG=392706 Change-Id: Iffb469427a9af700b111f1c654ae98e47a1aa304 Reviewed-on: https://chromium-review.googlesource.com/702180Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#506915}
-
Ben Chan authored
Bug: None Change-Id: I779f4a692b9ed403efe2c3999a043fb87ba4cc02 Reviewed-on: https://chromium-review.googlesource.com/703397Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506914}
-
Troy Hildebrandt authored
Bug: 761470 Change-Id: Id0f7795f425cef12bd9d77329770adaeb74dc055 Reviewed-on: https://chromium-review.googlesource.com/701364Reviewed-by:
-
Mike Baxley authored
This test is failing reliabily on the iOS 10 device bots. TBR: edchin Bug: 772186 Change-Id: If08dcce9410a2d8884fc455f0b33b7ba2f6801c9 Reviewed-on: https://chromium-review.googlesource.com/703999 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#506912}
-
Jonathan authored
Another test is flaky on telemetry_unittests, skipping it in config. TBR=sky@chromium.org Bug: 758065 Change-Id: I9d08df3109e43682b1edcff11b545bc684f06ab5 Reviewed-on: https://chromium-review.googlesource.com/703684Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#506911}
-
Kevin Marshall authored
There are some issues that need to be worked out, such as sharing resource files to embedder processes, before sandboxing will work satisfactorily on Fuchsia. This CL disables sandboxing and logs a soft NOTIMPLEMENTED() error when the browser attempts to launch one. Bug: 750938 Change-Id: I7a0253a2c4532e79fd8158d23cd262779285cf6f Reviewed-on: https://chromium-review.googlesource.com/701636Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#506910}
-
Vladimir Levin authored
This patch adds a check to ensure that we have the images that we expect to have (even if it's an empty set). R=khushalsagar@chromium.org Bug: 757049 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic544760e175be2bf95d467008cb3b5a59dc32a35 Reviewed-on: https://chromium-review.googlesource.com/703505Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506909}
-
Xing Liu authored
This CL fixed an issue that transient download may trigger android UI and cancel the download in download resumption. How it happens: In resumption, we feed current path as initial path to target determiner instead of forced path. Target determiner may change the download path from DS internal storage to external storage, this creates the following issues: 1. External storage needs permission. 2. Conflict files are not rewritten, but needs user confirmation with a snackbar, because we don't have webcontents, target determiner will delete itself and fail the download with reason USER_CANCEL. All the Android leak will call into DownloadManagerService::OnDownloadCanceled, where it shows two kinds of error messages in toast. This issue may be also related to issue 762173. Bug: 769805, 769426 Change-Id: I1ac6d2446fcc05c00517a65b465d7bf1ea2ccfeb Reviewed-on: https://chromium-review.googlesource.com/693400Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506908}
-
Antoine Labour authored
This reverts commit afd24343. Reason for revert: Caused a memory regression on Mac, for some reason: https://bugs.chromium.org/p/chromium/issues/detail?id=771766 Original change's description: > Avoid checking overlay ResourcePool in non CA Layer > > Overlay ResourcePool is only used for CA layer. > BUG=None > > Change-Id: Id37572e65d1b7a2c3307fa80be9820a94d693f7a > Reviewed-on: https://chromium-review.googlesource.com/685947 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Xing Xu <xing.xu@intel.com> > Cr-Commit-Position: refs/heads/master@{#505913} TBR=xing.xu@intel.com,piman@chromium.org,danakj@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I0543fa78a715438d9d27c9eb38f643008745679f Reviewed-on: https://chromium-review.googlesource.com/703714Reviewed-by:
-
Steven Bennetts authored
This adds a new WebUI dialog for network configuraiton using the shared network-config component. Bug: 380937 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I44d9db4f01e366afc59e56286cc8fd7adf536bea Reviewed-on: https://chromium-review.googlesource.com/693288Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#506906}
-
Ted Choc authored
Use SwitchCompat to get a material looking switch. Mutate the download and history icons to not break their usage in the rest of Chrome. Fix animation timing/display. The animation was not triggered because super.setVisible was not returning true (i.e. that it had changed). It likely defaulted to true pre-L. Second, setting the alpha values was not triggering invalidateSelf. Third, we were not registered as Drawable.Callback[s] for the child drawables so even if they did say invalidateSelf, it would have fallen on deaf ears. Fourth, due to rounding, there was a 1px gap on the border, so this makes the sheet drawable just a "bit" bigger to cover the gap. Fifth, there is nothing left, I'm just wondering if you're still reading. Kudos. BUG=772070, 772052 Change-Id: Ie4544977f09f1f0198c3ef2944fd044cda2dedfc Reviewed-on: https://chromium-review.googlesource.com/703510Reviewed-by:
-
Toni Barzic authored
This delayes final step in lock screen apps initialization (observing session state, thus preventing the state controller from reacting on session being locked) until stylus input is detected (for one settings UI for controlling lock screen apps is only shown for stylus enabled devices). Remove somewhat hacky solution where lock screen apps were disabled by simply not reporting any app lock screen enabled. BUG=765029 Change-Id: I214dbe09e95babdd4779268fa6abfa5c1615e80b Reviewed-on: https://chromium-review.googlesource.com/693961 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506904}
-
Yuly Novikov authored
https://chromium.googlesource.com/angle/angle.git/+log/a60d356..000dab8 BUG=None TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I619e797dbdb70aa00d0ae9d017bdbde3f79a4d19 Reviewed-on: https://chromium-review.googlesource.com/703459Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506903}
-
Ryan Landay authored
This reverts commit 0e5c6697. Reason for revert: This is instacrashing my test device (Pixel C) when I navigate to file:///sdcard/. Original change's description: > Added fieldtrial_testing_config entry for Client-side LoFi. > > Bug: > Change-Id: I9f792d5b74dd28ee9442725a182a69de62c4f66e > Reviewed-on: https://chromium-review.googlesource.com/700794 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Commit-Queue: Scott Little <sclittle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506482} TBR=rkaplow@chromium.org,sclittle@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id44e53b31dbfcad4639fe4e6ed70c942b8b2a4fa Reviewed-on: https://chromium-review.googlesource.com/703715Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#506902}
-
Tien-Ren Chen authored
This cleanup CL refactors TransformNode structure so that its member variables are splitted into input values and derived values, so that it is clearer which values are expected to be set by the client and which are to be recalculated by impl thread every frame. In the process, pre_local and post_local are eliminated and is only computed on the fly. To achieve this, the calculation of post_local needs to be unified between root and non-root layers. Previously the transform node #0 stores the scale component of the root transform[1], and node #1 stores the root transform with scale component extracted. With this CL, transform node #0 stores the whole root transform and node #1 becomes a regular node. This CL affects rounding error of draw matrices due to the change in association order. Should introduce no other behavior change. [1] root transform = device_transform * device_scale * page_scale Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia553ec5816d71eff6e2d7bc42b51b439817d9d2b Reviewed-on: https://chromium-review.googlesource.com/685544Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506901}
-
Yue Li authored
If PlayStore setup runs into an error (such as no network), close the wait a second screen. BUG=b/67100483 Change-Id: I5581b9411bed0396bd4acf0c5030eac55c5e3c2c Reviewed-on: https://chromium-review.googlesource.com/701494Reviewed-by:
-
Maks Orlovich authored
(but still close it when closing them all) Not sure if this could ever be hit IRL (testcase would check-fail on file being invalid in File::Read off ReadSparseRange), but I am going to be touching this for FD limits, and it helps if the code makes sense. Bug: 636400 Change-Id: Ie33f1787a81f90b893d963e1fcb1db3b4fd0aab2 Reviewed-on: https://chromium-review.googlesource.com/652965 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506899}
-
Fernando Serboncini authored
Also makes FontFaceInvalidated a virtual on FontSelector. Bug: 722511 Change-Id: I6144965b1d559bb418d2b823b4d6486e5769d8bc Reviewed-on: https://chromium-review.googlesource.com/702684 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506898}
-
Matt Menke authored
All consumers now use a single thread for prefs and the network stack, so there's no need for it to have thread hopping logic. This also makes HttpServerPropertiesManager better support the case where prefs aren't loaded when it's created (Always the case in consumers), and makes it flush to prefs on destruction, which can now be done, since the net and prefs threads are the same. This also fixes a crasher in the single-thread case, due to the use of base::Unretained when calling from the prefs thread to the network thread, which doesn't work when they're the same thread. Bug: 768884, 770179 NOPRESUBMIT=true (Unfortunately, the tests use banned APIs. This use predates this CL, and this CL doesn't introduce new uses of them. Fixing a crasher is more important than removing banned APIs). Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2692e3c02ff6028b585416808b60cabcf9d2e2e6 Reviewed-on: https://chromium-review.googlesource.com/693054Reviewed-by:Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506897}
-
iOS Autoroller authored
TBR=smut Change-Id: Ie4d656a4a09c8504206be049b39531a0373e967b Reviewed-on: https://chromium-review.googlesource.com/703755Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506896}
-
Hiroki Nakagawa authored
The Worklet spec allows addModule() on a cross origin resource: https://drafts.css-houdini.org/worklets/ Bug: 738769 Change-Id: Ib18114697112966309ccc4d6107a4804f05a24fe Reviewed-on: https://chromium-review.googlesource.com/694704Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#506895}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/8d64ee779599..ded7aa82afa9 $ git log 8d64ee779..ded7aa82a --date=short --no-merges --format='%ad %ae %s' 2017-10-05 angle-deps-roller Roll skia/third_party/externals/angle2/ 63c5a5974..000dab88d (1 commit) 2017-10-05 bungeman Fewer atomic ops in debug with SkBufferHead. 2017-10-05 csmartdalton Revert "Attempt both GL and GLES for GPU unit tests" 2017-10-05 angle-deps-roller Roll skia/third_party/externals/angle2/ ce8602ab7..63c5a5974 (1 commit) 2017-10-05 mtklein clamp to [0,1] in all gradient tilers 2017-10-05 bungeman Clean up SkString reference counting a bit. 2017-10-05 csmartdalton Attempt both GL and GLES for GPU unit tests 2017-10-05 robertphillips Use draws instead of clears on Macs w/ Intel Iris Pro GPUs 2017-10-05 mtklein abort if glyph metrics fall outside safe rect 2017-10-05 mtklein reformat hard-to-read preprocessor in SkJumper.cpp 2017-10-05 ethannicholas converted GrConfigConversionEffect to SkSL 2017-10-05 caryclark add constexpr to SkRect, SkIRect Make functions 2017-10-04 mtklein aggressively refactor pipeline building in SkColorSpaceXform 2017-10-05 mtklein disable object-size santizer in debug builds Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I6c77c6637a065bfdce2fb77b67cc58a76911fe52 Reviewed-on: https://chromium-review.googlesource.com/703496Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506894}
-
Tibor Goldschwendt authored
Change-Id: I0ac74f33ceb8f61593a16a957ee8b9c7c93f51fd Reviewed-on: https://chromium-review.googlesource.com/702775Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506893}
-
Scott Violet authored
Doing this means we can have the utility process load the common resources, which means we don't have to worry about copying resources from the services to devices. Additionally adds the service name to the command line so that it's easier to tell what service a process is running. BUG=771980 TEST=none Change-Id: Ib9219471e4d758157b515d0b27743e996f9fa6e2 Reviewed-on: https://chromium-review.googlesource.com/703736Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506892}
-
Patrick Meenan authored
Bug: Change-Id: I91fff588822c40f29a0b3e96aaf3c344d4cbabfd Reviewed-on: https://chromium-review.googlesource.com/700404Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Patrick Meenan <pmeenan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506891}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/400dbc4b2b00..aeaf34ca03f8 $ git log 400dbc4b2..aeaf34ca0 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 nednguyen Remove unneeded code from snap_page_script 2017-10-05 jbudorick [devil] Add support for line transformation to LogcatMonitor. 2017-10-03 jl Fix story sharding flags 2017-10-05 achuith Catch DevtoolTargetCrashException. Created with: roll-dep src/third_party/catapult BUG=651249 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If2adcdb2d31f8edcc3b1f2b68790d8fc0d0601d6 Reviewed-on: https://chromium-review.googlesource.com/703498 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506890}
-
Ivica Bogosavljevic authored
MIPS support was lacking in GN, only MIPS32 in combination with CLANG was working properly. This CL implements support for other flavors of MIPS, for both CLANG and GCC compilers, in the context of V8 project that needs it. Bug: Change-Id: Iaa4b4314cafe1631c40d75c151a82d52aa851131 Reviewed-on: https://chromium-review.googlesource.com/677302Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506889}
-
Stephen Martinis authored
# No try because trybot failures are unrelated to the change. NOTRY=true Bug: 758630 Change-Id: Ie3adb8ed81ecb5dab1578391f0fca0785c0ca23e Reviewed-on: https://chromium-review.googlesource.com/703501 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Sammie Quon authored
This reverts commit ab3c1bb4. Reason for revert: <INSERT REASONING HERE> Original change's description: > tray: Do not close accessibilty detailed menu when item selected. > > It is desired to remain open so users can try out the features without > having to tray->accessibilty->details each time. Also modified > hover_highlight_view to support showing/removing checkmarks dynamically, > for this purpose (other details views just recreate the whole view). > > Bug: 747473 > Test: browser_tests TrayAccessibility.DetailMenuRemainsOpen > Change-Id: I1160c29baac2afc8dc8a25dee3a87415ccef1adf > Reviewed-on: https://chromium-review.googlesource.com/692680 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506755} TBR=stevenjb@chromium.org,sammiequon@chromium.org Change-Id: I139e7255e7162e47b95715d5c7b006844ec15c37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 747473 Reviewed-on: https://chromium-review.googlesource.com/703934Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#506887}
-
Randy Smith authored
Both test and implementation were inverted from the comment in the Mojo interface for CookieManagerImpl deletion functionality. This CL fixes that. Bug: 721395 Change-Id: I39274d5fc91a27ab988dcc6de61ded25dfe874e0 Reviewed-on: https://chromium-review.googlesource.com/701138 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506886}
-
Khushal authored
This reverts commit f77a3ffb. The previous change inadvertently introduced a race in |cached_shader_| creation in PaintShader by removing the call to PaintFlags.getSkShader in PaintOpWithFlags::HasDiscardableImagesFromFlags, which would have always created the shader at record time on the main thread. With https://chromium-review.googlesource.com/c/chromium/src/+/701974, the PaintShader should always create the SkShader at construction time, ensuring that the access is safe. R=enne@chromium.org TBR=chrishtr@chromium.org Bug: 771156 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie29d549f597ec1f446febd6d294e3050105d466a Reviewed-on: https://chromium-review.googlesource.com/703014Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch implements major parts of positioning list-item markers. 1. Marker box creation is changed to better match to the spec and for more compatible layout. a. 'inside' position creates inline marker box[1]. b. 'outside' position creates inline block marker box. Out-of- flow position looks more reasonable, but crbug.com/734554 is blocking. 2. LayoutListMarker exposes the existing margin logic to share with LayoutNG. 3. Add new kListMarker NGInlineItem type. 4. NGLineBreaker and NGInlineLayoutAlgorithm support kListMarker. Remaining work: 1. Image is not supported yet. 2. Symbols (e.g., bullets) should use pre-defined font and heuristic width. 3. Block children is not supported yet. The idea was to wrap them with inline block, but the concern is an inline block is not breakable in the current LayoutNG. 4. Due to 3, nested lists do not render correctly. 5. Re-numbering is incorrect in some cases. 6. The marker inline block breaks editing lists. See 1.b above. [1] https://drafts.csswg.org/css2/generate.html#propdef-list-style-position Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I37995f53b5897bb161c54660bb13aaf24339a9a3 Reviewed-on: https://chromium-review.googlesource.com/697027Reviewed-by:Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506884}
-
David Vallet authored
[headless] Swizzle NSPopUpButtonCell handling enevents and action messages to avoid pop-up menus appearing in Headless Bug: 761065 Change-Id: If6c6743ce7cedf86fcf4eeb5094bf83b5cfabdca Reviewed-on: https://chromium-review.googlesource.com/701935Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#506883}
-
Steven Valdez authored
Bug: 631988 Change-Id: I16e2aaa227e36c3d025c6663b10f6a15e4a32428 Reviewed-on: https://chromium-review.googlesource.com/692946Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#506882}
-
Matthew Jones authored
If the Chrome Home promo has been disabled, clear the user setting from shared preferences. This will prevent the user from being locked into a state that cannot be changed by flags. The user will need to restart the browser before the setting is actually cleared since native needs to have loaded. BUG=767738 Change-Id: Ifced6d02ced94a731313deb96691fc094541c450 Reviewed-on: https://chromium-review.googlesource.com/702726Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#506881}
-
