- 28 Jan, 2020 40 commits
-
-
Yi Gu authored
This test has been flaky for a couple of days: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZgsSBUZsYWtlIltjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZmFzdC9mb3Jtcy9jYWxlbmRhci1waWNrZXIvY2FsZW5kYXItcGlja2VyLWFwcGVhcmFuY2Utem9vbTEyNS5odG1sDA TBR=tkent@chromium.org NOTRY=True Bug: 1046201 Change-Id: I11c98bd404d40feef82508c9d092a362726c7883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024911Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735867}
-
Tim Volodine authored
PhotoPickerDialogTest#testVideoPlayerPlayAndRestart fails on android-pie-arm64-rel. BUG=1046347 NOTRY=true TBR=chouinard@chromium.org,finnur@chromium.org Change-Id: I54a57c5f499266b6be83916604ea0aa4837686c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024852 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735866}
-
Omer Katz authored
This CL fixes a few atomic writes/reads in ListHashSet that were previously missed: 1) Write when constructing a deleted value. 2) Write when assigning a new value (during translation). 3) Read to check if node was destructed. These are very small and simple changes, thus I'm submitting them as a single CL. Bug: 986235 Change-Id: Ia1e89120506a802e7514633e42c929ddcbe33717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012387 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735865}
-
Colin Blundell authored
This class isn't actually needed as part of the ongoing componentization of SSLErrorHandler, but it makes more sense for it to live with all of its peer code in //components than to remain stranded in //chrome while all the rest of the guts of //chrome/browser/captive_portal has been componentized. TBR=jochen@chromium.org Change-Id: Ia2b2d7baa26910325a11916f46e388e64a93b550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019444 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#735864}
-
Yi Gu authored
The test started to be flaky on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBibGlua19oZWFwX3VuaXR0ZXN0c0BIZWFwVGhyZWFkRGVhdGhUZXN0Lk1lbWJlclNhbWVUaHJlYWRDaGVjaww TBR=keishi@chromium.org Bug: 1046332 Change-Id: I4fa05ce1f21c05ca474913a7bfe204177edb284e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024535Reviewed-by:
-
Andy Paicu authored
Finch is complaining about missing histograms The following histogram(s) could not be found: InProductHelp.NotifyEventReadyState.IPH_QuietNotificationPrompts: gcl_studies/QuietNotificationPrompts.gcl?dogfood_plan.active.launch gcl_studies/QuietNotificationPrompts.gcl?non_dogfood_plan.CANARY_DEV_BETA.beta gcl_studies/QuietNotificationPrompts.gcl?non_dogfood_plan.CANARY_DEV_BETA.canary_dev InProductHelp.ShouldTriggerHelpUI.IPH_QuietNotificationPrompts: gcl_studies/QuietNotificationPrompts.gcl?dogfood_plan.active.launch gcl_studies/QuietNotificationPrompts.gcl?non_dogfood_plan.CANARY_DEV_BETA.beta gcl_studies/QuietNotificationPrompts.gcl?non_dogfood_plan.CANARY_DEV_BETA.canary_dev Bug: 1039595 Change-Id: Ied0ee9cabb59073890f4647379c5219d3eecfad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020945 Auto-Submit: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#735862}
-
kylechar authored
HostFrameSinkManager communicates with FrameSinkManagerImpl over IPC so //components/viz/host should no longer need a dependency on //components/viz/service. There still exists a way to connect the two classes directly but it uses the same mojo interface just without a message pipe. Bug: 1035853 Change-Id: I2b570697744419b43b84999d290859bdd84ca7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021300Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735861}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: Ie5ff651d1e49634d0d8ab473d9e09a6a219c00ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015175 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#735860}
-
Sylvain Defresne authored
[ios] Fix uses of ios::ChromeBrowserState in /ios/chrome/browser/ui/browser_view/browser_view_controller_dependency_factory.mm The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I5c3b376cf001f736937a45c92b9fa2754db64d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017443Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735859}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5461451d..903be3ea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47875121347f0341fb20ad47851b2f3d15944e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025028Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735858}
-
Dominique Fauteux-Chapleau authored
2 instances of optional can be removed from DeepScanningDialog* code to make it more readable: - The access point no longer needs to be optional since all the access points have been added to Chrome. A default value is still included in order to simplify tests calling ShowForWebContents. - The state variable in DeepScanningDialogViews is better as an enum than an optional bool indicanting pending/success/failure, especially since a timeout state is very likely in the future. Change-Id: I767db78e428a607a7cc2dfe39d1d63c0f85c30d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020891Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735857}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8bd48a1c523..fe199f552f17 Created with: gclient setdep -r src-internal@fe199f552f17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iaebb04f9e994f7db3202c61f141229fda5f7fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735856}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 15de0d31. With Chromium commits locally applied on WPT: 3157910d "SharedWorker: Add WPT for referrer-policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I99d0e665a36cb8a073910a17c2d1fd70b10b9a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025027Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735855}
-
Dominik Röttsches authored
Fixed: 1005508 Change-Id: I97f5340c6d1881798ba51effc4a9e5c07de12e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023552 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Marc Treib authored
After https://crrev.com/c/2017429 it's always true. Bug: 2017429 Change-Id: I9dfced2ab491e7069c158e78033b6149a1c50824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022766 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735853}
-
Clemens Backes authored
We are currently finching on Canary and Dev, and want to promote to beta soon. This field trial testing config contains the same three groups used for finching. R=bcwhite@chromium.org Bug: 1040061, 1040030 Change-Id: Ibc43b37f74986166061290c4f92a9f5df8957d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022790Reviewed-by:
-
Tim Volodine authored
Failing on android-arm64-stable-tests: NGInlineCursorTest/NGInlineCursorTest.CulledInlineWithAtomicInline/1 NGInlineCursorTest/NGInlineCursorTest.CulledInlineWithFloat/1 BUG=1046338 NOTRY=true TBR=chouinard@chromium.org,kojii@chromium.org Change-Id: Ic4c94abe09498302c813bb4d48a47a28cc6a3bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023494 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a284e1614a3..4a5dab00ae22 git log 7a284e1614a3..4a5dab00ae22 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 hbos@webrtc.org [Stats] Include fecPackets[Reeceived/Discarded] in Members() 2020-01-28 srte@webrtc.org Reland "Only include overhead if using send side bandwidth estimation." Created with: gclient setdep -r src/third_party/webrtc@4a5dab00ae22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I352deac9d3e899355c271d98d96a472e38f6e223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735850}
-
Gabriel Charette authored
Bug: 1026641 Change-Id: I6772eb80d8cb9f6b55ec080091e57adc0d8afc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996993 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#735849}
-
Rayan Kanso authored
Update the WebAPK Install path to use shortcuts. Fetch the best shortcut icon per entry. Bug: 1045588 Change-Id: Ie5c179a32041217cc5bfd80ed964bfc653c2d90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020962 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#735848}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9b9f09268b2b..bb54eb5faa03 git log 9b9f09268b2b..bb54eb5faa03 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 mathias@chromium.org [e2e] Expose `$` helper Created with: gclient setdep -r src/third_party/devtools-frontend/src@bb54eb5faa03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7c1fa9860eceb3c7f669d65a0928dc8ec755f40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024972Reviewed-by:
-
Caleb Rouleau authored
R=nuskos@chromium.org, skyostil@chromium.org, wenbinzhang@google.com Bug: 1039747 Change-Id: Iaa05b829791952e5c086d043f65cb48dddf551cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017924Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#735846}
-
Sigurdur Asgeirsson authored
As the activity tracking will be used to extend crash reports, rather than for post-mortem debugging, this feature name is more appropriate. Bug: 1044707 Change-Id: I10b59daa44d846cf9fd8bed227860cabfd59e16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022252Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Robbie Gibson authored
The reason for the crash is that when the last tab is closed, there is no more current web state, so it's impossible to get a FindTabHelper. Bug: 1044606 Change-Id: I1f47ca7751c0f808e6d53abd4cb8356dd68de126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023831Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=rkgibson@chromium.org Bug: 1042208 Change-Id: I56ed201d400ffc56de8ff3b65408e4f0eaddd121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015095Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735843}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/43c070193ede..77f99a5a5380 git log 43c070193ede..77f99a5a5380 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 310fb8617946..44ac9b2f406f (2 commits) 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b0ada80356ca..07a55839eed5 (6 commits) 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src b181c1a7ddb5..e39b5cf6a1b6 (1 commits) Created with: gclient setdep -r src/third_party/angle@77f99a5a5380 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ic1e9e45b052d0adb5df84684ef80ed9a82e0279a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024967Reviewed-by:
-
Mikel Astiz authored
SyncPrefs is a thin layer on top of preferences and hosts two groups of preferences: 1) Actual user-facing settings, such as type-selection, exposed via SyncUserSettings. 2) Local "bookkeeping" sync metadata, such the last synced time or the client ID (cache GUID). In addition, there are two cases that fall somewhere in the middle, whose behavior is changed in this patch: a) FirstSetupComplete: which roughly represents the user having consented to sync-the-feature (as opposed to transport-only upon sign-in without explicit user consent). b) The encryption-bootstrap-token: which represent an explicit passphrase (usually custom passphrase) entered by the user, that allows decrypting the incoming sync changes and encrypt outgoing ones. The last two preferences above fit group 1 better, so this patch stops clearing them in SyncPrefs::ClearPreferences(), now renamed to SyncPrefs::ClearLocalSyncTransportData(). With such cleanup, what used to be ClearDirectoryConsistencyPreferences() is now merged into a single clearing function, ClearLocalSyncTransportData(), and all calling sites are unified by directly clearing prefs in ShutdownImpl(DISABLE_SYNC), as opposed to individual calling sites. This introduces -arguably desirable- behavioral changes because codepaths like RESET_LOCAL_SYNC_DATA or STOP_SYNC_FOR_DISABLED_ACCOUNT now actually clear all local metadata, which most notably includes keystore keys. Change-Id: I2c42f98c4e068c7e340580d0b78a5cd5b5c46171 Bug: 1046237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023649 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#735841}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=noyau@chromium.org Bug: 1042208 Change-Id: I9e5c5b84cacf0fceb728dd282b0de6aeb9d066eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017504Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735840}
-
Boris Sazonov authored
Bug: 1046254 Change-Id: I75b97c83d68bb2b04e3d5bfc1ee843601dbc0cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023829 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#735839}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99221b12be67..9b9f09268b2b git log 99221b12be67..9b9f09268b2b --date=short --first-parent --format='%ad %ae %s' 2020-01-28 szuend@chromium.org Revert "Introduce more accurate breakpoint decoration waiter for web tests" Created with: gclient setdep -r src/third_party/devtools-frontend/src@9b9f09268b2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ae594dbf7a16c57420c106cdc1f23e51d71f6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024969Reviewed-by:
-
Sylvain Defresne authored
As lpromero@ stopped working on Chromium, remove them from the OWNERS files (thus people will stop sending them CLs they won't review). Bug: none Change-Id: I0fb6aa9bf7774ff6dda6111c5238dae4ce1191db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023651 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Add SyncErrorInfoBarAndroid to chrome://flags for the testing plan. Bug: 1044903 Change-Id: I1bcfbb381b21de92c0295daa6badfdbdd1723771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016631Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#735836}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6136fdb28790..7a284e1614a3 git log 6136fdb28790..7a284e1614a3 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 jonaso@webrtc.org TCPConnection: Defer FailAndPrune by signaling to self Created with: gclient setdep -r src/third_party/webrtc@7a284e1614a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4fe1a93bbd81c41296b369b97e86c5006ed65f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024968Reviewed-by:
-
Marc Treib authored
It was used to check if "GCM is enabled" by calling a special API on the Sync service, but in practice this has always been true for years. Removing this code will let us (eventually) shut down this API. Bug: 1009361 Change-Id: I9de53187fc85e5b4eac0a7c566aafe36dbb3442c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017429Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Omer Katz authored
Tracing an HashTable involves checking whether keys are empty or deleted. This can result in data races with the mutator if the HashTable is modified while it is traced. To avoid such data races, we create a local copy of the key on the concurrent thread and perform the check on the copy. Using the local copy on the mutator thread would result in significant regressions. Measured locally on the facebook_infinite_scroll:2018 story from v8.browsind_desktop benchmark, showed an increase ranging from 70% to 110% in the time it takes to process ephemerons (this measurement doesn't cover all HashTables, just the ephemeron HashTable). To avoid these regressions, the local copy is used only for concurrent visitors. For further details see https://drive.google.com/open?id=13DTRcF3xfVjJ2QaKzAOYFzqvTfGRNiX6WWL3CCACSoM Bug: 986235 Change-Id: Ie135c1076bd1834ae7f8b97ca6446890fc30a02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012961 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
Create a list of component extensions which could not leak Signin profile. Unload all other extensions. Bug: 1036419 Change-Id: I2f055f9f0f36e59ffe99ea156796b0e3ef240dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980612 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735832}
-
Olya Kalitova authored
Removes translatable flag for Crostini container configuration messages. Bug: 1000287 Change-Id: Ia8878a0ba0624cb5629f4b6ec417239e688ff009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020970Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#735831}
-
Colin Blundell authored
This CL componentizes SSLErrorHandler for sharing with WebLayer. The componentization must be done together with that of CaptivePortalHelper as the two have a mutual dependency. After a *long* chain of leadup CLs, the actual componentization is now straightforward. \o/ NOPRESUBMIT=true Bug: 1030692 Change-Id: Idf572bfb45db2e4958028a9f361fa9498dc792f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022708 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#735830}
-
Rune Lillesveen authored
With BlockHTMLParserOnStyleSheets enabled, these unit tests needed RunPendingTasks calls to resume and finish the blocked parsing. Bug: 891767 Change-Id: Ie65a0ec884b70208bbbf2290ab86aa67684819bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014454Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735829}
-
Rakina Zata Amni authored
Attempting to reland https://crrev.com/c/1543258 which was reverted in https://crrev.com/c/1626417 because of a bug (not collapsing successive navigations into one), which is not a problem anymore now that PerNavigationMojoInterface has landed. With this CL, about:blank navigations (except initial navigations) will always go through the browser process. Some additional changes: - SitePerProcessBrowserTest.SubframeBlankUrlsAfterRestore is also updated in this CL because now about:blank navigations will use its initiator origin instead of the parent's origin when determining which SiteInstance it should use after getting restored. - about:blank navigation requests that go through the browser process got their referrer URL sanitized incorrectly, causing a WPT to fail, so we're updating Referrer::SanitizeForRequest too. Bug: 936696 Change-Id: I15adfc0ded269a9a10b1d4f5e820f3a627e9c101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006997Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#735828}
-
