- 06 Aug, 2020 19 commits
-
-
Xiaohui Chen authored
* Unified the logic around when to turn ambient mode off around screen off. This replaces the lid state, suspend state handlers. * Fixed a crash during shutdown when image download is scheduled Bug: b:162597832 Change-Id: Ie64e5464c37acda3e0fa638c9343e78c4dc0c17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333540Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#795278}
-
Jimmy Gong authored
Adds new test suite for PrintingManager. Bug: 1111684 Test: PrintingManagerUnittest Change-Id: Iea7abbea125e78e8e204360cf8c9a6354dcd4dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332045Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#795277}
-
Luis G Garcia authored
Tests: - Camera image texture is not null after 10 frames. - Camera image texture is not null after multiple consecutive calls to getCameraImage(). - No exceptions occur if site deletes camera image texture before API does. Bug: 1112356 Change-Id: I0149f47f143f47945312b08164b2064c636c972b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333306Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Luis Garcia <luisggarcia@google.com> Cr-Commit-Position: refs/heads/master@{#795276}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45 2020-08-05 dproy@google.com Merge "[metrics] Change the example chrome metric to not clash with chromium" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1abc336eec43ebcd4ac01f9c862c25900a96c155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795275}
-
Daniel Rubery authored
This CL replaces the existing metric, SBClientPhishing.PreClassificationCheckFail with the new histogram SBClientPhishing.PreClassificationCheckResult. The new histogram will also record how often pre classification checks all pass, giving us complete information about the result of pre classification checks. This makes it possible to easily answer questions like, "what proportion of the time do we skip classification due to the whitelist?", which previously required estimation combining multiple histograms. This CL also replaces the histogram macros in client_side_detection_host.cc with histogram functions, since they are not logged that frequently. Change-Id: Ia8ee8bcc212676a1fb7dafd57b9afb5ebb84e6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337410Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#795274}
-
Alex Danilo authored
When users have no default app for a file type we choose the application task that appears as the default from a linearly ordered set that's constructed in (sort of) arbitrary order. Add an extra pass over candidate matches that checks if an installed application was included as a fallback before we check for any view-in-browser fallback. --gtest_filter="*ChooseAndSetDefaultTask_FallbackTextApp" Bug: 1111399, 1112406 Tests: unit_tests Change-Id: I328b79e3ababe2752bd7c1f8930568ea5f696d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332079Reviewed-by:Bugs Nash <bugsnash@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795273}
-
Christoph Schwering authored
This CL fixes that Password Manager interferes with Autofill's form structure cache by calling AutofillExternalDelegate::OnPopupShown(). Bug: 1108116,1113241 Change-Id: I547aef08f7b29dfce395fe483733c30a0621a7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333203 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#795272}
-
Bettina authored
Client side detection will be made available on Android. This CL allows the needed files to be compiled on Android. additional compilation of CSD related files. They are needed to reduce phishing and improve telemetry on Android. Binary-Size: The increase in size is due to the Bug: 1108080 Change-Id: I002520d0ff8dbd58cb0c18df518049c35857a0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311898 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#795271}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b8940ee5e08..672c47689dc1 2020-08-05 michaelludwig@google.com Replace 'master' with 'top-level' or 'gradient' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I7c7336868d9d9c968918faa74c6329696c1f7bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340343Reviewed-by:
-
Etienne Bergeron authored
Bug: 1111044 Change-Id: I4772cf9f6246a498301cb9893caccddcd3c18f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332324 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#795269}
-
Zhuoyu Qian authored
Rename SignallingReceiver to SignalingReceiver to use the same naming as the spec. Bug: 1044584 Change-Id: I43465c08d073a61f87a659d791a814a41c4c8bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336343Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#795268}
-
Brian Malcolm authored
This is intended to replace the DeviceUserWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1103816 Change-Id: Ie4cb3376ffb92c41bb7036f23e4ee9cb182c39b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339500Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#795267}
-
Thomas Lukaszewicz authored
This is a reland of 0f67189b Original change's description: > Add duration based performance metrics to Tab Search > > This CL introduces the following UMA histograms: > TabSearch.WebUI.InitialTabsRenderTime > TabSearch.WebUI.LoadCompletedTime > TabSearch.WebUI.LoadDocumentTime > TabSearch.WindowOpenDuration > > These histograms aim to measure various duration related metrics for > the Tab Search feature. See the spreadsheet below for more details: > > https://docs.google.com/spreadsheets/d/15ygVicrrbJUJOzTn6IlnogxktExXJQzZ2PCSGMQFpWg > > Bug: 1099917 > Change-Id: I9d9db7abe2554d682fb0211eceaa6a07a567ba24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321232 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793736} Bug: 1099917 Tbr: isherman@chromium.org Change-Id: Ibc45739ebe71dfbf73f0d9c4d40c367c89ab686b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334817 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795266}
-
adamta authored
Modifies standard Discover feed header to match mockups. New Discover feed header UI for when feed is hidden. Animates transition between the two states. Bug: 1085419 Change-Id: Ib300b42fd0942759ec2aea2b0d3a027d1969423a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336293 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795265}
-
David Grogan authored
The test is minimally altered from the repro in the bug. It fails when I disable FlexNG, but passes in Chrome 84 and Firefox. Fixed: 886592 Change-Id: Ieb7be3619c0095c185b405703c384864d9046cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337416 Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795264}
-
chinsenj authored
Currently if a user is previewing a wallpaper and they enter overview mode it causes a visual glitch where the overview item for the wallpaper picker is transparent. This CL makes it so Ash can emit a new event through the chrome.wallpaper_private API, onClosePreviewWallpaper, to tell the app side of wallpaper preview to close its front-end. This CL also adds the necessary handling for the new event to the wallpaper manager. Bug: 895265 Change-Id: I127fcedcfbd8c19564043910b3eac793dac46995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329414Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795263}
-
wutao authored
This patch will fix no albums shown when going to the ambientMode/photos page directly. This patch is also a preparation of new UX to show more info on the topic source radio button based on album numbers in Google Photos. There are two APIs to get all required info: GetSettings and FetchPersonalAlbums. Previously, the ambientMode page only needs data from GetSettings, but the new UX will need data from both APIs. Similarly, the ambientMode/photos page needs data retrieved from both APIs. This patch waits the data and then render the Settings UI. Bug: b/159747583, b/161928422 Test: new js unittest and new AmbientModeHandlerTest.* Change-Id: I88961ca94708563a3719f16c8745bf9cfbad489f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324180 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#795262}
-
Daniel Rubery authored
This CL profile-keys the URLLoaderContext used by the RealTimeURLLookupService so that we can use separate network contexts for these communications. Bug: 1049833 Change-Id: If6badd5b5cafd61994656f444401e73578697faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337291 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Mike Wittman authored
This is a reland of b95277ba. Test failures that caused the revert were fixed in https://crrev.com/c/2305590. Original change's description: > [Sampling profiler] Fix and test NativeUnwinderAndroid module extents > > Reuses the ModuleCache POSIX module implementation for Android ELF > modules, which fixes the incorrect start and end addresses previously > generated by AndroidModule. Renames AndroidModule to NonElfModule. > Removes tests specific to the previous implementation. > > Also includes a latent 64-bit bug fix where the register copy would > only copy half the registers. > > Bug: 1004855 > Change-Id: I3b26fac427043b2022b1d35b5c985e468ce35692 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253221 > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783689} Bug: 1004855, 1101023 Change-Id: I448044caa12375bb2957d3732d68be894ba3472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305550 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#795260}
-
- 05 Aug, 2020 21 commits
-
-
Daniel Rubery authored
This CL adds some VLOG(2) to the client side detection model loading and classification so that new models can be more easily tested. Fixed: 1113025 Change-Id: I4e007643f6783b022a291d917ca881b718d3854c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339816Reviewed-by:
-
Sanket Joshi authored
Create a new API to documents picker tests that only open the picker to validate appearance. Also fixing a bug in the color-picker-appearance-disabled.html test. For a disabled color control, it is expected that the popup will not open. Therefore, we should fail the test if the popup does open. Bug: 1111999 Change-Id: Ica4ee5ce4db46d429e3949ec53a15b52e4ea5fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333342Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#795258}
-
Yoichi Osato authored
Bug: 1007703 Change-Id: I83939762da698fe83204e88781fe3cbc9fa8998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336431Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#795257}
-
Daniel Rubery authored
This CL changes the URLLoaderFactory used by the BlocklistStateFetcher to be the one provided by |g_browser_process|. It also removes cookies from such requests, to avoid leakage of identifiers when communicating with Safe Browsing. Going forward, the Safe Browsing Network Context will only be used when the Safe Browsing cookie is needed. Bug: 1049833 Change-Id: Ie52d88b2a2353afa7c520917605b125e6ae73ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337289Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#795256}
-
Devlin authored
This reverts commit 2ce4939f. Reason for revert: Causes failure on Linux MSan https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24975 Sample failure run: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8872767911337439776/+/steps/unit_tests/0/logs/Deterministic_failure:_OmniboxViewViewsTest.BlurNeverExitsKeywordMode__status_CRASH_/0 Looks like focus_resulted_in_navigation_ isn't initialized in the ctor or class definition? Original change's description: > Log abandoned omnibox interactions. > > Introduces new metric recording outcome of every Omnibox focus event. > Logged result will allow us to monitor for increase in abandoned > interactions as we introduce new suggestion types. > > Bug: 1105156 > Change-Id: I0b12e8cfa748e6a33f1d44e96ade77bf0b39cdd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329878 > Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795155} TBR=mpearson@chromium.org,tommycli@chromium.org,tedchoc@chromium.org,ender@google.com Change-Id: Id9b64ddcfb95666c40143d129ef3dd74cd6be0b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340386Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795255}
-
Sammie Quon authored
Affects all dragging (windows, overview windows, shelf icon, app list icon, etc.). Test: ash_unittests MagnificationControllerTest.DragWindow, manual Change-Id: I7d75eef4f3707486cc5d527969d92e2a891e31a7 Fixed: 1082393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339822Reviewed-by:
-
Tina Wang authored
Add "Learn More" to enterprise info item in 3-dot menu. When users click on it, the page will be navigated to chrome://management. Bug: 1109000 Change-Id: Idf032d4402f918089a03a17d78848f644948597a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337100Reviewed-by:
-
Dominic Mazzoni authored
This is useful for local development, because the media router opens up a local port and that triggers a permission dialog on macOS. Bug: 1111418 Change-Id: I9da8167d77615bce7840ff82723260a951671eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330007Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795252}
-
Sharon Yang authored
* Handle OnAccessibilityActionRequestedCallback once action has been dispatched * Remove map because guarantees aren't provided for if actions will return. Test: AccessibilityBridgeTest.PerformDefaultAction Bug: 1111141 Change-Id: Ib8242be381f0336d312b9e205abe173636cf956e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328052Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#795251}
-
Chris Cunningham authored
Flag was added to make it mergeable to m85. m86 should just have it enabled. Bug: 1105258 Change-Id: If935e0a7027fb7433b6fda61ed7dc4ede0b6f42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333339Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ied19851f1382195e09bea1755ae93bfe7344bdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339773Reviewed-by:
-
Yicheng Li authored
In-session auth dialog controller needs a way to authenticate the user upon user interaction with the dialog. This client class is responsible for handling the authentication by talking to chromeos::ExtendedAuthenticator. Bug: b:156258540 Change-Id: Ibd0b9ddc0d8bad01580afc8d56edcb354e2ab72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337540Reviewed-by:
-
Khushal Sagar authored
R=sunnyps@chromium.org Bug: 976583 Change-Id: Ibf1de465a4094e3ce3d679552892731f3302c94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340110 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#795247}
-
Jonah Chin authored
Replace various PaintImage::GetSkImage() callers with direct PaintImage equivalents. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1031050 Change-Id: I0a673e7171c5162c58e5496662b73cd96e5072e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337677 Commit-Queue: Jonah Chin <jochin@microsoft.com> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795246}
-
Eugene But authored
This CL workarounds the crash by not installing allocator shim only on iOS 13.4. The root cause of the crash is unknown, but the crash volume is too big to ignore the problem. Bug: 1108219 Change-Id: I44ce06d216c6dc51f66ab1ba7b047e4d1a48394a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335030 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795245}
-
Li Lin authored
As we are enabling native PAC validation on the client, we will stop sending the GAIA flow URL param obfuscated_owner_id to skip PAC validation on GAIA frontend. GAIA frontend is using obfuscated_owner_id as the signal to do PAC validation. Bug: 921142 Test: Manual tests Change-Id: Icc9bb60186cc2b2299c47e72b78bd4f24d108005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338919Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795244}
-
Daniel Clark authored
I submitted a change at https://chromium-review.googlesource.com/c/chromium/src/+/2339377 to fix the mac-retina failure of this test. The test was disabled slightly after the fix went in. The test had started passing after my fix, e.g. see https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/32112 whose head commit 322be03c contained the fix but not the disable. So, re-enabling the test. TBR=masonfreed@chromium.org,rdevlin.cronin@chromium.org Bug: 1112111 Change-Id: I090525527448154493f2a74a126d1eff00f882a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339762Reviewed-by:
Dan Clark <daniec@microsoft.com> Reviewed-by:
-
Josh Nohle authored
The HTTP result enum is not needed by the HTTP client, but the HTTP result enum requires knowledge of the HTTP error enum. So, it is necessary to move the HTTP error enum out of the "client" directory, and house all HTTP enums in the "common" directory. Change-Id: I5458d892f85b4045d2407954d16ef66f447139e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333871 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#795242}
-
Wenyu Fu authored
The main workflow on how we change FRE when launching through CCT for Enterprise clients. This CL also adds some generic integration tests for basic test coverage. Once policy is ready, we'll fulfill test cases with more detail. Bug: 1106987 Change-Id: I24530156f465ca7b8729e7dee5bdfb211a0ea664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320768 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#795241}
-
Fred Mello authored
https://docs.google.com/document/d/19UDqGiQnpkdjvvWpVG8TroXNK0MmhmccU0PkozS8IT0 Bug: 1112872 Change-Id: Id492ddd4d6f645397d22c1aeb96cdd1c1b0e8197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340060Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Greg Thompson authored
DeleteTmpFileWithRetry() must pass the histogram suffix as a std::string rather than a StringPiece when posting its delayed task. BUG=1112511 R=thestig@chromium.org Change-Id: I824e90e9e32b6587154de040c0da3cb7d30c8cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339737Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795239}
-
