GitLab

As a step towards removing WebDataConsumerHandle stop using the type in
DataPipeAndDataBytesConsumer.  Instead this code can instead use
DataPipeBytesConsumer to read the mojo::DataPipe.

Bug: 894819
Change-Id: I8b8cac639441a22b4498bc064f1b7bfd929b6acf
Reviewed-on: https://chromium-review.googlesource.com/c/1323789Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606712}

https://pdfium.googlesource.com/pdfium.git/+log/760b1c16f676..aab0b516aa87


git log 760b1c16f676..aab0b516aa87 --date=short --no-merges --format='%ad %ae %s'
2018-11-09 thestig@chromium.org Move creation code out of CPDF_DocRenderData::GetTransferFunc().


Created with:
  gclient setdep -r src/third_party/pdfium@aab0b516aa87

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idc41847c3e8567b11f336610cb7688779ddc7ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1327471Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606711}

Original CL: https://crrev.com/c/1309215
Revert: https://crrev.com/c/1326490
Fix: ash/keyboard/ash_keyboard_controller_unittest.cc

This CL:
* Introduces ShowKeyboard, HideKeyboard, and IsKeyboardVisible
  to keyboard_controller.mojom.
* Includes HideReason for HideKeyboard (User or System).
* Introduces keyboard::mojom::KeyboardEnableFlag::kTemporarilyEnabled
  for temporarily enabling the keyboard and showing it.
* Renames keyboard::mojom::ReloadKeyboard() -> RebuildKeyboardIfEnabled().
* Introduces keyboard::mojom::ReloadKeyboardIfNeeded() which calls
  KeyboardUI::ReloadKeyboardIfNeeded() which updates the keyboard URL if
  it has changed and otherwise does nothing.
* Replaces direct calls to KeyboardController from most of src/chrome
  Notable exception: ChromeVirtualKeyboardDelegate which will be
  transitioned in a follow up CL.

Bug: 843332
TBR from original review:
TBR=jamescook@chromium.org, shend@chromium.org, sky@chromium.org, tsepez@chromium.org, shuchen@chromium.org

Change-Id: I33dc2d472ddad793db02c5d317f7b7405162f5fa
Reviewed-on: https://chromium-review.googlesource.com/c/1327615Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606710}

R=bokan@chromium.org

Bug: 830145
Change-Id: I672d9e13aa3118f7c121f6ab8bfef82f46a47ce8
Reviewed-on: https://chromium-review.googlesource.com/c/1327419Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606709}

To share WebWorkerFetchContext from multiple FetchContext.

This CL doesn't change the behavior.

Bug: 880027
Change-Id: I09a8eb8355c5186ffd22456400ae934f586996c2
Reviewed-on: https://chromium-review.googlesource.com/c/1198679
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606708}

The target of this CL is removing content::SWFetchRequest and use
blink::mojom::FetchAPIRequest instead. To keep a minor size of CL, the
operation is restricted in content/browser/background_fetch/. The final
goal is removing content::SWFetchRequest completely.

As a part of work of moving fetch_api_request.mojom, the roadmap is as
follow:

1. Remove content::RequestContextType. Use blink.mojom.RequestContextType
instead. --------- CL:1229704

2. Remove content::ServiceWorkerFetchRequest. Use
blink.mojom.FetchAPIRequest instead.  --------(CL:1288084 and This CL)

3. Remove blink::WebURLRequest::RequestContext. Use
blink.mojom.RequestContextType instead. --------- CL:1242301

4. Remove blink::WebServiceWorkerRequest. Use
blink.mojom.FetchAPIRequest instead.

5. Remove blink::WebReferrerPolicy. Use blink::mojom::ReferrerPolicy
instead.  --------- CL:1212345

6. Remove content::Referrer, blink::Referrer Use blink::mojom::Referrer
instead.

Once all the above tasks get done, fetch_api_request.mojom can be moved
into third_party/blink/public/mojom/fetch/.

Bug: 789854
Change-Id: I9b442b3329293b21d483f468c3b4264526104b85
Reviewed-on: https://chromium-review.googlesource.com/c/1312673
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606707}

This change allows Frame owners to opt-in to system console
logging for JS logs generated via console.log(), console.error(), etc.

Change-Id: I3a17fd6535d9b49ed676d15ab45104fa93a5a15c
Reviewed-on: https://chromium-review.googlesource.com/c/1327551
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606706}

https://chromium.googlesource.com/chromium/deps/icu.git/+log/834113a..45f655f

45f655f Cherry-pick: UnicodeSet performance enhancement
d2afb05 Delete another empty block after trim data

TBR=ftang@chromium.org,gsathya@chromium.org

Bug: 899983,901532,v8:8414
Test: Android webview start-up perf
Test: v8: intl/regress-8414.js
Change-Id: Ibc3e84fb26c4b3a158823e9ce6cee709b3161da7
Reviewed-on: https://chromium-review.googlesource.com/c/1325564
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606705}

- document the test helpers and their test steps.
- change share() and manage(): use more specific names.
- in the share test: wait for the file/directory entry to
  be selected before proceeding to the next step.
- in the share test: wait for share menu to close before
  trying to get the browser URL to avoid flakes.

Bug: 903587
Change-Id: I666b6c828e348a41b6053b54b6094d04fb3b9def
Reviewed-on: https://chromium-review.googlesource.com/c/1328082Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606704}

Update build_cmd_buffer_lib.py to support multiple size-specifying args.
The existing code gen which assumes a single "data" argument with a final
argument specifying the number of bytes does not work for functions that
require multiple arrays of data.
This change is necesary for the GL_ANGLE_multi_draw extension
which adds entrypoints with multiple array arguments.

Bug: chromium:890539
Change-Id: I54c208e5592a1a06c90707536d90742e745eb7b7
Reviewed-on: https://chromium-review.googlesource.com/c/1297716Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606703}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/511e861d..c465c5ea

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib1b4da4a8f66a31628e052c672a99b3c4b23b8e3
Reviewed-on: https://chromium-review.googlesource.com/c/1327576Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606702}

Some Pedals need to be filtered by application state regardless
of whether a query suggestion triggers the Pedal suggestion, and
to do this requires a context that can inform the Pedal system
during autocomplete time (as opposed to the later execution time).
AutocompleteClientProvider is the abstract base class for this purpose,
and works well, so it is used by this CL for the first instance
of Pedal filtering: the UpdateChrome Pedal is filtered when no
update is ready.

Bug: 893183
Change-Id: I3344b26600188c0c952ea81dba1e90a6b4133318
Reviewed-on: https://chromium-review.googlesource.com/c/1297587
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606701}

Improve debugging in the future so we don't have to keep asking "are you
using a smartcard? which?".

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ifbaf6f5aa0aa73dcd19be0ccc0046c2c2c069319
Reviewed-on: https://chromium-review.googlesource.com/c/1292509
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606700}

Bug: 890972
Change-Id: Ic8efd5bc2d51a9173f717ff68dbe64f53c720b9d
Reviewed-on: https://chromium-review.googlesource.com/c/1315536
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606699}

Change line brekaing in LayoutNG to create ShapeResultView instances for
each line where the view shares the underlying glyph information structs
with the shape result for the paragraph. Previously that information was
copied instead. Avoiding the copy reduces memory usage and improves perf
by up to 25% for the inline blink_perf.layout benchmarks cross-platform.

To speed up bounding box computation for lines the left and right bounds
for each glyph is retained as part of the HarfBuzzRunGlyphData struct in
ShapeResult::RunInfo. This increases the size by 32-bits per glyph which
is more than offset by the memory reduction from sharing RunInfo objects
for LayoutNG. For legacy layout the impact of the increase is minimal as
the number of individual ShapeResults is kept low due to the word cache.

Bug: 900015
Test: renderer/platform/fonts/shaping/shaping_line_breaker_test.cc
Change-Id: Ia7c7d72bc1804d8302d26d09a846c4440faef90f
Reviewed-on: https://chromium-review.googlesource.com/c/1313831
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606698}

WeakPtrFactory::GetWeakPtr is not thread-safe, but SharedImageInterface
is expected to be called from multiple threads (without locks). Instead,
grab a single WeakPtr for the GPU thread at construction time. It's more
efficient anyway.

Bug: 870116
Change-Id: Ie550b788a4569e0ff8ed62a690e21ae52e0a1e0c
Reviewed-on: https://chromium-review.googlesource.com/c/1325566Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606697}

This caused issues in cases where we skip caches,
have special paint paths, and culling in the presence
of non-composited overflow clipping.

There are still optimizations for absence of paint
phases generally. This CL just removes ones where
we detect "empty" by means of no change to the
display list.

Bug: 898995, 901302

Change-Id: Ib3f79a615c88d0e97f4c9cec78056bf00e1358c6
Reviewed-on: https://chromium-review.googlesource.com/c/1320972
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606696}

The receiver callback is required to process browser process profiles.

Bug: 851163
Change-Id: I1477d7e4fa40d72fc97621ed463e5d8c0b84921a
Reviewed-on: https://chromium-review.googlesource.com/c/1327802Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606695}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6ad2f38573b..af8c416e43c0


Created with:
  gclient setdep -r src-internal@af8c416e43c0

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ibd0d7dbe00bad5e0df3cf4b07bad5ba245c98160
Reviewed-on: https://chromium-review.googlesource.com/c/1328001Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606694}

This reverts commit d0392055.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 606686 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QwMzkyMDU1ZDg3YWJjYjNiMzExY2Y4YjRkNmE4ZmU5YjFkYzA1NzgM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-rel/9945

Sample Failed Step: compile

Original change's description:
> fido/win: build Windows WebAuthn API integration unconditionally
> 
> This makes fido/win include webauthn.h from
> //third_party/microsoft_webauthn and drops the USE_WIN_WEBAUTHN_API
> build flag we previously added due to the missing header file.
> 
> The implementation remains behind a default-off feature flag.
> 
> Bug: 898718
> Change-Id: I45e100f8b10cc32ea7e32d2842a63c950b5965bb
> Reviewed-on: https://chromium-review.googlesource.com/c/1325074
> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606686}

Change-Id: I53414fbe41280dbcb7a753599c946f5ef5ebd4ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898718
Reviewed-on: https://chromium-review.googlesource.com/c/1328223
Cr-Commit-Position: refs/heads/master@{#606693}

BUG=903590

Change-Id: Ie7472e49e10f65193706e4483082ebbfc054efcc
Reviewed-on: https://chromium-review.googlesource.com/c/1327572
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606692}

Missed a check in the save-failed path. Fortunately saves fail
less than .01% of the time.

Also some tiny cleanups.

BUG=902233
TEST=new unit test

Change-Id: I26f233245cc2c78ee092befb453d18df539fd125
Reviewed-on: https://chromium-review.googlesource.com/c/1327577Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606691}

Using wpt-import in Chromium 85f78938.
With Chromium commits locally applied on WPT:
270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-scoping
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I33a1812e9621cbab43a6f5534d1421c7574d6939
Reviewed-on: https://chromium-review.googlesource.com/c/1327570
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606690}

This CL adds resource load priority tests ensuring that the priority of
requests that pass through a Service Worker is preserved.

R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org

Bug: 872776
Change-Id: I74f334359b3255fcac5c13fbdb9f1e601af0f8f0
Reviewed-on: https://chromium-review.googlesource.com/c/1316104
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606689}

Also ensure that JS type checking runs on non-ChromeOS. It was erroneously
running on ChromeOS only.

Bug: 902959
Change-Id: Ibd67a276325ac1e4461509341f6a198e27e9dabe
Reviewed-on: https://chromium-review.googlesource.com/c/1327420
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606688}

1) The Home Launcher used to use the wrong display ID when in
   Unified Desktop mode.
2) If (1) is fixed, we hit https://crbug.com/902601. The captive
   portal dialog widget used to be leaked and never destroyed.
3) If (2) is fixed, we crash on the first attempt to press the
   app list button. The reason is tablet mode triggers a switch
   to mirror mode. This switch happens asynchronously after the
   Home Launcher had already been created. Switching from Unified
   to mirror mode destroys the Unified host and the Home Launcher.
   That's why we need to ensure that the Home Launcher is
   recreated.

BUG=900956, 902601
TEST=Added a test that crashes without the fix.

Change-Id: If6eb9c2255dfa9d442aa115a3274db2d8a4110d7
Reviewed-on: https://chromium-review.googlesource.com/c/1325389
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606687}

This makes fido/win include webauthn.h from
//third_party/microsoft_webauthn and drops the USE_WIN_WEBAUTHN_API
build flag we previously added due to the missing header file.

The implementation remains behind a default-off feature flag.

Bug: 898718
Change-Id: I45e100f8b10cc32ea7e32d2842a63c950b5965bb
Reviewed-on: https://chromium-review.googlesource.com/c/1325074
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606686}

- Add new files to corpus that cover additional zip features
- Cover additional functions

BUG=900749

Change-Id: I0cd8b41112035b1ba95ab11155c67aeb8fded29f
Reviewed-on: https://chromium-review.googlesource.com/c/1325572Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606685}

Bug: 889029
Change-Id: Ia8ab74329953568bda37a324cc3a9b477acf732e
Reviewed-on: https://chromium-review.googlesource.com/c/1327548
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606684}

Bug: 877109
Change-Id: I1ef50be0c151c691825174c8ff3bbcba5ce17a10
Reviewed-on: https://chromium-review.googlesource.com/c/1323619Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606683}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I0dbad4a299ae4ce3be3696da7703822d87d151d5
Reviewed-on: https://chromium-review.googlesource.com/c/1325288Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#606682}

With https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949,
WebMediaPlayer blindly treats a resource experiencing cross-origin
redirects as TAINTED. In fact, it should be treated as TAINTED only
when its request mode is "no-cors".

The added tests are provided by hongchan@chromium.org.

Bug: 899745, 901383
Change-Id: Idb66407552085b053818f3e4a9d8d5ff3ddeaf45
Reviewed-on: https://chromium-review.googlesource.com/c/1325281Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606681}

The Crostini Installer spec uses a mascot icon without a background rather than
the version with the background circle and shadow.

This adds the mascot for use in the WebUI Installer.

Bug: 867117
Change-Id: Id56d65c625e86f085e43d067b89395fa669c7012
Reviewed-on: https://chromium-review.googlesource.com/c/1319393Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Josh Pratt <jopra@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606680}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/458e9fd3f8e8..81f7d1dd5fa4

$ git log 458e9fd3f..81f7d1dd5 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 dalecurtis Drop function: prefix in x86util.asm for macOS ffmpeg builds.
2018-11-08 dalecurtis Cleanup a few remaining yasm references in ffmpeg.
2018-11-02 dalecurtis Switch ffmpeg to using nasm for compilation.
2018-10-17 jeremya set install_name on mac when is_component_ffmpeg && !is_component_build
2018-10-16 vtsyrklevich CFI: Disable cfi-icall for ffmpeg component build
2018-10-02 liberato Group gn configs and gn config changes summary into one commit.
2018-10-02 liberato Cleanup of robosushi.py and robo_branch.py .

Created with:
  roll-dep src/third_party/ffmpeg

R=chcunningham

Bug: 766721
Change-Id: Ic513abcd66ca725b29dd9a745b5b93dd5b99ae26
Reviewed-on: https://chromium-review.googlesource.com/c/1327153
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606679}

Also use the correct button height const to reflect a recent change.

Bug: 881923
Change-Id: I2553c3d8d891a25b981edce8f0578e516d7ebe43
Reviewed-on: https://chromium-review.googlesource.com/c/1327557Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606678}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa347dd67ba1..a6ad2f38573b


Created with:
  gclient setdep -r src-internal@a6ad2f38573b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib1bb8314374ae1eccd690015b8b8cdebb607b696
Reviewed-on: https://chromium-review.googlesource.com/c/1327727Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606677}

While I was investigating traces I noticed that some trace events
in ServiceWorkerSubresourceLoader have the same IDs even for
different resource loading. This is probably because different
instances of ServiceWorkerSubresourceLoader are happend to be
allocated in the same address. These events are not overlapped
so this isn't a critical problem but it makes difficult to
analyze traces. Use resource_id_ as the trace event id to make
analyzing traces easy.

Change-Id: I6718bdc82d3aba1df422dbbbcbe3b4f1b06ca8cb
Bug: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/1325283Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606676}

Bug: 874296
Change-Id: I233cda30e59b696bc6960f1e7366cbee62849bed
Reviewed-on: https://chromium-review.googlesource.com/c/1325011
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606675}

Removed the pointer cursor and focus state when the checkbox is
disabled.  This should prevent the checkbox from maintaining any
unnecessary focus as well as preventing any confusion when hovering
over the overwrite changes checkbox.

Bug: 888464
Change-Id: I14547deb878f2948e5606f3bf0bbc01b9ba75886
Reviewed-on: https://chromium-review.googlesource.com/c/1318062Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606674}

Increase the default snackbar duration to 10s when accessibility
mode is on. Also make SnackbarManager to double the custom
duration automatically when accessibility mode is on.

Bug: 699160
Change-Id: If3762db7eea56eed614ce15ff69a6591c7ae7706
Reviewed-on: https://chromium-review.googlesource.com/c/1327330Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606673}