- 23 Aug, 2018 40 commits
-
-
Javier Ernesto Flores Robles authored
Enable bouncing in autofill suggestions scrollview. Bug: 876657 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8bbb27c6c2d567bc41e4931a85cefb97453030c3 Reviewed-on: https://chromium-review.googlesource.com/1184716Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585430}
-
Sylvain Defresne authored
AccountTrackerService only uses the PrefService from SigninClient. Remove the dependency on SigninClient by passing the PrefService to the service instead. The dependency on SigninClient was introduced to allow access to a URLRequestContext to download some images, but since they are downloaded by the AccountFetcherService, it is no longer necessary to depend on SigninClient. TBR=rkc Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd4c0fabe37431fec97c275d6529b30d8da9f2f9 Reviewed-on: https://chromium-review.googlesource.com/1161908 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#585429}
-
Pavol Marko authored
Mark policy-provided certificates using a policy indicator on the certificates UI (chrome://settings/certificates). UI Preview: https://screenshot.googleplex.com/fnM5QZLjBe5 Bug: 859950, 787602 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iad7bf5e5862bb2a5965db65302e10fe8bb14735f Reviewed-on: https://chromium-review.googlesource.com/1124853 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585428}
-
Stephane Zermatten authored
Extend the AssistantScriptExecutor to store the result of processing action, successful or not, and report it to the server, which then decides what new actions to execute. A notable change is the switch from passing to the actions exactly the data they need from passing the original action proto, as the original action proto is necessary anyways to generate a proper result proto. This also adds a unit test for the script executor and fix some, but not all, incompatibilities between the protos defined in assistant.proto and those on the server. Change-Id: I190768fb97399daaf347acac762c6ecbb5fe7cad Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1179894 Commit-Queue: Stephane Zermatten <szermatt@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585427}
-
Sylvain Defresne authored
ProfileDownloader::GetProfilePictureURL returns a std::string corresponding to the representation of a GURL then immediately converts it back to a GURL. This is wasteful, so convert this method to return a GURL instead and convert GetCachedPictureURL to also cache the GURL instead of the string representation. Convert static std::string to static char[] and use EXPECT_ instead of ASSERT_ macros when possible in unit tests (since the EXPECT_ macro do not stop the test in case of failure). Bug: none Change-Id: Ibe73f28b38b2061b37cbdb0b9b0696b25ca8c41c Reviewed-on: https://chromium-review.googlesource.com/1160645 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
As a preparation for stopping evaluating scripts moved between Documents. Bug: 721914 Change-Id: I611d4474f487f22ca8a1c18ec4d0fc6e90d83fad Reviewed-on: https://chromium-review.googlesource.com/1180800 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#585425}
-
Rayan Kanso authored
This will use the same permission model for downloads (only framed contexts) when a fetch is started. The permission will be checked every time a fetch starts (in the browser process) to prevent race conditions. Bug: 692647 Change-Id: Id67682cadaec3c0669d4308ac69e60447353a4e8 Reviewed-on: https://chromium-review.googlesource.com/1178281Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585424}
-
Hayato Ito authored
This reverts commit 32c8ebbe. Reason for revert: [sheriff] This might be a culprit for consistent failures [4 out of the last 4 builds] of telemetry_perf_unittests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29 Started at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/73930 Original change's description: > Enable Perfetto by default for all telemetry tests > > This will use Perfetto instead of TraceLog for all > trace-based Telemetry tests running on Mac/Windows/Android. > > R=nednguyen@google.com > > Bug: 839084 > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01 > Reviewed-on: https://chromium-review.googlesource.com/1176119 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#585368} TBR=oysteine@chromium.org,skyostil@chromium.org,nednguyen@google.com Change-Id: I162f26045f454c23eae1b99af5b3168c7f7b9e44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839084 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Reviewed-on: https://chromium-review.googlesource.com/1186301Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585423}
-
Alex Lau authored
This updates the file manager app icon as part of a revamp of existing system app icons. See the bug for details. Bug: 826002 Test: Manually tested on chromium build. Observed new icon in both the task bar and in the app drawer. Change-Id: I1074f4da9e3bd40aed7fe3cd26c2f29b863bd1d4 Reviewed-on: https://chromium-review.googlesource.com/1182903 Commit-Queue: Alex Lau <alexlau@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#585422}
-
Hayato Ito authored
TBR=davidben@chromium.org BUG: 876954 Change-Id: Ic06cbe4edc478ffe338ce533277d604732a890e5 Reviewed-on: https://chromium-review.googlesource.com/1186216Reviewed-by:
-
BUG=762641 TBR=jennyz@google.com Change-Id: I01987c6d906d33479c54152ce2feb3dfc7aeb382 Reviewed-on: https://chromium-review.googlesource.com/1186197Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585420}
-
Simon Zünd authored
The following CL changed how Array.p.sort works in JS: http://crrev.com/c/1151199 This broke some file manager tests. The reason is a broken comparison function when sorting the volumes for the tests. JS needs a comparsion function that returns < 0,0 or > 0 if a value is less than, equal to or greater than another one respectively. This CL fixes that. R=joelhockey@chromium.org Change-Id: I08c4ebf352d3e8ec984239edd01f39eac261e576 Reviewed-on: https://chromium-review.googlesource.com/1184848Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#585419}
-
Mike Wasserman authored
TODO: Get the keyboard to close when closing the KSV window. Bug: 876589 Test: a11y virtual keyboard shows on second KSV textfield click. Change-Id: I57a09acb9cf8b784a9c40763028c4733dd43d474 Reviewed-on: https://chromium-review.googlesource.com/1185736 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585418}
-
Kyoko Muto authored
For the help of 'supportting slot change event', this CL add crash test in the case of removing a slot after another slot's removal. Bug: 869308 Change-Id: I27ae390bc7ea051eae8b33fa68ad85319311113f Reviewed-on: https://chromium-review.googlesource.com/1186203Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
jchen10 authored
Remove the it from the expectation. Bug: 640389 Change-Id: Id90ed5c40069fe36710782fe440b385a2b1e69e3 Reviewed-on: https://chromium-review.googlesource.com/1174102Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#585416}
-
John Z Wu authored
iOS javascript command 'translate.ready' should only be handled the very first time translation is attempted for each page. Bug: 869729 Change-Id: I66ff19539ad42daa107c16443a15930bf6835510 Reviewed-on: https://chromium-review.googlesource.com/1183791Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#585415}
-
Giovanni Ortuño Urquidi authored
Adds a new policy that allows admins to install apps based on a provided URL and a launch container. The URL will be loaded in the background and a Bookmark App will be created based on the loaded content. Bug: 844278 Change-Id: I2ff89f7b39051de637bacab92286c9bdda69fdbf Reviewed-on: https://chromium-review.googlesource.com/1107026 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585414}
-
Hayato Ito authored
This reverts commit 86ba94de. Reason for revert: Compile failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/1338 log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8937424896625406016/+/steps/compile/0/stdout In file included from gen\chrome/chrome_cleaner/interfaces/pup.mojom-blink.h:25: ../..\mojo/public/cpp/bindings/struct_ptr.h(96,18): error: no member named 'Hash' in 'chrome_cleaner::mojom::blink::FilePath' return ptr_->Hash(seed); Original change's description: > Add chrome_cleaner/json_parser > > This does not use services/data_decoder because it's closely tied to > the service manager, which chrome_cleaner does not support. > > R=csharp > > Bug: 830892 > Change-Id: Ia3138624c9d723916fdf1ba174c89cbcc6e71401 > Reviewed-on: https://chromium-review.googlesource.com/1180349 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585408} TBR=csharp@chromium.org,tsepez@chromium.org,joenotcharles@chromium.org Change-Id: I10a119dfbdbc34ba06ad3d5c3d18ef4a8a5d09a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830892 Reviewed-on: https://chromium-review.googlesource.com/1186241Reviewed-by:
-
Hitoshi Yoshida authored
Before this CL, we did not check if a passed value for `object' argument is actually v8::Object. It could trigger null references in case non-Object values are passed into the arguments. (non-Object values are taken as null objects in Blink.) This CL adds a validation to check if the passed value is a v8::Object or not when a non-null value is passed into an `object` argument. Bug: 876608 Change-Id: Iedb35a3deee781ac4bbaddc0afcc8e7c25f0c6eb Reviewed-on: https://chromium-review.googlesource.com/1184593Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#585412}
-
Pavol Marko authored
Refactor CertificateManagerModel to internally use one or more "CertsSource"s to retrieve certificates to be listed. The main "CertsSource" is tied to the user's NSSCertDatabase. On Chrome OS, there are additionaly PolicyCertsSource and ExtensionCertsSource, which list certificates provided by user policy and extensions, respectively. There is a pre-defined priority handling: PolicyCertsSource > PlatformCertsSourceNSS > ExtensionCertsSource. This means that if e.g. a CA certificate is provided by policy and is also present in the user's NSS Database, the certificate manager will display the policy version (e.g. the cert will not be deletable, trust settings can not be changed). BUG: 787602,720159 Test: unit_tests --gtest_filter=*CertificateManagerModel* Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I73ff91070b1362afee37bff2413fb56cf4bc06ae Reviewed-on: https://chromium-review.googlesource.com/916681 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585411}
-
Anand K. Mistry authored
A lazy unmount detaches the mount point immediately. Existing file accesses will continue, but any new accesses will fail. For read-only mounts, we do this because there are no changes to sync back to the volume and therefore it is ok if the volume is removed without waiting for the unmount. Note, this doesn't take into account the safety of removing media that should be "safely removed", such as hard disks. BUG=789562,680903 Change-Id: I4dca06f825d5f3b4012bafa9a43e05bfe6455d23 Reviewed-on: https://chromium-review.googlesource.com/1184645Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0ec9d15571fb..81db1d50324a git log 0ec9d15571fb..81db1d50324a --date=short --no-merges --format='%ad %ae %s' 2018-08-23 tandrii@chromium.org git cl: cache GetRemoteUrl result. Created with: gclient setdep -r src/third_party/depot_tools@81db1d50324a The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876910 TBR=agable@chromium.org Change-Id: Ied55cf608667a6b638e4a7d8c990ba4e2613e834 Reviewed-on: https://chromium-review.googlesource.com/1185697Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585409}
-
Joe Mason authored
This does not use services/data_decoder because it's closely tied to the service manager, which chrome_cleaner does not support. R=csharp Bug: 830892 Change-Id: Ia3138624c9d723916fdf1ba174c89cbcc6e71401 Reviewed-on: https://chromium-review.googlesource.com/1180349Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Hayato Ito authored
TBR=dvadym@chromium.org BUG: 876954 Change-Id: Id8c8994dbb3c17abdaec0e3136ce825ea9d9c20b Reviewed-on: https://chromium-review.googlesource.com/1186205Reviewed-by:
-
Lei Zhang authored
PrintHostMsg_DidPreviewDocument_Params's modifiable field is never read. Change-Id: Ibea82ef12c9faf625719a65db2f31a449c2481c6 Reviewed-on: https://chromium-review.googlesource.com/1184504 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Joe Mason authored
R=csharp Bug: 830892 Change-Id: I8af09ba27cbc35d7bff39f4b7b6a9c972f1afc0d Reviewed-on: https://chromium-review.googlesource.com/1175202 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Sam McNally authored
Bug: 874314 Change-Id: I214166c74e78eed59eb6bda0ac0bcdf1992daa3c Reviewed-on: https://chromium-review.googlesource.com/1186020Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585404}
-
John Chen authored
Updated ChromeDriver W3C standard complaince document based on the latest information. In particular: * Removed resolved issue chromedriver:1500 (Accept/Dismiss Alert) * Removed resolved issue chromedriver:1990 (Close Window) * Added new issue chromedriver:2552 (error text) * Added new issue chromedriver:2537 (New Session) * Added new issue chromedriver:2398 and issue chromedriver:2556 (Execute Script and Execute Async Script) Change-Id: I0b1c875e6c4463b4a6ad0e42c0206425bdc2859d Reviewed-on: https://chromium-review.googlesource.com/1186187Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#585403}
-
Karan Bhatia authored
This CL implements versioning for indexed ruleset format. The indexed ruleset is now prefixed with a version header. On loading an extension, if Chrome detects a version mismatch between the current ruleset format version used by Chrome and the one used in the extension ruleset, the extension ruleset will be reindexed. This is necessary to support making breaking changes to the flatbuffer schema used for extension indexed rulesets. BUG=755717 Change-Id: I7e3947a15e66b556c864d1031899bfbe9702dfc5 Reviewed-on: https://chromium-review.googlesource.com/1152872 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585402}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d95dde6e066f..2229a8947448 git log d95dde6e066f..2229a8947448 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 simonhatch@chromium.org Dashboard - Failing with missing GetMostRecentValuesByNames Created with: gclient setdep -r src/third_party/catapult@2229a8947448 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:876952 TBR=sullivan@chromium.org Change-Id: I4102306b909705cf1d44f17429826934c7c000fc Reviewed-on: https://chromium-review.googlesource.com/1185695Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585401}
-
Ramin Halavati authored
Priniting preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I1e54ac665c125aa50ce5c7a3b277c559bdd78e1d Reviewed-on: https://chromium-review.googlesource.com/1179149Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585400}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ac87d4472f6..5953a476d9f7 git log 9ac87d4472f6..5953a476d9f7 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 brianosman@google.com Revert "Add support for unpremul image sources in the GPU backend" 2018-08-23 brianosman@google.com Revert "Stop conflating F16 with linear gamma" Created with: gclient setdep -r src/third_party/skia@5953a476d9f7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ibff94790b76090a7dfa2caeb8dc8cc317cd6619c Reviewed-on: https://chromium-review.googlesource.com/1185696Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585399}
-
Makoto Shimazu authored
This CL is to reflect kURLLoadOptionSniffMimeType when making ResourceHandlers. If there is no option to request mime sniffing, it won't create MimeSniffingResourceHandler. ServiceWorkerNewScriptLoader removes the mime sniffing option, so requests for service worker scripts can skip mime sniffing in RDHI. Context of this CL: Before NetS13nServiceWorker, network requests for service worker scripts is handled by ServiceWorkerWriteToCacheJob, and it rejects responses without mime type. It results in network error and none of ResourceHandlers handle the response. After NetS13nServiceWorker, network requests coming from the renderer reach ServiceWorkerNewScriptLoader first, and eventually they are routed to ResourceDispatcherHostImpl. It means that ResourceDispatcherHostImpl works as usual and MimeSniffingResourceHandler in RDHI handles the response. This CL helps to avoid the script response is handled by MimeSniffingResourceHandler. Bug: 871654 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia7c7885157029be16a3a4669cf204ac85232f1b6 Reviewed-on: https://chromium-review.googlesource.com/1179482Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585398}
-
Mythri Alle authored
Add support in blink::Platform and RenderMessageFilter to clear the code cache entry. Bug: chromium:812168 Change-Id: Ida83f17443f70d1cfbc83236f08628f0820a5cf7 Reviewed-on: https://chromium-review.googlesource.com/1160234 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Wez authored
Bug: 864351 Change-Id: Ifd04d1b7b48f80184122713850a823b8b2c15da2 Reviewed-on: https://chromium-review.googlesource.com/1185879Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#585396}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/81e0830e6734..ee0c9aa66269 git log 81e0830e6734..ee0c9aa66269 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 tsepez@chromium.org Use UnownedPtr<> in CXFA_RenderContext. 2018-08-22 hnakashima@chromium.org Remove m_currentRow from the state of CBC_BarcodeMatrix. Created with: gclient setdep -r src/third_party/pdfium@ee0c9aa66269 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib955725ef7ecbbd96cf2b959de54ba2597f71052 Reviewed-on: https://chromium-review.googlesource.com/1185603Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585395}
-
Timothy Gu authored
A few checks were moved from open() to open(Document*, ScriptState&) to conform to the order of execution laid out by the HTML Standard. Web Platform Tests were added to ensure the fixes stick. In particular, this ensures there is no side effects in a document.open() call that bailed early. Document::SetContent() is amended so that write() and close() are not called if open() bails out early. Comments were added for better correspondence with the specification. Bug: 866274, 875735 Change-Id: I14badd991bb723254f8889ba4073aff19126c7ba Reviewed-on: https://chromium-review.googlesource.com/1182370Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 870202 Change-Id: Iaa3c6ebcfc62636a7343b2d0720aaef710a60208 Reviewed-on: https://chromium-review.googlesource.com/1176586 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585393}
-
Weilun Shi authored
When open the dialog, the whole page is considered as the dialog. The default behavior of the arrow key on the scrollable page is to scroll the page. Adding preventDefault to each option and the dialog itself can prevent such behavior. Screencast: https://screencast.googleplex.com/cast/NTQ0OTg2NjI0MzIxMTI2NHxhYzQzMTRiYi01MA Bug: 870268 Change-Id: I5c3f92e6d2e9faaff704e053c0e9540f028ebed5 Reviewed-on: https://chromium-review.googlesource.com/1186073Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#585392}
-
Noel Gordon authored
Stop using navigateWithDirectoryTree in createNewFolder helper (return value unchecked, generally false if checked). All tests navigate the directory tree during test setup by clicking on subtree's expand icon. However, the createFolderNestedDownloads() test needs to do an extra step to navigate into sub-tree 'photos'. Since it is the only test that needs this extra step, navigateWithDirectoryTree can be used to do it, with a post-verify step to check that #file-list updated to the expected visual state (no files shown). Change createNewFolder API: navigateWithDirectoryTree gone so path etc can go. Add a tree |selector| argument so createNewFolder can check if that folders appear in the directory tree. Update the createNewFolder internals: focus the file list, use precise #file-list selectors when checking for [selected] [renaming] row, more checks to confirm that only one file-list row is [selected] [renaming] namely the New Folder entry, and verify the New Folder is "present" in directory tree HTML content. After the new folder is renamed, verify that its name is shown in file list and also in the directory tree. Finally, fully test the file-list selection state at the end of the test (the long way). Bug: 876267 Change-Id: I8693bdc43b95a4c3b510633697fa4b3d85e08051 Reviewed-on: https://chromium-review.googlesource.com/1186008Reviewed-by:
-
