- 21 Nov, 2020 4 commits
-
-
Matt Menke authored
Instead, use the shiny new one that takes net::SchemefulSites instead of url::Origins. Bug: 1145294 Change-Id: Id552fdb5f7711c5835d2551d5851d01d111c8b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545484Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829872}
-
Curt Clemens authored
Instead of a generic failure message, show a specific error string that depends on the TransferMetadata::Status. Change-Id: I86b6549c4f6de0477f9a63ef71f9298796f10065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551078Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#829871}
-
Daniel Cheng authored
This ensures that the speculative RFH is deleted even when it is already ready to commit and has sent a CommitNavigation() IPC to the renderer. Bug: 838348 Change-Id: Id834274219c3f8b4d837cce2a3d54148e938a0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536794 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#829870}
-
Xianzhu Wang authored
This reverts commit 6b916224. Reason for revert: Caused crbug.com/1150781. Original change's description: > Check Layer::SafeOpaqueBackgroundColor() is opaque when contents_opaque() > > Bug: 936906 > Change-Id: Ibbb8fad9bd4680a91e0a595e10db9b752c1450a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538330 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828829} TBR=wangxianzhu@chromium.org,vmpstr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 936906, 1150781 Change-Id: I6a880b97b48a5842ef00008d6ac75c00731024b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552986Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829869}
-
- 20 Nov, 2020 36 commits
-
-
Haiyang Pan authored
If it runs fine, it will be removed from MM-arm64-rel & MM-x86-rel-non-cq, and run on MM-x86-rel formally. Bug: 1127110 Change-Id: I55bdfece736a2ce00864be4b42e2ee1df1a6b777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552676Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#829868}
-
Christoph Schwering authored
Bug: 1142413, 1150277 Change-Id: I19a5f90933e5da7e9d2ea79e7c1fff7c48002cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550383Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#829867}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2340291. After that change went in, we are still seeing crashes in BrowserAccessibility::AccessibilityPerformAction where the anchor and/or focus nodes are not found, stemming from setSelectionRanges. Based on code inspection, I was able to come up with this variation, where the anchor and focus nodes are in the same tree as each other, but in a different tree than the caller. The crash dumps I have available not have enough data to prove that this is the root cause of those specific crashes, but the unit test added here is sufficient to show that this crash is possible. Rather than returning an error in this scenario, when the anchor and focus nodes are in in the same tree as each other, but a different tree than the node calling setSelectionRanges, the tree that the anchor and focus nodes reside in is used for looking up the manager and setting the selection. AX-Relnotes: n/a Bug: 1110522 Change-Id: I28cb18e87bcd0cfa2abd3220878d4b04ac70f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504630 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829866}
-
Dan Sanders authored
Without access to the shared main thread context, VideoFrame.createImageBitmap() is unable to handle texture-backed frames. This CL does not fix the issue, but it does change it from a check failure to a DOMException. Bug: 1148849 Change-Id: I3f8c292022dc3cb8fd6625591d2384511e253ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552901 Commit-Queue: Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#829865}
-
Rakib M. Hasan authored
Bug: 1041619 Change-Id: I530267388d8409f7e5c3e0f3a087e1fa5784607b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551674 Auto-Submit: Rakib Hasan <rmhasan@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#829864}
-
Josh Nohle authored
Upload the user's contact list and allowlist to the Nearby Share server every 24 hours to ensure that the server has the information needed to distribute certificates. This upload supplements the current strategy of uploading contacts whenever the contact list or allowlist changes. This ensures that, if the device record is removed from the Nearby Share database--after 9 days of inactivity, for example--the client will resend the contact list even if the contact list has not changed. Manually tested and verified. Fixed: 1151498 Change-Id: I9d4669ff1bafc3ac22c385cc8ef4aaf6f9dc355b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553035 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#829863}
-
Joe Downing authored
This CL adds the class which logs any ETW events received to the Windows event log. Bug: 1144185 Change-Id: I3972e2c5ef91ace511f5bebfa41fa00ff68ac521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545564 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#829862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/108b4ee97ef9..a08962107ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbansal@google.com,waffles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150459 Tbr: tbansal@google.com,waffles@google.com Change-Id: Ie8f08aad9287c6452ddebfcfbb98e17a944773d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829861}
-
Olivier Yiptong authored
This implements the content interface for embedders to enumerate fonts in the upcoming chooser UI, which can be found at https://crrev.com/c/2543603. Bug: 1138621 Change-Id: Iae647eb04417a865590595b8bb1b1f1e1e3a3c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531180Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829860}
-
Chris Palmer authored
Also fix a bug: `PCHECK` may itself allocate, creating re-entrancy problems, so we can't use it as a way to learn the `errno`. Instead, create a `PA_PCHECK` macro that uses `base::debug::Alias`. Bug: None Change-Id: Ic17e7c09d620e8f1f38da8b64a45fbfeeeac3b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546084 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829859}
-
Ken Rockot authored
Upstream Chromium no longer uses an InterfaceProvider to expose browser interfaces to render frames. Cast Shell still does this for a small handful of interfaces registered by downstream internal-only logic. In order to support the transition of the internal repository away from this mechanism, this CL introduces a bit of redundancy: interfaces registered with CastWebContents through either of its two registration mechanisms will now be exposed to *both* InterfaceProvider consumers as well as BrowserInterfaceBroker. Once this lands, internal renderer code can simply be rewritten to use RenderFrame::GetBrowserInterfaceBroker instead of RenderFrame::GetRemoteInterfaces(), and then upstream Chromium can completely remove all its gnarly support for a browser-exposed InterfaceProvider. Bug: 977637 Change-Id: I21ae1fc31b35b0ca77ab2a00645feafe0ac67a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547054Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#829858}
-
Garrett Beaty authored
This will reduce the amount of manual change that must be made when updating configuration for a branch and put more values inline in the config. Change-Id: I033beff961f1d88a30795e12ca7f784abd0c331a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551668 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#829857}
-
Jimmy Gong authored
cr-card-radio-button does not properly implement the paper-ripple effect and as a result the paper-ripple effect is at the root of the document. This results in a ripple effect to appear in the top left of the page. More details in the attached bug. Bug: 1150617 Fixed: 1148515 Change-Id: I60363c440f792d24f4b7e5957e89f156906164ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548366Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829856}
-
Maria Kazinova authored
Unlike login forms, change password forms are often kept on page after successful submission. This CL allows to detect submission for change password forms that are cleared field by field with HTMLInputElement::SetValue(), by setting an empty value. Bug: 1149948, 1147363 Change-Id: Ia5d8e27f91b4a9e36784517e87fff41167551ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537697 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#829855}
-
Andrew Xu authored
This CL is a part of the efforts to create multipaste menu items for copied files. This CL does the following jobs: (1) Create a new type for `ClipboardHistoryDisplayFormat` called `kFile`. (2) Move the code related to the text label out of ClipboardHistoryText- ItemView. Instead, create `ClipboardHistoryLabel` for the text label used by the multipaste menu. Right now a `ClipboardHistoryTextItemView` instance is built for a clipboard data whose display format is `kFile`. So this CL does not introduce any visual difference. Bug: 1134392 Change-Id: I7fb4b9ce5d37fcd298b5cfefcd9dcee0ad160c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547225 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#829854}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7a005c70ab6fad58e5fc014efc62fa2dca978f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829853}
-
Khushal Sagar authored
Bug: 1056730 Change-Id: I0515616e5524d002859d4f1c8ce7b8f8c930a119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299535 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829852}
-
Sophie Chang authored
This matches the enum checked into google3 Bug: 1146151 Change-Id: I934ae52656e765992c755733f4108773d6446f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552760 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#829851}
-
James Hawkins authored
This change fixes a crash where the device name is fetched from the DeviceNameStore, which is not initiatlized when the flag is off. R=khorimoto@chromium.org Bug: 1151252 Test: none Change-Id: I314b6bd27f3bfe1ff7bce9ebf9ebd7c28edf8188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552671Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#829850}
-
Jing Wang authored
This is required for cl/342559961 Bug: 1137621 Change-Id: Ic7fffc07a2ec9c62c4b92c894e0d961ab6d56382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536427Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#829849}
-
Kyle Milka authored
Subclass ScreenshotCoordinator to create LongScreenshotCoordinator. For now this class only overrides captureScreenshot() to launch the bottom bar after capture instead of directly launching the editor. Bug: 1142520 Change-Id: I378f1809ed1cf9a74df2f028a6a6ca0d75a06d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542924Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#829848}
-
Alison Maher authored
This change overrides the ColorIncludingFallback() function for fill, stroke, -internal-visited-fill, and -internal-visited-stroke. This allows us to use ComputedStyle::VisitedDependentColor() instead of ComputedStyle::ResolvedColor(). This change shouldn't result in any functional difference. Bug: 970285 Change-Id: I6a5b85cdbf1abe8dc9d255ba73c7f6c6e8530a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519272 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#829847}
-
Clark DuVall authored
Feed V2 has fragment classes that are not retained, so on configuration changes these are recreated using reflection. This change keeps track of isolated split ClassLoaders that were created for inflation, and checks if fragment classes can be loaded with these. Bug: 1151456 Change-Id: I46a64a1959e8879680babdb94fa33f4e928ff863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552205 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829846}
-
Daniel Rubery authored
We have some BUILD targets related to the URL lookup service that both depend on and are depended on by //chrome/browser/safe_browsing:safe_browsing This seems to be causing occasional build flakes (see bug). The solution is to merge these BUILD targets. Bug: 1151202 Change-Id: Id73c8a737f1f93bf0430b21f8ec770e865f5175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552571 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829845}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/32b14552d662..1286f58c2996 2020-11-20 apodtele@gmail.com Downgrade property tracing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: drott@google.com,thestig@google.com,bungeman@google.com Change-Id: I927897cd23df6500c22d70f2973254689a93ebcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829844}
-
Jacques Newman authored
NGGridLayoutAlgorithm::ComputeMinMaxSizes is fairly complicated, and would like to modify its internal data to make the algorithm easier to read. There does not seem to be any reason we must guarantee ComputeMinMaxSizes needs to be const. Bug: 1045599 Change-Id: I57f6ded3757b19694601b506747ccdd1c48d84a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552705 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#829843}
-
Stephen Roe authored
Bug: 1105654 Change-Id: Ief7bbafd18ce534400d674024b4239b17fe19dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532768 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#829842}
-
Dave Tapuska authored
Previously the message would just get dropped if the opener frame was discarded as it would be on a shutdown channel. Ultimately this code should go away if we didn't have the pending_contents_ list. I've created a separate issue for that because this change likely needs to be merged into M88. BUG=1149833, 1150976 Change-Id: If46b130a0c79a2e09ba7680ca6e3dfea881f39ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550250Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#829841}
-
rajendrant authored
This CL renames HttpsImageCompressionBypassDecider to LitePagesServiceBypassDecider. This class will be used for fetching compressed images and robots rules from LitePages service. This CL also renames the relevant histograms. Bug: 1147565 Change-Id: Id01134e496015f104c9e32639b8fa19afe1f075e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552822 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#829840}
-
Dale Curtis authored
MP3, FLAC, and AV1 are all codecs that were added in Chromium and Chrome. R=ddorwin Change-Id: I4c0cfed8eb68a56489d9147d4e35a7148bdc58b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552985 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829839}
-
Stephen Martinis authored
This reverts commit ce0f2cd4. Reason for revert: Landing after build side change Original change's description: > Revert "Remove Mac 10.10 builders" > > This reverts commit f983ad81. > > Reason for revert: Broke CI builder mac-updater-builder-rel https://ci.chromium.org/p/chromium/builders/ci/mac-updater-builder-rel/1198 > > Original change's description: > > Remove Mac 10.10 builders > > > > Bug: 1149560 > > Change-Id: Ib9798ca9e092edfba05dff7fa7f641e156182cb2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548680 > > Auto-Submit: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#829364} > > TBR=martiniss@chromium.org,gbeaty@chromium.org > > Change-Id: Ie979df929b64896c01ca4858909b8cbe902e7a25 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1149560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551638 > Auto-Submit: Gregory Guterman <guterman@google.com> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829417} TBR=martiniss@chromium.org,gbeaty@chromium.org,guterman@google.com # Not skipping CQ checks because this is a reland. Bug: 1149560 Change-Id: Id8920e3b96033cbce6422ef2263c4fb96df7077d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551641Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#829838}
-
Reilly Grant authored
This allows the SerialConnectionEvent interface to be removed because the port attribute is superfluous given the target attribute. Bug: 884928 Change-Id: I1e646c03a093cc9dd09776946597ec534e86636f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542923Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#829837}
-
Natalie Chouinard authored
Remove unused method now that downstream has been updated. See: https://crrev.com/i/3409426. Bug: 1102812 Change-Id: I59a8ce9629041fd290b2ca606497a7e733c81da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541671Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#829836}
-
Kevin McNee authored
Bug: None Change-Id: I77f2d4e364d8b2458c29fa28969e8abdb6d0f537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551777Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829835}
-
Matthew Mourgos authored
When a long press occurs on shelf app icons the icon is scaled up. This change adds an animation for scaling the notification badge with the shelf app icon during scaling. Bug: 1131076 Change-Id: I3372c305a46f22d3bd4381794cbc93855e81ecbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552085 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829834}
-
Clark DuVall authored
There were two definitions of createFeedContext(), and one did not have the original dark mode fix. See bug for more details. Bug: 1147705 Change-Id: Id930163d69cedbe07dcd272cf88246b5bb7da3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552642 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#829833}
-