GitLab

This CL adds test cases for opening the media router dialog from the page
context menu and the app menu.

BUG=678472

Review-Url: https://codereview.chromium.org/2621723003
Cr-Commit-Position: refs/heads/master@{#443398}

BUG=679846

Review-Url: https://codereview.chromium.org/2629273002
Cr-Commit-Position: refs/heads/master@{#443397}

BUG=680720
TEST=Linux Intel HD 530 bot
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629543006
Cr-Commit-Position: refs/heads/master@{#443396}

This CL removes the "deferred quit" from most of the touched helpers.

The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
They were already using immediate quit mode, so there is no change in
their behavior, just cleanup.

Regarding title checks in browser_browsertest.cc: in these tests there
is no guarantee on when the new tab will start and stop loading. It
can start loading after WindowedNotificationObserver::Wait returns; also
it can stop loading while we're still inside it. We can explicitly wait
for the title to handle all these cases, and this makes the call to
WaitForLoadStop unnecessary.

BUG=668707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2601843002
Cr-Commit-Position: refs/heads/master@{#443395}

BUG=657012

Review-Url: https://codereview.chromium.org/2530043002
Cr-Commit-Position: refs/heads/master@{#443394}

We have written a Physical Web WebUI that we intend to be the de facto
view for browsing Physical Web URLs.  This change makes sure the user
goes there when they try to display URLs from:
* the diagnostics page and
* the settings fragment.

BUG=663842

Review-Url: https://codereview.chromium.org/2601273003
Cr-Commit-Position: refs/heads/master@{#443393}

Reverted https://codereview.chromium.org/2625933003 as the GPU drivers on the Intel GPU perf bots need updating first.

R=jmadill@chromium.org
TBR=dtu@chromium.org, eyaich1@chromium.org, jmadill@chromium.org

Review-Url: https://codereview.chromium.org/2626373002 .
Cr-Commit-Position: refs/heads/master@{#443392}

Now, after http://crrev.com/2580343003, HTML diffs are available on all platforms, and dependency on wdiff can be removed.

BUG=672651

Review-Url: https://codereview.chromium.org/2582293004
Cr-Commit-Position: refs/heads/master@{#443391}

In rare cases, devices time out on the first real command sent to them.
On swarming, the total time required for this timeout can exceed that
amount of time allotted for the containing task to finish. This is bad.

This change checks that the device is fully booted before attempting to
do anything else with it. The commands this runs should ensure that we
can run basic commands on the device and that the package manager is
running. This all runs with a relatively short timeout, so we should
be able to identify a potentially problematic device before hitting
the swarming timeout.

BUG=664308

Review-Url: https://codereview.chromium.org/2628953003
Cr-Commit-Position: refs/heads/master@{#443390}

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620383007
Cr-Commit-Position: refs/heads/master@{#443389}

This is a follow up for https://codereview.chromium.org/2625453002/

Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0);
at the end of the test. The change is for making sure that last Animate()
won't call ScrollBy when the fling is over.

BUG=526463
TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled

Review-Url: https://codereview.chromium.org/2627793005
Cr-Commit-Position: refs/heads/master@{#443388}

Get rid of the functions to get each individual program type, and
replace them with calls to GetProgram with the appropriate key.

Move uniform tracking to ProgramBinding, and get rid of all of the
various "uniform cache" structures that were created to handle getting
uniforms from all of the different shader types.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2622243003
Cr-Commit-Position: refs/heads/master@{#443387}

https://pdfium.googlesource.com/pdfium.git/+log/db7647083d0a..98d00b230aa1

$ git log db7647083..98d00b230 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 dsinclair Remove used items from the CSS code.
2017-01-12 tsepez Don't put timers with ID == 0 into the global timer map.
2017-01-12 tsepez Custom toString() methods may delete annots.
2017-01-12 npm Fix leak in OJPEGReadHeaderInfoSecTablesAcTable when read fails.

BUG=679649,679643,680520

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2627073004
Cr-Commit-Position: refs/heads/master@{#443386}

BUG=680675,680684
TEST=Linux Intel HD 530 bots on GPU FYI waterfall
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629653003
Cr-Commit-Position: refs/heads/master@{#443385}

This fixes a missing word typo ("won't to make" -> "won't need to
make"), fixes some stylistic inconsistencies (fenced code blocks), and
reformats the markdown to conform to mdformat.

BUG=

Review-Url: https://codereview.chromium.org/2627003006
Cr-Commit-Position: refs/heads/master@{#443384}

TODOs have been removed since we are no longer componentizing
SafeBrowsingService and are not yet supporting reporting in WebView.
Comments for the base class methods have been updated to indicate these
methods are no-ops, but describe how they should be overridden.

BUG=488675

Review-Url: https://codereview.chromium.org/2629203002
Cr-Commit-Position: refs/heads/master@{#443383}

BUG=303429
TEST=Manual test by the instruction described in the issue.

Review-Url: https://codereview.chromium.org/2620273002
Cr-Commit-Position: refs/heads/master@{#443382}

Review-Url: https://codereview.chromium.org/2627103004
Cr-Commit-Position: refs/heads/master@{#443381}

These files define test cases inside a dedicated `registerTests`
function. This no longer has any benefit for isolating tests, and just
reduces the amount of horizontal space available for test code.

This CL only removes these registerTests functions and deindents
the corresponding code -- there are no functional changes to any
tests.

BUG=647115

Review-Url: https://codereview.chromium.org/2627263002
Cr-Commit-Position: refs/heads/master@{#443380}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/290f611623b2..4bd0c43eba04

$ git log 290f61162..4bd0c43eb --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd [dashboard] Remove console.log I added by accident
2017-01-12 aiolos TimelineTrackView Hoisting refactor: addKeyPressHotKey in TimelineTrackView.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2627113004
Cr-Commit-Position: refs/heads/master@{#443379}

Previously, these navigations were aborted due to this unfortunate
sequence of events:

1. A new provisional RenderFrame is created with a proxy_routing_id_
of the proxy that it would replace once it commits.

2. RFHM::UpdateStateForNavigate calls CommitPending early, because the
current RFH was not live (crashed).  This destroys the
RenderFrameProxy to which the RenderFrame's proxy_routing_id_ in step
(1) referred.

3. Next, when navigating the frame, RenderFrameImpl::OnNavigate
checks whether the proxy it's supposed to replace still exists, and
aborts the navigation because it doesn't.

This CL avoids this problem by sending a new IPC message,
FrameMsg_SwapIn, to the provisional frame when doing the early
CommitPending call in step (2).  This ensures that the renderer also
swaps the provisional frame into the tree, replacing its associated
proxy.

BUG=487872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2619123002
Cr-Commit-Position: refs/heads/master@{#443378}

BUG=596760

Review-Url: https://codereview.chromium.org/2623143006
Cr-Commit-Position: refs/heads/master@{#443377}

Review-Url: https://codereview.chromium.org/2625913002
Cr-Commit-Position: refs/heads/master@{#443376}

BUG=none

Review-Url: https://codereview.chromium.org/2625873003
Cr-Commit-Position: refs/heads/master@{#443375}

BUG=646864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2627793003
Cr-Commit-Position: refs/heads/master@{#443374}

This is needed for to correctly enabled variations seed
fetching after backup & restore in conjunction with this
CL: https://codereview.chromium.org/2614183002

BUG=669543

Review-Url: https://codereview.chromium.org/2621413008
Cr-Commit-Position: refs/heads/master@{#443373}

Revert of Enable viewing render tests results on buildbot on Android FYI bot. (patchset #1 id:1 of https://codereview.chromium.org/2625673003/ )

Reason for revert:
Reverting since the FYI bot seems to be having trouble running chrome_public_test_apk (seems like device or adb issue). Enabled this on another bot (M tester on chromium.android).

Original issue's description:
> Enable viewing render tests results on buildbot on Android FYI bot.
>
> Adding example test with render tests to FYI bot. If everything
> works as intended, will enable this on all bots. Will also switch
> implementation from needing to be configured by manually setting
> render_results_dir to detecting the render_results_dir automatically.

TBR=dpranke@chromium.org,mikecase@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2629523005
Cr-Commit-Position: refs/heads/master@{#443372}

This is a no-op for our bindings but it keeps us in sync with the spec.

BUG=None
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2627283002
Cr-Commit-Position: refs/heads/master@{#443371}

<base> has cropped up in some recent attacks, and maybe it's possible to
tweak things a little bit to make it play better with the platform at
large. Let's find out, shall we?

BUG=679318

Review-Url: https://codereview.chromium.org/2626243002
Cr-Commit-Position: refs/heads/master@{#443370}

Support for position:relative was added back in early 2011, in
23fab7d4, but the comment was never
updated to reflect the new code.

BUG=679759

Review-Url: https://codereview.chromium.org/2625723002
Cr-Commit-Position: refs/heads/master@{#443369}

HpackDecoderState listens to HpackWholeEntryBuffer, resolves indices
into the HPACK static and dynamic tables, updates the dynamic table as
appropriate, and reports fully decoded header entries to an
HpackDecoderListener instance.

This CL lands server change 130407086 by jamessynge.

BUG=488484

Review-Url: https://codereview.chromium.org/2619043003
Cr-Commit-Position: refs/heads/master@{#443368}

Change the LayoutUnit implementation to use base::saturated_cast instead of WTF
::clampTo as the former is much more efficient. Also removes clampToLayoutUnit.

R=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2615713007
Cr-Commit-Position: refs/heads/master@{#443367}

When switching from pending to activated state, there is no need to do
more animations as the final state of animations for these states are
the same. Otherwise, janks on slow devices might create some unwanted
effects like double ripples.

BUG=670831
TEST=manual

Review-Url: https://codereview.chromium.org/2615613003
Cr-Commit-Position: refs/heads/master@{#443366}

This is a new mechanism, replacing the previous technique of subclassing
SkDevice.

BUG=675977

Review-Url: https://codereview.chromium.org/2629523004
Cr-Commit-Position: refs/heads/master@{#443365}

Previously, they were only shown when the corresponding datatype was
checked. This led to uneven spacing between checkboxes and arguably
strange visual behavior where text was appearing and disappearing.

See the linked bug for screenshots.

BUG=654812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623033003
Cr-Commit-Position: refs/heads/master@{#443364}

https://skia.googlesource.com/skia.git/+log/90ee03b0d177..b621a35b436b

$ git log 90ee03b0d..b621a35b4 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 mtklein drop depot_tools dependency in bin/fetch-gn
2017-01-12 halcanary rm -r {include,src}/animator
2017-01-12 halcanary cleanup after 95e3c05
2017-01-12 msarett Fix tool with swapped fC, fE (SkColorSpaceTransferFn)
2017-01-12 msarett Use RasterPipeline to support full precision on 16-bit RGBA pngs

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2633523002
Cr-Commit-Position: refs/heads/master@{#443363}

The various programs stored in GLRenderer are 5-dimensional arrays,
and adding color conversion to them would require adding a 6th
dimension.

Create a ProgramKey structure that uniquely identifies a program, and
create a single unordered_map to cache programs.

Gut all off the GLRenderer::Get*Program* functions, to just call a
common GLRenderer::GetProgram function, which takes this key.

Adding color conversion will now just consist of adding a new field to
the ProgramKey structure. Before we do that, we'll remove all of the
(now-stub) GLRenderer::Get*Program* functions, and have the callers
all call GLRenderer::GetProgram.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2613903002
Cr-Commit-Position: refs/heads/master@{#443362}

Make sure the active URL is correctly set for crash reports.

BUG=643746, 630895

Review-Url: https://codereview.chromium.org/2622073005
Cr-Commit-Position: refs/heads/master@{#443361}

This will make it easier to land an upcoming ResourceHandler refactor,
and also gives us some more ASSERTs shared with other tests. Also add
checking of the error code the request is canceled with.

Also prevent next ResourceHandler in the chain from being called
re-entrantly

BUG=659317

Review-Url: https://codereview.chromium.org/2626663002
Cr-Commit-Position: refs/heads/master@{#443360}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2629003002
Cr-Commit-Position: refs/heads/master@{#443359}