- 03 Oct, 2018 40 commits
-
-
Ned Nguyen authored
Bug: 891747 Change-Id: I73142c8bb5c4bbc78da71f230188e33d548a3dab Reviewed-on: https://chromium-review.googlesource.com/c/1259475 Commit-Queue: Ned Nguyen <nednguyen@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#596397}
-
Kyle Milka authored
In https://crrev.com/c/1249834 the tabbable element was changed from a button to role=button so using space to press it no longer worked. Bug: 891652 Change-Id: I8dd7155de5deba6f2b25c3ba5cb39761f84eafdc Reviewed-on: https://chromium-review.googlesource.com/c/1258880Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#596396}
-
Jacob Dufault authored
This works on webui, so port it over to views as well. Also generally rename version info -> system info to better capture what this data represents. Bug: 888049 Change-Id: Icb35156aafc9b0898dcd57e4c50dd09b067585b6 Reviewed-on: https://chromium-review.googlesource.com/c/1249823 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596395}
-
Jordy Greenblatt authored
In the HEAD version, a click on the Settings UI 'learn more' link will route to the subpage when there is a set host (i.e. when waiting for connection/verification) in addition to the intended behavior of opening the subpage. This CL just adds a check to the settings-multidevice-page's click handler that returns before routing if the click target was a link. Screenshot: http://screen/ka5Vd3vk1YC Bug: 881375 Change-Id: I6c1c8e2ed2e6043d2f21442a0ce0b8e211da522e Reviewed-on: https://chromium-review.googlesource.com/c/1259300Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#596394}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cfc9679f85fe..75bbf56da825 git log cfc9679f85fe..75bbf56da825 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 dgarrett@google.com cbuildbot: Define luci-scheduler-updater. 2018-10-03 vapier@chromium.org paygen: urilib: drop unused protocol helpers Created with: gclient setdep -r src/third_party/chromite@75bbf56da825 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I08b1a9778249b855dde8a136c76928f67b538496 Reviewed-on: https://chromium-review.googlesource.com/c/1259825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596393}
-
Samuel Huang authored
This is an experiment to test incremental update framework, to prepare for Zucchini launch in Stable, where the "old" setup.exe uses Courgette to patch itself to the "new" setup.exe, which then uses Zucchini to patch chrome.7z. In this CL, we remove Zucchini from setup.exe, so that incremental install would revert setup.exe to the old state. Then after a few releases (also an opportunity to gather metrics for Courgette), reverting this CL would simulate Stable launch. Bug: 729154 Change-Id: I4962b0f0df3dfbc32c39a663b559b84801b1af44 Reviewed-on: https://chromium-review.googlesource.com/c/1259471Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#596392}
-
John Budorick authored
TBR=lindsayw@chromium.org Bug: 850125 Change-Id: Ie1185a8cf043d09c1bc6c8b6802115665212901a Reviewed-on: https://chromium-review.googlesource.com/c/1259473Reviewed-by:
-
Tom Anderson authored
BUG=737995,881371 R=pkasting Change-Id: I0723a4cf2e31c2ffd8a07869ce4742091e1ea8c1 Reviewed-on: https://chromium-review.googlesource.com/c/1258522 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#596390}
-
Gang Wu authored
Also change the feed_logging_metrics.h into class for future features, Like hook up all the UMA with Feed internal page. Bug: 867767 Change-Id: I5559207df16d9c431208bd65cf20326a22116202 Reviewed-on: https://chromium-review.googlesource.com/c/1258250 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#596389}
-
Brandon Wylie authored
Change-Id: I0482302dcb63fcf260743d1eb5fe471030a01534 Reviewed-on: https://chromium-review.googlesource.com/c/1250201Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596388}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59021ba4e1dc..cd18bf9522d4 git log 59021ba4e1dc..cd18bf9522d4 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 mbonadei@webrtc.org Compile remote_bitrate_estimator without -Wno-exit-time-destructors. 2018-10-03 buildbot@webrtc.org Roll chromium_revision 14de2307..f33d9eb9 (596155:596278) 2018-10-03 danilchap@webrtc.org Move RtpHeaderExtensionMap::GetTotalLengthInBytes into own file Created with: gclient setdep -r src/third_party/webrtc@cd18bf9522d4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4bdfd696aaae2f9162b862571d815bfd670b7715 Reviewed-on: https://chromium-review.googlesource.com/c/1259498Reviewed-by:
-
Clark DuVall authored
Eventually we want to use TYPE_RAW_FILE for network service file uploads, which will work when network service is sandboxed. For now, we are still using TYPE_FILE, so support this in webReqeust. Bug: 888441 Change-Id: Icb3acf80d466404ee0a21a726c3f192322a6eb87 Reviewed-on: https://chromium-review.googlesource.com/c/1257672Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#596386}
-
Bailey Berro authored
Switches to using the windows format of the smb url (\\server\share) rather than the smb://server/share format since it's more familiar to users. Bug: chromium:889289 Change-Id: Ic9118980e05cf367b4049b426313408316472006 Reviewed-on: https://chromium-review.googlesource.com/c/1256112 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596385}
-
Sky Malice authored
Bug: 890007 Change-Id: I870130381eb5376ea0a9ecf5c2fc1ab5f8761f18 Reviewed-on: https://chromium-review.googlesource.com/c/1258310Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#596384}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2116cd3af9f..4d422c290779 git log c2116cd3af9f..4d422c290779 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jmadill@chromium.org Vulkan: Move blit mipmap init to ImageHelper. Created with: gclient setdep -r src/third_party/angle@4d422c290779 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If736ffde9b090108e543685636ce3cf53546fdf5 Reviewed-on: https://chromium-review.googlesource.com/c/1259484Reviewed-by:
-
Cathy Li authored
Bug：867488 Change-Id: Ic9417d136011b2268d149bbdc0d1bd13163c0dea Reviewed-on: https://chromium-review.googlesource.com/c/1248124Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#596382}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bfa76f20bfcf..9e0efe3189e0 git log bfa76f20bfcf..9e0efe3189e0 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 mtklein@google.com remove SkColorSpaceXform 2018-10-03 egdaniel@google.com Pass a VkRenderPass through pipeline state creation instead of GrVkRenderPass. 2018-10-03 reed@google.com remove some dead flags 2018-10-03 mtklein@google.com rehome SkColorSpace <-> skcms_Profile routines 2018-10-03 fmalita@chromium.org [skottie] Multi-frame image support 2018-10-03 egdaniel@google.com Reland "Reland "Always include public/include headers for vulkan and just guard src files with SK_VULKAN."" Created with: gclient setdep -r src/third_party/skia@9e0efe3189e0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:862144 TBR=mtklein@chromium.org Change-Id: I4e4662efc6dec4e79e0b3014df26576929b17e51 Reviewed-on: https://chromium-review.googlesource.com/c/1259822Reviewed-by:
-
Paul Miller authored
This reverts commit 8bf4bf24. Reason for revert: PermutedEntropyProvider regressed perf & memory. BUG=890413 Original change's description: > Revert "WebView: Ignore permanent-consistency experiments" > > This reverts commit ef70c85e. > > Reason for revert: WebView now supports permanent-consistency. > > BUG=866722 > > Original change's description: > > WebView: Ignore permanent-consistency experiments > > > > Android WebView currently treats permanent-consistency experiments > > (which are intended to retain their group assignments across runs) as > > session-consistency (which are intended to be randomly assigned on each > > run). It's safer to not apply permanent-consistency experiments to > > WebView at all, to avoid mistakes. > > > > BUG=866722 > > > > Change-Id: I9d501437718d934c2a59b95335c787302ce758e7 > > Reviewed-on: https://chromium-review.googlesource.com/1148991 > > Reviewed-by: Changwan Ryu <changwan@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Paul Miller <paulmiller@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#578070} > > TBR=changwan@chromium.org,holte@chromium.org,paulmiller@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 866722 > Change-Id: Ifd00450fbba1afc1db619109cf918ef75cbcf84f > Reviewed-on: https://chromium-review.googlesource.com/1237244 > Reviewed-by: Paul Miller <paulmiller@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Paul Miller <paulmiller@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594491} TBR=changwan@chromium.org,holte@chromium.org,paulmiller@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866722 Change-Id: I58435ac0c107214e15b0e54ff8aee422eb98fa06 Reviewed-on: https://chromium-review.googlesource.com/c/1259807Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596380}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d73b9d8dfbf7..19c07731fce3 git log d73b9d8dfbf7..19c07731fce3 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 stevenperron@google.com Change handling of unknown extentions in validtor. (#1951) 2018-10-03 webmaster@khronos.org Revert LICENSE to Apache 2.0 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@19c07731fce3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5671283e523fd14e416e5f1327d3f39fa37c4b18 Reviewed-on: https://chromium-review.googlesource.com/c/1259500Reviewed-by:
-
Lukasz Anforowicz authored
CORB makes an exception for content scripts, because they are allowed to receive cross-origin responses from origins covered by the extension manifest. This CL is desirable to: 1. Avoid making this exception when no content scripts have been injected into frames hosted in a given renderer process. 2. Pave a way for future CLs to 2a. stop making this exception if a specific extension doesn't need it. 2b. make the exception more granular (e.g. instead of turning off CORB altogether, turn it off for a few, select origins). This CL makes the following code changes: 1. Adds |initiator_specific_factories| field to content.mojom.URLLoaderFactoryBundle. 2. Introduces public //content APIs for saying that an origin requires a separate URLLoaderFactory RenderFrameHost::MarkInitiatorAsRequiringSeparateURLLoaderFactory this API is called by the following methods of extensions::URLLoaderFactoryManager: - ReadyToCommitNavigation - WillExecuteCode 3. Introduces public //content APIs for overiding the URLLoaderFactory created by RenderFrameHostImpl: ContentBrowserClient::CreateURLLoaderFactoryForNetworkRequests This API is overriden at the //chrome layer and ultimately delegated to extensions::URLLoaderFactoryManager::CreateFactory. This API is called by RenderFrameHostImpl for both - Creating the default URLLoaderFactory for extension frames - Creating initiator-specific factories as requested by MarkInitiatorAsRequiringSeparateURLLoaderFactory (see above). 4. Moves code that evaluates whether content script matches the given document so it can be reused by URLLoaderFactoryManagerForContentScripts. This includes: - A little bit of code moved from UserScriptSet::GetInjectionForScript to UserScript::MatchesDocument - ScriptContext::GetEffectiveDocumentURL which got replicated into helper functions in an anonymous namespace used by URLLoaderFactoryManagerForContentScripts 5. Removes URLLoaderFactoryParams::corb_excluded_initiator_scheme. For content scripts, this flag is made obsolete by the changes above. For more details please also see the design document at: https://docs.google.com/document/d/1fuBUmLZj1H319jMkK8waUbf5WdQS0N95J_mWXVzbP7A Bug: 846346 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I28e14e9b8f6eca4f41687609da56177ec94b4272 Reviewed-on: https://chromium-review.googlesource.com/c/1228478 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596378}
-
Jonathan Freed authored
Change-Id: I2b5007bcc8c8af400e4d97c2519479dd0591cc17 Reviewed-on: https://chromium-review.googlesource.com/c/1259809Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#596377}
-
rbpotter authored
Enabling: CrSettingsIncompatibleApplicationsPageTest CrSettingsLanguagesPageTest.AddLanguagesDialog CrSettingsLanguagesPageTest.LanguageMenu CrSettingsLanguagesPageTest.Spellcheck Bug: 875452, 875454 Change-Id: I5b5fa399bb76ec133e2cfee1ae3b949eedb7c7db Reviewed-on: https://chromium-review.googlesource.com/c/1259465 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596376}
-
Daniel Bratell authored
Coding standard and compiler do not like unused private fields, but sometimes they slip between the cracks until they trigger something: In file included from gen/chrome/utility/utility_jumbo_1.cc:12: In file included from .\../../chrome/utility/importer/firefox_importer.cc:26: In file included from ../..\chrome/utility/importer/nss_decryptor.h:13: ../..\chrome/utility/importer/nss_decryptor_win.h(169,29): error: private field 'PK11_CheckUserPassword' is not used [-Werror,-Wunused-private-field] PK11CheckUserPasswordFunc PK11_CheckUserPassword; ^ 1 error generated. This removes the unsued field. Also removing an "explicit" to get past presubmit checks. Running presubmit upload checks ... L: \src\clean_chromium\src\chrome\utility\importer\nss_decryptor_win.cc:18: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] Change-Id: Id310c0f65a406c1a47ec29312472580d15dfd1ce Reviewed-on: https://chromium-review.googlesource.com/c/1259018 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596375}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f9e0498bb1ce..2ff6cd661c02 git log f9e0498bb1ce..2ff6cd661c02 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 tsepez@chromium.org Make CCodec_ProgressiveDecoder::ReadMoreData() slightly saner 2018-10-03 hnakashima@chromium.org Reland "Make potentially dangerous Actions require a user click." 2018-10-03 thestig@chromium.org Fix nits in CFX_FontSourceEnum_File. 2018-10-03 thestig@chromium.org Split CFX_FontSourceEnum_File into its own file. 2018-10-03 thestig@chromium.org Add FxFolderHandleCloser for use with std::unique_ptr. Created with: gclient setdep -r src/third_party/pdfium@2ff6cd661c02 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851821 TBR=dsinclair@chromium.org Change-Id: Id2e46631c3c86f62a70337eaf11dfe7e06ff6a8a Reviewed-on: https://chromium-review.googlesource.com/c/1259491Reviewed-by:
-
Caleb Rouleau authored
NOTRY=true TBR=nednguyen@google.com CC=andruud@chromium.org,futhark@chromium.org Bug: 891878 Change-Id: I52e2b98faee15e90b2d6dbb71f1d572fa64c5ab7 Reviewed-on: https://chromium-review.googlesource.com/c/1259617Reviewed-by:
-
Alex Leung authored
Bug: b:117117082 Change-Id: I14fdddd09de741e763cb9ba6cf69abb58bfdf9ef Reviewed-on: https://chromium-review.googlesource.com/c/1258317Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#596372}
-
Becca Hughes authored
For cross process audio focus requests we need to support async audio focus requests in MediaSessionImpl. This adds support and test coverage but does not yet fully convert them to async. BUG=875004 Change-Id: Ie4236b5e78d63593d9ec3bf0968e03bef36ee1fc Reviewed-on: https://chromium-review.googlesource.com/c/1192105 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596371}
-
Carlos Knippschild authored
The group name used in the variations' field trial test configuration didn't match the one set in the flags configuration, causing DCHECK crashes when the feature flag is used. This change makes those names match. Bug: 852872 Change-Id: Ie817d84bdf3801d344497543b21a12428dc66fbf Reviewed-on: https://chromium-review.googlesource.com/c/1257653Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#596370}
-
Philip Rogers authored
A webview's preferred content height is typically the minimum height required to display the main document without scrollbars. This is not true for quirksmode documents (documents without <!doctype html>) where the height will always fill the viewport at a minimum. This is not obvious so a comment and test have been added. Change-Id: Id39755a81f2d258d4b078501f37c425f8dc2d8ba Reviewed-on: https://chromium-review.googlesource.com/c/1259041 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596369}
-
Weilun Shi authored
The logoImg.complete event was not working as intended on Mac's chromium chrome://apps. Directly using onload event to adjust the width for the footer menu and the logo instead. Screencast: https://screencast.googleplex.com/cast/NTY2NzA1MTk2ODM5NzMxMnw1ZDVjMjU5NS1jYQ Bug: 864267 Change-Id: I614d44c9377e276f6d3084c299ab9ced98ed831d Reviewed-on: https://chromium-review.googlesource.com/c/1257676Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#596368}
-
Becca Hughes authored
Move AudioFocusManager and its unit tests to //services. This CL does not remove the existing AudioFocusManager in //content as this will be done in a follow up CL with some mojo work. BUG=875004 Change-Id: Ife982e671d21ca7be29a6bed38097e842937b35f Reviewed-on: https://chromium-review.googlesource.com/c/1197351 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596367}
-
Collin Baker authored
This adds the feature and event definitions to the IPH backend for our desktop IPH pilot feature: recommending users reopen accidentally closed tabs. See associated issue for design doc, PRD, and mocks. Bug: 887991 Change-Id: I939b0b8de95d7340d902ad2273c8bae0a751f12e Reviewed-on: https://chromium-review.googlesource.com/c/1259476Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#596366}
-
Sophie Chang authored
Bug: 883528 Change-Id: I9b909ece49229149efa75cf0cb70ced808f22835 Reviewed-on: https://chromium-review.googlesource.com/c/1252782Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596365}
-
David Bertoni authored
Bug: 891788 Change-Id: I2bbef101cf0d95114836391a508b366982da5d4d Reviewed-on: https://chromium-review.googlesource.com/c/1257552 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Brian Salomon authored
If quads are antialiased this can trigger shader blending. Also Skia has optimized code paths for textures drawn src-over. Bug: 811523 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9f0405d7651464aeb761c02f5d16f4de29dbbd75 Reviewed-on: https://chromium-review.googlesource.com/c/1259543Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#596363}
-
Xiaohan Wang authored
This can be used to control whether to fall back to another decoder after audio/video decode error. This is useful in debugging and testing to avoid surprises, e.g. playback works after falling back to another decoder while the test doesn't expect a fallback. Bug: 877673 Test: Disable fallback on encrypted media (content) browser tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I66787a84ce369e003f6b15187b0d31653cb6df68 Reviewed-on: https://chromium-review.googlesource.com/c/1257364 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#596362}
-
Eugene But authored
Error presentation code does not work if navigation is failed without a pending item. It is easier and more correct to actually create navigation item for state restoration than workaround the bug in error presentation code. This fixes the bug when placeholder URL is displayed in the omnibox. Bug: 887385, 888021 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I94a124d3477d074fcea2d94128f5bbffe4091f2f Reviewed-on: https://chromium-review.googlesource.com/c/1258611 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596361}
-
Jimmy Gong authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/536735c00911..f63dc2e08f0c $ git log 536735c00..f63dc2e08 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 jimmyxgong smbprovider: Add MountConfigProto to directory_entry 2018-09-21 semenzato system_api: add anomaly event service interface Created with: roll-dep src/third_party/cros_system_api Change-Id: Ibb5fbd044ae7c52ec321c6331935a0d8840b034e Reviewed-on: https://chromium-review.googlesource.com/c/1259493Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596360}
-
Philip Rogers authored
The md extension options dialog has an inner frame with the options page contents. The dialog is sized based on the preferred size of the options page contents using preferred size change events. The options page contents's size is also dependent on the dialog size, so resizing the dialog can result in a preferred size change event which then resizes the dialog size again. Because the options dialog and the options page contents are on different threads, this size update logic can infinitely oscillate between two sizes. This bug became more prominent with two recent changes: https://crrev.com/581383 - made preferred size changes synchronous https://crrev.com/582708 - moved preferred size change events from the middle of a frame to the end of a frame. This patch adds a delay between getting the preferred size update and changing the dialog size, fixing the options dialog size oscillation. This mimics the asynchronous preferred size updates that were done before https://crrev.com/581383. Test: manually tested using 4 custom extension options pages (short quirksmode, tall quirksmode, short html5, and tall html5). Bug: 882835 Change-Id: I97bd61c3137ae851d855637aed75029bce1e5404 Reviewed-on: https://chromium-review.googlesource.com/c/1259040 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
When overridding SetUpCommandLine(), subclasses of MediaBrowserTest should always call MediaBrowserTest::SetUpCommandLine(). This also helps remove duplicate code in setting autoplay policy in these tests. Bug: 707128 Test: Clean up only. No functionality change. Change-Id: Ic06ba4b48e20cf342db7f60a32565766f5d1a1d5 Reviewed-on: https://chromium-review.googlesource.com/c/1257599Reviewed-by:
-
