GitLab

- LayoutTestSupport -> WebTestSupport
 - IsRunningLayoutTest() -> IsRunningWebTest()
 - SetIsRunningWebTest() -> SetIsRunningWebTest()
- kLayoutTestResourcesDir -> kWebTestsResourcesDir
- LayoutTestsFilePath() -> WebTestsFilePath()
- BlinkLayoutTestsDir() -> BlinkWebTestsDir()

Change-Id: If31f8d73f795d4271ccec76f51182a18c891fb30
Bug: 843412
Reviewed-on: https://chromium-review.googlesource.com/c/1352116Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611524}

Remove the failing and crashing expectations. It seems to only pass
or timeout these days. Also it no longer fails on NetworkService.

Bug: 849670
Change-Id: Ie5d67c154e06bcd32d77f32648d31bfebb8466fb
Reviewed-on: https://chromium-review.googlesource.com/c/1352081Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611523}

It was disabled due to a crash that looks similar to a bug that was
fixed, issue 854993. Try re-enabling it.

Bug: 838759
Change-Id: Ia3e21a9fdccd5239af270987e6c432612f5ae15c
TBR: peter
Reviewed-on: https://chromium-review.googlesource.com/c/1352082Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611522}

The error message is saying to add a scoped task environment.

TBR=nektar@chromium.org

Bug: crbug.com/909062
Change-Id: I5aca973574fd8754bdfc1ef44af1319a494b3d13
Reviewed-on: https://chromium-review.googlesource.com/c/1352869
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611521}

Load CloudManagementEnrollmentMandatory policy first. If not set, read the
/Library/Google/Chrome/CloudManagementEnrollmentOptions file. If it contains
Mandatory, then the enrollment is forced.

Also, always use com.google.Chrome as the bundle Id of Preference.

Bug: 904983
Change-Id: I1d45c48bef30c78ecddcb501e091a1132805b0ef
Reviewed-on: https://chromium-review.googlesource.com/c/1348910Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611520}

Update atoms with Selenium code as of 11/26/2018. This includes fix to
the error code returned by FIND_ELEMENT and FIND_ELEMENTS atoms when
an invalid locator is used.

The following WPT tests now pass:
* webdriver/tests/find_element/find.py
* webdriver/tests/find_elements/find.py

The following WPT tests still fail and will be fixed in the future:
* webdriver/tests/find_element_from_element/find.py
* webdriver/tests/find_elements_from_element/find.py

Bug: chromedriver:2677
Change-Id: I4e8c11d5f264e950312493f6fed491d8ef780302
Reviewed-on: https://chromium-review.googlesource.com/c/1352626Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611519}

https://chromium-review.googlesource.com/c/chromium/src/+/1351501 has
reverted some perf changes due to high-end mac laptops crashing. Re-add
that CL piece by piece. This CL adds no new tests, only the RAF
functionality.

Current canvas benchmarks only measure CPU time.
Using requestAnimationFrame (raf) in javascript we can
measure CPU + raster + GPU time. This CL adds a mode to
blink_perf.py that runs canvas all canvas test in a way
that takes raster and GPU time into account.

Roughly doubles the duration of `blink_perf.canvas`
benchmark from ~2 minutes to ~4 minutes on a linux desktop.

Bug: 894043
Change-Id: I50eeacbe47f3f3f0b09f1cb44806cabcad97dc2e
Reviewed-on: https://chromium-review.googlesource.com/c/1352475
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611518}

Partial reverted the cl which introduced this regression. I will reopen
the original bug and try a better fix later.

Test: manual
Bug: 881756, 907002
Change-Id: Idbe3a587caad485968d78b0b4841f1bfa0105366
Reviewed-on: https://chromium-review.googlesource.com/c/1344221Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611517}

https://pdfium.googlesource.com/pdfium.git/+log/d429f5426b5b..3e2cdea95cd8


git log d429f5426b5b..3e2cdea95cd8 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 tsepez@chromium.org Better tests for CFXJSE_FormCalcContext::Decode().
2018-11-27 asweintraub@google.com Fix compilation issue when using clang.


Created with:
  gclient setdep -r src/third_party/pdfium@3e2cdea95cd8

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ibbb5d6f26a492773ed580cac96e2738f186cbef4
Reviewed-on: https://chromium-review.googlesource.com/c/1352603Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611516}

Updates VR golden images for JavaScript dialogs and permission prompts
that changed due to
https://chromium-review.googlesource.com/c/chromium/src/+/1351790.

TBR=huayinz@chromium.org

Change-Id: I61d83a33d7d96e004496ed9d317fbd4b9315e869
Reviewed-on: https://chromium-review.googlesource.com/c/1352811Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611515}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: Icb9edd7ce1fddb023b92e27e289c27aa88c88473
Reviewed-on: https://chromium-review.googlesource.com/c/1351203Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#611514}

 InkDrop is handled before View::OnMouseEvent() in OnMouseEvent().
So, If I want to override the functions associated with InkDrop(ex : CreateInkDropHighlight()),
there is a problem with not getting the something appropriate(ex. Button::STATE).

 But, changing the order of handling inkdrop and mouse event causes crashes on windows.
(See, http:://www.crbug.org/902279.)
The cause of this crashes is calling views::OnMouseEvent() might delete "this".
So We Check if it's being detroyed to avoid crashes.


Bug: none
Change-Id: I2051ddbff9d674418c42e8fd81fcd9a4ab47a984
Reviewed-on: https://chromium-review.googlesource.com/c/1335068Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611513}

Bug: 823392
Change-Id: I23d47a25a47c5be77971fcde0f24a4bc591788fd
Reviewed-on: https://chromium-review.googlesource.com/c/1350170
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611512}

For consistency with https://crrev.com/c/1333014
- remove type="text/javascript"
- replace "var" with "const"

Change-Id: Ie809fa22763494fd6ca4b20112d4a3e6afdd1f0b
Reviewed-on: https://chromium-review.googlesource.com/c/1350431Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611511}

Clear all notification animation consists of two phases:
CLEAR_ALL_STACKED and CLEAR_ALL_VISIBLE.

During CLEAR_ALL_STACKED phase, only the counter at the top should
animate, so each notification should not move even though
GetCurrentValue() might not return 1.0.
See the bug for detail.

TEST=UnifiedMessageListViewTest.ClearAllWithStackingNotifications
BUG=908782

Change-Id: I24f369753cc17ad761d85c654743504a07e9e148
Reviewed-on: https://chromium-review.googlesource.com/c/1352111Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611510}

This CL extracts a Fake TestingPlatformSupport with the
GetGpuMemoryBufferManager implemented to a common location
under the test/ folder.

canvas_2d_layer_bridge_test.cc had two methods that were not
used, this CL removes those.

Bug: 902585
Change-Id: Iea41033d59794a9f3fb550739d0736345318f291
Reviewed-on: https://chromium-review.googlesource.com/c/1352472
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611509}

This is a follow up to http://crrev.com/c/1338165, so we can track the
performance impact of extraHeaders.

Bug: 827582
Change-Id: I91190cf9dd66ca0539a365725823a6647d674dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1352356Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611508}

Views now rely on layout manager for both preferred and minimum size,
and layout managers can be notified when a view's layout is invalidated.

Change-Id: I189eab4bf1ab4369db0d7ca5391b432ac3424fcc
Reviewed-on: https://chromium-review.googlesource.com/c/1351967
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611507}

This test was disabled due to being flaky long time ago, especially on
MacOS 10.6. It seems working fine on newer versions of Mac. So we
re-enable it.

BUG=84299

Change-Id: I1aca1edb36d6942e0ee4c7e0230e7bc76d874556
Reviewed-on: https://chromium-review.googlesource.com/c/1347276Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611506}

Bug: 881327
Change-Id: I7e9f50f598210e75d613561855dd4bde95ebaa0f
Reviewed-on: https://chromium-review.googlesource.com/c/1342761
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611505}

When MyFilesVolume is enabled and the its volume is already mounted
|GetDownloadsFolderForProfile| was returning actually MyFiles path
instead of MyFiles/Downloads path, this CL fixes this.

Bug: 873539
Change-Id: I099f788a6d067dce4857a6b4946808559799b45d
Reviewed-on: https://chromium-review.googlesource.com/c/1352070Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611504}

This CL adds content/browser/worker_host/ directory, and moves files under
content/browser/dedicated_worker/ and content/browser/shared_worker/ to the
directory so that browser-side loader classes are sharable between dedicated
workers and shared workers.

See the design doc for details:
https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing

Bug: 906991
Change-Id: Ibe2a342495589abab10c08c83ab801ae4f1bceee
Reviewed-on: https://chromium-review.googlesource.com/c/1351198
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611503}

AXSelection: Added unit tests for retrieving and clearing the current selection, and for cancelling a selection that is in progress

R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: I9bb2589a938930e9e967525c4a627c893eecaa48
Bug: 639340
Reviewed-on: https://chromium-review.googlesource.com/c/1350195Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611502}

 - remove file_operation_manager_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - define mockChrome and install it in unittest Setup()
 - fix Closure compile errors

No change in test behavior, no new tests.

Bug: 907967
Change-Id: I523218dd179c5e9b0ae55b81d4a5480eea279f8c
Reviewed-on: https://chromium-review.googlesource.com/c/1352115Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611501}

This CL creates a new type of KeyboardHook to listen to media keys.
KeyboardHook::Create is split in two, providing access to each type of
KeyboardHook. This creates the media hook implementation for Windows,
and returns nullptr for other platforms.

Bug: 903582
Change-Id: I5eb6bbd94ec23dd54867eeb9ced585bc1b726961
Reviewed-on: https://chromium-review.googlesource.com/c/1333118
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611500}

Record metrics when user logs out the demo session by using the buttons
on shelf and system tray.

Bug: 900263
Change-Id: I23ad6bf89b3b0e7a0edee265792cbffe8a9b9951
Reviewed-on: https://chromium-review.googlesource.com/c/1328231Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611499}

@IntDef annotation are preferred way for declaring set of int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is replacing DetailsField enum to the style common with other @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface


Change-Id: I4e551520fd51c23a60f5d9d561fb23f6f0e93909
Reviewed-on: https://chromium-review.googlesource.com/c/1350901Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#611498}

If we currently have audio focus we should re-request
audio focus when the web contents is focused. This
means with grouping the media session that was
last focused will be pushed to the top of the stack.

BUG=906285

Change-Id: I9a7a72897c3c7be1186bdfbc4ef87364f7744a20
Reviewed-on: https://chromium-review.googlesource.com/c/1347614
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611497}

This was part of the reason one of the Android tests is failing.

Bug: 721403
Change-Id: I58493a24c32aaac2e568ade3541dea36ff87b88c
Reviewed-on: https://chromium-review.googlesource.com/c/1352325Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611496}

Bug: 867154
Change-Id: I456d03ab6ec8f9f995d8cbbc00f2a3e6b195bef1
Reviewed-on: https://chromium-review.googlesource.com/c/1352117Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611495}

Move CrashKeys class to //components/crash so that other components can
make use of it. This CL is a precursor for adding the installed feature
modules to crash reports.

Bug: 873719
Change-Id: I68d51a50cc9f239a94171ab7afec19b78224c53e
Reviewed-on: https://chromium-review.googlesource.com/c/1349729
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611494}

This CL allows PWA title bars to show the manage passwords icon
by moving it from LocationBarView to PageActionIconContainerView.

PWA title bar:
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368396&signed_aid=_t4hsG2GFjiEe__8vT-LtQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368397&signed_aid=q2ASdnVuMGpsPn9GAjrdmg==&inline=1

Location bar (no diff):
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368398&signed_aid=hPiZlkK4KcRMeaLejACitg==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=368399&signed_aid=q0PRCcZ5Fi0BRFv3oqcSQA==&inline=1

Bug: 788051
Change-Id: I54508125c77858bb8c40e80a0971fb6f9ddc9384
Reviewed-on: https://chromium-review.googlesource.com/c/1345672
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611493}

https://chromium.googlesource.com/chromium/deps/nasm.git/+log/a0a6951e259b..4ee6a69ce33b

$ git log a0a6951e2..4ee6a69ce --date=short --no-merges --format='%ad %ae %s'
2018-11-19 dalecurtis Remove uses of time(NULL) for build determism.
2018-11-19 dalecurtis Add README.patches, clone find_patches.py from ffmpeg repository.

Created with:
  roll-dep src/third_party/nasm

R=davidben

Bug: 766721
Change-Id: Ie98e0aae2b4c955913da9bc88e19820232aa0a88
TBR: davidben
Reviewed-on: https://chromium-review.googlesource.com/c/1352586Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611492}

Change-Id: I85fd510b4245f966e32340b9d433f7d9b96b3810
Bug: 904000
Reviewed-on: https://chromium-review.googlesource.com/c/1303041
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611491}

Changes:
1, make init screen focusable so as to read it's content for accessibility
2, announce first run experience is shown and autofill assistant is available
3, announce autofill assistant message
4, do not show autofill assistant bottom bar when showing init screen.
5, move the functions around in controller.cc to match their declaration order.

Bug: 806868
Change-Id: I7376ef905d3e7dc7f9949557f1307cb07ed28c95
Reviewed-on: https://chromium-review.googlesource.com/c/1351649
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611490}

Previously it was only available in test on Chrome OS

Bug: 719176
Change-Id: Ie329c8c900f0f9e57a2aadfe4863133b0fd8e39d
Reviewed-on: https://chromium-review.googlesource.com/c/1350376Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611489}

This line currently causes my gdb sessions to error out with:

  TypeError: unorderable types: list() > int()

Looks like this just wants to check for an empty list

Bug: None
Change-Id: I5de214c2373045a320e83db229b2ae449b78c967
Reviewed-on: https://chromium-review.googlesource.com/c/1352645Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611488}

The omnibox is always automatically focused after a blank new tab is
opened. Hence, we don't have to consider the omnibox being focused in
the triggering logic for reopen tab in-product help.

Bug: 887991
Change-Id: Ie9bac48ebb471002926156c488deb886688a4af4
Reviewed-on: https://chromium-review.googlesource.com/c/1351495Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611487}

Writes to cross-thread persistents are no longer atomic (release) stores, so
this is not more safe than a non-atomic access -- its correctness depends on
external synchronization, which at the sole call site is provided by
ProcessHeap::CrossThreadPersistentMutex(), which also guards all writes to
PersistentBase::raw_ for cross-thread handles.

Bug: 736037
Change-Id: Ic47ef65b731030cdf9897f2d7dd48899514eea5e
Reviewed-on: https://chromium-review.googlesource.com/c/1351567Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611486}

Prevents the loading animation from looking stuck. 0% looked buggy, like
we wouldn't even start loading. 100% looks similarly buggy, if we're
100% done we should not be stuck in a loading state.

Bug: chromium:908920
Change-Id: I280a9f7ce9f7db3920c41add9220a5ed4604b900
Reviewed-on: https://chromium-review.googlesource.com/c/1351103
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611485}