GitLab

CWS widget team requested to pass the access token by the 'initialize' message.

BUG=none
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23494024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221646 0039d316-1c4b-4281-b951-d872f2087c98

r186536 made it so focus focus changes while capture held are
ignored. Problem is we enter this scenario when activating a
window. In particular the window has capture, then we activate it but
the activation is ignored because it has capture. In this case we need
to allow the focus change else events are completely dropped.

BUG=277593
TEST=covered by tests
R=ananta@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23892006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221645 0039d316-1c4b-4281-b951-d872f2087c98

From the bug report and the other relevant bug 236392 reported by ASan,
The problem arises when ReadData() had some errors or completed, and then freed
the NetworkStats, but later the callback of the Write() is started on the freed
object. This most likely happened when the initial ReadData() had some errors.
So I did two modifications.
1. For the first time when ReadData is called, I checked the return value.
Only if it is ERR_IO_PENDING, it continues to Send requests.
2. The Write() callback is on a WeakPtr. If the NetworkStats object is freed,
the callback will be a no-op.

BUG=273917

Review URL: https://chromiumcodereview.appspot.com/23875004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221644 0039d316-1c4b-4281-b951-d872f2087c98

This is part 2/3 of re-landing https://codereview.chromium.org/22198004/.

It will land before part 1/3 @ https://codereview.chromium.org/23534006 because this part is core to getting Aura on the waterfall and part 1/3 has already been blocking us for too long.

We want to use the blacklist rather than hardcode OS versions in compositor_util, but for now hardcoding is fine...

TBR=zmo
BUG=233830, 267038

Review URL: https://chromiumcodereview.appspot.com/23874016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221643 0039d316-1c4b-4281-b951-d872f2087c98

Implement a people search provider that uses the Google+ People Search endpoint.

R=xiyuan@chromium.org
BUG=267208

Review URL: https://chromiumcodereview.appspot.com/23874015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221642 0039d316-1c4b-4281-b951-d872f2087c98

TEST=On aura, navigate to chrome.google.com/webstore; navigate through page and get spoken feedback.
BUG=285464

Review URL: https://chromiumcodereview.appspot.com/23819020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221641 0039d316-1c4b-4281-b951-d872f2087c98

Provide observer functions for NOTIFICATION_WEB_CONTENTS_CONNECTED, NOTIFICATION_WEB_CONTENTS_SWAPPED, NOTIFICATION_WEB_CONTENTS_DISCONNECTED

BUG=170921
TEST=no functional change

Review URL: https://chromiumcodereview.appspot.com/23784005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221640 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23772008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221639 0039d316-1c4b-4281-b951-d872f2087c98

This patch keeps the state of used layers and updates it in register
and unregister tile. This eliminates the need for CleanUpImageDecodeTasks.

This also provides a fix to the memory limits in the perftest, so by
comparison the performance should drop significantly. However, this is
only because the perftests are now properly testing the full
ManageTiles code path. The patch to remove CleanUpImageDecodeTasks
actually improves performance by about 15%.

BUG=283777
R=reveman@chromium.org,tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23757024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284219
TEST=run related code on daisy
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23745007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221637 0039d316-1c4b-4281-b951-d872f2087c98

The twitter site in the top_25 page set doesn't load completely.

BUG=224049

Review URL: https://chromiumcodereview.appspot.com/23740005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221636 0039d316-1c4b-4281-b951-d872f2087c98

Originally, the file browser private tasks APIs parse the arguments and generate
the results manually.  This CL lets the APIs use the auto generated helper
classes to parse the arguments.

BUG=241693
TEST=file_manager_browsertest

Review URL: https://chromiumcodereview.appspot.com/23740004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221635 0039d316-1c4b-4281-b951-d872f2087c98

DriveIntegrationServiceFactory::GetForProfile may return NULL, if the Drive
is disabled, so ->file_system() can be SEGV error. This CL replaces it by
drive::util::GetFileSystemByProfile and handles cases that NULL is returned.

BUG=284972
TEST=Ran unit_tests

Review URL: https://chromiumcodereview.appspot.com/23739006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221634 0039d316-1c4b-4281-b951-d872f2087c98

Instead of having absolute positions for most elements, Layout() now
works one by one, packing the View in question onto either the left or
right. This should allow us to configure whether window control buttons
are being inserted on the left or the right.

BUG=281788

Review URL: https://chromiumcodereview.appspot.com/23724019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221633 0039d316-1c4b-4281-b951-d872f2087c98

I don't see any reason why the .cur files are explicitly included and
then (were) also included by the rather obliquely named
ui_unscaled_resources. Assuming it's probably just cruft so nuke the
.curs and re-include the .grd in the browser-side. All of the .cur
that are in 'sources' are also in the .grd.

R=jamesr@chromium.org
BUG=283704,237249

Review URL: https://chromiumcodereview.appspot.com/23716004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221632 0039d316-1c4b-4281-b951-d872f2087c98

use "--trace-shutdown" to enable the feature to start profiling when the user has pressed "shutdown" and specify "--trace-shutdown-file=<name>" to specify the file where you want to dump to. Additionally you can specify which modules to trace with e.g. "--trace-shutdown=base,net".

That said: NOTE that the dumping will cost time since it has to be done after the shutdown of Chrome is finished. As such it takes time and will make it impossible to get a correct reading of time from shutdown till a new startup is finished.

Note: This is similar to the trace-startup - with the exception that upon shutdown it is not possible to rely on threads for IO anymore.

BUG=281524
TEST=visual tests

Review URL: https://chromiumcodereview.appspot.com/23691025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221631 0039d316-1c4b-4281-b951-d872f2087c98

Now we detect unexpected process termination for all chrome processess so the
code for renderers and flash is redundant.

BUG=275818
TEST=none
R=cpu@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23687007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221630 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23658022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221628 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23653019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221627 0039d316-1c4b-4281-b951-d872f2087c98

linux-release-64/sizes/chrome/chrome: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes%2Fchrome&rev=221383&checked=core
linux-release-64/sizes/chrome-text/text: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes%2Fchrome-text&rev=221383&checked=all
linux-release/sizes/chrome/chrome: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome&rev=221383&checked=core
linux-release/sizes/chrome-text/text: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome-text&rev=221383&checked=all

BUG=240647
R=hajimehoshi@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23460018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221626 0039d316-1c4b-4281-b951-d872f2087c98

So that the functions can escape 'const char*' or 'const char16*'
without creating a std::string or string16 object for the parameter.

BUG=none
TEST=StringEscapeTest.JsonDoubleQuoteNarrow

Review URL: https://chromiumcodereview.appspot.com/18648003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221625 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221624 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157329:157336&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/23726022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221623 0039d316-1c4b-4281-b951-d872f2087c98

* Automatically delete the whole database when Watchdog is uninstalled
* Give the activityLogPrivate API the ability to delete the entire database
* Give the activityLogPrivate API the ability to selectively delete URLs

BUG=277260
R=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23629015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221622 0039d316-1c4b-4281-b951-d872f2087c98

until after session restore has completed.

This is mainly to help login/startup times so that Chrome is useful to
the user earlier.  To make sure that this is actually helping, this CL
includes a Finch experiment that will only enable the deferral on 50%
of the clients.

It is also expected that deferring these will help with some problems
we've seen when extensions attempt to do GAIA authentication.

BUG=279427,259791
TEST=Ran performance tests on ChromeOS and Linux

Review URL: https://chromiumcodereview.appspot.com/23618014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221621 0039d316-1c4b-4281-b951-d872f2087c98

Previously, an app could request just the fileSystem.write permission,
followed by just the fileSystem.directory permission. This would prompt
the user to allow write access to files and read-only access to
directories, respectively. If the app were to later request both at the
same time, this would allow write access to directories without further
user confirmation.

This change adds an implicit fileSystem.writeDirectory if both
fileSystem.write and fileSystem.directory are requested at the same
time. This requires the user to confirm write access to directories.

BUG=148486

Review URL: https://chromiumcodereview.appspot.com/23506021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221620 0039d316-1c4b-4281-b951-d872f2087c98

Currently just implements the API layer which allows adding a listener and defines a manifest key to specify mdns service types to watch.

BUG=280900
TBR=erg

Review URL: https://chromiumcodereview.appspot.com/23437015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221619 0039d316-1c4b-4281-b951-d872f2087c98

To be rolled into the tree when quiet, and then reverted.

BUG=285442
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/23581009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282725

Review URL: https://chromiumcodereview.appspot.com/23765003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221617 0039d316-1c4b-4281-b951-d872f2087c98

Once https://codereview.chromium.org/23848006/ has landed, we can remove the
webkit category, and leave only webkit.console.

R=nduca@chromium.org, tonyg@chromium.org
BUG=264308

Review URL: https://chromiumcodereview.appspot.com/23777006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221616 0039d316-1c4b-4281-b951-d872f2087c98

kPasteboardTypeFilePromiseContent simply does not work, and it's getting to be a pain working around its issues.

This reverts r219601 and r207414, and works around the original bug in a new way.

BUG=249271, 278515, 282916
TEST=fixes bug 282916, does not regress either bug 278515 or bug 249271

Review URL: https://chromiumcodereview.appspot.com/23775005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221615 0039d316-1c4b-4281-b951-d872f2087c98

The prefs are integrated into the PlatformVerificationFlow class.

BUG=chromium:270316
TEST=unit

Review URL: https://chromiumcodereview.appspot.com/23765004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221614 0039d316-1c4b-4281-b951-d872f2087c98

> Files.app: Let the PreviewPanel class control the visibility of the preview panel.
> 
> Originally, PreviewPanel is not used from any code.
> This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel.
> 
> BUG=284215
> TEST=manually
> R=yoshiki@chromium.org
> 
> Review URL: https://codereview.chromium.org/23464030

TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/23903018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221613 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=toyoshim@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23606017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221611 0039d316-1c4b-4281-b951-d872f2087c98

BUG=256576

Review URL: https://chromiumcodereview.appspot.com/23601004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221610 0039d316-1c4b-4281-b951-d872f2087c98

the client private key is a 1024-bit RSA or DSA key.

Older Estonian ID cards with 1024-bit RSA keys cannot sign SHA-256
hashes.

1024-bit DSA keys were formerly specified to be used with SHA-1 only.

R=agl@chromium.org,rsleevi@chromium.org
BUG=278370
TEST=manual testing by someone who has an older Estonian ID card

Review URL: https://chromiumcodereview.appspot.com/23596013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221609 0039d316-1c4b-4281-b951-d872f2087c98

When in DWM, the DefWindowProc handling of WM_NCPAINT was clearing (to
white) in the area that was not yet drawn. When the wndclass's
background is set to COLOR_WINDOW this is avoided and the frame
appears to stay more "solid".

This only affects the white flash in the NC area in the linked bug,
not the grey in the content area. We should also consider reverting
the compositor.cc change from here http://crrev.com/192657 as it seems
to make resize a bit laggier.

R=sky@chromium.org
BUG=177115

Review URL: https://chromiumcodereview.appspot.com/23596011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221608 0039d316-1c4b-4281-b951-d872f2087c98

shader code is one example where abs() without std:: is acceptable.
But we still would like to generally keep the PRESUBMIT check that
enforces all uses of abs() and related functions must be prefixed
with "std::"

So in order to prevent PRESUBMIT annoyances when we modify shader
code or other similar situations, the regular expression for the
presubmit is modified to recognize a "// NOLINT" comment. In that
case, it ignores any un-prefixed abs() usage.

BUG=261900

Review URL: https://chromiumcodereview.appspot.com/23591027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221607 0039d316-1c4b-4281-b951-d872f2087c98