- 16 Feb, 2018 40 commits
-
-
Makoto Shimazu authored
Currently 'git cl uplaod' fails when all files are skipped (e.g. fixing LayoutTest). This patch makes it pass. Bug: none Change-Id: Ib028d39ed63e0cba21918cb565a5c264ad047da7 Reviewed-on: https://chromium-review.googlesource.com/923782Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537270}
-
Yuta Kitamura authored
We plan to have WebViewScheduler owned by Page, which will delay the execution of WebViewScheduler's destructor because Page is garbage collected. This patch moves the execution of the destructor to WebViewImpl:: Close() to ensure nothing will break even if we clear the WebViewScheduler object early. Bug: 812986 Change-Id: I5de6b7ad3f3598922a408b2a26cec4718a132f6f Reviewed-on: https://chromium-review.googlesource.com/923246Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#537269}
-
Hayato Ito authored
We should never leave any node which has a LayoutObject, but doesn't have a parent in a flat tree after having run UpdateStyleAndLayoutTree. That means we forget to detach a node which should be detached. Update TestExpectations because some tests would hit this assertion when IncrementalShadowDOM is enabled. Bug: 776656 Change-Id: I273b9ddd083766fe687aedb178fc6e0c65248fde Reviewed-on: https://chromium-review.googlesource.com/920329 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537268}
-
Pavol Marko authored
When a synchronous profile load is happening (e.g. after chrome restart on Chrome OS), make sure to invoke UserCloudPolicyManagerChromeOS's OnStoreLoaded handling. This is also the place where user affilitaion is determined. BUG=810013 TEST=browser_tests --gtest_filter=*UserAffiliation* Change-Id: Ib4a4b1ad3e61eba637f527dfa89cb5cd1fd2159b Reviewed-on: https://chromium-review.googlesource.com/908565Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#537267}
-
Hikaru Nishida authored
This patch changes "5206311-1.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename this test file to "delete_selection_contains_table_row.html" to provide hint about what this test file verifies. Change-Id: Ie0f6e54b998c9679e316f5e488e6a19679236d12 Reviewed-on: https://chromium-review.googlesource.com/914209 Commit-Queue: Hikaru Nishida <hikarun@google.com> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537266}
-
Xi Cheng authored
Change-Id: Ice85ebdd73350f8228a7591496716d73efe3695b Reviewed-on: https://chromium-review.googlesource.com/922862 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537265}
-
Alex Clarke authored
This patch plus https://chromium-review.googlesource.com/c/chromium/src/+/921082 Fixes the broken headless browswer tests in https://chromium-review.googlesource.com/c/chromium/src/+/762520 Bug: 777763 Change-Id: I44ef4ea78e673129e65d23fdd4cd1169569e478b Reviewed-on: https://chromium-review.googlesource.com/922622 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537264}
-
Charles Harrison authored
We removed this constraint earlier. TBR=avi@chromium.org Bug: None Change-Id: I6ccbfc0d15e520a48921328eb5966147b0aa29dd Reviewed-on: https://chromium-review.googlesource.com/922504Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#537263}
-
https://chromium.googlesource.com/angle/angle.git/+log/b92f92a780a1..b66de58fc571 $ git log b92f92a78..b66de58fc --date=short --no-merges --format='%ad %ae %s' 2018-02-15 thakis Mark third-party code in ANGLE as no_chromium_code. 2018-02-15 jmadill Add missing is_fuchsia to system_utils selection. 2018-02-15 jmadill Vulkan: Add depth/stencil surfaces. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Ib19d3fc02e35bb0b490918a34e3b8b48e6c41901 Reviewed-on: https://chromium-review.googlesource.com/923702Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537262}
-
Khushal authored
This reverts commit 2319141f. R=chrishtr@chromium.org TBR=enne@chromium.org, piman@chromium.org Bug: 776216 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I36744f2939f565ce2e89a5d7c850dfcd138b70cb Reviewed-on: https://chromium-review.googlesource.com/918122Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537261}
-
Gauthier Ambard authored
This CL changes the animations of the toolbar when the omnibox is unfocused. The buttons are now appearing after the omnibox is resized. Bug: 804748 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I149a004f4aa9e8d643ad2cc6d88de95855a66f83 Reviewed-on: https://chromium-review.googlesource.com/922102 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537260}
-
Eero Häkkinen authored
This CL increases AudioArray alignment on x86 family architectures so that blink::VectorMath functions can better utilize AVX optimizations. Bug: 778262 Change-Id: Ibe94130ba0d0223342ae25f844c69767194370e9 Reviewed-on: https://chromium-review.googlesource.com/738239Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#537259}
-
Takayoshi Kochi authored
After multiple shadow roots are removed, getting a shadow root can be done by Node::GetShadowRoot() or Element::GetShadowRoot(). Old code used to use get ElementShadow first, then use ElementShadow::GetShadowRoot(), but it is no longer necessary. This is a step to merge ElementShadow class into ShadowRoot class. TBR=dmazzoni@chromium.org, mlamouri@chromium.org Bug: 624724 Change-Id: I44af0d2de85e45badb36e5ba59facc03f7d81602 Reviewed-on: https://chromium-review.googlesource.com/923245 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#537258}
-
Jens Widell authored
Change-Id: Ibc5e0d946c57a4a3be7fc24a9c0773ec830514f0 Reviewed-on: https://chromium-review.googlesource.com/922822Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#537257}
-
Tsuyoshi Horo authored
The pull request has been merged. https://github.com/WICG/webpackage/pull/119 Bug: 803774 Change-Id: Ic14b0eeb1e63ce687a51709098f049c2dea99cba Reviewed-on: https://chromium-review.googlesource.com/923764Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#537256}
-
Michael Lippautz authored
Latest clang rolls require a bit more stack space when calling through the eager marking visitors. Bug: chromium:807994 Change-Id: I5bb2a80fdca7f5d536fd965a9cd6151e81573f9a Reviewed-on: https://chromium-review.googlesource.com/922206Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Network traffic annotation is added to: google_apis/gcm/engine/connection_factory_impl.cc Bug: 656607 Change-Id: Ibc0d1cc04607b67100d9922c27b867db2761c633 Reviewed-on: https://chromium-review.googlesource.com/916001 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#537254}
-
Kent Tamura authored
Add |factory| argument to Element:: CloneElementWithoutAttributesAndChildren(), and use it in Document:: importNode(). Bug: 572693, 812089 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1c89cdf45f9a1f38b9ab6a3e7149692b66e1c44d Reviewed-on: https://chromium-review.googlesource.com/920965 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Reilly Grant authored
These mock methods are never used by tests and can be safely removed. If possible the corresponding virtual methods in DataReductionProxyConfig are also made non-virtual. Change-Id: I76aa2fe9ff1e8fddb5f9204b1d79681136694a16 Reviewed-on: https://chromium-review.googlesource.com/919322Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537252}
-
Takayoshi Kochi authored
HTMLShadowElement.h is unnecessary. Change-Id: I5153baa3c3022d67b4f2754a6804e2f45c226495 Reviewed-on: https://chromium-review.googlesource.com/923682Reviewed-by:
-
Khushal authored
When requesting a buffer for OOP raster, the client requests the largest free size for which no tokens are pending, and can be allocated without waiting. This is queried from RingBuffer::GetLargestFreeSize. However, since this size is rounded up to the next alignment when making the allocation, this results in synchronously waiting on tokens to make room for the extra padding. Ensure that ShrinkLastBlock rounds up the new size for the block so the buffer always has memory aligned free size. R=enne@chromium.org, piman@chromium.org Bug: 803925 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iff1286b6f412f126dbf33300387f85f9c21e91ed Reviewed-on: https://chromium-review.googlesource.com/922445 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537250}
-
Tsuyoshi Horo authored
Currently DCHECK in ExtensionApiFrameIdMap::GetCachedFrameDataOnIO() fails because the default value of ResourceRequest.render_frame_id is 0 which is a valid ID. Bug: 803774 Change-Id: I41207153e22f0b856de0b730b402dbae1b26c518 Reviewed-on: https://chromium-review.googlesource.com/923763Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#537249}
-
Yoshifumi Inoue authored
This patch moves |VisibleUnitsTest.startOfword| to |VisibleUnitsWordTest| to improve grouping of test cases for ease of maintenance. Note: The patch[1] moves |VisibleUnitsWordTest.endOfWord| to |VisibleUnitsWordTest|. [1] http://crrev.com/c/923604 Move VisibleUnitsTest.endOfWord to VisibleUnitsWordTest Change-Id: Id197e62704bb31dfc66a6a83ec24aabe3ccf21f9 Reviewed-on: https://chromium-review.googlesource.com/923606 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
We have several component extension as the initial default app, which means set to default before user explicitly changes default app. Audio player and the "Office Editing for Docs, Sheets & Slides" app were not included in that list despite these are also components. Bug: 810986 Test: unit_tests --gtest_filter=FileManagerFileTasksTest.* Test: manually verified Office Editing shown as default Change-Id: I1ee20773714ecda50fbe3d17f8cda1c0bb72fd96 Reviewed-on: https://chromium-review.googlesource.com/920124Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537247}
-
Yoshifumi Inoue authored
This patch moves |VisibleUnitsTest.endOfword| to |VisibleUnitsWordTest| to improve grouping of test cases for ease of maintenance. Note: The patch[1] moves |VisibleUnitsWordTest.startOfWord| to |VisibleUnitsWordTest|. [1] http://crrev.com/c/923606 Move VisibleUnitsTest.startOfWord to VisibleUnitsWordTest Change-Id: Id7929d2aefb766fb40701a5be7a2ca70614659f9 Reviewed-on: https://chromium-review.googlesource.com/923604Reviewed-by:
-
Matt Falkenhagen authored
This matches the service worker specification and Firefox. This change itself is probably not enough to skip all EMBED/OBJECT requests, as some requests get initiated by PepperURLLoaderHost or MimeHandlerViewContainer. In implementor concerns: https://w3c.github.io/ServiceWorker/#implementer-concerns "Plug-ins should not load via service workers. As plug-ins may get their security origins from their own urls, the embedding service worker cannot handle it. For this reason, the Handle Fetch algorithm makes the potential-navigation-or-subresource request (whose context is either <embed> or <object>) immediately fallback to the network without dispatching fetch event." In Handle Fetch: https://w3c.github.io/ServiceWorker/#handle-fetch "If request is a potential-navigation-or-subresource request, then: Return null." R=kinuko, yhirano Bug: 771933 Change-Id: Ia04ae8dec8c968de6a73dca088aa88a67b21718a Reviewed-on: https://chromium-review.googlesource.com/923445Reviewed-by:
-
Robert Ma authored
This reverts commit 47b21786. Reason for revert: rebaseline-cl fails, which blocks wpt-import It's a bit premature to set this flag, which includes mac10.13 in rebaseline-cl automatically. Baselines haven't been created for mac10.13 so the first engineer/bot that tries to run `rebaseline-cl` with the flag enabled will need to conduct the huge mac10.13 rebaseline. Original change's description: > Set is_try_builder on mac10.13_blink_rel in builders.json. > > To optimize baselines properly, rebaseline-cl needs mac10.13_blink_rel > in its try bot set, because mac10.13 is the only port whose baseline > search path begins with "platform/mac". If BaselineOptimizer doesn't > see a baseline in platform/mac, it will consolidate matching baselines > from other Mac ports under platform/mac-mac10.12, and fail to merge them > with matching baselines in platform/win into the generic path. > > Bug: 812784, 774301 > Change-Id: Ifda7a0051bed79a044ab516b40c0795242247b46 > Reviewed-on: https://chromium-review.googlesource.com/922791 > Commit-Queue: Steve Kobes <skobes@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537146} TBR=qyearsley@chromium.org,dpranke@chromium.org,skobes@chromium.org Change-Id: Id6c23f2bde53ac42fbc49fa5b5211b2f1d90303f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812784, 774301 Reviewed-on: https://chromium-review.googlesource.com/923781Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#537244}
-
Wei Li authored
These mainly include painting placeholders for cross process subframes, sending messages to browser to inform printing such subframes, serialization and deserialization of printed content, and compositing these contents into the final result. The high level design doc is at goo.gl/CF1RUy, and browser side change is at https:/crrev.com/c/822155. BUG=455764 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I15066f46da41d416356cad7392efb669b5f9f024 Reviewed-on: https://chromium-review.googlesource.com/838512Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#537243}
-
Jian Li authored
Per the spec, CRLF should be added to the beginning of all boundaries to separate MHTML parts. We did not add CRLF for boundary following binary part and this patch fixes this issue. In addition, we need to support parsing the binary part without CRLF added to the following boundary in order to support the MHTML files that are saved with the bug. This CL is built based on Dan's parser fix: https://chromium-review.googlesource.com/c/chromium/src/+/905391 Thanks Dan for finding the bug and proposing a fix. BUG=809806 Change-Id: I8dea2af8044b96abb4bb72149994e16d61fb96ed Reviewed-on: https://chromium-review.googlesource.com/915135 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537242}
-
Giovanni Ortuño Urquidi authored
Changes BookmarkAppNavigationThrottle to retrieve the disposition and open the app if the disposition is CURRENT_TAB, FOREGROUND_TAB, or NEW_WINDOW. This means that navigations started with Ctrl + Click will no longer result in an app window being opened. Bug: 756675 Change-Id: I4975c967554f1c380edeb2a49ed1c47dbc324afa Reviewed-on: https://chromium-review.googlesource.com/907773Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#537241}
-
Christopher Cameron authored
Make BrowserCompositorViewMac be the source of ScreenInfo, and merge the update for screen properties with the resize update as BrowserCompositorViewMac::UpdateNSViewAndDisplay. Merge all RenderWidgetHostViewMac paths that update size or screen info into RenderWidgetHostViewMac::UpdateNSViewAndDisplayProperties, which communicates the changes (if any) to RenderWidgetHostImpl. Change-Id: Idc7f654c93d0622815825fdb6fff46afcb38767e Reviewed-on: https://chromium-review.googlesource.com/918284 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#537240}
-
Wez authored
The action rules had |depfile| set, but did not actually create a file, resulting in the steps being re-run even in no-op builds. Bug: 812352 Change-Id: Ia1aa862b2ec96cb5a0304339c861f564bc77b34a Reviewed-on: https://chromium-review.googlesource.com/920794 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537239}
-
Toni Barzic authored
Adds "enabled_on_launch" optional property to "secondary_kiosk_apps" items manifest type. When set, the property controls whether the associated extension should be enabled before kiosk app launches (i.e. before onLaunched event is sent to the kiosk app): * when set to true, the associated secondary extension will be enabled on kiosk app launch - provided that the extension is not disabled due to a reason different than user action. E.g. if the extension is disabled due to a policy, the extension will remain disabled, but DISABLED_USER_ACTION will be removed from its disable reasons. * if set to false, the associated secondary extension will be disabled on kiosk app launch; DISABLED_USER_ACTION will be added to the extension's disable reasons. If the property is not set, the secondary extension's enabled state will not be changed as part of kiosk session startup. BUG=800441 Change-Id: I0b44d1c05846d811d7840cbce65246c0dd7ea885 Reviewed-on: https://chromium-review.googlesource.com/868398 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537238}
-
Yoshifumi Inoue authored
This patch introduces |FlatTreeTraversal::AncestorsOf()| as |NodeTraversal|. This patch is a preparation of the patch[1]. Note: The patch[2] introduces |FlatTreeTraversal::InclusiveAncestorsOf()|. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection [2] http://crrev.com/c/742770 Introduce FlatTreeTraversal::InclusiveAncestorsOf Bug: 778507 Change-Id: I5f76f00c06a4e02b5981600049af11853fa2f60b Reviewed-on: https://chromium-review.googlesource.com/923443Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/2388506a1ba1..067a44fcad91 $ git log 2388506a1..067a44fca --date=short --no-merges --format='%ad %ae %s' 2018-02-16 hnakashima Fix fallthroughs in XFA code. 2018-02-16 dsinclair Improve performance of writing path floats. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I92b9eeac8b32895ae7bd69c93cce72bf5366efb3 Reviewed-on: https://chromium-review.googlesource.com/923704 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537236}
-
Hikaru Nishida authored
Before this patch, default values of members in WebSelectionBound are specified in constructor initialization list. To improve maintainability, this patch adds default values to each member definitions. This patch also adds default constructor of WebSelectionBound to improve readability of the patch crrev.com/c/908169 . TEST: No change in behavior. Change-Id: I54c7910aba6ce9fe1dd4c881c7b944da52cf5ec0 Reviewed-on: https://chromium-review.googlesource.com/920048 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoichi Osato authored
LocalCaretRectTest returns null LayoutRect for "after" node such as kAfterAnchor, kAfterChildren, kOffsetInAnchor and offset==length. This patch adds such cases. I'll fix it in later patch. Bug: 812535 Change-Id: I6349360ab6b7ff41870e05f154471436653917dc Reviewed-on: https://chromium-review.googlesource.com/920127Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#537234}
-
Yoshifumi Inoue authored
This patch changes |DeleteSelectionCommand::HandleGeneralDelete()| to use the clean layout tree for calling |start_node->GetLayoutObject()| after calling |DeleteTextFromNode()| or |RemoveChildrenInRange()| to avoid removing |start_node|. Note: When |Text| node with ::first-letter is modified, Blink detach layout object from it in |Text::UpdateTextLayoutObject()| to follow |ShouldUpdateLayoutByReattaching()| which returns true for |true| for |Text| node with ::first-letter. Bug: 808516 Change-Id: I7139398ca3938e56960c81c9196bd58e91bed668 Reviewed-on: https://chromium-review.googlesource.com/920051 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit fefcfdfc. Reason for revert: WinMSVC64(dbg) bot error: https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20(dbg)/2965 c:\b\c\b\win\src\content\browser\webauth\authenticator_impl.cc(393) : error C2220: warning treated as error - no 'object' file generated c:\b\c\b\win\src\content\browser\webauth\authenticator_impl.cc(393) : warning C4702: unreachable code Original change's description: > [webauthn] Don't terminate operations early that return NotAllowedError. > > NotAllowedError responses should not be returned until after the > timer has expired in order to prevent a leak of possibly-identifying > user information. > > See https://w3c.github.io/webauthn/#createCredential step 21. > > Bug: 809104 > Change-Id: I3655f4c9cac29dc29c68c234c2e0b8ea00f1c5c2 > Reviewed-on: https://chromium-review.googlesource.com/912149 > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537229} TBR=engedy@chromium.org,kpaulhamus@chromium.org Change-Id: I022d8586c26a9201c5d80a025b2a954cca3fe5d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809104 Reviewed-on: https://chromium-review.googlesource.com/923223Reviewed-by:
-
Takeshi Yoshino authored
This reverts commit 12325b07. Reason for revert: Broke linux-chromeos-dbg build. See my comment for the details Original change's description: > NetworkConfig: Escape names before passing to i18n() > > i18n() asserts if any unsafe tags are passed to it. We need to > HTMLEscape any network names passed to i18n(). > > Bug: 811562 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I3112dc2f38b0560d1d6ad9fdde91581f1c498a45 > Reviewed-on: https://chromium-review.googlesource.com/920903 > Reviewed-by: Toni Barzic <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537108} TBR=stevenjb@chromium.org,tbarzic@chromium.org Change-Id: I15e8ea3b7ea7eb4bc45ff9262d0c0176fda4c481 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811562 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/923222Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#537231}
-
