- 05 Oct, 2018 40 commits
-
-
Tetsui Ohkubo authored
This CL adds Clear All button to NewUnifiedMessageCenterView. NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: Ibadc6e5a3d799fcbeb6c94199d68656d169295d4 Reviewed-on: https://chromium-review.googlesource.com/c/1260530Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#597005}
-
Yoshifumi Inoue authored
This patch makes Element#innerText to collapse white space after <br> to avoid emitting extra space for improving interop. Bug: 892491 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8dd429a8af6ecd2e6d5195d6a6ec7b0214c6345c Reviewed-on: https://chromium-review.googlesource.com/c/1263638Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597004}
-
Ryan Sturm authored
This allows a future CL to add PreviewsState to this object without violating DEPS. Change-Id: Ibfb1def6224f208147d2cb37e340a4cebf23c6ca TBR=mmenke,jianli Change-Id: Ibfb1def6224f208147d2cb37e340a4cebf23c6ca Reviewed-on: https://chromium-review.googlesource.com/c/1263395 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597003}
-
Xiaoqian Dai authored
After the drag ends, the dragged tab window might need to merge back into the source window if 1) the dragged window or the source window is not added to overview and 2) the dragged window has dragged farther than half of the screen height and 3) the dragged window is not in snap preview area and 4) the dragged window is not dragged to other side of the splitscreen if source window is showing in splitscreen. Bug: 887739 Change-Id: I21bab4ef5fbfc4c9c4294a6028798be3793b8b5c Reviewed-on: https://chromium-review.googlesource.com/c/1259468 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597002}
-
Yuta Kitamura authored
This CL moves web_thread.h to blink/renderer/platform/scheduler/public and renames WebThread to Thread, so this class can only be referred from Blink. All the existing #include lines are rewritten, but references to WebThread in Blink are not renamed yet. The rename will happen in later CLs. To make the migration easier, temporary aliases of old names are added. Bug: 826203 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3cc9d209fd0c53c8a6362321661a361602f12dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1257473 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597001}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7a24422d086..56216d7832a4 git log a7a24422d086..56216d7832a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chiniforooshan@chromium.org Telemetry: pixel approximated/checkerboarded Created with: gclient setdep -r src/third_party/catapult@56216d7832a4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890757 TBR=sullivan@chromium.org Change-Id: I00fdd306c02a5ff45b9706d9664e45bed98bec4f Reviewed-on: https://chromium-review.googlesource.com/c/1263862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597000}
-
Matt Falkenhagen authored
This treats the network service crashing like the worker's process crashing, and prevents clients getting stuck with a broken worker. Bug: 848256 Change-Id: Iab8864d673da04cea062f65644e2ee10f74de4da Reviewed-on: https://chromium-review.googlesource.com/c/1260903Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596999}
-
Darren Shen authored
For the inline handwriting feature, we introduced a private onFocus event to pass along stylus information. However, third party IMEs cannot listen to this, so we have to dispatch the public onFocus events to them. In our original patch, we did consider this issue and made sure that we only dispatch the private onFocus if "HasListener" is true. However, it turns out that "HasListener" returns true if *any* extension is listening to the event, so as long as the XKB extension is active, no third party IMEs will receive the public onFocus event. We change it so that we check whether each particular extension is listening to the private onFocus event before dispatching, so that the XKB extension receives the private onFocus event and third party IMEs receive the public one. We think that the other usages of HasListener are technicaly incorrect as well, but we will fix them in a follow up patch to limit the scope of this one. TBR=shuchen@chromium.org Bug: 835699 Change-Id: I7895d8503eb3677de8d248475f2856d1dfd397ca Reviewed-on: https://chromium-review.googlesource.com/c/1258702 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596998}
-
Ilya Sherman authored
* Hide more internal logic within PendingProfiles * Ensure that the functions that collect profiles cannot be called without verifying that collection is enabled. * Move profile serialization out from being under a lock. There's an important implementation detail: Profiles stored in the two vectors might end up interleaved, in terms of timestamps. However, it is still guaranteed that profiles from a single process are ordered consistently in the uploaded data, which is sufficient for later efficient processing. BUG=888716,851163 R=chengx@chromium.org Change-Id: I94c4ab165753e8a09a53490494f8161b197f1428 Reviewed-on: https://chromium-review.googlesource.com/c/1258514Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596997}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/84583f618399..0a74e09b39c1 git log 84583f618399..0a74e09b39c1 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0af97cea..618ddbcb (596847:596951) Created with: gclient setdep -r src/third_party/webrtc@0a74e09b39c1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie39b01f2cdf1f4e3cb6506f6227ea9c6162e7da7 Reviewed-on: https://chromium-review.googlesource.com/c/1263860Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56f1cb670eca..3b0f761dc3cd Created with: gclient setdep -r src-internal@3b0f761dc3cd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic362e27c3b92777804bd669671483dcbc099ccdb Reviewed-on: https://chromium-review.googlesource.com/c/1263856Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596995}
-
Naoki Fukino authored
When the current directory is hidden by filter setting (incl. disabling "Show all Play folders" option), the current directory should be changed to visible one. This CL change the current directory to the volume's root directory for such cases to be consistent with the case when the current directory is deleted. . Bug: 877405 Test: manual test on a arc-enabled device, and browser_tests --gtest_filter=*hideCurrentDirectoryByTogglingHiddenAndroidFolders Change-Id: Ie2db1f297df0cf6ee1dcf2719f204763985a1c80 Reviewed-on: https://chromium-review.googlesource.com/c/1258807 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596994}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b4ad765627f..4f87e2255b8a git log 1b4ad765627f..4f87e2255b8a --date=short --no-merges --format='%ad %ae %s' 2018-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 76dd2d6f9f5e..14246813a110 (4 commits) Created with: gclient setdep -r src/third_party/skia@4f87e2255b8a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I5e3b8cbb44c9dd15bc0b78813e2dcb6c339aa97a Reviewed-on: https://chromium-review.googlesource.com/c/1263857Reviewed-by:
-
Lei Zhang authored
Change-Id: If2ff3976bae6216853ba9a70a189ba0932f16c6b Reviewed-on: https://chromium-review.googlesource.com/c/1257245 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#596992}
-
Fergal Daly authored
This creates a blinkpy/preusbmit directory, so that we run also run audit_non_blink_usage_test.py Change-Id: I7ce7832a90bc4a02e3f886fad216a4eb82188064 Reviewed-on: https://chromium-review.googlesource.com/c/1261103 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#596991}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f7d74f7cd02..a7a24422d086 git log 3f7d74f7cd02..a7a24422d086 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chiniforooshan@chromium.org Telemetry: fix thread_other_cpu_time_per_frame_tbmv2 Created with: gclient setdep -r src/third_party/catapult@a7a24422d086 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891546 TBR=sullivan@chromium.org Change-Id: I4b92e40272ff65e082998a2ca6379ae661e43d1a Reviewed-on: https://chromium-review.googlesource.com/c/1263858Reviewed-by:
-
Noel Gordon authored
Now we have the QuickView <webview> infra to detect the 'loaded' state of thew <webview> content, add a <file-safe-media> image test and also check the <webview> renders its content on a transparent black body. Bug: 891150 Change-Id: I8e6aac85ce09e0fcbe0cbba660630d1427e2962b Reviewed-on: https://chromium-review.googlesource.com/c/1263678Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596989}
-
Ian Clelland authored
This queues a report through the Reporting API whenever requestPictureInPicture is called in a frame in which the 'picture-in-picture' feature is not allowed according to feature policy. Bug: 867471 Change-Id: I1cede10385f6a5110fd0ddd5bf124ff5d3737dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1262432 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596988}
-
Sergei Datsenko authored
BUG=chromium:854481 Change-Id: I3f6fe2429d9bc762b3f6552811c3d58326b18bac Reviewed-on: https://chromium-review.googlesource.com/c/1263641Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#596987}
-
Jinsuk Kim authored
SwipeRefreshHandler is used for the active WebContents to handle swipe-to-refresh gesture. It's now managed as TabWebContentsUserData - created on the first initialization of WebContents, and destroyed at the end of the life of the Tab it belongs to. Accompanied changes: - TabGestureStateListener should also have the same lifetime i.e. created on the first WebContents of a Tab becomes active, then have its associated WebContents init/destroyed as active one changes over time, and finally destroyed together with Tab. Previously it was created repeatedly for new WebContents. This CL changes it. - All TabWebContentsUserData (so far) need to call |cleanupWebContents| upon |destroy|. This CL factors the common pattern out to their base class. Bug: 877878 Change-Id: I6f6264866338e763be7737716b93dab86ea1414b Reviewed-on: https://chromium-review.googlesource.com/c/1253525 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596986}
-
Darren Shen authored
KeyboardUI::GetKeyboardWindow lazily creates a keyboard window and loads web contents. Because the KeyboardController lifecycle is quite complicated, it's not clear from reading the code whether a call to GetKeyboardWindow creates a window or not. In fact, only one particular call to GetKeyboardWindow creates the keyboard window. All the other calls are guaranteed to occur after that call. Thus, we keep that one call to GetKeyboardWindow to create the keyboard window and replace the other calls with KeyboardController ::GetKeyboardWindow, which, by contrast, has no side effects. Bug: 845780 Change-Id: I56e86932e82ced8b25a6f9eb034c60034e3a3548 Reviewed-on: https://chromium-review.googlesource.com/c/1235353 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596985}
-
siyua authored
The feature is already existing, and previously we just by default disabled it. This CL ensures we can config this feature from Chrome://flags Bug: 852904 Change-Id: I9c5e37070eed995e03b5bfddcb7fd05c744a9091 Reviewed-on: https://chromium-review.googlesource.com/c/1262929 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#596984}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 71098fe5. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25850 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ia0cff643cfe95b7fa0aea7460abb60051238234f Reviewed-on: https://chromium-review.googlesource.com/c/1263591 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596983}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e9443f5b7f8..d1d4dc8eb878 git log 8e9443f5b7f8..d1d4dc8eb878 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d1d4dc8eb878 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6ad82b1795c42dc41426f292ea03023f36a52770 Reviewed-on: https://chromium-review.googlesource.com/c/1263855Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 8aa00e1b. Reason for revert: Causes crash on shutdown: Received signal 11 SEGV_MAPERR 000000000088 #0 0x7f228f7b5a3f base::debug::StackTrace::StackTrace() #1 0x7f228f7b5521 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f22832c80c0 <unknown> #3 0x7f228a01add1 std::__1::__tree<>::find<>() #4 0x7f228a0294dc dbus::ObjectManager::UnregisterInterface() #5 0x7f228a1978b3 bluez::BluetoothAdapterClientImpl::~BluetoothAdapterClientImpl() #6 0x7f228a1a05b0 bluez::BluetoothDBusClientBundle::~BluetoothDBusClientBundle() #7 0x7f228a1c808e bluez::BluezDBusManager::Shutdown() #8 0x559074b4094e ChromeBrowserMainPartsLinux::PostDestroyThreads() Original change's description: > Reland "bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState" > > This is a reland of 837b3c20 > > The original patch attempted to init the alternate dbus client on Linux where > there is no alternate bus connection. The latest patchset fixes this by > returning early if there is no alternate bus connection. > > TBRing since it's a minor addition to the original patch. > > Original change's description: > > bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState > > > > There are two parts to this change: > > > > 1. Create a new BluetoothAdapterClient instance. For this we add > > "alternate_bluetooth_adapter_client()" to the bundle of DBus clients. > > This new instance uses a separate DBus Connection through > > BluezDBusThreadManager. This ensures actions on one client won't > > affect the other client. > > > > 2. Implement BluetoothSystem::GetState using the new client. > > > > Bug: 870192, 882771 > > Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201 > > Reviewed-on: https://chromium-review.googlesource.com/c/1215427 > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Dan Erat <derat@chromium.org> > > Reviewed-by: Sam McNally <sammc@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#596520} > > TBR=stevenjb@chromium.org, derat@chromium.org, sammc@chromium.org, reillyg@chromium.org > > Bug: 870192, 882771 > Change-Id: I0e92cc90f095c6049b2b967e46249e8488f71fcb > Reviewed-on: https://chromium-review.googlesource.com/c/1263217 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596975} TBR=derat@chromium.org,stevenjb@chromium.org,reillyg@chromium.org,sammc@chromium.org,ortuno@chromium.org,sonnysasaka@chromium.org Change-Id: I92bd726f551e48e0b2013d9e58f76e10b90196ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870192, 882771 Reviewed-on: https://chromium-review.googlesource.com/c/1263639Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#596981}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/40a16ffeefe6..15082f69653d git log 40a16ffeefe6..15082f69653d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 zhuohao@chromium.org kalista: add new paladin Created with: gclient setdep -r src/third_party/chromite@15082f69653d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7eb20e75a5454e6e191fab94a07c0bdf1718c395 Reviewed-on: https://chromium-review.googlesource.com/c/1263815Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aa43b7bb2fcd..84583f618399 git log aa43b7bb2fcd..84583f618399 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 benwright@webrtc.org Enable End-to-End Encrypted Audio Payloads. Created with: gclient setdep -r src/third_party/webrtc@84583f618399 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b51964a2fc00e848f4b89a25ffe6d9ae11e1cf5 Reviewed-on: https://chromium-review.googlesource.com/c/1262993Reviewed-by:
-
Mathias Carlen authored
Before this patch, we cleared the delegate for web_content unconditionally. That means we would remove an already existing delegate from web_content. This patch introduces a bool in the controller to track whether the delegate should be cleared in the destructor. After this patch, we will no longer stomp on other components setting a delegate in web_contents. R=gogerald@chromium.org Bug: 806868 Change-Id: I92ce1ef2dcf4a48f6709bddee0f76871a58c2df4 Reviewed-on: https://chromium-review.googlesource.com/c/1263118Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#596978}
-
Ian Clelland authored
Bug: 888668 Change-Id: I7afdab5a71a6650b218e5fc16c930103d3069938 Reviewed-on: https://chromium-review.googlesource.com/c/1243114Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596977}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I1b19917ea7a375a81a79868edbf36b62c7cec786 Reviewed-on: https://chromium-review.googlesource.com/c/1263915Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#596976}
-
Giovanni Ortuño Urquidi authored
This is a reland of 837b3c20 The original patch attempted to init the alternate dbus client on Linux where there is no alternate bus connection. The latest patchset fixes this by returning early if there is no alternate bus connection. TBRing since it's a minor addition to the original patch. Original change's description: > bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState > > There are two parts to this change: > > 1. Create a new BluetoothAdapterClient instance. For this we add > "alternate_bluetooth_adapter_client()" to the bundle of DBus clients. > This new instance uses a separate DBus Connection through > BluezDBusThreadManager. This ensures actions on one client won't > affect the other client. > > 2. Implement BluetoothSystem::GetState using the new client. > > Bug: 870192, 882771 > Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201 > Reviewed-on: https://chromium-review.googlesource.com/c/1215427 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596520} TBR=stevenjb@chromium.org, derat@chromium.org, sammc@chromium.org, reillyg@chromium.org Bug: 870192, 882771 Change-Id: I0e92cc90f095c6049b2b967e46249e8488f71fcb Reviewed-on: https://chromium-review.googlesource.com/c/1263217Reviewed-by:
-
Hitoshi Yoshida authored
While deserializing V8 contexts from snapshot, the process can fail, unfortunately. This CL makes the routine to catch such unexpected cases and disables the feature to avoid crashes. Bug: 881417 Change-Id: I874a16b63fd6b8ae7a3532bc5c662531a895e3ed Reviewed-on: https://chromium-review.googlesource.com/c/1258786 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Dale Curtis authored
Adds a STEP trace with the decoder name being initialized as well as a STEP trace when DecryptingDemuxerStream is initialized. BUG=883620 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I958b4f98836e8e4d43ec59931d3cd952c52a09e1 Reviewed-on: https://chromium-review.googlesource.com/c/1263576 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#596973}
-
Alexander Nohe authored
Hide |filenameEdit_| line edit box when there is no image to be displayed. This fixes an undesired grey line appearing as the bottom of this edit box. Changing the "disabled" state doesn't change the style of this box, "disabled" state is only used for read-only behaviour not style. R=fukino@chromium.org Bug: 796503 Change-Id: I6fc9a4eb218231781325ba7a5af992b12610b929 Reviewed-on: https://chromium-review.googlesource.com/c/1212263Reviewed-by:
-
Takashi Sakamoto authored
BUG=888904 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I17c89d0ffd9b1dece4bd8779572ff5605e3072fc Reviewed-on: https://chromium-review.googlesource.com/c/1258784Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#596971}
-
Maggie Chen authored
According to Intel, the NV12 overlay format should not be used if DXGI_COLOR_SPACE_YCBCR_STUDIO_G22_LEFT_P709 is not supported. At least one Intel Gen9 SKU will not support NV12 overlay. This color space info is recorded through UMA. BUG=889633 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0406b833e8cfbe0af0a9a408f8e665e3d6e87d77 Reviewed-on: https://chromium-review.googlesource.com/c/1247183Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596970}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d945698c5dfa..1b4ad765627f git log d945698c5dfa..1b4ad765627f --date=short --no-merges --format='%ad %ae %s' 2018-10-05 csmartdalton@google.com ccpr: Unblacklist PowerVR Rogue Created with: gclient setdep -r src/third_party/skia@1b4ad765627f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ib0c8aa8e1e9b19ccf2a98e5b71a0e8cdf112980b Reviewed-on: https://chromium-review.googlesource.com/c/1262992Reviewed-by:
-
Devlin Cronin authored
If an extension using the webRequest API has access to a.com, and the user visits b.com, and b.com requests a script from a.com, the request will be withheld from the extension. However, we shouldn't badge the extension as wanting to run in this scenario, since invoking the extension won't grant access to a.com (because it's not the tab's origin) or b.com (because the extension didn't request access). Thus, the extension still won't be able to intercept the request. Because there's no actionable behavior, don't badge. Add a test for the same. Bug: 891586 Change-Id: I673bac4cd936f0c659d3c32467c4976daaafe6a7 Reviewed-on: https://chromium-review.googlesource.com/c/1260211 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596968}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b52a7683757..56f1cb670eca Created with: gclient setdep -r src-internal@56f1cb670eca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I75298dc30da5661706edf7a5e7986132e4fe1b8b Reviewed-on: https://chromium-review.googlesource.com/c/1262991Reviewed-by:
-
Sam McNally authored
TtsHandler doesn't remove itself as a VoicesChangedDelegate on destruction, causing use after frees. Bug: 885311 Change-Id: Id6ed9cd5e9a1caa16e7f095eeeeb6baae1baa327 Reviewed-on: https://chromium-review.googlesource.com/c/1260604 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#596966}
-
