- 20 Mar, 2020 34 commits
-
-
Dale Curtis authored
This wires up VP8 decoding through the same MFT we use for VP9 hardware decoding. The feature is default off. VP8 does not have color space information despite a comment in the spec saying its BT470NG. It does have range information though, so we indicate JPEG if full range. Bug: 1062849 Test: No intel hardware, so untested at present. Change-Id: Ia7006006f943c3dd1078f3a11ededa7e4b410c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109171Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751885}
-
Reilly Grant authored
These tests are expected to time out on MSAN and the test names changed recently. Bug: 1063162 Change-Id: I0925fa2b0e3e5d0287755d6fc7b042237e8fe82e Tbr: harringtond@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111471Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751884}
-
Chris Harrelson authored
There is nothing behind the root element stacking context in the same frame, and it's also important not to blend with any white behind the root frame. This is also causing a problem at the moment in Chromium because to implement the semantics in [1] for filters of the root element group applying after drawing and before compositing into the root group, we now paint two PaintChunks for the LayoutView [2]. The second such PaintChunk has a PropertyTreeState that includes filters (including at the moment backdrop-filter). But since it's not composited the code fails to work correctly. This CL does not apply to iframes, because they do have a well-defined backdrop from their containing frame's contents. [1] https://drafts.fxtf.org/compositing/#pagebackdrop [2] https://chromium-review.googlesource.com/c/chromium/src/+/1979258 Bug: 1061802 Change-Id: I9212213d1787647b171fbefcf18ef80d51b74a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109318Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751883}
-
Felipe Erias authored
Add the "auto" value for the -webkit-appearance property. The element will have the appearance returned by AutoAppearanceFor() (in layout_theme.cc). Spec: https://drafts.csswg.org/css-ui/#valdef-appearance-auto Bug: 965432 Change-Id: Ia3c829637fcfa8a897b6a8d2e155f5861c3d9c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108264Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#751882}
-
Livvie Lin authored
Check whether it's possible to go back before trying to perform a back navigation on a committed interstitial when the "Back to safety" button is pressed. This CL fixes the stability issue--a follow-up CL will fix the actual functionality of the button on e.g. interstitial opened in new tab. Bug: 1059142 Change-Id: Icc03af381ca376731b451238ccb671a216764bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111411Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751881}
-
Donn Denman authored
This test is consistently failing on a builder on the M82 branch. Original CL https://crrev.com/c/1743028 TBR=sarsha@microsoft.com BUG=1063198 Change-Id: Iec2e5cc719ab54a7752447872296e9f13bfb1c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111831Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#751880}
-
Mason Freed authored
TBR=schenney@chromium.org Bug: 1055943 Change-Id: Iff49353d43a8366b0878862ffc2f4232b8d37d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111611Reviewed-by:
-
Shik Chen authored
GpuMemoryBuffer-based video capture is enabled on selected Chrome OS boards to reduce memory copies. This CL allows the Pepper media stream video track host to convert the GpuMemoryBuffer-based VideoFrames to the I420 buffer PPAPI MediaStream Video [1] supports. [1] https://source.chromium.org/chromium/chromium/src/+/master:ppapi/examples/media_stream_video/ Bug: 1039514 Test: Check the camera frames from the PPAPI media_stream_video example Change-Id: I02a41ef3a458cbe2df3740b4bd6b380ea6d57ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109510Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#751878}
-
Jarryd authored
Bug: 1062272 Change-Id: I11127d39c02ef5ae9e17743393ded51c43c39bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106963 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751877}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I91a78c8ea90916f22248e7731efcf0b023289cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751876}
-
Dale Curtis authored
Adds kMediaFoundationVP8Decoding as disabled by default. Updates our supported profiles code to use it. Bug: 1062849 Change-Id: I36b6c6b202411a7bd842a28727a7b67dd3f31882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110516 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use CurrentPageVerifier - Adds homescreen-shortcut and WebAPK subclasses of Verifier - Introduces WebappActiveTabUmaTracker for recording metrics about active tab - Makes CustomTabDelegateFactory#shouldDisableExternalIntentRequestsForUrl() use ExternalIntentsPolicyProvider for Webapps & WebAPKs BUG=1054718 TESTS=WebApkInitializationTest.testInitialization AddToHomescreenCurrentPageVerifierTest.* WebApkCurrentPageVerifierTest.* CustomTabExternalNavigationTest.testShouldDisableExternalIntentRequestsForUrl Change-Id: I2bbd0505f28b99569c4bed8fb4e6e10295620eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068116 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751874}
-
Brian Sheedy authored
This reverts commit 04d9ccbc. Reason for revert: https://crbug.com/1063165 Original change's description: > [AW] DevUI: Always merge dev ui launcher manifest to the final manifest > > Always merge dev ui launcher manifest for standalone and trichrome > webview into the final manifest unconditionally similar to monochrome > launcher manifest. > > Use jinja_template to: > - Generate the manifests for all variants from one Manifest file. > - Pass a variable to determine the default enabled state for the > launcher activity-alias. > > Standalone, Trichrome and Monochrome WebView, all use one activity-alias > to show the launcher icon. > > Change the name and the behaviour of the GN flag to always show the > launcher icon. If the flag is set to true then Monochrome will always > show the icon unconditionally. > > Fixed: 1047824 > Test: Enable/Disable the flag for stable/prestable WebView variants > Test: check no changes permissions in standalone and trichrome manifest > Change-Id: Ida10e39e294715e69ad19f1253cf302113322cc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098804 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Auto-Submit: Hazem Ashmawy <hazems@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751735} TBR=torne@chromium.org,ntfschr@chromium.org,hazems@chromium.org Change-Id: I7fea8cf56a9396d30ac272de4a870e0b4bcb9c99 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111950Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#751873}
-
Yulun Wu authored
Change-Id: I8be1da447a3728bb48bae48a5fa6018595089f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103365 Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751872}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1d34dc592fc1..1512c36ab69c git log 1d34dc592fc1..1512c36ab69c --date=short --first-parent --format='%ad %ae %s' 2020-03-19 tsepez@chromium.org Finish gutting logic from CFX_V8 2020-03-19 kmoon@chromium.org Roll v8/ 07a0ee92d..633234050 (457 commits) 2020-03-19 kmoon@chromium.org Roll third_party/zlib/ b9b9a5af7..156be8c52 (2 commits) 2020-03-19 kmoon@chromium.org Roll third_party/catapult/ ea794b87a..df670f0be (114 commits) 2020-03-19 tsepez@chromium.org Add exception helper to fxv8.h. 2020-03-19 tsepez@chromium.org Make more of CFX_V8 methods ordinary functions. 2020-03-19 negupta@microsoft.com Add keyboard tabbing for links & highlights 2020-03-18 tsepez@chromium.org Use proper namespace instead of CFX_V8 static functions. 2020-03-18 tsepez@chromium.org More small fxjs / v8 cleanup. Created with: gclient setdep -r src/third_party/pdfium@1512c36ab69c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:994500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: If3c959722b8562b15fd78fb22f8ccd62e880ff54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111280Reviewed-by:
-
Aaron Leventhal authored
SerializeNodeChanges() checks every descendant node to see if it was reparented, which is considered an error condition, because reparented nodes should be handled in the caller SerializeChanges(). When this error condition is reached, it means that the helper AnyDescendantWasReparented() did not detect a reparented node, and the tree is Reset() -- meaning it will need to be rebuilt. In addition, generated events on reparented nodes will be lost. This error condition occurred when nodes change their ignored status, because of a line in AnyDescendantWasReparented() that causes it to skip checking children recursively for valid nodes. Skipping this check when node is ignored avoids the error condition. In addition, a DumpWithoutCrashing() calls is added so that the accessibility team can understand how often this error condition occurs. This change has the side effect of detecting more reparenting changes, because when a subtree becomes display:none, a new accessible is created for each node in the subtree -- unless one of the objects in the subtree was already display:none. Those nodes will effectively get new parents. As a result of this side effect, menupopupend changes need to be fired on any menu nodes that are deleted, not just when they're the root of a subtree that's deleted. This is a more robust solution for menupopupend events in any case. Bug: 1059394 Change-Id: I0433690d6f7ac9708bcc54dafe4b3f9b09d30ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090736 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751870}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1171d314efc7..4b55ff097b9d git log 1171d314efc7..4b55ff097b9d --date=short --first-parent --format='%ad %ae %s' 2020-03-19 bsalomon@google.com Fix cmake angle build on linux. 2020-03-19 chinmaygarde@google.com Allows Skia users to disable use of API_AVAILABLE in the Metal backend. Created with: gclient setdep -r src/third_party/skia@4b55ff097b9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: Ifacffe0c7cc6560b563c318094ff6deba1c0d73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110586Reviewed-by:
-
Martin Šrámek authored
The Site settings menu entrypoint returns to use the old "Site settings" string. The new string resource which was previously added there can be removed. We will remove it in a followup CL to make this CL safer to merge: https://chromium-review.googlesource.com/c/chromium/src/+/2108543 The Password leak check toggle currently has an explanatory string that the feature only works for signed-in users, which only shows when the user is signed out. When the user is signed in, there is no secondary text. The design paradigm of privacy settings is that the secondary text should always explain the privacy implications. Therefore, we're adding existing explanatory string from the password leak check UI under this toggle as well, in both signed in and signed out cases. See mocks: https://docs.google.com/presentation/d/1utofQR2FyZlTOOsUgYGi0SyPeVA3DxCDjHmaAuu0EIo/edit?ts=5dcf17c5#slide=id.g700853307c_2_104 https://docs.google.com/presentation/d/1utofQR2FyZlTOOsUgYGi0SyPeVA3DxCDjHmaAuu0EIo/edit?ts=5dcf17c5#slide=id.g710b7438a5_5_83 Bug: 1062607 Change-Id: I6f404d147e09ec71caf0d843f371d2c4bf774b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108143 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751868}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fb670f56acbd..1c9f24263e6c git log fb670f56acbd..1c9f24263e6c --date=short --first-parent --format='%ad %ae %s' 2020-03-19 sugoi@google.com Fix float to r11g11b10 conversion Created with: gclient setdep -r src/third_party/swiftshader@1c9f24263e6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I73d7ecdb99c0b65c4adef2e466cfbccc28b9a7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110043Reviewed-by:
-
Ken Rockot authored
This ensures that JS doesn't attempt to decode optional MinVersion'd fields in structs received with a lower version number. Fixed: 1063092,b:151950986 Change-Id: Id7e4d2c5ce2d355a6e87a38d729025929c42008f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110670 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751866}
-
Robert Ogden authored
Allows server experiments to set the probe timeout. Bug: 1023486 Change-Id: Ia64db9e855b5667da848b6727bdc5ef8a7998132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107718Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#751865}
-
Alexander Cooper authored
As part of the refactor to move the VRService into content, the isolated device service will need to move from chrome/services to components/services and from chrome/utility/services to content/utility/services. At that time, XRRuntimeProvider will no longer be able to use anything from either chrome_features or content_features. While it is a pattern for components to define their own features, these features indicate the support of an implemented runtime, and thus make more sense being implemented at this layer. Bug: 1031622 Change-Id: I7649bf5c20a2973ca4eaa818fa05a76a7f8432d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108964 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#751864}
-
Patrick Monette authored
Since they don't need access to the PerformanceManager instance on the main thread, they can be implemented by calling CallOnGraphImpl(), which is static. Bug: 1013127 Change-Id: I3cdb2bc77f2258e013bdc3dd384f1527c08f1d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108086 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751863}
-
Akihiro Ota authored
Change-Id: I0bfd465bfa5c193ca711ef0c479ac9a4bd35b370 menu. RELNOTES: Improve color contrast of disabled items in the Chromevox Change-Id: I0bfd465bfa5c193ca711ef0c479ac9a4bd35b370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111076Reviewed-by:
-
Michael Chang authored
This is an implementation for performing an update of a product from a dmg in macOS. It modifies the keystone_install.sh script in //chrome/installer/mac, and reduces it down so that the need for ksadmin and tickets are removed. The update flow will be, a crx will be downloaded, dmg will be extracted from the crx, InstallFromDMG() in installer.mm will mount the extracted dmg and run the install executable within the dmg. setup_unittest.mm will simulate an update by creating a simple app, a simple update app and package it in a dmg with the new .install executable by using the install_test_helper.sh script. Then we run different update scenarios based on the args we pass to InstallFromDmg(). Bug: 1056274 Change-Id: I5bb7c667a6b23880a3f655a155d15f58b31bf544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090026Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Michael Chang <donchan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751861}
-
Haiyang Pan authored
This reverts commit 4d265fc5. Reason for revert: ShareButtonControllerTest starts fail on a couple of builders See https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24669 https://ci.chromium.org/p/chromium/builders/ci/android-lollipop-arm-rel/799 https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/774 Original change's description: > [ShareButtonInToolbar] Minimum width driven via finch config. > > Add a requirement for devices to have a min width, and use finch param. > > Bug: 1036023 > Change-Id: I75e15afc4ddd646f6d3f8577dae792160d13f215 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088635 > Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> > Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751751} TBR=dtrainor@chromium.org,twellington@chromium.org,hnakashima@chromium.org,jeffreycohen@chromium.org Change-Id: I1d4b97f65ec9a8b5d16c552b5a286549a1eaf6d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111756Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#751860}
-
Lijin Shen authored
1. add semantic_colors_non_adaptive.xml and semantic_colors_adaptive.xml 2. add more semantic colors Bug: 775198 Change-Id: Id116f0e9ae956b23e2a5ebbe2a282901508b9035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104452 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751859}
-
Robert Liao authored
BUG=1057754 Change-Id: Ibd1c4c7cfb67ec58ba34b539cea871246e03fd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111058 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751858}
-
Mugdha Lakhani authored
Refactor PageInfoUI so it can be moved to components easily. This extracts out chrome dependencies from PageInfoUI into ChromePageInfoUiDelegate. The only dependencies now in PageInfoUI are resources which can be moved to components and shared. Bug: 1052375 Change-Id: Ibb50b9252af3f87586a4c9d22697be74a992d765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109915 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#751857}
-
Daniel Cheng authored
This reverts commit 20f4f32b. Reason for revert: theory has been confirmed Original change's description: > Add crash keys to debug infinite recursion in cloud print service > > Hopefully, this will help confirm the theories... > > Bug: 1061138 > Change-Id: Id452de7f436f9970517814540db06343fbc896c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106536 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751018} TBR=dcheng@chromium.org,rockot@google.com,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1061138 Change-Id: Ie7fa1b159156db1037eda879d4d107caf3a739cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111050Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751856}
-
David Van Cleve authored
This CL adds a new TrustTokenRequestHelper implementation responsible for executing the issuance step of the Trust Tokens protocol. Given a request, it 1. uses the request's destination's origin as the Trust Tokens issuer; 2. checks preconditions and, if they pass, adds a Sec-Trust-Token request header bearing blinded, unsigned tokens; 3. inspects the corresponding response for a Sec-Trust-Token response header; 4. passes the response header's contents to an underlying cryptographic layer responsible for validating the header and splitting it into a collection of signed, unblinded trust tokens; and 5. stores the tokens in storage. Bug: 1042962 Test: Adds unit tests. Change-Id: I455acbf083dbf8eca87327f6d610033b4a59d55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057527 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#751855}
-
Dan H authored
This reverts commit c7d0001d. Reason for revert: May be causing test failures: https://bugs.chromium.org/p/chromium/issues/detail?id=1063167 Original change's description: > Fix accessibility dump tree tests to not need an end-of-file sentinel. > > The DumpAccessibilityTree tests generate an output text file and diff > the results against an expected file. Previously, the way that the > algorithm handled files of different lengths was by adding an > end-of-file sentinel to the end. This resulted in that sentinel > getting checked in, which was just confusing. > > Fix this by modifying the DiffLines helper function to properly compare > files that don't have the same number of lines. Add full unit tests for > DiffLines so we can be confident it works. > > Continue to LOG the end-of-file sentinel, because it's needed by > running rebase_dump_accessibility_tree_test.py to parse actual output > files from remote logs. > > Bug: none > Change-Id: If1bcef063822fd5786acaeff9133c05d5fc5b065 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109458 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751791} TBR=avi@chromium.org,dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: Ic369d42c9bd201792b03bcf995cb57ad3383b93a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111771Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#751854}
-
Ionel Popescu authored
This is a reland of 0fac3886 Fixed the test flakiness by converting it to a ref-test. Original change's description: > Fixed color-picker style when opened from datalist via Other button. > > The issue was caused by the fact that the color-picker style wasn't added > when constructing the color-suggestion-picker popup. > > Added a test to validate the change and prevent future regressions. > > Bug: 1062501 > Change-Id: Iaf561f33e18bf2f26a8f87ffd1fb549118e02764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108091 > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751610} Bug: 1062501 Change-Id: I85c13c644d819689a0c80ea419abf58fb12ce263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110215Reviewed-by:
-
Robert Ogden authored
Found this flake in an in-flight CL so I am confident this will fix the issue without disabling. Bug: 1060454 Change-Id: Ie5420a260c90e94a825428099483e0258996c370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111069 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
- 19 Mar, 2020 6 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7daf31d8029b..b1eb44bf8f33 git log 7daf31d8029b..b1eb44bf8f33 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 jmadill@chromium.org Track if a Texture is bound as a sampler. 2020-03-19 lexa.knyazev@gmail.com Refactor BitCount Created with: gclient setdep -r src/third_party/angle@b1eb44bf8f33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I987dabe981bb42f8f4cd10dc1fef68cac89bbf15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110583Reviewed-by:
-
Owen Min authored
Delete Lzma metrics for unpack result and unpack ntstatus: Setup.Install.LzmaUnPackResult_* Setup.Install.LzmaUnPackNTSTATUS_* With four consumer names: _ChromeArchivePatch _CompressedChromeArchive _SetupExePatch _UncompressedChromeArchive Setup.Install.LzmaUnPackStatus_* metrics will be kept in the code as the top level metrics for this year. Bug: 1053135 Change-Id: I9203a7da2c06e9e6a301a774e56366373dd3ce4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092180Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751850}
-
Akihiro Ota authored
This is a clean up change for: http://crrev.com/c/2094714. It changes the name of LanguageSwitching and replaces many instances of 'language' with 'locale'. Bug: 923068 Change-Id: If4958a9e8d23f71eb1048021aad40f8ae64dba2e RELNOTES: N/A Change-Id: If4958a9e8d23f71eb1048021aad40f8ae64dba2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105656 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751849}
-
Moe Ahmadi authored
Adds a method to the FaviconCache API that allows requesting the largest favicon from the favicon::FaviconService. This new method is used in SearchTabHelper for AutocompleteMatch favicons which otherwise would appear pixelated in high density displays or when zooming is used. Below is a comparison of using FaviconCache::GetFaviconForPageUrl vs FaviconCache::GetLargestFaviconForPageUrl in SearchTabHelper respectively: screenshot/Zg6JMTUB4jo screenshot/ZpoUZ7LYi8H Bug: 1039357 Change-Id: Iccfaf3ef2493edc490e83da5cc0df195b5520b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108902 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#751848}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0550b313874..2f6e1e2b69e8 Created with: gclient setdep -r src-internal@2f6e1e2b69e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046374,chromium:1057652 Tbr: jbudorick@google.com Change-Id: I4930573eda954b10c5d9a42385438a31d866e125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111271Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751847}
-
Brian Sheedy authored
Updates manage_render_test_goldens.py to remove orphaned PNG files (i.e. PNG files without a corresponding SHA1 file) during the download step. This is so that goldens don't get left around if someone removes the SHA1 file due to the test being removed, etc. Also updates a few images that were incorrectly added as part of the repo. Bug: 1063058 Change-Id: I2e5f40e6907f04cb71691f7bfeab618a01004e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110454 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
