GitLab

Sync.USSMigrationEntityCount.<datatype> metrics are introduced to
count the number of entities that go through a USS migration
procedure.

In particular, it's useful to know how many entities were migrated
from directory to USS in order to explain differences in metric
Sync.ModelTypeEntityChange during rollout, because the USS migrator
doesn't really involve fetching updates from the server.

NOPRESUBMIT=true

Bug: 895899
Change-Id: I5c3b731187fadab30dc499426d0121d6f97769ec
Reviewed-on: https://chromium-review.googlesource.com/c/1280583
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600080}

The tests need to test mail.google.com with known and unknown roots, to
check that some of the metrics work correctly. This trips the pin list
on Chrome builders. Disable the pins to avoid this.

Bug: 895801
Change-Id: Iee41b9729157bb71df0ba5619ce83e9bef5255eb
Reviewed-on: https://chromium-review.googlesource.com/c/1283933Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600079}

Create a work around to force getAllCookies: completion handler to be executed
as soon as possible.
Workaround description and reasoning on the document:
https://docs.google.com/document/d/1aPNO5p44T-LMQT1Mocdll-SG7xq_9DIjb4N0oOTHZUs

Bug: 894540, 885218
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I94090ed1b6b6aa1dce3f764bfa46bc1d700ddf4d
Reviewed-on: https://chromium-review.googlesource.com/c/1281685
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600078}

Many layout tests will flakily fail when run in a clean content shell, but will
deterministically fail or pass when run in a reused content shell.

Unfortunately, we cannot restart content shell between all tests because that
significantly increases run time. [2X on Windows, 3X on Linux, 5X on macOS].

This CL adds the functionality to restart content shell between all test runs,
but then only enables it for tests with --gtest_repeat or --repeat-each with a
repeat count > 1.

Effects:
* For a local developer, this will only have an effect when using --gtest_repeat
  or --repeat-each. In this case, the developer is already trying to tease out
  some type of non-determinism between tests, and it's important to use a clean
  content shell. With this CL, flaky tests can be easily reproduced with
  --gtest_repeat, whereas they could not before. See
  https://bugs.chromium.org/p/chromium/issues/detail?id=894527#c5 for examples.
* On the CQ, this will only have an effect on 'retry without patch' and 'retry
  with patch', which retry failing tests looking for flakiness. This will help
  the CQ better detect tests that are flaky on ToT to reduce false rejects.

Change-Id: I4c04e382e733f8e1b40f4a6dde78292a41126a1b
Bug: 875884,  889036
Reviewed-on: https://chromium-review.googlesource.com/c/1273810Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600077}

MetadataCache is being deprecated.
For M70, we started migrating all data to DownloadDBCache.
For M71, we will stop using MetadataCache data at all. All migrated data
will be destroyed afterwards as the data could be outdated.

BUG=894978

Change-Id: I2f7a070726cdd22d9188dc61f33816db4741ba5e
Reviewed-on: https://chromium-review.googlesource.com/c/1279192
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600076}

On MacOS 10.13+, NSDateFormatter formats Arabic dates using non-breaking spaces
instead of ascii spaces. This behavior is probably more correct but there's no
way to configure pre-10.13 NSDateFormatters to behave that way as well, so this
change simply has LocaleMacTest.formatTime test for the behavior per OS version.

This re-enables LocaleMacTest.formatTime.

Bug: 811685
Change-Id: Ib25247a28f382639d9aadde45fb1db01aff1c2d8
Reviewed-on: https://chromium-review.googlesource.com/c/1283834
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600075}

This is a reland of 1c6c9d1b

Now correctly waiting for DeviceSyncClient to be ready.

Original change's description:
> Make Instant Tethering work with legacy hosts before hosts update.
>
> The phone side flags and enrollment will be slower than the ChromeOS
> rollout. In order to avoid breaking Instant Tethering in the meantime,
> look for cases where:
>
> 1) There are no host devices reporting BETTER_TOGETHER_HOST support.
> 2) There is at least one host device reporting INSTANT_TETHER_HOST
> support.
>
> In this scenario, the only possiblity is that this host device has not
> reenrolled yet after receiving the new flags.
>
> Bug: 893769
> Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d
> Reviewed-on: https://chromium-review.googlesource.com/c/1277272
> Commit-Queue: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599058}

Bug: 893769
Change-Id: I89aff002fe1235f08aa690ef7f8374aa4100e858
Reviewed-on: https://chromium-review.googlesource.com/c/1278542Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600074}

Currently all the effects of an animation are driven by the local time
of the first effect. Rather, they should be driven by the individual
local time.

This patch adds WorkletGroupEffectProxy to Animator and only initialize
it when necessary, i.e. animating group effects. Single effect animation
follows the existing logic which is not affected by this patch.

Bug: 894180
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I24a828d5afd07d94854683744e5d765af45c82c8
Reviewed-on: https://chromium-review.googlesource.com/c/1274192Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600073}

Change-Id: If94a0bfa08381a856e7ba682cbd5b85971ed1eac
Reviewed-on: https://chromium-review.googlesource.com/c/1282210Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johnny Ding <jnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600072}

Add explicit enumerator values set for enum AssistantOptInFlowStatus
to make it clear and to make it easy to match the values in
histograms.xml.

Test: local compile and manually test.
Change-Id: I844ff68a6cb9ed1e13eba813071e4f3220e515d6
Reviewed-on: https://chromium-review.googlesource.com/c/1282302Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600071}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/views/frame.

This CL was uploaded by git cl split.

R=pkasting@chromium.org

Bug: 809610
Change-Id: Ib6b3670ddcac53d42e955d4cb51596b9f194e39a
Reviewed-on: https://chromium-review.googlesource.com/c/1258767
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600070}

This reverts commit bb70008e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Autofill Assistant] Add ShowProgressBar action.
> 
> Screenshot: https://screenshot.googleplex.com/chZ1byvKBqa.png
> 
> Bug: 806868
> Change-Id: Ib7714b1b554d030c461614bcd51cc30156cac594
> Reviewed-on: https://chromium-review.googlesource.com/c/1278808
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600015}

TBR=twellington@chromium.org,gogerald@chromium.org,lsuder@google.com,jdemeulenaere@chromium.org

Change-Id: I56cf273550bc82f36e2eb1e3cafaedfd935f6c45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 806868
Reviewed-on: https://chromium-review.googlesource.com/c/1284067Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600069}

A planned change will use this from a Blink variant's mojom traits
to natively interact with variables of type WebVector.

Bug: 717812
Change-Id: I844d189c601d3a6310034abeebe51b66a36b3bc5
Reviewed-on: https://chromium-review.googlesource.com/c/1282211Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600068}

If we do have an override height, children will size themselves relative
to the override height (e.g. flexbox flexing/stretching, percentage
heights). Because our intrinsic height is based on our children,
we would then store an incorrect intrinsic height.

Right now this is rarely a problem in practice because we do not use
this height for min-height: auto in case of a nested column flexbox,
but we would like to apply this in the future. This change will
make it possible to do so without affecting performance.

For context, see crrev.com/c/1246730 and crrev.com/1631033003

Change-Id: I1ee8ad87a9d6a6517a3154f47e2be170be44a189
Reviewed-on: https://chromium-review.googlesource.com/c/1283482Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600067}

BUG=415871,889703

Change-Id: Ifa76627a000b66f1e77aa5d2229a81bf470e7d55
Reviewed-on: https://chromium-review.googlesource.com/c/1282038Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600066}

New Clang versions warn that kAuto shadows LengthType::kAuto. It's easy to fix
because the enum isn't used at all.

Bug: 895475
Change-Id: I04c63a9ff87afdb08b060a987bc7a160fecc62e4
Reviewed-on: https://chromium-review.googlesource.com/c/1283691
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600065}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c68a1753c53a..74b702466046


git log c68a1753c53a..74b702466046 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@74b702466046

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Id4f4ae2fb1201363fa9ffa30e7d00c10ce50b6f7
Reviewed-on: https://chromium-review.googlesource.com/c/1283516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600064}

As part of the effort to make all test harness supported by Findit,
this CL adds four new flags that are unified across different test harness:
1. --isolated-script-test-filter=test1::test2::test3
2. --isolated-script-test-repeat=30
3. --isolated-script-test-launcher-retry-limit=0
4. --isolated-script-test-also-run-disabled-tests

For test filter, both ":" and "::" are supported.

Bug: 836417
Change-Id: Ie931812ade9899a2b2ae1a97bdac215ed9e0ea73
Reviewed-on: https://chromium-review.googlesource.com/c/1272655
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600063}

JobDetails into one JobState enum.

as promised in a previous review comment:
https://chromium-review.googlesource.com/c/chromium/src/+/1249075/3/chrome/browser/background_fetch/background_fetch_delegate_impl.h#133

Change-Id: I442acd04f01b7e5e75a6db3977ff373f3bb620aa
Reviewed-on: https://chromium-review.googlesource.com/c/1280842
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600062}

This reverts commit 9780253f.

Reason for revert: test failure was real, and caused by https://chromium-review.googlesource.com/1267235 , which has since been reverted.

Original change's description:
> Disable ContextLost_WebGLUnblockedAfterUserInitiatedReload
> 
> gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests
> is flaky on Win10 Debug
> 
> TBR=kbr@chromium.org
> 
> Bug: 895765, 879423
> Change-Id: Ic36400494df68f257329e040be2c72f1ad2ec3a6
> Reviewed-on: https://chromium-review.googlesource.com/c/1283049
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599973}

TBR=kbr@chromium.org,cfroussios@chromium.org

Change-Id: I33951694d070e6eb183eba9a05d9ea517f81ce65
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 895765, 879423
Reviewed-on: https://chromium-review.googlesource.com/c/1283945Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600061}

Recent versions of Clang started taking enumerations into account for the -Wshadow warning, e.g.

../../third_party/blink/renderer/core/html/forms/html_select_element.h:237:5:
warning: declaration shadows a variable in namespace 'blink' [-Wshadow]
    kDispatchInputAndChangeEvent = 1 << 1,
    ^
../../third_party/blink/renderer/core/html/forms/text_control_element.h:48:3:
note: previous declaration is here
  kDispatchInputAndChangeEvent
  ^

Fix this by adding a Flag suffix to the enumerations, which is good for clarity too.

Bug: 895475
Change-Id: Ie9225dc711fc3985a46c2f56040bc56c8a451495
Reviewed-on: https://chromium-review.googlesource.com/c/1283749Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600060}

This is to remain consistent in how the Chrome Cleanup Tool removes other force installed extensions. They interact badly with administrator permissions and so removing them entirely is cleaner than simply disabling like we do with normally installed extensions when the cleanup tool detects UwS.

Change-Id: I1b6b814d521e78edccd7c603f1eae3ef7a9a6c5f
Reviewed-on: https://chromium-review.googlesource.com/c/1278852Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Preston Carpenter <timidger@google.com>
Cr-Commit-Position: refs/heads/master@{#600059}

It was using SigninManagerBase API to get the primary (authenticated)
account id. It's now using the IdentityManager API.

Bug: 890806
Change-Id: I2902cd16c4040301f84d238dc46ca2b8f9e10793
Reviewed-on: https://chromium-review.googlesource.com/c/1276609
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600058}

Change-Id: I7c6d15d75fd6ea4a936729bc2b07445778fae165
Reviewed-on: https://chromium-review.googlesource.com/c/1281867Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600057}

- Make sure all registry entries created by GCP is not hardcoded to chrome
- Make sure we can install different versions of the GCP for Chrome/Chromium

Bug: 883943
Change-Id: I72aa14545ad7b0ab4320b14baf210b3b80979ffe
Reviewed-on: https://chromium-review.googlesource.com/c/1278503Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600056}

ClosingView is destroyed during its call to Widget::CloseNow().
ClosingView::widget_ should not be accesses after calling CloseNow().

Bug: 895882
Test: No flaky crashes
Change-Id: I40bb3306e969332191fc7118a905eee5900f0f2e
Reviewed-on: https://chromium-review.googlesource.com/c/1283690Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600055}

The original change fixed the bounds for app list window, but not for
its parent, so the issue is not fixed entirely. Fix it for the parent
window in this CL.

Bug: 884889
Change-Id: I6a48bae85fd3d89957d58a4aabf270c7df288d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1282386
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600054}

Specifics:
      +731,605 bytes normalized apk size
            +5 zip entries file count
       +58,328 bytes main lib size
      +452,576 bytes main dex size
InstallSize:
      +281,657 bytes APK size
 +2,110,064.04 bytes Estimated installed size
InstallBreakdown (+2,105,796.04 bytes):
        +2,628 bytes unwind_cfi (dev and canary only) size
        +1,883 bytes Non-compiled Android resources size
       +58,328 bytes Native code size
          +344 bytes Package metadata size
 +2,027,013.04 bytes Java code size
       +15,600 bytes Compiled Android resources size
Dex:
        +2,305 entries fields
        +3,207 entries methods
          +757 entries types
        +1,604 entries strings

Change-Id: Ic9266a66c247d20fa0872235b2b0d2b4a46afd7e
Reviewed-on: https://chromium-review.googlesource.com/c/1282029Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600053}

This is in preparation of referencing this type from the code
generated by third_party/inspector_protocol/code_generator.py.

My overall WIP change is in here, and happy to explain more:
https://chromium-review.googlesource.com/c/chromium/src/+/1244719

Bug: chromium:891377
Change-Id: I2e59d49bbe333bb132ea8e16fcac2dace589f163
Reviewed-on: https://chromium-review.googlesource.com/c/1282224
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600052}

This is in preparation of referencing this type from the code
generated by third_party/inspector_protocol/code_generator.py.

My overall WIP change is in here, and happy to explain more:
https://chromium-review.googlesource.com/c/chromium/src/+/1244719

Bug: chromium:891377
Change-Id: I9fbb8b980e522c0063f96a8a2a42498903d445a8
Reviewed-on: https://chromium-review.googlesource.com/c/1282208
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600051}

Before this change, a square focus ring was recently added to make sure
that text set using chrome.browserAction.setBadgeText was not clipped by
the focus ring.

This new focus-ring style unfortunately looks very out of place, so this
change just removes the FocusRing::SetPath call so that it matches the
ink-drop style (and focus-ring style) of all toolbar buttons.

Obscuring the badge text is not too bad here since the text is clearly
visible when the view is not in focus and only partially occluded with
the focus ring present.

Bug: chromium:895263
Change-Id: I210893c84c138944f12923a1b844c833134ff7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1281904Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600050}

Previously, prefetch articles were showing notification on download, and
showing up in the wrong place in Downloads. I verified the fix locally.

Bug: 895906
Change-Id: I893ec8232f40d1f4a27ee7b89e860c39ca9b3cfe
Reviewed-on: https://chromium-review.googlesource.com/c/1283849Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#600049}

It's currently using the SigninManager API to retrieve the currently
authenticated account's email. Replaced by the IdentityManager
equivalent API so it could eventually use the identity service.

Bug: 890776
Change-Id: I2ed33724ec940d955fbe10bfbc1eaaea29ea473a
Reviewed-on: https://chromium-review.googlesource.com/c/1280276Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#600048}

We don't implemented Mojo named channels under Fuchsia, so remove those
test cases.

Bug: 754038
Change-Id: Iac1d282d69fd972e3efa26db412f0ffcb4afe993
Reviewed-on: https://chromium-review.googlesource.com/c/1282723
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600047}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55fbadac66fe..ffad1c5fd295


Created with:
  gclient setdep -r src-internal@ffad1c5fd295

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1764f2769107934b30d4c4881c113e54c4ae2c6d
Reviewed-on: https://chromium-review.googlesource.com/c/1283513Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600046}

This will permit Windows authentication to work with WebSockets. See
Intent to Ship thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/kEtUcy7W0fU/dTyvzUy0BgAJ

Turn on the WebSocketHandshakeReuseConnection feature by default.

Test coverage for the old behaviour has been removed; since the flag
itself will be removed in the next version, this seems acceptable.

BUG=423609

Change-Id: I1373b7b4adcfe695f56a174a7fed2a3bd67ad56b
Reviewed-on: https://chromium-review.googlesource.com/c/1283349Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600045}

Previously, defines in Blink variants would be set to both the
Chromium and the Blink variants export_define* values.  This isn't
correct since Blink variants must export their own defines.

This CL causes Blink variants to only define what's set with
export_define_blink.

Bug: 717812
Change-Id: Ie554cef3044eba6e4ee093098b9c4afedaecd89e
Reviewed-on: https://chromium-review.googlesource.com/c/1282209Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600044}

https://android.googlesource.com/platform/external/perfetto.git/+log/c0c9df23b38c..f7eaeb14ee78


git log c0c9df23b38c..f7eaeb14ee78 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 treehugger-gerrit@google.com Merge "profiling: Properly align register_data."


Created with:
  gclient setdep -r src/third_party/perfetto@f7eaeb14ee78

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I8adc047f533d90779608cc87d652212b113ddb0d
Reviewed-on: https://chromium-review.googlesource.com/c/1283512Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600043}

This reverts commit 7f0c13c7.

Reason for revert: we don't have the capacity :(
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel

Original change's description:
> Move telemetry_unittests from cros VM fyi bot to CQ bot.
> 
> Bug: 876494
> Change-Id: Icfa8631e1278745a50e439d78b4373fb1f0f1f3a
> Reviewed-on: https://chromium-review.googlesource.com/c/1281230
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599851}

TBR=achuith@chromium.org,bpastene@chromium.org,jbudorick@chromium.org

Change-Id: I8b9981920ec5078da9147e0ef36d2c96028501b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 876494
Reviewed-on: https://chromium-review.googlesource.com/c/1283932Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600042}

Bug: 894790
Change-Id: I67d67ee8849e97195fe8e5bf82f83b8f809145a6
Reviewed-on: https://chromium-review.googlesource.com/c/1281236Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Zachary Kuznia <zork@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600041}