- 24 May, 2018 40 commits
-
-
arthursonzogni authored
I am working on https://crbug.com/831155. Some tests that are relying on how things are scheduled in Blink are failing. There was a race condition in this test. The iframe "#fr2" was asked to navigate to a first URL, but soon after, a javascript function modifies the iframe.src to navigate elsewhere. What happened when it didn't work? 1) The first navigation starts. 2) The second navigation is scheduled (See blink's NavigationScheduler) 3) The first navigation commits. FrameLoader::CommitProvisionalLoad() executes: frame_->GetNavigationScheduler().Cancel(). It cancels the second navigation. This CL fixes the race condition. Bug: 831155 Change-Id: I2dd951140b4c5a671c749348ca0247f1901d8b77 Reviewed-on: https://chromium-review.googlesource.com/1069013 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561659}
-
Xiaohan Wang authored
This CL adds MediaCryptoDeferrer to ensure there will be only one provisioning flow at any time. If NotProvisionedException is thrown when another provisioning flow already started, the MediaCrypto creation process will be deferred and resumed when the previous provisoning process finishes. If creating MediaCrypto doesn't trigger provisioning, it'll not be affected. Note that when we resume the MediaCrypto creation, we may trigger provisioning again, which is also handled in MediaCryptoDeferrer. This could happen when per-origin provisioning is enabled and we have different origin IDs. MediaCryptoDeferrer is only used when mRequiresMediaCrypto is true. Bug: 834965 Change-Id: I4e9ce60acbb6132b8170b9f47bc85ef5fc946f4c Reviewed-on: https://chromium-review.googlesource.com/1071103 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#561658}
-
Sergey Volk authored
I've accidentally copied the values into wrong sections, they need to be swapped. Bug: none Change-Id: I19cb35c593b3e8666371b9d135d54a48e39c1086 Reviewed-on: https://chromium-review.googlesource.com/1072526Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#561657}
-
James Cook authored
Mash services like tap_visualizer are launched as utility processes so Chrome's crash reporting system works fine with them. Using chrome's crash system gives us Chrome's version number for the crashes (which makes sense, since the services are built into the chrome binary), support for chrome-specific crash features like crash-keys, etc. Override the process type with the service name so these crashes show up independently in the crash console, similar to what we do for extension renderers. Bug: 846123 Test: browser_tests, also kill -SEGV the tap_visualizer process and check reports Change-Id: I133aedcf1f263beb2d349e9bc24e5b3624d03ea8 Reviewed-on: https://chromium-review.googlesource.com/1072205Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561656}
-
rbpotter authored
Bug: 844513 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic00f1af465b742a23701a85aad2f0d68d22f8808 Reviewed-on: https://chromium-review.googlesource.com/1071071Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#561655}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7dc0e251e9a9..9a12da75442c $ git log 7dc0e251e..9a12da754 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 wangxianzhu Update reference builds of all channels 2018-05-24 csharrison Fix chown cmd in AndroidPlatformBackend.PushProfile Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia1f0a72544bf46fdf0d3ec443ea6d9959000411b Reviewed-on: https://chromium-review.googlesource.com/1072149Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561654}
-
Jennifer Apacible authored
This utilizes the ic_play_arrow.svg and ic_pause.svg used for the modern media controls. The SVGs are skiafied before replacing the previous controls; the new controls do not have a white circular background behind them. This change also adds a way to specify the horizontal and vertical alignment for images and background images separately for ImageButton. Previously, the image and background image had the same alignment. No other ImageButton that sets the background image currently specifies alignment. Part 1 of multiple diffs to move to modern styling. BUG: 836389 Change-Id: I5d01fb237c262e0610907c580a12914d30500443 Reviewed-on: https://chromium-review.googlesource.com/1069265 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 846291 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16f71655271eab77480c3744250618a2077481fe Reviewed-on: https://chromium-review.googlesource.com/1072041Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
- Start test_ime_driver when ash_shell_with_content starts; - Make test_ime_driver handle keystroke events in addition to char events used in tests; - Make test_ime_driver call DispatchKeyEventPostIME before handling it, similar to InputMethodMinimal, so that non-input keystrokes such as backspace, arrow keys are handled; Bug: 837710 Change-Id: Ib70ac5e424ab7e30517200763b3cff0f9a9f13bd Reviewed-on: https://chromium-review.googlesource.com/1070690Reviewed-by:
-
Max Morin authored
Only the "real" name, if any, is added in the audio service. The Default/Communications prefix is applied in the browser. Also fix some lint/IWYU stuff. Bug: 843145 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8a00a5d235807c8e7aeebac4a8062fa171152da6 Reviewed-on: https://chromium-review.googlesource.com/1071447 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#561650}
-
Xiaohan Wang authored
This is avoid flooding about://media-internals with too many audio timestamp gap warnings. For an example of excessive audio timestamp gap warnings, and the result after this CL: https://photos.app.goo.gl/9QiPxCVmJLtZNoIV2 Test: Manually verified Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic2570d98419407dde0643e62fe62975fddf2ef14 Reviewed-on: https://chromium-review.googlesource.com/1072027 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561649}
-
Mounir Lamouri authored
At the moment, we only notify the player if it was playing. This will notify the player all the time but only pause it if it is playing. Bug: 845560 Change-Id: Ifceafbc5eaa79927935ed4b5f50a147b03f955b5 Reviewed-on: https://chromium-review.googlesource.com/1069713 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#561648}
-
Daniel Park authored
>Adds variables for IPH >Implementing/showing IPH in a separate patch Bug: 843639 Change-Id: I9a20eca6504f083216dfc430a08d4bbda1c63d27 Reviewed-on: https://chromium-review.googlesource.com/1067778Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561647}
-
Tommy C. Li authored
Previously we could crash, because within this method, we iterate over a collection and update its elements, and subsequently invalidate the very collection we are iterating over. This CL fixes it. pbos@ provided the diagnosis. Bug: 846406 Change-Id: Ibeadddfaef2e7a3700b9b9fae6143892aee10af1 Reviewed-on: https://chromium-review.googlesource.com/1072189Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561646}
-
Aleks Totic authored
Bug: 728378 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iea3a95e237792af3d1f99dc23e8b68b3ce10c60d Reviewed-on: https://chromium-review.googlesource.com/1071088 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#561645}
-
Findit authored
This reverts commit ce767464. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 561616 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NlNzY3NDY0NGQxM2UzN2IyNzQ3MTY4NzZhMzg2N2UxYjFkZDhiOGQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/8468 Sample Failed Step: ozone_unittests Original change's description: > [Ozone-DRM] Refactor plane management and add tests > > * We use plane properties on legacy DRM to get some details (plane > type, in_formats). Read the properties in HardwareDisplayPlane and > check that the required properties are available in DRM atomic. > * Split dummy plane into its own class to clean up code. > * Remove test plane since we can now create the real objects via > injected state in DrmDevice. > * Cleanup plane initialization. > * Remove MockHardwareDisplayPlaneManager and rely on MockDrmDevice to > inject the necessary state. > > BUG=839487 > TEST=Ran unittests > > Change-Id: I03c91620557dcf7426629cf97bb989d8d7e83c68 > Reviewed-on: https://chromium-review.googlesource.com/1048585 > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561616} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=839487 Change-Id: Ie87a4ecea2b6c31aa25acd3633cda1b7547b0151 Reviewed-on: https://chromium-review.googlesource.com/1072667 Cr-Commit-Position: refs/heads/master@{#561644}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0115c356f675..b1a5e452d31e $ git log 0115c356f..b1a5e452d --date=short --no-merges --format='%ad %ae %s' 2018-05-23 agable Remove Rietveld-only apply_issue 2018-05-24 agable Remove more Rietveld support from presubmit Created with: roll-dep src/third_party/depot_tools BUG=chromium:770408,chromium:770408 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3c4783648fdd94df71a875e0444218c125cd94b6 Reviewed-on: https://chromium-review.googlesource.com/1072494 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561643}
-
Calder Kitagawa authored
Located by fuzzing ZTF Apply (WIP): https://chromium-review.googlesource.com/c/chromium/src/+/1072231 Found two fatal errors: - OffsetForKey always assumes a key is valid however, the validity of the key is not checked prior to the caller invoking the method. The caller also had no way to check validity if it was external to TargetPool. Fix: Add a method to check for key validity ahead of calling OffsetForKey. - ConvertToTargetLineCol for absolute references had a logic bug that resulted in attempting to dereference an invalid base::Optional Fix: Change the logic to avoid issue. Bug: 835341 Change-Id: I99c91741eef41dfaa3036af8e708eb3f0d5ca84a Reviewed-on: https://chromium-review.googlesource.com/1072272 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#561642}
-
Calder Kitagawa authored
zucchini_raw_apply_seed is failing on ToTWinCFI this disables building the target on Windows. A first attempt at a fix failed so until a better method of diagnosing the problem is determined we will disable it as it wasn't used by ClusterFuzz anyway (Linux only). Bug: 844826 Change-Id: I47820432ddb94334006ee727120a242684152b97 Reviewed-on: https://chromium-review.googlesource.com/1072506 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
AuthenticatorData was previously created with the hash of the clientDataJSON, rather than the hash of the RP ID. See https://www.w3.org/TR/webauthn/#authenticator-data for reference. Bug: 678128 Change-Id: I1628172212fadedd02a8ccf5daa46237bccd12bd Reviewed-on: https://chromium-review.googlesource.com/1066486 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561640}
-
Qiang Xu authored
Metrics added: Arc.AppShortcuts.BuildMenuTime in unit of "ms". Bug: 843676 Test: chrome://histograms Change-Id: I89887e965bcd9b6dce943fd54e0c00020ce513e8 Reviewed-on: https://chromium-review.googlesource.com/1069907 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561639}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5bf772bade61..97db69faaeb4 $ git log 5bf772bad..97db69faa --date=short --no-merges --format='%ad %ae %s' 2018-05-24 thestig CPDF_HintTables should not try to read 0 bits. Created with: roll-dep src/third_party/pdfium BUG=chromium:846394 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idef67cc9c19f519f36d8617c19c144253737f305 Reviewed-on: https://chromium-review.googlesource.com/1072493 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561638}
-
Yuri Wiitala authored
Media Remoting has launched. This change removes all the feature flag conditionals. TBR=rkaplow@chromium.org,imcheng@chromium.org Bug: 632399 Change-Id: I08edd86bf97cc4d180379edd2c6c4b309e7421f4 Reviewed-on: https://chromium-review.googlesource.com/1071001Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#561637}
-
Nate Chapin authored
It's only read for an event source probe that needs the resource identifier. Save the identifier in EventSource so it can be passed when it's needed. Change-Id: If95f5408b4f16bf97c79383d2a4203bb883c76e9 Reviewed-on: https://chromium-review.googlesource.com/1072271Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#561636}
-
Steven Bennetts authored
This CL: * Removes IsRunningInForcedAppMode from ChromeShellDelegate (ash.mojom.SessionInfo.is_running_in_app_mode is used instead). * Moves enabling of MagnifierKeyScroller and SpokenFeedbackToggler to ash::Shell. * Eliminates unused PreShutdown method. * Replaces call back into ash::Shell (ugh!) to show settings with direct call. Bug: 665064 Change-Id: I31e68366be2f6efab3845be6d00ebc3e967c99c7 Reviewed-on: https://chromium-review.googlesource.com/1070771Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#561635}
-
Scott Violet authored
It's only needed when we have the UI service, which for now is only on ChromeOS. BUG=846127 TEST=none Change-Id: I31980540ac15a63657cb1043b59c4ad6f2f03a0e Reviewed-on: https://chromium-review.googlesource.com/1072029Reviewed-by:
-
Mounir Lamouri authored
Implements a callback mechanism to notify the blink PictureInPictureWindow when the //content/browser window's size has changed. Bug: 806249 Change-Id: I5a110e64ab2762f28d963a15790d842b9f6e126c Reviewed-on: https://chromium-review.googlesource.com/1068066 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#561633}
-
Takuto Ikuta authored
We need to tell the location of dwo files to gdb too, to load debug information correctly. Reported in https://groups.google.com/a/chromium.org/d/msg/chromium-dev/Y_2aYS6_DXA/qQCeeznpCwAJ I also changed to use event handler for newly loaded objfiles. Bug: crbug.com/439949, crbug.com/603286 Change-Id: Ib0b52c5553578333cd0dd44f11a9117345622844 Reviewed-on: https://chromium-review.googlesource.com/1068785Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#561632}
-
Brian White authored
Some metrics record accumulated counts such as bytes or milliseconds that can rapidly overflow the 31-bit counters for them. This new histogram type auto-scales the counts down by some factor while keeping the "remainder" to add to future additions, thus keeping accuracy until such time as the program exits. This is similar to the AddScaled() method but is faster because it doesn't required generation of random numbers and also rounds the reported value to the nearest number rather than truncating it. Bug: 682680 Change-Id: I109229970924627a584bcb1b0984fc8455e6294d Reviewed-on: https://chromium-review.googlesource.com/1055623Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#561631}
-
Chase Phillips authored
Bug: 846408 Change-Id: Ib2b7fe4adcc948b88a6fbc46f9a2a678ce016aa3 Reviewed-on: https://chromium-review.googlesource.com/1072187 Commit-Queue: Chase Phillips <cmp@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#561630}
-
Ken Rockot authored
Two new things: * It is probably infeasible (at least not worth the effort) to migrate some consumers away from using arbitrary strings as invitation attachment names. Reverts the Attach/Extract calls to supporting arbitrary byte strings as names rather than limiting names to 64-bit ints. * Adds a disconnect indicator flag to MojoProcessErrorDetails to convey that no more invocations of the process error handler will occur for a given invitee. This allows more interesting uses of the provided context value, e.g. to have it represent an owned heap allocation, because there is now at least one guaranteed invocation of the handler and the final invocation will always set the disconnected flag. Bug: 844763 Change-Id: Ic8d951cb376c1ef746942bdef1de1856d74d6cbd Reviewed-on: https://chromium-review.googlesource.com/1069571 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561629}
-
Aldo Culquicondor authored
Bug: 846356 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ie4fb40df279faea04be86b5b35f44420c24b5785 Reviewed-on: https://chromium-review.googlesource.com/1072512Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#561628}
-
Jeremy Roman authored
Use base/ and/or crypto/ directly, instead. Change-Id: I7fecadacb4bb3c0cfc0f144ebc284b47349621df Reviewed-on: https://chromium-review.googlesource.com/1071878Reviewed-by:
-
Roger Tawa authored
This change was originally landed as: https://chromium-review.googlesource.com/c/chromium/src/+/1053763 It was reverted because it broken official builders: https://chromium-review.googlesource.com/c/chromium/src/+/1069387 Patchset #1 of this CL is exactly the patch that was originally landed. Patchset #3 contains the fix: update javascript test code to accept new arguments in the C++ to javascript bindings. Bug: 834939 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia04822d91cdc436b482d0f0c5f3af2c71d003c1f Reviewed-on: https://chromium-review.googlesource.com/1071712 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Robert Ma authored
Based on https://crrev.com/c/1038431 Bug: 831847 Change-Id: Id3ce9733954f9c97f5bb67ebaa8e3c9c6d436cb9 Reviewed-on: https://chromium-review.googlesource.com/1064805Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#561625}
-
Ken Rockot authored
These are cleaned-up versions of the EDK's PlatformChannelPair and NamedPlatformChannelPair, which will be removed but remain untouched for the moment. Most of the logic is duplicated verbatim, modulo cleanup. For test coverage, since actual I/O operations are not being ported to the public library, the new types are used in place of EDK types within the invitation API tests. Bug: 844764 Change-Id: Ieeea396370e37d4fa3a0e9a65b6f9b71855b85fc Reviewed-on: https://chromium-review.googlesource.com/1068652 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Stuart Langley authored
We have stopped using (Get|Set)LargestChangestamp in favor of (Get|Set)StartPageToken. This CL removes the code and fixes the UI to display the start page token instead. We leave (Get|Set)LargestChangestamp in resource metadata storage to facilitate DB upgrades, where we write the existing largest changestamp to the start page token field. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I57c8f61e3914cdfd3ea15046c8551f0456f9e636 Reviewed-on: https://chromium-review.googlesource.com/1071149Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#561623}
-
Rohit Rao authored
UINavigationBar renders incorrectly when pushViewController:animated: is called from within viewDidLoad. Sidestep this by pushing every BookmarkHomeViewController onto the navigation stack before making the Bookmarks UI visible. In cases where the BookmarkModel has not yet been loaded and a spinner is shown, we fall back to the original logic of recursively pushing new view controllers. That does not trigger the UIKit bug because viewDidLoad has already completed. BUG=None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id9535f6cb9e93fb85d27d4627adeb404d8564dc4 Reviewed-on: https://chromium-review.googlesource.com/1070793 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#561622}
-
Peter Wen authored
Pak symbols were not getting their full name propagated to name and template_name, making it harder to see their names in the diffs. Bug: 842728 Change-Id: Id98edbc246239f053ab48d398adf3a058a022514 Reviewed-on: https://chromium-review.googlesource.com/1072496 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#561621}
-
Xiaoqian Dai authored
It's an initial implementation of the feature. See the UI mock: https://docs.google.com/presentation/d/1zCV2v5rXFUndWC5ECMKj06i5WNbRJ-uZWyZTFxU8dEE/edit#slide=id.g21b4c071a9_0_116 See Doc for expected behaviors: https://docs.google.com/document/d/1rm8_JyTY883IiNNis6LGtI1jsx_WHCWm5KY7hwAGOe8/edit#heading=h.i5t24a7vxw8j See recorded video: https://drive.google.com/open?id=1KcqAyHrxj6zheSEkgGz-ozlg7mILrmxT 1) Add a new feature flag --enable-features=DragTabInTabletMode And also expose it to chrome flag --enable-drag-tabs-in-tablet-mode 2) Only tab(s) area can be dragged. 3) For a maximized window, its tab(s) can be dragged out to create a new window to either be maximized or snapped to one side of the screen, or can also be merged back to the original window 4) For a snapped window, its tab(s) can be dragged out to create a new window to snap to either side of the split, or can also be merged to an existing window to either side of the split Change-Id: Ieb2e8921d5c116a83e1b7998d992f8e32a904099 Reviewed-on: https://chromium-review.googlesource.com/1020294 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
