GitLab

By not detaching the GL functor until after the teardown, we ran the
risk of stray draw calls occurring that could potentially reinitialize
the hardware renderer, causing the SharedRendererState destructor to
DCHECK.

BUG=

Review URL: https://codereview.chromium.org/920083002

Cr-Commit-Position: refs/heads/master@{#316222}

This is the first of three patches.

The second patch (in blink) will make all existing uses of
window.eventSender.gestureFlingStart pass a source device.
(https://codereview.chromium.org/901323004)

The third patch (in chrome) will change
EventSenderBindings::GestureFlingStart to require a source device.

BUG=456136
TEST=LayoutTests/fast/events/touch/

Review URL: https://codereview.chromium.org/902173003

Cr-Commit-Position: refs/heads/master@{#316221}

This makes its appearance consistent with the permission request, which
asks a user whether the site can show notifications.

BUG=458143

Review URL: https://codereview.chromium.org/919033002

Cr-Commit-Position: refs/heads/master@{#316220}

Previously, TestMockTimeTaskRunner had only supported vending out TimeTicks and TickClocks. Now it supports mock Time and mock Clocks too (they start at the Unix epoch).

This CL also shortens the names of the methods that vend the current time and time ticks to Now() and NowTicks(), respectively; removes using the "base" namespace prefix inside the "base" namespace; and provides a clean implementation for FastForwardUntilNoTasksRemain() instead of a hacky solution.

BUG=329911
TBR=phajdan.jr@chromium.org  # OOO.

Review URL: https://codereview.chromium.org/899863002

Cr-Commit-Position: refs/heads/master@{#316219}

PasswordAutofillAgent::SendPasswordForms is called twice during page load:
On DidFinishDocumentLoad, when it is interested in parsed HTML forms,
and on DidFinishLoad, when it is interested in those forms, which are also visible.

Currently, the method does the visibility check all the times, and throuws out the result in the first situation.

This is not only wasting computational resources, but possibly causing crashes due to not finished rendering computations.

This CL fixes that, and only does the visibility check if needed.

BUG=457243

Review URL: https://codereview.chromium.org/925983002

Cr-Commit-Position: refs/heads/master@{#316218}

BUG=393668

Review URL: https://codereview.chromium.org/690103008

Cr-Commit-Position: refs/heads/master@{#316217}

BUG=418485

Review URL: https://codereview.chromium.org/919393003

Cr-Commit-Position: refs/heads/master@{#316216}

Because there is no signing identity on upstream bots. Omitting this variable is causing at least device bots to assume it should be 1, might as well be explicit on all bots.

BUG=452193

Review URL: https://codereview.chromium.org/918213004

Cr-Commit-Position: refs/heads/master@{#316215}

Cr-Commit-Position: refs/heads/master@{#316214}

Revert of Reset Screen moved to ScreenContext. (patchset #6 id:100001 of https://codereview.chromium.org/904163003/)

Reason for revert:
Conflict with https://codereview.chromium.org/872633008/

Original issue's description:
> Reset Screen moved to ScreenContext.
>
> BUG=456778
>
> Committed: https://crrev.com/4b77f613917020e58b31975355e4ca2347f216e2
> Cr-Commit-Position: refs/heads/master@{#316212}

TBR=dzhioev@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=456778

Review URL: https://codereview.chromium.org/917613005

Cr-Commit-Position: refs/heads/master@{#316213}

BUG=456778

Review URL: https://codereview.chromium.org/904163003

Cr-Commit-Position: refs/heads/master@{#316212}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5479a76..d05f5ed

TBR=senorblanco@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/927523002

Cr-Commit-Position: refs/heads/master@{#316211}

In order to make a view vibrant we need to:
1. Place the view inside NSVisualEffectView
2. Return YES from allowsVibrancy

In order to make it possible to use WebContentsViewCocoa in vibrant view hierarchy, we need to implement allowsVibrancy.

From NSView documentation for allowsVibrancy:
"AppKit checks this property when the view is incorporated into a view hierarchy that uses vibrancy."

This means that only returning YES from allowsVibrancy will have no effect on the way view is rendered, we are safe to just return YES here.

Note: returning YES from isOpaque causes problems with vibrancy, that is why a setter is needed on RenderWidgetHostViewCocoa.

Review URL: https://codereview.chromium.org/869563003

Cr-Commit-Position: refs/heads/master@{#316210}

BUG=455705
TEST=Existing tests, manual.

Review URL: https://codereview.chromium.org/872633008

Cr-Commit-Position: refs/heads/master@{#316209}

Revert of bookmarks: Remove url_database.h entry from DEPS list. (patchset #2 id:20001 of https://codereview.chromium.org/912653005/)

Reason for revert:
Seem to cause a failure related to bookmark dependencies.

Original issue's description:
> bookmarks: Remove DEPS file now that componentization is almost done.
>
> Since the componentization of bookmarks is mostly done, we don't need the rules forbidding usage of //chrome/browser anymore, as the files still in
> //chrome/browser/bookmarks won't be moved in the component  (factories,
> client, etc, all belongs to the embedder, not the component).
>
> BUG=383597
> TEST=checkdeps
> R=sky@chromium.org,sdefresne@chromium.org
>
> Committed: https://crrev.com/de85300a1986e3ce43f89a56b08dbd5e2049c041
> Cr-Commit-Position: refs/heads/master@{#316201}

TBR=sdefresne@chromium.org,sky@chromium.org,tfarina@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=383597

Review URL: https://codereview.chromium.org/920403002

Cr-Commit-Position: refs/heads/master@{#316208}

Currently Device Orientation/Motion null event tests with alert are
flaking on some windows and android bots. This patch splits the null
event tests into basic tests and one test with modal alert dialog.
The latter test ensures that the null events still arrive when active
dom objects are suspended (by alert).

BUG=360578

Review URL: https://codereview.chromium.org/870103004

Cr-Commit-Position: refs/heads/master@{#316207}

Adds idle% measurement unit and use it for v8 idle gc times measurement.

BUG=455713.

Review URL: https://codereview.chromium.org/924433004

Cr-Commit-Position: refs/heads/master@{#316206}

BUG=402344

Review URL: https://codereview.chromium.org/923933002

Cr-Commit-Position: refs/heads/master@{#316205}

Code was not present for handling drag by mouse.
Now we are passing message when their is selection happening and based on mousemove event handler we are scrolling page when mouse points are outside the viewport.
When we move mouse outside the viewport and does not move then mousemove events will not come then we are scrolling based on timer.

BUG=446831

Review URL: https://codereview.chromium.org/814573004

Cr-Commit-Position: refs/heads/master@{#316204}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/925603005

Cr-Commit-Position: refs/heads/master@{#316203}

These changes are to make behaviour of chrome shell
similar to chrome by hiding Url bar when tab switcher is shown.

BUG=458042

Review URL: https://codereview.chromium.org/914083003

Cr-Commit-Position: refs/heads/master@{#316202}

Since the componentization of bookmarks is mostly done, we don't need the rules forbidding usage of //chrome/browser anymore, as the files still in
//chrome/browser/bookmarks won't be moved in the component  (factories,
client, etc, all belongs to the embedder, not the component).

BUG=383597
TEST=checkdeps
R=sky@chromium.org,sdefresne@chromium.org

Review URL: https://codereview.chromium.org/912653005

Cr-Commit-Position: refs/heads/master@{#316201}

Fixes and updates to NavigatorTestWithBrowserSideNavigation.

This is a pre-step for working on the navigation cancellation logic.

Several small things going on in this CL:
* Renamed methods, added and updated comments to make things clearer
* Added a couple new tests for renderer initiated navigations and
  beforeUnload canceling the navigation.
* Replaced calls to TestRenderFrameHost::SendBeginNavigationWithURL with
  TestRenderFrameHost::SendBeforeUnloadACK now that they represent
  different things (beforeUnload reply vs renderer-initiated navigation
  request)
* Added more checks in general but especially for the NavigationRequest
  state, its browser_initiated flag

BUG=376014

Review URL: https://codereview.chromium.org/912833002

Cr-Commit-Position: refs/heads/master@{#316200}

Now there's a MockPresentationService that's owned by WebTestProxy and
accepts private method calls from the tests.

MockPresentationClient was moved to WebFrameTestProxy instance since
we want one per each frame. Reset logic is added too to make tests more
independent.

BUG=412331

Review URL: https://codereview.chromium.org/907893002

Cr-Commit-Position: refs/heads/master@{#316199}

This is using PostTaskAndReplyWithResult() instead of PostTask,
making sure that the callback is destroyed in the same thread as it
was called in.

BUG=457287

Review URL: https://codereview.chromium.org/918613003

Cr-Commit-Position: refs/heads/master@{#316198}

Review URL: https://codereview.chromium.org/919943002

Cr-Commit-Position: refs/heads/master@{#316197}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/684cb67..5479a76

TBR=senorblanco@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/927463002

Cr-Commit-Position: refs/heads/master@{#316196}

This revers https://codereview.chromium.org/905353002 and instead
waits with initializing liblouis until the DOMContentLoaded event
fires.  This makes loading the nacl module reliable and also gets rid of the
retry loop that was used before.

TESTED=manual
BUG=none
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/917793003

Cr-Commit-Position: refs/heads/master@{#316195}

This is a second attempt at:
https://codereview.chromium.org/904833004/
which caused flakiness in pixel tests and was reverted here:
https://codereview.chromium.org/919273002/

This CL merges the fix from:
https://codereview.chromium.org/918313003/

It also handles the case where dumpDragImage is called but no drag occurs
by dumping a 1x1 empty transparent image.

This is used by:
https://codereview.chromium.org/886323005/

BUG=451759, 458077

Review URL: https://codereview.chromium.org/916893003

Cr-Commit-Position: refs/heads/master@{#316194}

This can be disabled using the --disable-namespace-sandbox flag.

BUG=312380

Review URL: https://codereview.chromium.org/915433002

Cr-Commit-Position: refs/heads/master@{#316193}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/920943002

Cr-Commit-Position: refs/heads/master@{#316192}

Due to a bug the queue was running more tasks than maximum capacity of the
queue. That made the browser tests flaky.

Unfortunatley this case wasn't covered by unit tests. This CL adds it.

TEST=None
BUG=None

Review URL: https://codereview.chromium.org/925873002

Cr-Commit-Position: refs/heads/master@{#316191}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e926c1e..684cb67

TBR=lushnikov@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/917713003

Cr-Commit-Position: refs/heads/master@{#316190}

Cr-Commit-Position: refs/heads/master@{#316189}

They just go away as soon as the page (e.g. History) loads and it looks funky.

R=dmazzoni@chromium.org
BUG=457165

Review URL: https://codereview.chromium.org/914033002

Cr-Commit-Position: refs/heads/master@{#316188}

when we are viewing the PDF in a MimeHandlerViewGuest then we should
use its embedder WebContents.
Changes done to use the embedder WebContents if we have guest view.

BUG=449919

Review URL: https://codereview.chromium.org/913663002

Cr-Commit-Position: refs/heads/master@{#316187}

This is follow up CL to crrev.com/922593002

BUG=442214
TEST=compiled_resources.gyp passes
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/922133002

Cr-Commit-Position: refs/heads/master@{#316186}

This CL also contains following fixes.
* Add error handling to ThumbnailLoader.loadAsDataUrl.
* Removed unnecessary document argument from ListThumbnailLoader.

BUG=438050
TEST=manually tested;Open a folder which contains photos in it with list view and grid view.

Review URL: https://codereview.chromium.org/912783002

Cr-Commit-Position: refs/heads/master@{#316185}

For tools/sort_sources.py to be useful, existing GYP files
should be sorted.

BUG=456014
TEST=everything should build as before

Review URL: https://codereview.chromium.org/923863002

Cr-Commit-Position: refs/heads/master@{#316184}

For tools/sort_sources.py to be useful, existing GYP files
should be sorted.

BUG=456014
TEST=everything should build as before

Review URL: https://codereview.chromium.org/923853002

Cr-Commit-Position: refs/heads/master@{#316183}