- 12 Jul, 2017 40 commits
-
-
Gregory Chatzinoff authored
Add edchin@ and gchatz@ as owners of the badge view files within the reading list directory. Bug: none Change-Id: I4eace37f01184d72a838c519f06cb848e50391bb Reviewed-on: https://chromium-review.googlesource.com/567798Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#485901}
-
Mythri Alle authored
After the fix to V8 (https://chromium-review.googlesource.com/c/563301/) the following tests should not fail anymore. deqp/functional/gles3/texturefiltering/* deqp/functional/gles3/textureformat/* deqp/functional/gles3/textureshadow/* deqp/functional/gles3/texturespecification/* Bug: chromium:725664 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I66255692b1c3a763a3cb1ccb087d00b7c1828328 Reviewed-on: https://chromium-review.googlesource.com/552551Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#485900}
-
yoshiki iguchi authored
Bug: none Change-Id: I48da5486779d4874a75d573b09c79b503925d992 Reviewed-on: https://chromium-review.googlesource.com/567900Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#485899}
-
Jia authored
ConsumeShorthandVia2LonghandAPIs is a modified version of Consume2Values of CSSPropertyParser. The difference between the two is that the new version expects component longhands to have API impl already as it will forward parsing logic to component longhands API via ParseLonghandViaAPI. Consume2Values will be deprecated soon, when shorthand properties are ribbonised (i.e. have their own APIs). Until then, there is a slight code duplication between the two versions, see crrev.com/c/564875 for discussions why it is necessary. In addition to ConsumeShorthandVia2LonghandAPIs, the cl also contains the following * Implement API for shorthand property scroll-padding-block as a use case of ConsumeShorthandVia2LonghandAPIs. * Change ConsumeShorthandVia4LonghandsAPI to ConsumeShorthandVia4LonghandAPIs. - Also updated "margin" API to reflect the naming change. Bug: 668012 Change-Id: I45d1f5177c5ff3f381a24085ecde0647c5e08baf Diff: https://gist.github.com/a54354ab973c928d2717251b56caeb57/revisions Reviewed-on: https://chromium-review.googlesource.com/565662Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485898}
-
Mihai Sardarescu authored
This CL removes the usage of the Google password from sync as discussed over email. Email from zea@: "That's all legacy code really. It's only used for people with very old sync accounts that might still be based on their GAIA credentials, and should only be used once as we'll immediately transition that account. I'm fine with removing that logic." This CL also removes the usage of password from ChromeOS (and the method RefreshSpareBootstrapToken), as GoogleSigninSucceeded method is only called by SigninManager (not from SigninManagerBase) that is not used on ChromeOS. Bug: Change-Id: I43d5cdf38d5b9ff97f13e31b5c2069203a803565 Reviewed-on: https://chromium-review.googlesource.com/565512Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#485897}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f2c153fc..6c835897 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I519ce32c7724b1e98dc773e289ea405a52ae73be Reviewed-on: https://chromium-review.googlesource.com/567631Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485896}
-
hugoh authored
Background: - When the GPU thread is *in-process* it runs inside the browser process. - GpuChildThread is a ChildThreadImpl and a IPC::Listener. - When GpuChildThread sees an error (or shutdown) of its IPC channel, it quits its message loop (= stops the thread). Problem: The browser process' IOThread calls InProcessGpuThread::StopSoon() while the in-process GPU thread destructs itself. When InProcessGpuThread::StopSoon asks for task_runner() the in-process GPU thread has - sometimes - already destructed itself and its MessageQueue. The IOThread then sees task_runner() == null and crashes: [FATAL:ref_counted.h(484)] Assert failed: ptr_ != nullptr. 0 base::debug::StackTrace::StackTrace() 1 base::debug::StackTrace::StackTrace() 2 logging::LogMessage::~LogMessage() 3 base::Thread::StopSoon() 4 base::Thread::Stop() 5 content::InProcessGpuThread::~InProcessGpuThread() 6 content::InProcessGpuThread::~InProcessGpuThread() 7 content::GpuProcessHost::~GpuProcessHost() 8 content::GpuProcessHost::~GpuProcessHost() 9 content::BrowserChildProcessHostImpl::TerminateAll() 10 content::BrowserProcessSubThread::IOThreadPreCleanUp() 11 content::BrowserProcessSubThread::CleanUp() 12 base::Thread::ThreadMain() 13 base::(anonymous namespace)::ThreadFunc() Solution: If a thread runs in the browser process, only Thread::Stop should stop its message loop. Otherwise, QuitWhenIdle could race Thread::Stop. BUG=258935 Review-Url: https://codereview.chromium.org/2973723003 Cr-Commit-Position: refs/heads/master@{#485895}
-
Christopher Cameron authored
This matches the behavior of --force-device-scale-factor. Move the checks for "is the color profile forced" from the implementation of ICCProfile::FromBestMonitor to the call sites to avoid layering violations. Bug: 740663 Change-Id: I8f37b8b5ca6300465a1e7e0132e587378805a813 Reviewed-on: https://chromium-review.googlesource.com/565763 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485894}
-
Hiroshige Hayashizaki authored
As a result of centralizing script execution and load/error event dispatching into ScriptLoader::ExecuteScriptBlock(), ExecuteScript(), DispatchLoadEvent() and DispatchErrorEvent() are now called only from ScriptLoader. Bug: 686281 Change-Id: I47f7b1c0d79d9d7bc586cb02028d72260f20be7b Reviewed-on: https://chromium-review.googlesource.com/557383 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485893}
-
tzik authored
This is a generated CL to rewrite base::Bind to base::BindOnce where the result of base::Bind is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); An explainer of OnceCallback is available here goo.gl/YZiUL1. The rewriting tool is in //tools/clang/base_bind_rewriters. To build and run locally, follow //docs/clang_tool_refactoring.md. This conversion makes almost no behavior change except that a bound objects are passed-by-move to the target function. Bug: 554299, 714018 Change-Id: Ief819fd7850d61a377300d61fd5a317104084c77 Reviewed-on: https://chromium-review.googlesource.com/547179Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#485892}
-
Takashi Toyoshima authored
Now that ResourceLoadScheduler depends on WebFrameScheduler, and it is useful to enable ResourceLoadScheduler even on platform unit tests, let's introduce a simple mocked WebFrameScheduler that allows calling MockFetchContext::GetFrameScheduler(), and use it to call {Add|Remove}ThrottlingObserver() for testing. This also makes it possible to remove the test-only purposed GetTaskRunner() method from the MockFetchContext, and makes FetchTestingPlatformSupport consistent in terms of Blink scheduler. Bug: 729953 Change-Id: Ib5ab2ad1c5b6ce2b4267667ad0b0cacbb1cc8f17 Reviewed-on: https://chromium-review.googlesource.com/563216 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485891}
-
kojii authored
This patch fixes two issues in NGInlineNode::ComputeMinMaxContentSize() 1. The max-content algorithm was incorrect. Fixed to compute the max of line widths when available width is infinite. 2. Negative text-indent can make min > max. CSSWG test indicates we should take min of the two values in the case. BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2974823004 Cr-Commit-Position: refs/heads/master@{#485890}
-
kojii authored
This patch computes baseline from fragment tree. Design doc: https://docs.google.com/a/chromium.org/document/d/1ukrQxkSKMuU1lW2XaQMzgRlsurBjkxZxAq028EbhFjo/edit?usp=sharing BUG=636993 Review-Url: https://codereview.chromium.org/2867293002 Cr-Commit-Position: refs/heads/master@{#485889}
-
Kent Tamura authored
This behavior is similar to the current behavior on macOS. Note that Windows and Linux have height and width grow animation from the center of a bubble, and Android has no animation. Bug: 739091 Change-Id: I771b1f22ba503287222e91919afa1c2853aea940 Reviewed-on: https://chromium-review.googlesource.com/567616Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485888}
-
dougt authored
This CL switches accNavigate completely over to the AXPlatformNode code. It also moves the table handling code from BrowserAccessibility to AXPlatformNodeBase. BUG=703369 Review-Url: https://codereview.chromium.org/2964313002 Cr-Commit-Position: refs/heads/master@{#485887}
-
Sergey Ulanov authored
Updated version now builds on Fuchsia. There are no other changes. Bug: 737802 Change-Id: I134248a719aaea783349ec3f6a663bde1a82ec30 Reviewed-on: https://chromium-review.googlesource.com/567024 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#485886}
-
tzik authored
media::BindToCurrentLoop used to be unable to handle move only type, so its user needed to make custom ones, which are no longer needed since m::BTCL can handle move-only types after http://crrev.com/2b817313110d5178. Change-Id: I6287a3ac8f29a15d9d915a2b3b74e6da6de49f9b Reviewed-on: https://chromium-review.googlesource.com/567614 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#485885}
-
David Reveman authored
This reverts commit c3dec2b9. Reason for revert: Last version of patch broke ARC++ import of all buffers Original change's description: > gpu: Fix FD leak when importing DMA-bufs with multiple FDs. > > CreateFromHandle is expected to take ownership of all FDs so > when passed multiple FDs we need to make sure they are closed > if not used. > > BUG=b/63409814 > TEST=exo_unittests --gtest_also_run_disabled_tests --gtest_filter=DisplayTest.DISABLED_CreateLinuxDMABufBuffer > > Change-Id: I2a8a7b0149a08f08890a725c6ce9aff8aeaab97f > Reviewed-on: https://chromium-review.googlesource.com/566879 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Commit-Queue: David Reveman <reveman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485761} TBR=reveman@chromium.org,dcastagna@chromium.org Change-Id: Idad3a18398c1c1ce959bff646f83d607b9e3c2c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/63409814 Reviewed-on: https://chromium-review.googlesource.com/566863Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485884}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d96ed9d0def2..c4176a2fa5aa $ git log d96ed9d0d..c4176a2fa --date=short --no-merges --format='%ad %ae %s' 2017-07-11 fmalita Always use raster pipeline for perspective 2017-07-12 fmalita Revert "Experimental blur code." Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ic1fc51b3f2a09bbcef13fc29f292722dd04915c7 Reviewed-on: https://chromium-review.googlesource.com/567864Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485883}
-
Gabriel Charette authored
And cleanup MachineIdProvider to be a free function (making it clear that this is fine to call in an unsequenced task while cleaning up issue 354882). TBR=thestig@chromium.org (chrome_browser_main.cc side-effects) Bug: 689520, 354882 Change-Id: Iac7d683c2e74c6c6b865110033b669584277f92a Reviewed-on: https://chromium-review.googlesource.com/545158 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#485882}
-
Yoshifumi Inoue authored
This patch gets rid of |SelectionTemplate::granularity_| since it is always |TextGranularity::kCharacter| since the patch[1] for improving code health. This patch also renames |SelectionTypeWithLegacyGranularity()| to |Type()| since |SelectionTemplate| doesn't have granularity any more. [1] http://crrev.com/2970043002: Simplify SelectionController::UpdateSelectionForMouseDrag() Bug: 692923 Change-Id: Ic58dfcf8eef7f7fe2121df27b5639d98da16986d Reviewed-on: https://chromium-review.googlesource.com/567781Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485881}
-
Wez authored
This is a reland of 45df4f39 Original change's description: > Fix threading in FileDescriptorWatcher and MessagePumpLibevent tests. > > Changes to MessagePumpLibevent & tests: > 1. Add an explicit wait for thread start-up to TestWatchingFromBadThread, > which was not updated when the base::ThreadStart() call was changed to > not wait for the thread startup to complete. > 2. Reinstate TestWatchingFromBadThread on all libevent platforms. > 3. Add sanity-check tests for readable/writable notifications. > 4. Clean up some .get()s and add some DPLOGs. > > Changes to FileDescriptorWatcher & tests: > 1. Add a DLOG_IF() to StartWatching, to make it easier to spot > WatchFileDescriptor failures. This can't be a DCHECK or CHECK, since the > StartWatching operation is racey with file-descriptor close() on the > calling thread. > 2. Fix the test fixture to Stop() |other_thread_| to ensure it is done > working before we tear down the test file descriptors. > 3. Fix the WatchWritable test to request write notifications for the > correct end of the pipe (since pipe()s are uni-directional). > > Bug: 138845,740692 > > TBR=dcheng,fdoray > > Change-Id: I86bdd100561fbc56c1e6291216cafc3168b185dc > Reviewed-on: https://chromium-review.googlesource.com/565227 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485822} TBR: dcheng, thakis Bug: 138845, 740692 Change-Id: Ibc6e48316351b311bfa06727964bbcf4cf5e699b Reviewed-on: https://chromium-review.googlesource.com/566840Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#485880}
-
Evan Stade authored
Bug: 736539 Change-Id: I7ae1d4f48f613fb5b2526755d7282ced7f424b23 Reviewed-on: https://chromium-review.googlesource.com/567200Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#485879}
-
Jia authored
Implement parseShorthand for -webkit-border-[start|end|before|after], -webkit-text-stroke and outline. All these shorthand properties call the same helper function ConsumeShorthandGreedilyViaLonghandAPIs. Hence these properties are grouped in one cl. Bug: 668012 Change-Id: I4341dd88c9e69ef0105846094324f673adffa967 Diff: https://gist.github.com/56c80c6712e00d58983a557381f20664/revisions Reviewed-on: https://chromium-review.googlesource.com/567605Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Suzy Howlett <suzyh@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485878}
-
Eric Roman authored
Bug: 740871 Change-Id: I8571bf9448da2a257c45da7f1943226095ab08b7 Reviewed-on: https://chromium-review.googlesource.com/567638 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485877}
-
Tsuyoshi Horo authored
I removed the UMA (ServiceWorker.NavigationHintPrecision) when we stopped "Speculatively start Service Workers on UI-events" experiment (crbug.com/616502). But we will start "Warm-up service worker on omnibox signal" experiment (crbug.com/732681). So this CL revive the UMA as ServiceWorker.StartHintPrecision. Bug: 740102 Change-Id: I84034f9a3c8edb9ff25e5644d6b94c624ae00f1c Reviewed-on: https://chromium-review.googlesource.com/566138 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485876}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f9afdad..f2c153fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I1bb1a398e0422df6ab613f7de030a5a6b3d23fe5 Reviewed-on: https://chromium-review.googlesource.com/567709Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485875}
-
Giovanni Ortuño Urquidi authored
This flag will be used to develop new windowing related behavior for Desktop PWAs. Bug: 729923 Change-Id: I594eadbdf9f00928e9c1963f510e4b7c7b7788f7 Reviewed-on: https://chromium-review.googlesource.com/566263 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#485874}
-
Makoto Shimazu authored
This is 4th patch of script streaming project split off from https://chromium-review.googlesource.com/c/538477. This patch adds Mojo's interface to stream installed scripts to the renderer during launching up. This patch implements: - WebServiceWorkerInstalledScriptsManagerImpl::Internal as a receiver of streamed scripts which lives on the io thread on the renderer - ServiceWorkerInstalledScriptsSender as a sender of installed scripts on the browser process Bug: 683037 Change-Id: I6d7ae63aea670c37fe00c0c81afceb71dd70c62a Reviewed-on: https://chromium-review.googlesource.com/558529Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485873}
-
dougt authored
This CL moves all ia2_role handling from BrowserAccessibilityComWin to AXPlatformNodeWin. In addition, we now forward IAccessible2::role() to AXPlatformNodeWin as well. BUG=703369 Review-Url: https://codereview.chromium.org/2965873002 Cr-Commit-Position: refs/heads/master@{#485872}
-
Yuki Awano authored
- unzReadCurrentFile in third_party/minizip/src/unzip.c supports to read a data up to UINT16_MAX at a time. BUG=359837 TEST=enable --zip-archiver-on-filer-manager flag and try to open and read a file with zip archiver. Change-Id: If92948199c6c3077ce35c0d4fdc60b20406acb1f Reviewed-on: https://chromium-review.googlesource.com/566767Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#485871}
-
zhenw authored
This is the 1st CL for staggered background tab opening feature. It adds TabNavigationThrottle, which plumbs navigation information into TabManager and enables TabManager to defer navigation for background tabs. This CL uses a simple algorithm, which defers background tab's navigation when some tab is loading. After a tab finishes loading, it will resume another pending navigation. TabManager will also resume a pending navigation when a background tab is selected. This feature is currently implemented behind a flag. This feature will not be enabled until the corresponding metrics are ready. This CL focuses on plumbing navigation into TabManager. The actual algorithm to delay background tab opening is simple. But it should be fine because the whole feature is behind a flag right now. There will be follow-up CLs to consider system resources and refine the algorithm. Design doc: https://docs.google.com/document/d/1_CS5kcY00CE3pzDTtW5Ny221gWfk4mFXYGiezoYSCBI/ BUG=730098 Review-Url: https://codereview.chromium.org/2931023002 Cr-Commit-Position: refs/heads/master@{#485870}
-
Yoshifumi Inoue authored
This patch changes "undo-{combined-,forward-,}delete-boundary.html" to use |assert_selection()| and integrate into "undo-delete-boundary.html" since these test are similar for improving readability. Bug: 230267, 679977 Change-Id: I7f07399e83ee02ca9e945eeef5163e278cb9a10a Reviewed-on: https://chromium-review.googlesource.com/567615Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485869}
-
rnephew authored
Should never have been re-enabled on android. Did not read the bug associated with the disabling close enough. Will need to be more careful in the future. TBR=charliea@chromium.org Bug: 713222 Change-Id: Ib8908be570e772791167b38a57e7a96358ae8274 Reviewed-on: https://chromium-review.googlesource.com/567110Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#485868}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a781af7..4d97f36 BUG=738298 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ida9f06b57f57a77676da21e6542640916db6bae6 Reviewed-on: https://chromium-review.googlesource.com/566949Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Cr-Commit-Position: refs/heads/master@{#485867}
-
Joel Hockey authored
Code in LayoutEmbeddedContent::UpdateGeometry which is checking whether view is LocalFrameView or PluginView and then applying type-specific logic is moved into new virtual method EmbeddedContentView::UpdateGeometry and implemented by the relevant subtype (LocalFrameView, PluginView). Update RootScrollerController::UpdateIFrameGeometryAndLayoutSize to call LocalFrameView::UpdateGeometry rather than calling it on the Layout. Remove PluginView::GeometryMayHaveChanged, instead call plugin->ReportGeometry from PluginView::SetFrameRects. PluginView::GeometryMayHaveChanged was called as a special case in LayoutEmbeddedContent::UpdateGeometry, but it can be handled by PluginView::SetFrameRect which is also called at the same time. Remove unneeded protector from LayoutEmbeddedContent::UpdateGeometry. Bug: 637460 Change-Id: I2f9b4cab874e167afe9e4fb860351e92881f7bc6 Reviewed-on: https://chromium-review.googlesource.com/527862Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#485866}
-
wychen authored
The following tests are re-enabled: - testValid - testNoMeta - testCache All flaky failures in CopylessPasteTest are due to timeout in CallbackHelper.waitForCallback(). Wait for longer to see if it gets better. Reference: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&showAllRuns=true&tests=org.chromium.chrome.browser.CopylessPasteTest%23 BUG=713172,713895,713878,693650 Review-Url: https://codereview.chromium.org/2826253004 Cr-Commit-Position: refs/heads/master@{#485865}
-
yhanada authored
- Remove unused include_rule. - Restrict access to content/ and media/audio under ui/keyboard/content. - Move "+ui/gl/test/..." rule to ui/keyboard/test/DEPS. Test: trybots pass. Change-Id: I4cb1f8a34f8bd8cf6e1202bd0d1751af0f270367 Reviewed-on: https://chromium-review.googlesource.com/558591Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#485864}
-
Koji Ishii authored
Currently, NGLayoutInputNode::IsInline() uses a bit field in LayoutObject. This can mis-behave when NGBlockNode and NGInlineNode share a LayoutNGBlockFLow. This patch adds a type field back to NGLayoutInputNode. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 739087 Change-Id: I137ee5a5233d96fbb3297f1054f2cab7e4c06d33 Reviewed-on: https://chromium-review.googlesource.com/566984Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#485863}
-
dougt authored
This CL moves all ia2_state handling from BrowserAccessibilityComWin to AXPlatformNodeWin. In addition, we now forward get_states() to AXPlatformNodeWin as well. BUG=703369 Review-Url: https://codereview.chromium.org/2968833002 Cr-Commit-Position: refs/heads/master@{#485862}
-