- 14 May, 2019 40 commits
-
-
Robert Ma authored
The merge_web_test_results.py script used to use the current working directory when --output-directory isn't specified but --output-json is (which is the case on Swarming). This could be dangerous as the script will clean everything in the output directory. This CL changes the behaviour to always create a temporary output directory if it's not specified. Bug: 960994 Change-Id: If1dd0f060557e7fb7014ea0a1dc2ba0bf234e1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606820Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#659717}
-
Giovanni Ortuño Urquidi authored
In preparation for a follow up CL that moves UninstallApp into InstallFinalizer, make UninstallApp async. Bug: 916381 Change-Id: Id8e053cb6708c210a3221bfcdce39efa6a7a34ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608866 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#659716}
-
Javier Fernandez authored
The CSS WG resolved [1] to add a new value 'anywhere' to the 'line-break' CSS property in order to allow additional breaking opportunities not considered in the definition of the 'word-break: break-all'. See the intent-to-implement request [2] for further details. This patch implements the feature for LayoutNG too. [1] https://github.com/w3c/csswg-drafts/issues/1171 [2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/r7PkIqQDvlU/X0aocVo9BQAJ Bug: 720205, 959131 Change-Id: I8938e3c2216b130f0bfafa7a3f132b5dac194fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497133 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659715}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/69258ffdb88a..c8a84d2b7ff9 git log 69258ffdb88a..c8a84d2b7ff9 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 robertphillips@google.com Move compute_combined_buffer_size behind GR_TEST_UTILS 2019-05-14 mtklein@google.com preserve comments past the #include "" 2019-05-14 bungeman@google.com Remove GpuLayerCacheTest 2019-05-14 mtklein@google.com remove SkMiniPicture and co. 2019-05-14 robertphillips@google.com Remove some uses of GrBytesPerPixel (take 2) 2019-05-14 mtklein@google.com remove SkLiteDL 2019-05-14 csmartdalton@google.com Clear and discard stencil buffers on tilers 2019-05-14 egdaniel@google.com Reduce use of GrPixelConfig inside of GrVkCaps. 2019-05-14 bungeman@google.com Remove SK_ALLOW_STATIC_GLOBAL_INITIALIZERS from tests. 2019-05-14 brianosman@google.com Fix stack indexing bug in vectorized unsigned -> float conversion Created with: gclient setdep -r src/third_party/skia@c8a84d2b7ff9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Ibf705db9e8bf7884f36fe1ab2061789f52fb9932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659714}
-
Annie Sullivan authored
Bug: 914500 Change-Id: Icd2173d32a40b1038c5ce8efd8f4cdff03632660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610298Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659713}
-
John Lee authored
Bug: 956954 Change-Id: I6478ba316c02b46e93c30135e6f7077f680d57dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609595Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#659712}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f1377b76560..3d86f06bc794 git log 9f1377b76560..3d86f06bc794 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@3d86f06bc794 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie6249eca0b9f0254d3af567acc627a6f8dc76c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612201Reviewed-by:
-
Tommy C. Li authored
UX provided some final strings for the Remove dialog, and this CL adds those strings. This CL also updates the RemoveSuggestionBubbleDialogDelegateView by giving the buttons translated text, providing a translated title, and reordering some labels. It also plumbs in TemplateURLService to fetch the shortname of the default search provider. Bug: 929477 Change-Id: I56d38c006faa51f921b5a054ae5443b3d1656acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610503 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659710}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/69c37491787a..3d7b7ea134d1 git log 69c37491787a..3d7b7ea134d1 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 bclayton@google.com Implement a2b10g10r10_unorm_pack32. 2019-05-14 amaiorano@google.com CMake: apply the warning treatment to msvc builds Created with: gclient setdep -r src/third_party/swiftshader@3d7b7ea134d1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131896622,chromium:b/131171141,chromium:b/132445520 TBR=swiftshader-team+autoroll@google.com Change-Id: Ife9cc94d88f345f0a4786174563c45e8da6e10f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612204Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddf034cde9e9..01010b5cd43c Created with: gclient setdep -r src-internal@01010b5cd43c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: Ie382fe548472694185ecdcc9acbb424a5b91e06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612203Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659708}
-
Ramya Nagarajan authored
Updated field trial config to separate features into the individual groups that are used in the study. This should resolve issues raised by Finch analyzers. Bug: 956164,956613 Change-Id: I7b07f0cab091f39aed7bd9ecce17126322c81287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612257Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659707}
-
Alex Leung authored
This is needed by Cast to change the values of the constants when Multizone is enabled. Bug: 124402185 Change-Id: I4563ec0c9de875cf998ffc8ebedc7b2b701b80e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610842Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#659706}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/40748dc575b7..ea6122f18e6a git log 40748dc575b7..ea6122f18e6a --date=short --no-merges --format='%ad %ae %s' 2019-05-14 akeshet@chromium.org skylab create-test: don't capture stderr 2019-05-14 evgreen@chromium.org cros_build_lib: Ignore false parted failures 2019-05-14 gbiv@google.com cros_tidy: point at our parser's new home Created with: gclient setdep -r src/third_party/chromite@ea6122f18e6a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I63bf4d7cb5de3a0a0342603775f6aa658fbe0190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612206Reviewed-by:
-
Robert Liao authored
In general, threads shouldn't care if they're not the first one to initialize OLE or COM. BUG=961019 Change-Id: I4ea87d67a2f2693b54d845d71bfc241f526ba96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612317 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#659704}
-
Khushal authored
R=ellyjones@chromium.org Change-Id: Iebb76f3643c63ba41a3414986d8f6847a20b4948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612318 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#659703}
-
Jenny Zhang authored
Bug: 941516 Change-Id: If61199c999f6018d4993eaa2bd6c1fb02006845a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611870Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#659702}
-
Ethan Jimenez authored
1. In order to collect the anchors between the start and end positions of an `AXRange`, an incorrect condition is evaluating if the start of the current anchor is equal to its end position, expecting such case to only be present when we reach the end of the `AXRange`. Such assumption does not hold for anchors of objects invisible to the text representation (such as checkboxes, images, etc.), since the anchor is empty and its start and end positions are the same. Refactoring `AXRange::GetAnchors` to cover such case. 2. Introducing unit tests for `AXRange::GetAnchors`. 3. Adding unit test coverage in `AXPlatformNodeTextRangeProviderTest` for the issue in `GetBoundingRectangles` which led to this bug. Bug: 928948 Change-Id: I73ef429b7fb5043cfb535ce05909ac243b31aef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595545 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#659701}
-
Aleks Totic authored
This testcase hit a DCHECK while rebalancing split inlines LayoutInline::SplitInlines LayoutBoxModelObject::MoveChildTo Layout tree looks like it should work. I think that our previous fix of not splitting any anonymous inlines was incorrect. This reverts my older fix at https://chromium-review.googlesource.com/c/chromium/src/+/1610522/1 to a more conservative skip: if (o->IsLayoutNGInsideListMarker()) instead of if (o->IsAnonymous()) clusterfuzz layout tree looks like this: LayoutNGBlockFlow 0x71c8ea202a0 FORM id="el0" LayoutNGBlockFlow (anonymous) 0x71c8ea20530 LayoutInline (anonymous) 0x71c8ea303d0 * LayoutInline 0x71c8ea30250 continuation=0x71c8ea203e8 Q id="el2" LayoutInline 0x71c8ea30310 <pseudo:before> LayoutQuote (anonymous) 0x71c8ea3c2f8 LayoutTextFragment (anonymous) 0x71c8ea40370 """ LayoutInline 0x71c8ea30190 Q id="el5" LayoutInline 0x71c8ea300d0 <pseudo:before> LayoutQuote (anonymous) 0x71c8ea3c108 LayoutTextFragment (anonymous) 0x71c8ea40130 "'" LayoutInline 0x71c8ea30490 <pseudo:after> LayoutQuote (anonymous) 0x71c8ea3c010 LayoutTextFragment (anonymous) 0x71c8ea4001 Bug: 962841 Change-Id: I5165089499c2ff7856f999d2926e07d4a992960d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611866Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659700}
-
Allen Bauer authored
One page proposal: https://docs.google.com/document/d/1I-d_va17XsFDPS3PqgwXtdKnpJNF6eiWJ7GsNrVz9AM/edit?usp=sharing Change-Id: I5a5d0de9f74b873ee1ea5cef53a1bbfc8a44b91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579475 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#659699}
-
Ben Pastene authored
Can be overwritten if a suite/bot wants something other than userdebug. Needs to wait for https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1603622 to roll to prod. But this dimension is present on staging devices: https://chromium-swarm-dev.appspot.com/bot?id=build20-b4--device5 Bug: 960917 Change-Id: I9c6b95ca909d396cbd904edf4209a7484cf477fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605508 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659698}
-
Gayane Petrosyan authored
For themes with no image but with NTP background color, calculate shortcut icon background color. Request shortcut icons without background color and use the calculated color to draw circle around the icon using CSS. Lighter theme - https://screenshot.googleplex.com/8oVBiMDBB0K.png same in dark mode - https://screenshot.googleplex.com/b5LtUCDNFKt.png same with custom_background - https://screenshot.googleplex.com/LO6qicfXF4A.png dark theme - https://screenshot.googleplex.com/Nz3rbG5dJpU.png just black - https://screenshot.googleplex.com/ZB66nvsbZHm.png classic blue - https://screenshot.googleplex.com/LiwaCodQ7dA.png There is no change for themes with images or custom backgrounds. Bug: 959394 Change-Id: Id87111fe1b93f722a944114cf53f44667c8867e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601632 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#659697}
-
btolsch authored
This change enables third_party/openscreen to be built as part of gn_all so we can get coverage on linux bots which will help to ensure we aren't breaking our Chromium compatibility while we are still pre-integration. This doesn't cause anything to be linked into any shipping binaries. Bug: 951615 Change-Id: I65a67054d9545865a51c5dc3cf8d1bb206fc8391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562751Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#659696}
-
Samuel Huang authored
This CL compresses DOM distiller's resources, which reduces Chrome's binary size by 86 kB on Android. Details: * Add compress="gzip" to all dom_distiller_resoruces.grdp items. * Add resource_utils.* with GetResrouceFromIdAsString() to centralize ui::ResourceBundle() usage, and perform uncompression. * Ensure that all IDR_* usage go through GetResourceFromIdAsString(). * Exception: WebUI (for chrome://dom-distiller), which uses content::WebUIDataSource, so decompression is already handled. Also update third_party/zlib: * Add GzipUncompress(base::StringPiece, std::string*), which allocates the output string (used by GetResrouceFromIdAsString()). * Add CompressionUtilsTest::GzipUncompressionFromStringPieceToString. Bug: 872559, 961866 Change-Id: I54f7f80bd3b90e9e0226901295043a25e714a938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606245 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659695}
-
Michael Giuffrida authored
TBR=dpapad@chromium.org Bug: 962114 Change-Id: Idda41a72dd60f443b6a84fe24dd18dcdc9e93fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611913Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#659694}
-
Shakti Sahu authored
Bug: 960733 Change-Id: I99176099dc6aad8fc587cc3824aa48947c37054c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610505 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#659693}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88ad352aa1c6..578d0b9046cc git log 88ad352aa1c6..578d0b9046cc --date=short --no-merges --format='%ad %ae %s' 2019-05-14 sadrul@chromium.org rendering: Process presentation-timestamp if available. 2019-05-14 perezju@chromium.org Revert Telemetry changes to remove fallback code for old Chrome versions Created with: gclient setdep -r src/third_party/catapult@578d0b9046cc The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960824,chromium:962883 TBR=oysteine@google.com Change-Id: Id8dfd23b41e8bbdfa3ae02b7d7556f5ff456e431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611774Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8e80f4e9. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" b480479e "Allow empty backdrop_filter_bounds" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I9b1dbfeb2d9d7fea60879fe53a857eac569fd88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612061Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659691}
-
Michael Spang authored
This adds compile coverage for angle_end2end_tests and angle_unittests to fuchsia-angle-rel so we can test this configuration in the ANGLE CQ. Also change the bot to actually set target_os properly in GN args. Bug: angleproject:3146 Change-Id: Idce7155309d10e18137c9192fc89b6e8c922cbeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612021Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/031ad2bc420a..a47facdd75f9 git log 031ad2bc420a..a47facdd75f9 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 treehugger-gerrit@google.com Merge "Document why we do not need to null check client in realloc." Created with: gclient setdep -r src/third_party/perfetto@a47facdd75f9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I477cac68e5db6a60e6a053744f46f137558bc0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612200Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8642c0be..0829f5e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I310803d81d200fc90121018d8927160f9b2900c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612059Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659688}
-
Ehsan Karamad authored
The tests use the old input targeting approach of sending events to the embedder which does not work correctly when MHV is frame-based. This CL makes sure that with frame-based MHV the input goes to the guest directly. Bug: 961786 Change-Id: I2b3b78a3db7dd5be3f5435c6babf3b647fa79839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611776Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659687}
-
khachatryan authored
Tests disabled by ChromeDriver bugs 2855, 2661 and 2663 are now passing with the latest Chrome/ChromeDriver versions. Enabling those tests on WaterFall. Bug: chromedriver:2661, chromedriver:2663, chromedriver:2855 Change-Id: I493ed5b95f4c2608192e5ec94a44d45d77e8bb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612324Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659686}
-
Emil A Eklund authored
Add debug checks to NGBoxFragmentPainter ensuring it's only used for box fragments, as the implementation assumes the NGPhysicalFragment supplied to the NGBoxFragmentPainter constructor is a true NGPhysicalBoxFragment. Fixing this uncovered another issue where InlinePainter assumes that all LayoutNG formatting contexts are boxes, using NGInlineBoxFragmentPainter to paint them. This mostly works as the fragment types are quite similar but involves incorrect type casts and can potentially read uninitialized memory with unpredictable results. This change updates the InlinePainter Paint method to use the LayoutNG painter appropriate for every fragment. Bug: 962004, 962338 Change-Id: I28e21544da423a21a2bb41a692052feace71d90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610092Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#659685}
-
Esmael El-Moslimany authored
Bug: 962621 Change-Id: I0d986bb92b501fa3eba8cbf40776430bdb452282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610481Reviewed-by:
-
Kyle Milka authored
When the menu is reset also reset the scroll position to the top. Bug: 937570 Change-Id: I9e90b986a26bfab5af88d481fa2c35afceba8c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611771 Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659683}
-
Ian Kilpatrick authored
As above this is a partial revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1158391 (partial as LayoutObject::IsLayoutNGObject() is used elsewhere now). Bug: 869866 Change-Id: I9e775fc484f004445a0a7d03cd899943dc5a07af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611859 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#659682}
-
Tarun Bansal authored
Deprecate the use of field trial, and use a feature instead. Bug: 955544 Change-Id: I32c069d0e5960af90256382132db93250613d754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610582Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659681}
-
Nicolás Peña Moreno authored
This is a reland of 3bd9684c The failure was not getting an entry for click: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/13241 Thus, we instead look at the mousedown. Since mousedown can be the first input, we stop observing for firstInput but check that entry separately as well. Original change's description: > [EventTiming] Fix programmatic click test > > Commits aee8357d and > faed29aa landed almost at the same time, > so we accidentally landed a test with the wrong script src for the > helper functions. > > Bug: 961547 > Change-Id: Id8a615477a54e56139d9d90fc4feb5f780b729a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606225 > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658761} Bug: 961547 Change-Id: I11f1a5f28e7e4e5ebda28c90555d89669142cc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610022Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#659680}
-
Wei-Yin Chen (陳威尹) authored
After calling #setImageDrawable(null), the Bitmap is still retained in the BitmapShader of mPaint. This CL resets the Shader in that case. Bug: 959886 Change-Id: I995f46940281eedd4160b139e67a5ee4e18b5c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595292 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#659679}
-
Ian Kilpatrick authored
The DerivedGeometry class gets moved from exclusion-space to exclusion-space as a fast way of determining layout opportunities (where lines, etc get placed). For speed we only allocate "NGShapeExclusions" if we've seen any shapes within the formatting context. This crash was due to an inconsistent state of the: NGExclusionSpaceInternal::track_shape_exclusions_ flag. "other" NGExclusionSpaceInternal - derived_geometry_ = (non-null) - track_shape_exclusions_ = false - num_exclusions_ = 1u "this" NGExclusionSpaceInternal - derived_geometry_ = null - track_shape_exclusions_ = true - num_exclusions_ = 2u (2nd exclusion has shape data). Within the NGExclusionSpaceInternal::MoveAndUpdateDerivedGeometry method we moved the derived geometry over to the "this" exclusion space. However we didn't also move the track_shape_exclusions_ flag as a result we'd try to add the 2nd shape exclusion, and a NPE was hit. Bug: 962135, 962272, 962052 Change-Id: Id095bd2924f83ba6b2dbe90446d1f4613de09933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610021 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
