GitLab

Remove and deprecate SEARCH_SUGGEST_ANSWER.  This type is no longer used in the UI code, since answers can be attached to suggestions of any type.

BUG=430513

Review URL: https://codereview.chromium.org/815273002

Cr-Commit-Position: refs/heads/master@{#314167}

NaCl now supports AVX2.

R=shyamsundarr@chromium.org
TBR=jmedley@chromium.org, shyamsundarr@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3637

Review URL: https://codereview.chromium.org/888313002

Cr-Commit-Position: refs/heads/master@{#314166}

Now ChromotingHostContext disallows blocking operations on then
network thread. This will help to avoid issues such as the one
that was fixed in https://codereview.chromium.org/886913002/
(Network thread was used to load policies from disk).

Also made the following changes to avoid blocking operation on
the network thread:
 - Moved PolicyWatcher to the main thread in the Me2Me host.
   PolicyLoader uses blocking IO for initialization. Also this is
   more consistent with the It2Me host where PolicyWatcher also
   runs on the UI thread.
 - Moved NetworkChangeNotifier initialization out of
   HostSignalingManager. NetworkChangeNotifier creates a thread
   internally and therefore should be destroyed on the main thread.
 - Added a reference to URLRequestContextGetter in HostProcessMain
   to make sure it's destroyed on the main thread. This is necessary
   because BasicURLRequestContext owns threads and needs to be
   deleted on the main thread.

Review URL: https://codereview.chromium.org/891663005

Cr-Commit-Position: refs/heads/master@{#314165}

BUG=452257

Review URL: https://codereview.chromium.org/883693006

Cr-Commit-Position: refs/heads/master@{#314164}

This patch implements RevokePermission() method in the mojo
PermissionService. This method will probably be for internal
use only for now. The semantics of the method is that it
will reset the permission to its default value in chrome if
the permission is currently granted.

BUG=430238

Review URL: https://codereview.chromium.org/819463002

Cr-Commit-Position: refs/heads/master@{#314163}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3d91aad..ad49b3b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/896443002

Cr-Commit-Position: refs/heads/master@{#314162}

Cr-Commit-Position: refs/heads/master@{#314161}

"by default" = whenever we build Chromoting.

This is a re-land of crrev.com/878793003, which failed on
the Official builds.

The build problem has been fixed in crrev.com/886543002.

BUG=

Review URL: https://codereview.chromium.org/875463004

Cr-Commit-Position: refs/heads/master@{#314160}

* Check size of scans.
* Create and cache selection scans (needed to check their size)....but only cache until the next selection change.
* Improve test coverage, covering both "while importing" and "insufficient size" cases.
* Improve tests to check for labels too (uncovering one bug in the test).
* Fix bug where we were no-longer updating import state/widget on selection changes.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Need a review from either mtomasz@ or hirono@, not both. First one to review, kindly remove the other.

Review URL: https://codereview.chromium.org/886093003

Cr-Commit-Position: refs/heads/master@{#314159}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c32ffd2..7d3717c

TBR=vsevik@chromium.org,japhet@chromium.org

Review URL: https://codereview.chromium.org/890143003

Cr-Commit-Position: refs/heads/master@{#314158}

BUG=452879

Review URL: https://codereview.chromium.org/891713002

Cr-Commit-Position: refs/heads/master@{#314157}

If the android build version pre-dates KitKat and the device
manufacturer is Samsung, skip the check for mmap exec support.
This avoids triggering a warning on these devices.
The version check is included because these devices do not show
the warning on later OS builds.

BUG=448084
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/869593002

Cr-Commit-Position: refs/heads/master@{#314156}

TBR=tbreisacher@chromium.org
BUG=none
TEST=http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux goes green

Review URL: https://codereview.chromium.org/895663002

Cr-Commit-Position: refs/heads/master@{#314155}

Currently, CredentialManagerDispatcher is a PasswordStoreObserver, and
handles responses from `request()` directly. We can't do that going
forward, as we also need to handle responses when dealing with (at
least) `notifySignedOut()`.

This patch splits the password store observer functionality out into
a new `PendingRequestTask` class, with the intent of introducing
`PendingSignedOutTask`, etc. classes in the future.

BUG=450581
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/886793002

Cr-Commit-Position: refs/heads/master@{#314154}

'pngcrush -v' writes to stderr. Redirected stderr to stdout.

BUG=none
TEST=manually

Review URL: https://codereview.chromium.org/869433004

Cr-Commit-Position: refs/heads/master@{#314153}

Change HistoryService::ExpireLocalAndRemoteHistoryBetween() to
receive the history::WebHistoryService instance to use in order
to remove a dependency of HistoryService on Profile.

It is not possible to pass the WebHistoryService instance to the
HistoryService constructor and add a dependency between the two
factories due to http://crbug.com/171406 (as WebHistoryService
depends on a KeyedService calling Profile::GetRequestContext()).

BUG=453790
R=droger@chromium.org

Review URL: https://codereview.chromium.org/891763002

Cr-Commit-Position: refs/heads/master@{#314152}

BUG=

Review URL: https://codereview.chromium.org/879983002

Cr-Commit-Position: refs/heads/master@{#314151}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/672177b..c32ffd2

TBR=vsevik@chromium.org,japhet@chromium.org

Review URL: https://codereview.chromium.org/891323003

Cr-Commit-Position: refs/heads/master@{#314150}

BUG=452710
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/894723002

Cr-Commit-Position: refs/heads/master@{#314149}

Now, NaCl supports to build x86-32 nonsfi binary even with target_arch=x64,
so this CL enables browser_tests for PPAPI.

BUG=358465
TEST=browser_tests --gtest_filter=*Transitional* locally. Run trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_arm

Review URL: https://codereview.chromium.org/786273008

Cr-Commit-Position: refs/heads/master@{#314148}

At present, if a user changes zoom on OSX while the zoom bubble is
already being shown, the new zoom bubble (with the most up to date
information) is not shown. This CL changes this behaviour by allowing
a new zoom bubble to be created, and replace the existing one.

Example: load a PDF and repeatedly click the zoom +/- controls in the
lower-right corner of the viewer.

BUG=444995

Review URL: https://codereview.chromium.org/886883002

Cr-Commit-Position: refs/heads/master@{#314147}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c927918..3d91aad

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/883463004

Cr-Commit-Position: refs/heads/master@{#314146}

This [\\/] should account for both Windows \ and Posix /.

BUG=None
TEST=git cl presubmit -uv
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/892743002

Cr-Commit-Position: refs/heads/master@{#314145}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e5825c..672177b

TBR=vsevik@chromium.org,japhet@chromium.org

Review URL: https://codereview.chromium.org/890423002

Cr-Commit-Position: refs/heads/master@{#314144}

BUG=453982
TEST=tested manually
TEST=content_unittests:ServiceWorkerDispatcherHostTest.Register_FileSystem*

Review URL: https://codereview.chromium.org/889323002

Cr-Commit-Position: refs/heads/master@{#314143}

BUG=452950

Review URL: https://codereview.chromium.org/890463003

Cr-Commit-Position: refs/heads/master@{#314142}

A follow up to https://codereview.chromium.org/883773004/

BUG=None

Review URL: https://codereview.chromium.org/889913002

Cr-Commit-Position: refs/heads/master@{#314141}

This is a two part fix:
1. Fix get_sdk_extras_packages.py to correctly identify its own location.
2. Fix install-build-deps-android.sh to launch get_sdk_extras_packages.py
   when the current-working-directory isn't the location of the script.
This fixes the script when run in the way recommended by
https://code.google.com/p/chromium/wiki/AndroidBuildInstructions

Review URL: https://codereview.chromium.org/869633003

Cr-Commit-Position: refs/heads/master@{#314140}

BUG=454283

Review URL: https://codereview.chromium.org/886073003

Cr-Commit-Position: refs/heads/master@{#314139}

BUG=chromium:449920
TEST=apprtc loopback with resolution 640x354 on peach pit

Review URL: https://codereview.chromium.org/874083005

Cr-Commit-Position: refs/heads/master@{#314138}

This builds on the previous refactorings (linked in the bug), and unifies the
parsing of object files. It also removes the fuzzy matching of offsets done
that was previously also done in patch_orderfile.py.

It is also faster for three reasons:
- Elimination of an O(N^2) search
- Parallelization of object file parsing.
- No binary search

BUG=452879

Review URL: https://codereview.chromium.org/874683004

Cr-Commit-Position: refs/heads/master@{#314137}

In the event of network error, the WebSocket server response is not
validated. However, some network errors are ignored higher up in the
stack.

For example, in HttpNetworkTransaction::DoReadHeadersComplete at
http_network_transaction.cc:988, ERR_CONNECTION_CLOSED is converted to
OK.

To avoid this whole class of bugs, do not keep status code 101
(Switching Protocols) if there was a network error. It is changed to
503.

The response headers that are displayed in devtools are copied before
the change, so they will still retain the original status code.

BUG=408061
TEST=net_unittests

Review URL: https://codereview.chromium.org/889783002

Cr-Commit-Position: refs/heads/master@{#314136}

Should not return constant when compared against object of class Preference.

BUG=450862

Review URL: https://codereview.chromium.org/875003002

Cr-Commit-Position: refs/heads/master@{#314135}

This patch makes the Chromium apptest runner resilient to missing apps
(e.g. tracing.mojo) polluting the output of mojo_shell that it tries to
parse.

BUG=450356
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/892933002

Cr-Commit-Position: refs/heads/master@{#314134}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/31cf1e7..3e5825c

TBR=vsevik@chromium.org,japhet@chromium.org

Review URL: https://codereview.chromium.org/873593008

Cr-Commit-Position: refs/heads/master@{#314133}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/889273003

Cr-Commit-Position: refs/heads/master@{#314132}

BUG=452479

Review URL: https://codereview.chromium.org/892443002

Cr-Commit-Position: refs/heads/master@{#314131}

Now tests are failing because "Offer to save passwords checkbox is
disabled". This patch enables it by running js script using webdriver.

R=vabr@chromium.org
BUG=435249

Review URL: https://codereview.chromium.org/891283002

Cr-Commit-Position: refs/heads/master@{#314130}

BUG=453829

Review URL: https://codereview.chromium.org/884773003

Cr-Commit-Position: refs/heads/master@{#314129}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/531baa3..31cf1e7

TBR=vsevik@chromium.org,japhet@chromium.org

Review URL: https://codereview.chromium.org/875143004

Cr-Commit-Position: refs/heads/master@{#314128}