GitLab

1. Create MockNetworkConnectionTracker.
2. Refactor ChromeSigninClientTest to use it (instead of three
   separate locally-defined mocks).
3. As a drive-by, make ChromeSigninClientTest more explicit about
   what events it is waiting for to complete asynchronously.

Bug: 775415
Change-Id: Ib860e986c00285ae0b66a8e9248656a35f4d64f2
Reviewed-on: https://chromium-review.googlesource.com/1119921
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571565}

https://skia.googlesource.com/skia.git/+log/4e85e80a5a32..c91fe3ab1c5d


git log 4e85e80a5a32..c91fe3ab1c5d --date=short --no-merges --format='%ad %ae %s'
2018-06-29 caryclark@google.com fix fuzzer found timeout


Created with:
  gclient setdep -r src/third_party/skia@c91fe3ab1c5d

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:858985
TBR=jcgregorio@chromium.org

Change-Id: Iceb8a9b3e8821e17ea0d8eaf8d118228aa3c4713
Reviewed-on: https://chromium-review.googlesource.com/1120409Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571564}

When a new tab is added in the background, its title color is calcuated
before single-tab mode is updated, which means it uses a frame color of
white regardless of the actual frame color. This patch fixes that.

This patch also changes Tab::ViewHierarchyChanged to AddedToWidget since
it's more correct and helped me debug.

Bug: 855338
Change-Id: I007c5f1577260e22265f5c3df877955f3953cfee
Reviewed-on: https://chromium-review.googlesource.com/1119574Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571563}

Since scheduler/base is getting moved to //base/task/sequence_manager
we don't want to explicitly support the concept of virtual time
because it might be confused with the existing mechanism to override
a TickClock in //base. So we can't move VirtualTimeDomain to //base.
It was used in some tests in scheduler/base as a mock time domain,
so this CL makes it explicit and test-only.

Bug: 783309
Change-Id: I0a11e565de94fce06af4aff288427b6bc78e890b
Reviewed-on: https://chromium-review.googlesource.com/1120257Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571562}

This is temporary until we have bandwidth to do a correct dark mode
implementation. Opting out fixes glitches caused by the system thinking
that Chrome is in dark mode (for example, light text colors where we
are expecting the system to provide dark text colors).

Bug: 850103
Change-Id: I38d46631f714907231da89bd47bdd800ceb1bb3e
Reviewed-on: https://chromium-review.googlesource.com/1120744Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571561}

This makes RenderViewHostTestHarness own a NetworkChangeNotifier,
so Network Service can skip creating one (see
CreateNetworkChangeNotifierIfNeeded() in network_service.cc). The
in-process NetworkService is a leaky global singleton, which also
leaks a NetworkChangeNotifier that conflicts with subsequent unit
tests.

See: https://groups.google.com/a/chromium.org/d/msg/network-service-dev/IgNFrq1zFHI/FNCAplsCCQAJ

An alternative approach is to tear down the in-process singleton
NetworkService, but I ran into issues when doing that mostly because
the BrowserThreadDelegate::CleanUp hook is only implemented by
chrome/browser/io_thread.h and not by other content embedders.

Change-Id: I1fbfca32e582621c3cfcbb7af3a82a4243c5b44b
Reviewed-on: https://chromium-review.googlesource.com/1114924
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571560}

Since the smoothness.__ benchmarks have been merged into
rendering.desktop and rendering.mobile, remove the benchmarks and the
no longer necessary page set json files. For now, add the deleted
benchmarks to NON_TELEMETRY_BENCHMARKS in perf_data_generator.py to
avoid errors related to the sharding map.

For the fetch_benchmark_deps_unittest that used
smoothness.top_25_smooth, change to use system_health.common_desktop
because using rendering.desktop fails the "no static local files"
assertion.

Also, remove tough_ad_cases.py completely because it is no longer used.

Bug: 855063
Change-Id: I9b3c0a46b7704b520f8d44479fcd5385c78eb573
Reviewed-on: https://chromium-review.googlesource.com/1120345Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#571559}

Bug: 807724
Change-Id: Iff21f7cc6ba5c3005b440fb7b6d51fdccbbd230b
Reviewed-on: https://chromium-review.googlesource.com/1117325Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571558}

When we coalesce the touch events or mouse events, we should check their
pointer id and pointer type, so we do not coalesce events from stylus
inputs with events from other input sources.

Bug:857209

Change-Id: I157ca5047047bb812564382f49e316bee9f88f19
Reviewed-on: https://chromium-review.googlesource.com/1117633
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571557}

This puts ChromeVox in line with other popular mobile screen readers where these gestures are mapped to their physical equivalents and non-accessibility scrolling actions.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ice2da6bf013fbbb5c0213505b34fdb9189620dc0
Reviewed-on: https://chromium-review.googlesource.com/1116074Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571556}

Most window managers clear the _NET_WM_STATE property when a window is unmapped,
as specified by the EWMH spec [1].  This means if apps set always-on-top for a
window which is hidden and then shown, the window will no longer be
always-on-top.

This CL restores the state set by Chrome when a window is re-mapped.

[1] https://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336

BUG=856607

Change-Id: I1c72d9b20c0b68198c7f3d0f31ea28ce5e6f2da3
Reviewed-on: https://chromium-review.googlesource.com/1117439Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571555}

https://webrtc.googlesource.com/src.git/+log/43d0b98fe5ad..7a29426142dd


git log 43d0b98fe5ad..7a29426142dd --date=short --no-merges --format='%ad %ae %s'
2018-06-29 phensman@webrtc.org Detach audio devices from thread on terminate.


Created with:
  gclient setdep -r src/third_party/webrtc@7a29426142dd

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I65be0b275e1fde671302714ea0b8cba3593a3eb7
Reviewed-on: https://chromium-review.googlesource.com/1120407Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571554}

Selection and dragging should be done regardless
of whether js calls preventDefault on mousemove
or pointermove events according to the spec:

https://w3c.github.io/uievents/#event-type-mousemove

This cl makes Chrome to handle selection/dragging
regardless of return value of js handler to match
other browsers.

Bug: 346473
Change-Id: I71f2c808f224be23ffbc80ee25e2897a9dc9f090
Reviewed-on: https://chromium-review.googlesource.com/1112628Reviewed-by: Lan Wei <lanwei@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571553}

Use the standard RenderWidgetCompositor instead of test overrides of
the WebLayerTreeView interface. This gets us closer to removing the
interface, and removes a bunch of test-only lines of code, using the
standard FrameTestHelpers::TestWebViewClient instead, which provides
a RenderWidgetCompositor.

R=haraken@chromium.org

Bug: 838693
Change-Id: Ifc5f219f6918a793a46ec229667f43fa72ec4b03
Reviewed-on: https://chromium-review.googlesource.com/1119247Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571552}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/406de133efaf..a19649b86b3d


git log 406de133efaf..a19649b86b3d --date=short --no-merges --format='%ad %ae %s'
2018-06-29 iannucci@chromium.org Clean up cache_dir handling in gclient/git_cache/bot_update.


Created with:
  gclient setdep -r src/third_party/depot_tools@a19649b86b3d

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:823434
TBR=agable@chromium.org

Change-Id: I3003d9a0a791da948c861cb0156cf924fb6864e9
Reviewed-on: https://chromium-review.googlesource.com/1120411Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571551}

TBR=carlosk@chromium.org
NOTRY=true

Bug: 857520
Change-Id: I5ac3dd6a38f7000c82d8e17545bf6d5463501560
Reviewed-on: https://chromium-review.googlesource.com/1120857Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571550}

https://chromium.googlesource.com/angle/angle.git/+log/cdf50444934c..71a151fd11ae


git log cdf50444934c..71a151fd11ae --date=short --no-merges --format='%ad %ae %s'
2018-06-29 jmadill@chromium.org Vulkan: Use TSymbolTable in ExtractStructSamplers.


Created with:
  gclient setdep -r src/third_party/angle@71a151fd11ae

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I5e4fabe50963357dddf6a288df5ba713c6b376fe
Reviewed-on: https://chromium-review.googlesource.com/1120412Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571549}

When r565930 (CL:999080) implemented background support for
`::first-line`, it broke applying other properties to first
line because anonymous inline box prevents to apply
`::first-line` style to its descendants.

This patch fixes computing first-line style for anonymous
LayoutInline for that specific case. How to fix other
anonymous LayoutInline (such as one for `display: content`)
isn't clear yet, and even this fix may need to revisit.

css2.1/t0510-c25-pseudo-elmnt-00-c.html turns IMAGE+TEXT
failure to TEXT failure due to the additonal anonymous inline
box. This patch includes text dump rebaselines.

Other 3 rebaselines are the height of LayoutBR, which we
generally rebaseline.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5e08c6b783fb82b5e0bdc97bd1d782ccb569a38c
Reviewed-on: https://chromium-review.googlesource.com/1118405Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571548}

Bug: b:77876001
Change-Id: Iac4efcebda4573cb66af4f47a21c373a9a86ec92
Reviewed-on: https://chromium-review.googlesource.com/1112903
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571547}

This issue is not very easy to fix since:
- The png decoder is not reliable according to [1]
- The default codec is considered "unsafe", confirmed by multiple
  sources (e.g. [2], [3])

So I think we should continue to use the jpeg decoder on login screen
(it's always working because we re-encode all the wallpaper images in
jpeg [4]) and make an "exception" to use the default codec only when
it's safe. This will solve the issue because online wallpapers used to
be decoded by the code point at [3] before the refactoring, which uses
default codec.

[1]
https://cs.chromium.org/chromium/src/ui/gfx/codec/png_codec.h?dr=Ss&g=0&l=24
[2]
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc?type=cs&q=DEFAULT_CODEC&sq=package:chromium&g=0&l=386
[3]
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/extensions/wallpaper_function_base.cc?q=wallpaper_function_base&sq=package:chromium&dr=C&l=81
[4]
https://cs.chromium.org/chromium/src/ash/wallpaper/wallpaper_controller.cc?type=cs&g=0&l=207

Bug: 857240
Change-Id: I1bb0f1351a72acec233539e08c43221c8952d032
Reviewed-on: https://chromium-review.googlesource.com/1117764Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571546}

Get rid of Mac-specific code that uses LocalFrameView as a
ScrollableArea.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic7f7ffe99d2d3fdd6e12dd950d78e4f26eecdf9b
Reviewed-on: https://chromium-review.googlesource.com/1119664Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571545}

Many devs have complained that the text moves unexpectedly when the
popup opens. After consulting with UX, we are embracing the text jogging
to make it line up with the suggestions text.

This CL adds an animation to slide the text over, making the text jog
hopefully less jarring.

Bug: 853355
Change-Id: If272e4076e30c967c0211c988e5e9f10300366bf
Reviewed-on: https://chromium-review.googlesource.com/1119400
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571544}

Check Document::hidden() in LayoutObject::WillRenderImage,
thus pausing animations on pages that are not visible.
To resume animations, we may need to explicitly resume the
timeline, so a hook is added in Page::SetVisibilityState to
allow calling StartAnimation() on the relevant SVGImages.

Bug: 856082
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4a0b008730ec3e6c2af26e15d52eebb26020ad32
Reviewed-on: https://chromium-review.googlesource.com/1115130Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#571543}

FeedbackKit V2 launched in M67. In order to deprecate the V1
implementation, the first step needs to force the chrome://flags to
true and then implementation code can be removed.

Bug: 847329
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9451fa04453584d6e056e82f8c9f323d0a87c06c
Reviewed-on: https://chromium-review.googlesource.com/1119355Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571542}

Managing the Surface/SurfaceTexture pair is somewhat expensive,
and we don't need it for SharedBuffer transport. Now that the
mailbox_to_surface_bridge supports surfaceless initialization
(thanks to AR mode), use that to avoid this allocation.

This required some minor reshuffling to ensure we have the
right initialization order.

BUG=857547

Change-Id: I7edca6e791f9b13bef4a3a50266715182517fdef
Reviewed-on: https://chromium-review.googlesource.com/1120677Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571541}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/f05c58b1e0ca..ec6d4902f36c

$ git log f05c58b1e..ec6d4902f --date=short --no-merges --format='%ad %ae %s'
2018-06-08 baileyberro smbprovider: Add auth params to the Remount proto
2018-06-22 derat system_api: Add GetKeyboardBrightnessPercent constant.
2018-06-12 smbarber vm_cicerone: add LXD container methods and signals

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I670db644532a43a18fad629ea4c5b2c9d8c09b92
Reviewed-on: https://chromium-review.googlesource.com/1119345
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571540}

Adds a new test file that is simply an audio stream fully encrypted with
'cbcs' encryption.

BUG=850679
TEST=new content_browsertests and browser_tests pass

Change-Id: I930af7aeb36cd4ccddab279849e3a84e6487bee3
Reviewed-on: https://chromium-review.googlesource.com/1093995
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571539}

Fixes a race condition that can lead to a crash when taking a photo via the
image capture web API on Android.

Bug: 846576
Change-Id: I0008391acfd4fd1f84db1d403d33c0dc31410294
Reviewed-on: https://chromium-review.googlesource.com/1117845Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571538}

Using wpt-import in Chromium d0b89cd8.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20356

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler

TBR=kereliuk

No-Export: true
Change-Id: I03de0c3a0cc86d0e9c81a8593dc68802b16eef17
Reviewed-on: https://chromium-review.googlesource.com/1120156
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571537}

BUG=
TEST=

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I90a5f6b6904547bb64ef72f01664e6807377870f
Reviewed-on: https://chromium-review.googlesource.com/1120351Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571536}

This change applies three heuristics to make trackpad scrolling feel
smoother. We increase the frequency at which we submit scroll events to
the platform, we also decrease the scroll scale factor (to make the
scrolls less jumpy), and we do some simple filtering of our scroll
values.

I pair-programmed much of this change with asimjour@ and he wrote the
initial code to interpolate events in the android ui gesture target.

Bug: 859075
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad
Reviewed-on: https://chromium-review.googlesource.com/1120425Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571535}

Some java code in the CheckCallback can synchronously delete the
ongoing navigation. This should probably be fixed, but for now this CL
just makes the InterceptNavigationThrottle robust to this failure case.

The CL splits up the async and sync check logic in a way that improves
readability as well.

Bug: 856737
Change-Id: I540f3d18a7bcc923583991f1fecceae563be6641
Reviewed-on: https://chromium-review.googlesource.com/1115786Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571534}

TBR=bartfab@chromium.org

Bug: 844936
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I573698e0994b6dc6e70f0d17e6dcbbb83aa1a142
Reviewed-on: https://chromium-review.googlesource.com/1102725
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571533}

Keep usage & diagnostics false during ARC setup if the user does not
see the ARC ToS dialog due to all relevant settings being managed,
even if usage & diagnostics is enabled for the device.

Also removes the notification added by crrev.com/c/1086354.

Bug: b/73338614, 859104, 855448
Test: Opt in to ARC with managed and unmanaged users
Change-Id: If5bd6b10d4059df97af0b6c14c8f8a15ceaaddc0
Reviewed-on: https://chromium-review.googlesource.com/1115712
Commit-Queue: Josh Horwich <jhorwich@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#571532}

https://android.googlesource.com/platform/external/perfetto.git/+log/da32244d8116..e9d405363cbf


git log da32244d8116..e9d405363cbf --date=short --no-merges --format='%ad %ae %s'
2018-06-29 lalitm@google.com trace_processor: add support for quantized slices


Created with:
  gclient setdep -r src/third_party/perfetto@e9d405363cbf

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:80416541
TBR=perfetto-bugs@google.com

Change-Id: Ia244315f9b7b6846d5777de9a9c06aae45466ccd
Reviewed-on: https://chromium-review.googlesource.com/1120405
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571531}

Fade out the toolbar buttons rather than scrolling them off when the NTP
is scrolled.

BUG=835412

Change-Id: I9c273aaa83f3546c9e04f9a7140c39796f09af9c
Reviewed-on: https://chromium-review.googlesource.com/1120442Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571530}

BUG=
TEST=

Change-Id: I30e2f477136d3ed79577368874ade5f932906a5f
Reviewed-on: https://chromium-review.googlesource.com/1120353Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571529}

Bug: 856578
Change-Id: Ifb2a1b7e6c22e1af36e12eedba72427f51d925b9
Reviewed-on: https://chromium-review.googlesource.com/1114617Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571528}

Adds a named guide to the content area so it can be positionally matched by transitions.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifcb0d873d88cf0af2b9f898a8d9e151b601504da
Reviewed-on: https://chromium-review.googlesource.com/1118169
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571527}

When Dice is enabled, this will allow the reconcilor to perform
a full web logout, in addition to turning off Sync.

Bug: 852000
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I55bda4d7151fccd8c1f40b522fed0f5b63adbc1f
Reviewed-on: https://chromium-review.googlesource.com/1117071
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571526}