GitLab

Broke ScriptBadgeControllerTest.ExecutionMakesBadgeVisible on Linux Clang (dbg)

[ RUN      ] ScriptBadgeControllerTest.ExecutionMakesBadgeVisible
[16238:16238:0528/195340:652289748:ERROR:activity_log.cc(168)] BrowserThread::DB does not exist, running on UI thread!
Received signal 11 SEGV_MAPERR 000000000058
 [0x7f664570b17e] base::debug::StackTrace::StackTrace()
 [0x7f664570acb7] base::debug::(anonymous namespace)::StackDumpSignalHandler()
 [0x7f66363facb0] <unknown>
 [0x0000032aa59c] extensions::RulesRegistryService::content_rules_registry()
 [0x0000032a8cc8] extensions::TabHelper::DidNavigateMainFrame()
 [0x7f663c8ca46d] content::WebContentsImpl::DidNavigateMainFramePostCommit()
 [0x7f663c8cba53] content::WebContentsImpl::DidNavigate()
 [0x7f663c8cbb97] content::WebContentsImpl::DidNavigate()
 [0x7f663c7d58a1] content::RenderViewHostImpl::OnNavigate()
 [0x000002efa9dd] content::TestRenderViewHost::SendNavigateWithParameters()
 [0x000002efa462] content::TestRenderViewHost::SendNavigateWithTransitionAndResponseCode()
 [0x000002efa4df] content::TestRenderViewHost::SendNavigateWithTransition()
 [0x000002efa34d] content::TestRenderViewHost::SendNavigate()
 [0x000002ef30d2] content::TestWebContents::CommitPendingNavigation()
 [0x000002ef2df3] content::TestWebContents::NavigateAndCommit()
 [0x000002eeb1a7] content::RenderViewHostTestHarness::NavigateAndCommit()
 [0x000000b9d012] extensions::(anonymous namespace)::ScriptBadgeControllerTest_ExecutionMakesBadgeVisible_Test::TestBody()
 [0x000003567393] testing::internal::HandleSehExceptionsInMethodIfSupported<>()
 [0x00000355e25e] testing::internal::HandleExceptionsInMethodIfSupported<>()
 [0x000003555da5] testing::Test::Run()
 [0x0000035564ab] testing::TestInfo::Run()
 [0x000003556a47] testing::TestCase::Run()
 [0x00000355ad75] testing::internal::UnitTestImpl::RunAllTests()
 [0x000003564453] testing::internal::HandleSehExceptionsInMethodIfSupported<>()
 [0x00000355f70e] testing::internal::HandleExceptionsInMethodIfSupported<>()
 [0x00000355aa64] testing::UnitTest::Run()
 [0x0000043d60df] base::TestSuite::Run()
 [0x0000042948ed] content::UnitTestTestSuite::Run()
 [0x00000406ad24] main
 [0x7f663402776d] __libc_start_main
 [0x0000004fbb09] <unknown>
  r8: 0000000000000020  r9: 0101010101010101 r10: 00007fff7dd127c0 r11: 00007f6634091d2e
 r12: 00000000004fbae0 r13: 00007fff7dd14f00 r14: 0000000000000000 r15: 0000000000000000
  di: 0000000000000000  si: 00007fff7dd12840  bp: 00007fff7dd12b00  bx: 0000000000606cd0
  dx: 0000000000000000  ax: 0000000000000000  cx: 0000000000000001  sp: 00007fff7dd12b00
  ip: 00000000032aa59c efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000058

> Change RulesRegistryService to use ProfileKeyedAPI.
> 
> BUG=179951
> 
> Review URL: https://chromiumcodereview.appspot.com/13825014

TBR=patrickriordan177@gmail.com

Review URL: https://codereview.chromium.org/16109003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202763 0039d316-1c4b-4281-b951-d872f2087c98

Move webkit/blob to new locations. Also move content::WebBlobRegistryImpl to the new common_child library.
- just moving the files in the source repository
- and fixing up complilation guards
- and fixing up include paths throughout
- and fixing up DEPs files as needed
Note: Everything in /webkit is still being built into the same old webkit_storage target
for now, new actual build target(s) will come later.

TBR=kinuko@chromium.org, thestig@chromium.org
BUG=239109

Review URL: https://codereview.chromium.org/15746017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202762 0039d316-1c4b-4281-b951-d872f2087c98

R=nduca@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/16069004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242304
R=jln@chromium.org
TBR=jln@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15766009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202760 0039d316-1c4b-4281-b951-d872f2087c98

- Improved UX of the dev tools.
    a/ "Load unpacked", "Pack" and "Update now" buttons have been moved to the top
    b/ The header is now sticky like in chrome://extensions
    c/ The list of extensions/apps is centered when the window is expanded

BUG=242747
BUG=242743

Review URL: https://chromiumcodereview.appspot.com/15389003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202759 0039d316-1c4b-4281-b951-d872f2087c98

Alt-F4 key events are handled by the window manager, who then sends an X11
message telling us that we should close. This used to be hooked up, but it
looks like it broke when we merged with the crossplatform
DesktopNativeWidgetAura code that we also use on Windows.

BUG=176783

Review URL: https://chromiumcodereview.appspot.com/15827009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202758 0039d316-1c4b-4281-b951-d872f2087c98

test is disabled because it will fail until the bug is fixed

BUG=244515

Review URL: https://chromiumcodereview.appspot.com/16096007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178853

Review URL: https://chromiumcodereview.appspot.com/15692009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202756 0039d316-1c4b-4281-b951-d872f2087c98

Cubic bezier timing functions are based on two knots (x1, y1) and (x2, y2) (the
other knots are assumed to be (0, 0) and (1, 1)). We require that x1, x2 lie
within (0, 1) (so that the bezier does not 'fold back' on itself), but y1, and
y2 should have no such constraint. They currently do. This CL reimplements
bezier interpolation without this restriction. This interpolation has two steps:
   1) Find the t corresponding to the desired x.
   2) Interpolate y's at the t computed in step 1.
Step 1 is an iterative minimization. Here I do bisection for simplicity, but I
could take Newton steps if this turns out to be a bottleneck.

R=ajuma@chromium.org
BUG=178070

Review URL: https://chromiumcodereview.appspot.com/16112002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202755 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/16041004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202754 0039d316-1c4b-4281-b951-d872f2087c98

In the network list on the settings page, the pop-up bubble for a managed
network has that network's list entry as its parent. The list entry must
allow overflow to be visible so that the bubble does not get clipped.

BUG=243659
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/15690006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202753 0039d316-1c4b-4281-b951-d872f2087c98

After recent refactorings chrome/browser/api and a few
chrome/browser/profiles/
includes are not necessary anymore. c/b/api was removed in r195919 by Peter
and
some c/b/profiles/ were moved in r201167 by Pawel.

BUG=138280,144783, 140037, 144050, 146851, 233552
TEST=checkdeps.py passes.
TBR=joi@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16182002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179951

Review URL: https://chromiumcodereview.appspot.com/13825014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202751 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178543

Review URL: https://chromiumcodereview.appspot.com/14985005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202749 0039d316-1c4b-4281-b951-d872f2087c98

This breaks 'git cl upload'.

> chrome/browser: Remove unnecessary entries from DEPS files.
> 
> After recent refactorings chrome/browser/api and a few chrome/browser/profiles/
> includes are not necessary anymore. c/b/api was removed in r195919 by Peter and
> some c/b/profiles/ were moved in r201167 by Pawel.
> 
> BUG=138280,144783, 140037, 144050, 146851, 233552
> TEST=checkdeps.py passes.
> R=joi@chromium.org, thestig@chromium.org
> 
> Review URL: https://codereview.chromium.org/16072002

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/15974007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202748 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244572,152006

Review URL: https://chromiumcodereview.appspot.com/16023019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202747 0039d316-1c4b-4281-b951-d872f2087c98

Removed unused code path and moved counting to proper location.
Added counter native printing code, because native dialog on ChromeOS is actually Cloud Print Web Dialog.

BUG=244059

Review URL: https://chromiumcodereview.appspot.com/15716006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202746 0039d316-1c4b-4281-b951-d872f2087c98

d:\src\w\crbk\src\chrome\nacl\nacl_listener.cc(149) : error C2220: warning treated as error - no 'object' file generated
d:\src\w\crbk\src\chrome\nacl\nacl_listener.cc(149) : warning C4703: potentially uninitialized local pointer variable 'ipc_fd' used

NOTRY=true
TBR=ncbray@chromium.org
BUG=n/a

Review URL: https://codereview.chromium.org/16107003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202745 0039d316-1c4b-4281-b951-d872f2087c98

The function's signature states it returns a std::string, so it shouldn't
NULL on failure. This is also consistent with the other Add functions.

TEST=unit test

Review URL: https://chromiumcodereview.appspot.com/15867003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202744 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes BrowserContext so it store a DownloadManager
directly (as UserData), instead of storing a refptr to it.

Client code (mostly tests) that used refptrs was changed to use either
raw pointers or to use scoped_ptr/ScopedVector in case of
DownloadManagers created by it.

The Bind() in DownloadManagerImpl::CheckForFileRemoval() is now using
a weak pointer to itself.

BUG=237871
TEST=content_unittests and {unit,browser}_tests with *Download* and *SavePage*

Review URL: https://chromiumcodereview.appspot.com/15701007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202743 0039d316-1c4b-4281-b951-d872f2087c98

These all pass locally, but they fail on the bots.
BUG=180861
R=piman@chromium.org
TBR=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15891013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244605
R=sky@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15827010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202741 0039d316-1c4b-4281-b951-d872f2087c98

Goes to https://support.google.com/chrome/?p=cws_app_launcher.

BUG=225068

Review URL: https://chromiumcodereview.appspot.com/14007002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202740 0039d316-1c4b-4281-b951-d872f2087c98

This causes left/right to page flip on boundary and up/down to do nothing. This
patch also makes out of bounds selections on the last page snap to the last
available item instead of not switching page.

This patch updates the OSX app launcher to be consistent with revision 200812.

BUG=237092

Review URL: https://chromiumcodereview.appspot.com/15648003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202738 0039d316-1c4b-4281-b951-d872f2087c98

GL_ARRAY_BUFFER and GL_ELEMENT_ARRAY_BUFFER could definitely be
non-zero, as seen in testing. So always restore 0. Also move them to the
last things to be restored. This patch seem to be helping a lot with not
destroying app UIs.

BUG=230195
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16096004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202737 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Cancel and re-prioritize worker pool tasks.
> 
> This adds a task graph interface to the worker pool and
> implements a simple queue instance of this interface for
> use by the tile manager.
> 
> The task graph interface can be used describe more
> complicated task dependencies in the future and
> provides the immediate benefit of seamlessly being
> able to cancel and re-prioritize tasks.
> 
> BUG=178974
> 
> Review URL: https://chromiumcodereview.appspot.com/14689004

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/16178002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202736 0039d316-1c4b-4281-b951-d872f2087c98

This is to make triple-tap select a paragraph.

BUG=236402
TEST=triple-tap on a paragraph and make sure the whole paragraph is
     selected.

Review URL: https://chromiumcodereview.appspot.com/16018006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202735 0039d316-1c4b-4281-b951-d872f2087c98

Recently layout tests changed to use content_shell instead of DRT. Content_shell attempts to use the sandbox if it can, and that made the Valgrind layout test bot unhappy. All other Valgrind bots disable the sandbox, and layout tests should too.

TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16087005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202732 0039d316-1c4b-4281-b951-d872f2087c98

After recent refactorings chrome/browser/api and a few chrome/browser/profiles/
includes are not necessary anymore. c/b/api was removed in r195919 by Peter and
some c/b/profiles/ were moved in r201167 by Pawel.

BUG=138280,144783, 140037, 144050, 146851, 233552
TEST=checkdeps.py passes.
R=joi@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16072002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229940

Review URL: https://chromiumcodereview.appspot.com/16115002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177394

Review URL: https://chromiumcodereview.appspot.com/15754003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202726 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202725 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151268:151287&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16146004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=221543

Review URL: https://chromiumcodereview.appspot.com/15086005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202723 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a method HasWord(string) to SpellcheckCustomDictionary and changes
the internal data structure in SpellcheckCustomDictionary from a vector to a set
for more efficient querying. Spelling service client will use the new method to
send IN_DICTIONARY feedback to spelling service for words that are in user's
custom spellcheck dictionary. Spelling service client will use this method in
upcoming CLs.

This CL also modifies IPC message "SpellCheckMsg_Init" to pass a set instead of
a vector of custom dictionary words. The browser sends this message to the
renderer to initialize spellcheck.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15940004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238041

Review URL: https://chromiumcodereview.appspot.com/15897003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202721 0039d316-1c4b-4281-b951-d872f2087c98

http://src.chromium.org/viewvc/chrome?revision=202702&view=revision

TBR=cmp@chromium.org

Review URL: https://codereview.chromium.org/15846019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202720 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/16069006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202718 0039d316-1c4b-4281-b951-d872f2087c98

This function returns an object whose keys are the notification
IDs of all notifications created by that extension.

BUG=240924

TBR=miket@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15715008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202716 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the existing "WebRTC hack" where the native audio layer runs at 44.1 but WebRTC at 44.0. Now when native WebRTC supports 44100, it is possible to add the same support to WebRTC in Chrome.

BUG=243450
TEST=content_unittests and misc. WebRTC clients using 44.1 as sample rate on input and output devices.

Review URL: https://chromiumcodereview.appspot.com/15907005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202713 0039d316-1c4b-4281-b951-d872f2087c98