- 22 Nov, 2019 40 commits
-
-
Morten Stenshorne authored
Using the LayoutObject associated with other (non-CSS box) fragments (such as lines and columns) is generally wrong. We already had guards for lines, but not for columns. Had to add a couple of new methods to the NGPhysicalFragment API. Also inlined some of the NGPhysicalFragment methods that I changed. One change: There used to be a direct call to LayoutObject::IsAnonymous(). I replaced this with NGPhysicalFragment::IsAnonymousBlock(), which calls LayoutObject::IsAnonymousBlock() instead of IsAnonymous(). I assume this is more correct (given the comment where it's used), if it matters at all. Change-Id: I2fe133fc85c5888adbc303d0d392e65ae548908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913410 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#718089}
-
Kalpak Tapas authored
This CL introduces a method PDFiumPage::PopulateHighlights which reads highlight annotations from the PDF document and stores relevant accessibility info in a vector within PDFiumPage. Also included is a test pdf file containing simple highlights and a unit test which validates the new method. Bug: 1008775 Change-Id: I1c04f2cc7dc2885aa3a5f49ec66fcccc5a2c1311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862872 Commit-Queue: Kalpak Tapas <katapas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718088}
-
Chris Lu authored
This transfers the correct boolean values stored in the prefs dictionary. Bug: 1014959 Change-Id: I048a33f0d19456ba9c63382608aa443234d310a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929812 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#718087}
-
Felipe Andrade authored
Add the list of remaining accounts to RemoveAccount() and ClearAccount() method response messages on FakeKerberosClient. The KerberosClient class doesn't need to be changed because the method call is been forwarded in a generic way. Therefore the new field should be parsed automatically if its present on the response from kerberosd. Bug: 952251 Change-Id: If72632d3ce6c8c0c1a2e17f15f914f217a0c1929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912700 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#718086}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f4d4668529f1..43fe7bafb14e git log f4d4668529f1..43fe7bafb14e --date=short --no-merges --format='%ad %ae %s' 2019-11-22 johnkslang@users.noreply.github.com Merge pull request #1980 from mattst88/respect-CMAKE_INSTALL_LIBDIR Created with: gclient setdep -r src/third_party/glslang/src@43fe7bafb14e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,courtneygo@google.com Bug: None Change-Id: I3198e3d3f33ebea335d37d8e208f6f1c53bd24d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930483Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718085}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0174ffe70018..4995f872ca2f git log 0174ffe70018..4995f872ca2f --date=short --no-merges --format='%ad %ae %s' 2019-11-22 sprang@webrtc.org Cleans up the round robin packet queue. Created with: gclient setdep -r src/third_party/webrtc@4995f872ca2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I06979204b001f47d6465ded5688e074365d1819c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930484Reviewed-by:
-
Alex Clarke authored
This is needed by telemetry. Bug: 1026937, 1022812 Change-Id: If3fb7b1c47548d6ad4b1bebed68bf19798bb0380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929224 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#718083}
-
Ankit Kumar 🌪️ authored
This CL uses PdfAccessibilityPageObjects struct in the renderer side of PDF a11y. Currently the members of PdfAccessibilityImageInfo struct are passed and used accordingly as needed. More members would be added in struct in the coming future to enable annotation support for PDF a11y. Bug: 1008775 Change-Id: I0388adaebf981a85e4f4a2f7ab7b965ebb40fa0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890380Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718082} -
sczs authored
- Since unittest were using a TestConfirmInfobarDelegate, the previous change broke unit_test. In order to fix this TestInfobarPasswordDelegate was created which actually improves tests since the PasswordsCoordinator actually has a badge. -Updates infobar_container_coordinator_unittest and infobar_badge_tab_helper_unittest to use the new Test delegate. Bug: 1026578 Change-Id: I47ddfe0748c32d5fe74b886462b33bad146757eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928692 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#718081}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3943.1-1572866479-benchmark-80.0.3964.0-r1 to 80-3945.24-1574073604-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I3ec33932cd5b23c2c52572aa20428a14208cc4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930487Reviewed-by:
-
Michael Spang authored
Bug: 1019015 Change-Id: I8351899f0781392582aa0a2a3acfcbea1ebe70d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928306Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718079}
-
Chris Lu authored
Bug: 1014959 Change-Id: Ia61628ca24233bcd329709f35fb7c90f202e326d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925053 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
When a new tab is opened with a URL redirecting to another app, the other app isn't launched. This CL fixes this issue. Bug: 1024336 Change-Id: Iab9f03472e89b65e2c49540df79c1f4ab20457cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924569 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#718077}
-
Hirokazu Honda authored
AcceleratedVideoDecoder notifies a resolution change, but not a profile change while parsing a bitstream. Some hardware video decoders (e.g. decoder using VA-API) may need to reconfigure with the new profile. AcceleratedVideoDecoder needs to inform the client the profile change. From this CL, AcceleratedVideoDecoder returns kConfigChange on Decode() if it detects a profile change or resolution change. This is reasonable because * a profile can vary in IDR frame (H264) or key frame (VP8, VP9, AV1), which a resolution may change at that time, and * a new surface needs to be allocated by the profile change, for example, vp9 profile 2 (10bit), h264 high 10 profile (10bit) and av1 profile 2 (12bit). (1*) This is the first step to handle the profile change. This CL changes AcceleratedVideoDecodeAccelerator, and handle profile changes in Videodecoder/ VideoDecodeAccelerator using V4L2-API. (1*) Note that we need to allocate new surfaces even though a profile is unchanged in av1, because bit depth is 8 and 10 bit in av1 profile main. Bug: 1022246 Test: video.DecodeAccel(VD).h264_profile_change (crrev.com/c/1924217) on kevin, eve and grunt Change-Id: I3b9956624162146cd6242073993d41ad94e45032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923986 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#718076}
-
Kalpak Tapas authored
This is a reland of 4389c2c3 This change was reverted due to "Windows Deterministic" bot failing. These bots seems to have a problem with any changes to ppapi/. I am suppressing the errors in CL:1924340. This is the exact same CL as the one that was reverted. Original change's description: > Add annotation structs for PDF accessibility > > This change adds new *AccessibilityAnnotInfo structs to transfer > accessibility related PDF annotation data from the plugin process up to > the mimehandler process via the pepper API. This annotation information > is bundled along with links and images into the > *AccessibilityPageObjects group of structs introduced as a part of > http://crrev.com/c/1831957. It will be populated from within pdfium_page > in a subsequent change. > > Bug: 1008775 > Change-Id: I89eabc8f56c135eac95c2c887d33854fbccbbcb7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837558 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Kalpak Tapas <katapas@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#716555} TBR=dcheng@chromium.org,kbabbitt@microsoft.com,bbudge@chromium.org, iapres@microsoft.com Bug: 1008775 Change-Id: I6fa8d63e81076dae291ccc74cd9a32e5eb78078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926107Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718075} -
Yuki Shiino authored
Adds a validator that checks the type between literal values and type of constants, arguments, and dictionary members. Bug: 839389 Change-Id: I3bb9efd88508bedddba377531ef058b59a404739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920018 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#718074}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/37ba927e040f..bcf9cf89aea5 git log 37ba927e040f..bcf9cf89aea5 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src ba6cbb047868..24347673152e (1 commits) Created with: gclient setdep -r src/third_party/angle@bcf9cf89aea5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: I2fff0bbd455121e2924e473b3277f59b5e9cefc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930478Reviewed-by:
-
Yuki Shiino authored
The default values of HTMLCanvasElement's toDataURL and toBlob are not correct, plus it's grammatically wrong to assign IDL null to DOMString. This patch fixes them. Change-Id: I628199d5a8f69858cec0d85448e8862021b96ac1 Bug: 1024695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921007Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e6c3dfe3b7b9..a3b566b814f7 git log e6c3dfe3b7b9..a3b566b814f7 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 eirage@chromium.org Do not draw coalesced latency info in performance panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@a3b566b814f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:956681 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f9ac647429f2d6535570dd27f44291b63d9ce7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930479Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd3b1fd5108f..3cecbbfa9aaa Created with: gclient setdep -r src-internal@3cecbbfa9aaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie3925cd4fce33d40f6dcc7e8c5e2a4fc2f106617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930475Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718070}
-
Fredrik Söderquist authored
This was previously using reverse iterators (rbegin(), rend()) when appending to the result vector. In this case (washingtonpost.com), there's a favicon with 4 subicons - the largest one being 256x256 in size. Since these subicons will be returned in order of decreasing size, the 256x256 icon will be first. For Android WebView the favicons are requested without any constraint specified, so the full set of 4 icons will be returned. It will then pick the first entry. This entry is now the 256x256 sized icon, which in turn yields increased memory use. WebVector does not have rbegin() and rend(), so use Reverse() on the result vector instead. This restores the old ordering of the list and will make WebView pick a smaller icon (one with the size 16x16 in this case). Bug: 1026840 Change-Id: I9cba04c6ca06b52f7b9d00bef00fcbf3f48b3655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929214Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#718069}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I4c6d695c91bd2d9329f3767d31c73943875b9bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926273 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
With BlockHTMLParserOnStyleSheets enabled, there is no concept of render blocking stylesheets. Always turn the runtime flag off for test testing that functionality. Bug: 891767 Change-Id: Ia637f0c27be70aeb5bc29b01a740599f08e120fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929212Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#718067}
-
Rune Lillesveen authored
Many tests relied on the HTML parser not blocking on stylesheets in <head>. Make sure the expectations are aligned with the runtime flag for BlockHTMLParserOnStyleSheets. Bug: 891767 Change-Id: If2909a5967325c56576dbd8e0b55ca301bce49ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928700Reviewed-by:
-
Chris Lu authored
This CL also changes GetInfobarBadgeItems to return an NSArray. It is possible for an unordered_map to have keys with nil values, because calling [] operator can automatically insert such keys if there was none before. Instead of adhering strictly to C++ objects in the TabHelper and dealing with this difficulty, Obj-C objects are used instead for peace of mind. Bug: 1016360, 1016360 Change-Id: I60f5c20e7807e31bd7500564ab46eadc867ca8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926490Reviewed-by:
-
Sara Kato authored
Having an invalid window_id, causes navigation to crash on system tray. This was introduced in the clean-up performed in crrev/c/1860524. This CL adds kInvalidTreeID, and using the same convention as kInvalidAXID (in ui::AXNode::kInvalidAXID). When obtaining the windowID, if it does not exist (as it is an optional), the value kInvalidAXID will be returned. The change in this CL, will prevent actions being performed on nodes which have an invalid windowID. Test: manual (follow repro steps in bug, and observe no crash). Bug: 1020413 Change-Id: Iacc1efcd70ad0eec702249f6a318f71e84e2b0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903171Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#718064}
-
Etienne Bergeron authored
This CL is removing either the virtual keyword or the RenderText implementation depending on whether or not the method is present in RenderTextHarfbuzz. The removed code is unreachable and should not change the behavior. R=pkasting@chromium.org Bug: 1025561 Change-Id: I01abf8110ed4523ffb27f19d69fbe21d340fe637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929990 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#718063}
-
Ankit Kumar 🌪️ authored
On the Windows Deterministic bot, any ppapi/ changes will make this DLL non-deterministic. Suppress this for now so ppapi/ changes can land. lib32 were suppressed as part of CL:1899566, this CL suppresses lib64. Fix formatting errors in the file as well. Bug: 429358 Change-Id: If19a8c661a2b2394e70281e07bdb67008cfbabf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924340Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718062} -
Katharine Daly authored
In a future change, the ResolveErrorInfo field will be set to a non-default value and will be used to retrieve the underlying error. The last change in this sequence will alter the top-level error code to be only ERR_IO_PENDING, OK, or ERR_NAME_NOT_RESOLVED. Bug: 1016325 Change-Id: Ia76588cb48d4aee11de7d50ca155a6b6ff20c797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907419 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#718061}
-
Etienne Bergeron authored
The MultilineSupported call is always true on RenderTextHafbuzz. This CL is removing every uses of the deprecated API. R=pkasting@chromium.org Bug: 1025561 Change-Id: Ifd10f603dd1ac5517a33e333ad2de8262295f6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929989 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch changes |NGBoxFragmentPainter| to paint |NGFragmentItem| when layout produced them, not when |ChildrenInline()|. This can fix some inconsistencies when painting self-painting inline boxes for FragmentItem. Also helps the painter to have less assumptions on what the layout does. I'm experimenting not to generate |NGFragmentItems| for empty boxes because it is not necessary at all. Not sure if I want to land it, but having less assumptions is better for the code health. There is no behavior changes unless FragmentItem is enabled. Bug: 982194 Change-Id: I5fc3b23cb712adc9d2f723f0d609fa03f8dc70c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930280Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#718059}
-
Demetrios Papadopoulos authored
Most of these have been fixed automatically with ESLint's --fix flag. This is in preparation of turning on presubmit checks for no-var and prefer-const for components/. Bug: 792774 Change-Id: Idffb1fe5ce8169925166a0f2ff4c7dd3cd8dc1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928302 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#718058}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves ServiceWorkerProviderHost::is_execution_ready() and relevant functions to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I3f881bec3f617f2b5a4f637b9ee31f513d256a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930358Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#718057}
-
Yoshifumi Inoue authored
This patch changes culled inline box traversal in |NGInlineCursor| not to visit non-inline fragment, e.g. floating, as before utilzing |NGInlineCursor|. Bug: 1021677 Change-Id: If3b01e91084c4cc0787b8eb08b398a2ed87d5c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928464 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
David Munro authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/600160410ee1..ac7755fac459 $ git log 600160410..ac7755fac --date=short --no-merges --format='%ad %ae %s' 2019-11-18 davidmunro system_api: Add constants for permission broker port forwarding. Created with: roll-dep src/third_party/cros_system_api Bug: chromium:848127 Test: Build Change-Id: I3156d4fb7cf051267ffa494476abb98e7ecfcd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930355 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#718055}
-
Alexey Baskakov authored
Should include the last valid value. Bug: 891172 Change-Id: I006ca471e0b27808018a538d23057fdd955523fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930248 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#718054}
-
Matt Falkenhagen authored
Bug: 1007763 Change-Id: I2d0a7c9f1fea7b4357c2f961290b40bcac29af8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930281 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#718053}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/053b2ec4a6b4..fd3b1fd5108f Created with: gclient setdep -r src-internal@fd3b1fd5108f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic03094c9a8922d4cdd5ae4529c9f22e990197e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929370Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d4691cf9..c8755d97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5270518102709483e2214c422ba9813af0fb6414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929785Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718051}
-
Chris Cunningham authored
This is a reland of e23ee999 Original change's description: > MediaCapabilities: Ship encrypted (EME) decodingInfo() > > Intent thread: > https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/0yw8CuNaQEw/ppTxJme2EQAJ > > Bug: 961885 > Change-Id: I0b066a66288e00e27354a21d382500fe2dd838e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915824 > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717946} TBR=chcunningham,foolip Bug: 961885 Change-Id: I7554f6c9af8b1dcd36333ceeb433bb29ff0db62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930356Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#718050}
-
