- 12 Sep, 2020 4 commits
-
-
Markus Handell authored
Recently a few changes (crrev.com/c/2391767 and crrev.com/c/2399238) entered the AVFoundation capturer, and it's better if these are controlled by a new base::Feature instead of raw changes, because 1) More evolution is expected, 2) We had one regression introduced (crbug.com/1124884#c7). 3) Additionally, this change enables A/B testing in a few months. The change introduces a new feature kMacNextGenerationCapturer controlling which implementation (default: new capturer) is in use by the system. The change also dupes the current _mac-suffixed capturer into a new _legacy-suffixed variant. In future CLs, last weeks evolution to the _mac capturer will be reverted inside the _legacy variant. Bug: chromium:1126690 Change-Id: I972663eef38623c9a76e0b2424e048bc24fc7093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401168 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#806403}
-
Xing Liu authored
When there are multiple scheduled downloads in different tabs, always show the scheduled infobar in the latest tab instead of the first tab. Also tweaked the delay, that 2 scheduled download must show inside a 12 seconds window to have the multiple scheduled string shown. Bug: 1123924 Change-Id: I9b9de9d484871b94c2a3e2c4a60dad31950e29d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401404 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806402}
-
David Bienvenu authored
A little other miscellaneous cleanup, no functional changes. Bug: 1010217 Change-Id: I9d1c56723c0de2293c06c810fa7175cbf5031f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393633Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806401}
-
Brian Salomon authored
The decoder can choose either if both are available. Bug: skia:10632 Change-Id: Ia089845f7b16354fe20d34762ee41aa24c0a5f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405440 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806400}
-
- 11 Sep, 2020 36 commits
-
-
Shrek Shao authored
Bug: 1122394 Change-Id: I724673e312a2e4c93ced178adb532323860cc263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406606Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#806399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef8507d106ad..32eb03a1fbe2 2020-09-11 deadbeef@webrtc.org Get rid of NetworkMonitorBase helper class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0ac3c685f5e36dff3ea3367afc1821a893a3f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806398}
-
Ayu Ishii authored
This updates get() to return a TypeError if called with no options or empty options. Details of this decision can be found at https://github.com/WICG/cookie-store/issues/94. Bug: 1124073 Change-Id: I3bae610cc6f5d4f46e392d968f7ae82a08bcbab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404412 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#806397}
-
Brian Salomon authored
Bug: skia:10632 Change-Id: I66625bcf31c69df65f104d7abe6cd2508c0a2f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405899 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Adrienne Walker authored
As I'm adding a 4th file stream reader unittest, I thought I would combine all of the similar-but-not-exactly-the-same sets of file stream reader unittests. This is one behavior difference between all of the file stream readers, so I thought I would clean it up first. This return value is how file system file stream reader and local file stream reader behave when seeking past the end. Change-Id: Ife39c7c82b8aee161dd26aa67e001c09e93d30ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406703 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#806395}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ed34138a32b..c62a79d55ed7 2020-09-11 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewSidebarPanel.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2eb9b2f4c1d2f380b4d1508d9e405edb9b254118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406746Reviewed-by:
-
Will Cassella authored
This CL adds two additional feature flags for controlling decoder selection: `DisableNonPlatformVideoDecoders` and `DisableNonPlatformAudioDecoders`. These change the predicate DecoderSelector uses to skip any non-platform decoders, regardless of config resolution. This is primarily useful for testing platform decoders without worrying about fallback. Bug: 1119939 Change-Id: I25191207f65b0da0fc0220133ebf6f383c9dc5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388272 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#806393}
-
Daniel Hosseinian authored
When the active page changes, scroll the thumbnail into the visible area of the thumbnail bar. Bug: 652400 Change-Id: I6333a66b88202b7dabcb1a0f287b3fbee2d3b701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404564 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806392}
-
Anders Hartvoll Ruud authored
This CL implements support for element-based offsets in the CSS API. In order to make parsing as painless as possible, the code that consumes a selector(<id-selector>) has been moved from at_rule_descriptor_parser to a separate function in css_parsing_utils (ConsumeSelectorFunction). This makes it possible to reuse that code for parsing element-based offsets. Note that the drive-by removal of the ConsumeWhitespace() call at the beginning of ConsumeScrollOffset is just to align with the convention that whitespace should be consumed _before_ a Consume* function is called. Bug: 1102788, 1074052 Change-Id: I8caa3caa4fe1efe05b4d451c989e10bb9f67267c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391072 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#806391}
-
Sky Malice authored
Bug: 1127502 Change-Id: I28cccaca3666f409f1c266f6319a064b33871946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406185Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#806390}
-
Josiah K authored
AX-Relnotes: N/A Change-Id: I12f3a7b7a4ca94adddb166c8c3f0eaa1ecc1a533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405513 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806389}
-
Sophey Dong authored
Also removes URL from the screenshot share so they will share properly as image-only shares, and removes the distinction between screenshot and regular shares. Bug: 1123862 Change-Id: Icc763397da04eed96e5d63e09e0a42170fa195c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393008 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806388}
-
Daniel Hosseinian authored
Change the color of the thumbnail of the active page. This CL sets the plumbing for a thumbnail to know it is active. More styling will be added after the painting of the thumbnails is implemented. Bug: 652400 Change-Id: Ib3cd864b13c6a97a46acb6b938ddcd5b1412e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402438 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/83ba93022571..9eb848ae8218 2020-09-11 brianosman@google.com Give SwitchCase it's own Statement::Kind value 2020-09-11 bungeman@google.com Add SkFILEStream constructor which takes a size. 2020-09-11 bungeman@google.com Refactor SkFILEStream for clarity. 2020-09-11 johnstiles@google.com Fix warning in Flutter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ic43923560cb3499989bdb3e04960e62666392b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406743Reviewed-by:
-
Hiroki Nakagawa authored
This CL passes optimization guide hints for DelayCompetingLowPriorityRequests from LocalFrame to ResourceLoadScheduler. Bug: 1112515 Change-Id: I6637aa13cc27b01a4c96edb980e6646b76446202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397116Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#806385}
-
Clark DuVall authored
This metric was not previously recorded on Android because startup_metric_utils::RecordStartupProcessCreationTime was never called. We can use Process.getStartUptimeMillis() to get this value. Bug: 1126301 Change-Id: Ic94be3635389c4a3c9b5e0f870b9d3290767a530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402209 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#806384}
-
Eugene But authored
Chrome relies on prefs::kLastSessionExitedCleanly pref to verify that browsing session has ended exited cleanly as oppose to app crash. The assumption is that prefs::kLastSessionExitedCleanly pref is always flushed and crash detection logic won't work correctly if assumption is not correct. This CL adds a temporary Stability.iOS.UTE.MobileSessionAppState histogram to verify the assumption. The value of the histogram should always be ActiveUTE or ActiveXTE. Any other value indicates that prefs were not properly flushed. Bug: None Change-Id: I09d407d645f05a41179a9e1faee54f0cf294ef40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399769Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#806383}
-
Xiaohan Wang authored
Currently EXPECT_WV_SUCCESS can actually be EXPECT_UNSUPPORTED, which is confusing. Also we have EXPECT_ECK and EXPECT_WV_AV1 which don't have _SUCCESS suffix either. Bug: 1126664 Change-Id: If616e201beba5fad022ecb6dbab9153a5c33d0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405710 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806382}
-
Shengfa Lin authored
Explicitly specify chromedriver log for saving to avoid running default merge as json file Bug: 1127106 Change-Id: Id4af7bfe101c633ced5ece5c6d5cbb748a9b2f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406613Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#806381}
-
Emily Stark authored
This CL adds test configs for the URL display experiment group that launches all three URL display experiments and SafeBrowsing Delayed Warnings. SafeBrowsingDelayedWarnings was launched standalone for M85. In M86 and above, it's launched with the other URL display experiments. It's also no longer launched on Android as the URL display experiments aren't implemented on Android. The CL also removes a couple of obsolete configs so that the bots don't hit the command line length limit. Bug: 1111429 Change-Id: I037fb3a456a31d7617516eb7ad554ec1a02f4d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399563Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#806380}
-
Nick Harper authored
https://quiche.googlesource.com/quiche/+/808b6c7b0d8953251b36eeeb34e9974714e9a3af fixed TlsClientHandshaker::crypto_negotiated_params to return non-empty params after a 0-RTT handshake is attempted, so the check added in crrev.com/c/2315435 that the TLS handshake is complete before providing SSLInfo is no longer needed. Change-Id: I5d42a58e19e32badea7b1d7d457e3f90dcb39177 Bug: 1122700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406458 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806379}
-
Tom Anderson authored
This fixes an improper usage of the XProto API introduced in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2327373 BUG=11240791,1126756 R=sky Change-Id: I641bc226b573188f84b491069580e87117c9bf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406382 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#806378}
-
Avery Musbach authored
Overview exit animation histograms shall include when overview ends because you drag two windows from overview and snap on opposite sides. Test: All/SplitViewOverviewSessionInClamshellTest.BothSnappedOverviewExitAnimationHistogramTest/? Change-Id: I5a1e7d11a4e6d4e3aff49c32e489b9042aa5cf0e Fixed: 1124786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401941Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#806377}
-
Tim Song authored
BUG=1106937,1126208 Change-Id: I58ef9ad83bb18ee8193563820c3c0a223295e6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400765 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806376}
-
Matt Mueller authored
This reverts commit 629c4109. Reason for revert: regression on cronet_perf_tests, reverting to confirm if this CL was the cause: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDIvO-0lgoM https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDI_IX5rwkM https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDI_Nq_rgsM https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDI_KezuwsM Original change's description: > Quiche merge for Sept 11, 2020. > > > Roll src/net/third_party/quiche/src/ 5c52ad843..0c20b03c8 (3 commits) > > https://quiche.googlesource.com/quiche.git/+log/5c52ad843f8a..0c20b03c83cc > > $ git log 5c52ad843..0c20b03c8 --date=short --no-merges --format='%ad %ae %s' > 2020-09-10 renjietang deprecate gfe2_reloadable_flag_quic_do_not_use_stream_map. > 2020-09-10 renjietang deprecate gfe2_reloadable_flag_quic_remove_streams_waiting_for_acks. > 2020-09-10 bnc Use IETF application error codes for STOP_SENDING frames. > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > R=dschinazi@chromium.org > > Change-Id: Iba8427627fcbfd7417a0d619f80f8b139c153cf6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404718 > Auto-Submit: Ian Swett <ianswett@chromium.org> > Commit-Queue: David Schinazi <dschinazi@chromium.org> > Reviewed-by: David Schinazi <dschinazi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806254} TBR=ianswett@chromium.org,dschinazi@chromium.org Change-Id: I178b3341725551de6012eec906ba6768089a309f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406391Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#806375}
-
Andrew Grieve authored
It's used only in a single file, so define it there (condition_variable_posix.cc). Bug: None Change-Id: Ia59b42486feee2920f77dbcbef40a0d801bd2b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405416 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#806374}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aeac9f88598d..ef8507d106ad 2020-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55b6d728..86121ae2 (806095:806200) 2020-09-11 kwiberg@webrtc.org Proof of concept: Cancer Stick Castle, a sigslot replacement 2020-09-11 sprang@webrtc.org Updates rtcp::CompoundPacket to contain unique pointers to packets. 2020-09-11 lndmrk@webrtc.org Delete kHEVCCodecName 2020-09-11 jleconte@webrtc.org Change gtest name to allow filtering based on the story name. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice4ec2b20d6865f978f9ef4606cb4e6b05efed51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406741Reviewed-by:
-
Mei Liang authored
On rare occasions the fetcher returns a null bitmap before the ImageView finishes its measurement, which causes setMinimumHeight to 0 instead of the expected value. This CL fixes the “pill” shape tab in GTS and TabGridDialog by extending the RoundedCornerImageView and overriding the onMeasure to apply the aspect ratio to the height when the ImageView drawable is null or a ColorDrawable. Everything introduced in this CL is gated by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout". Most of Java code is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. The following changes can't be verified by the tool, but it is expected and no-op without the flag: * The tab_grid_card_item.xml file * The newly added file TabGridThumbnailView Bug: 1121283 Change-Id: I29da57a72b2de6783b44ace6c1568d07c76c8663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392976 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806372}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I67f3dce1cbb16a4e7e69862c7dcea37db3fc76ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406601Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806371}
-
Mustaq Ahmed authored
Bug: 1096189 Change-Id: Ie6d6bb110580d5b96751331483bac6ac46153f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367991Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#806370}
-
Shengfa Lin authored
Differentiate passing host for new session and pass host instead of session id so that we can use it to construct WebSocketUrl potentially Bug: chromedriver:3588 Change-Id: Ib7a0dda3daf816b36ecf6220140dc906e2040487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391903Reviewed-by:
-
Ionel Popescu authored
This CL adds eye dropper support for pre-macOS 10.15 due to NSColorSampler not being supported. The pre-macOS 10.15 support is added by splitting the current aura specific implementation. Since the eye dropper can currently be opened from the color picker which is a popup[1], there is a need to add Mac specific support for: - moving the view to the front of the screen list within the popup level - event monitor since the popup had already installed one to be able to close when the user clicked outside of its bounds [1]: https://source.chromium.org/chromium/chromium/src/+/master:content/app_shim_remote_cocoa/popup_window_mac.mm Bug: 992297 Change-Id: I5de7b21845ef8a4e45243d257fa7a8a9af4a193f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405302 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806368}
-
Orin Jaworski authored
If a Pedal attached to a suggestion that later became a duplicate of an entity suggestion, the Pedal was suppressed. This CL resolves such cases by waiting until after deduplication (done in SortAndCull) to attach. This ensures that only root-level suggestions are considered for Pedals. Bug: 1126572, 893183 Change-Id: I778ff524b7343304d3f14e79567195080760b298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401780Reviewed-by:
-
Prakhar authored
Observed rise in pending build times http://shortn/_wl495QJZSE Bug: 1024915 Change-Id: Ie15cbaf6e0a52f489d77189b020203b4db1dc279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405035 Auto-Submit: Prakhar Asthana <pasthana@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#806366}
-
Dominic Mazzoni authored
This adds the toggle button for caret browsing to Chrome OS accessibility settings; previously it was only in browser accessibility settings which isn't used on Chrome OS. Also fixes the syntax for the accelerator on Chrome OS. The actual user-facing shortcut is Ctrl+Search+7, but the only way to achieve that in accelerator_table.cc is to use VKEY_F7. Manually tested on-device and confirmed that the correct shortcut Ctrl+Search+7 does work and that no permutation of modifier keys with F7 has any effect. Bug: 1120826 Change-Id: I89b4948a874f232e2c893f00611a927b3f45e44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390876Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#806365}
-
David Black authored
Currently a screenshot is added to holding space when the user takes a screenshot using the ChromeScreenshotGrabber. The same should occur if the user takes a screenshot using the CaptureModeController. This CL wires that up and adds test coverage for both code paths. Bug: 1126643 Change-Id: I65f25392d4f3dc83b26156ba31827b76ded015a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404420 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
