- 22 Aug, 2018 34 commits
-
-
Yoshifumi Inoue authored
This patch disables following layout tests: - fast/events/autoscroll-iframe-no-scrolling.html - fast/events/middleClickAutoscroll-drag.html - fast/events/middleClickAutoscroll-event-fired.html - fast/events/middleClickAutoscroll-nested-divs-forbidden.html - virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-drag.html - virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-in-iframe.html - virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-nested-divs-forbidden.html - virtual/user-activation-v2/fast/events/middleClickAutoscroll-click.html - virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html - virtual/user-activation-v2/fast/events/middleClickAutoscroll-nested-divs.html TBR=sahel@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876609 Change-Id: Iacfe4248b77d438a01741b82b62855d8cc70691f Reviewed-on: https://chromium-review.googlesource.com/1184562Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584962}
-
Alexander Alekseev authored
This reverts commit e94813f4. Reason for revert: Cannot start session after sign-in (stuck at Sync Consent). Original change's description: > Move assistant optin into oobe flow > > Bug: b/112564431, b/78190629 > Test: Manual Test > Change-Id: Ie046c8ab05918d4aabaa931a59a4fcdf0270e4f4 > Reviewed-on: https://chromium-review.googlesource.com/1176377 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584833} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org Change-Id: I9e690a8bcd1e7da8e56a467ac1b038dae95b554d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/112564431, b/78190629 Reviewed-on: https://chromium-review.googlesource.com/1184542Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#584961}
-
Yoshisato Yanagisawa authored
Instead of boolean flag use_goma_canary, let me make it use string property to allow us to specify arbitrary cipd ref to use. Bug: 874754 Bug: 876583 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6ad5233986b0b7d4a98a0857500a490f2ffc3a39 Reviewed-on: https://chromium-review.googlesource.com/1183042 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#584960}
-
Takuto Ikuta authored
This is a reland of be7c1259 chromeos's simple chrome and build_package set additional flags in cc/cxx. This CL checks that before relativize compiler path. Original change's description: > Relativize cros compiler path > > Combined with https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1180801 > this patch removes absolute path from command line for simple chrome build. > > This is a part of effort for build cache sharing when using goma by > removing absolute path from compile result. > > Bug: chromium:846610 > Change-Id: Ia40a7194b4e485f26424f27ebfc210355e352cc0 > Reviewed-on: https://chromium-review.googlesource.com/1180826 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584648} Bug: chromium:846610 Change-Id: I142f6b466be0147252b419abca8abd87cb099ee1 Reviewed-on: https://chromium-review.googlesource.com/1183121 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584959}
-
Yuki Yamada authored
This CL modifies source path that is used in wpt test of Accept-CH. window.open() uses the base URL of the entry realm's window in order to resolve a relative URL. The entry realm should be main window on calling function |acceptChLoaded| as a listener for load event of non-main window in this test. We want to open do_not_expect_client_hints_headers.html in resources/ so the relative URL in this test should start from "resources/". Also, entry realm is not set correctly by current chromium implementation, so fixed test is assumed to fail. Change-Id: I973393e0a7ca74cac882eb58f5a58aa9a81556ff Reviewed-on: https://chromium-review.googlesource.com/1179511 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#584958}
-
Peter Kasting authored
Bug: 874560 Test: Run chrome with --enable-features=SingleTabMode, there should be no stroke around the (one) tab. Change-Id: I002f058478c46ca68942e55c3bad8c1376f231fb Reviewed-on: https://chromium-review.googlesource.com/1184378Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584957}
-
George Burgess IV authored
While looking into some Chromium size fluctuations, I stumbled across this function. Depending on what our execution profiles look like, clang may/may not inline some relatively large methods that vector::push_back calls at each push_back callsite. This can cause Chrome's binary size on Linux to fluctuate by ~25KB. This CL saves us around 28KB + helps stabilize the binary size of Linux, and saves ~1.8KB on Android (on which clang is way more reluctant to inline methods). Please note that this has a functional change: we were previously resizing this vector (not reserving it), then doing push_back. This would leave us with `NUMBER_OF_GPU_DRIVER_BUG_WORKAROUND_TYPES` NULL elements in the vector. I expect that this was a bug, so this patch writes to those slots resized slots instead. Bug: None Test: `ninja`. Hoping the CQ will catch anything. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idc351d39ff91856e36e6fb9383a37d696b9bbb55 Reviewed-on: https://chromium-review.googlesource.com/1176963 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#584956}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ie1e4f6e3e15d5bcde28978144944af58e84efdcb Reviewed-on: https://chromium-review.googlesource.com/1184400Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#584955}
-
Scott Violet authored
EventMonitor makes use of Env for screen coordinates. In SingleProcessAsh there will be two Envs, which means EventMonitor needs to know which Env to ask. This injects a NativeWindow so that the right Env can be used. This also updates Widget::SynthesizeMouseMoveEvent() appropriately. BUG=874481 TEST=covered by test Change-Id: If2deb18e06950ab056bc3f3339a0676784d7deae Reviewed-on: https://chromium-review.googlesource.com/1183883 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584954}
-
James Cook authored
We need to distinguish between MultiProcessMash, SingleProcessMash and both (aka IsUsingWindowService). This is the last of the uses in //chrome/browser. It mostly covers window frames. Bug: 874468 Change-Id: Ia6ab9e9a5fc0787f3f295f8ce8a3efff46b37e6b Reviewed-on: https://chromium-review.googlesource.com/1184115 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#584953}
-
Alexei Filippov authored
This is a reland of c5126022 TBR=dgozman@chromium.org Original change's description: > DevTools: Do not start tracing in renderer process explicitly. > > The tracing is now initiated by the browser process. There's no need > to start it in renderer anymore. TracingStartedInPage event is not > going to be produced anymore. It has been replaced with TracingStartedInBrowser. > > Change-Id: I9e7759f7f792421d3f32fd21e82066e13a4901dc > Reviewed-on: https://chromium-review.googlesource.com/1182287 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584797} Change-Id: Iaa5195808a2339c1b3a52e122b906134fb859dc6 Reviewed-on: https://chromium-review.googlesource.com/1183824 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#584952}
-
Justin Cohen authored
Followup to crbug.com/848762, which had too broad of a fix. This narrows the scope of the fix to RxR size class only. Bug: 848762, 868945 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic72760d395eea7aadc32560133c0885657852bcc Reviewed-on: https://chromium-review.googlesource.com/1183561Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584951}
-
Kyle Horimoto authored
This CL adds: (1) Four .png files (two icons in both 1x and 2x sizes). (2) Three .svg files. Bug: 870111, 824568 Change-Id: I39f2a24f128a63ee081629eaa755b9fbea1ef4db Reviewed-on: https://chromium-review.googlesource.com/1184332Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#584950}
-
David Black authored
Ideally we would not have an empty query, but we should still handle that case for now to avoid an ugly UI state. See bug for additional details. Bug: b:112908989 Change-Id: I450c7624221646d3edd440ae355f92a8516a0930 Reviewed-on: https://chromium-review.googlesource.com/1184101 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584949}
-
Ryan Hansberry authored
Before Smart Lock or Better Together Suite can be enabled, the user is prompted to confirm their password. The auth token that is generated by the process is then passed along to MultiDeviceSetupService. For other features which don't require authentication, simply call out to MultiDeviceSetupService with no auth token. This CL always requires Better Together Suite enabling to be an authenticated request. However, that's really only necessary in the case that the Smart Lock user pref is enabled. A follow-up CL will remove this unnecessary authentication requirement; see crbug.com/876377. Bug: 870122 Change-Id: I95056000a3dccf27c4d62329d7f04a737f1e1c4a Reviewed-on: https://chromium-review.googlesource.com/1184025 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#584948}
-
Devlin Cronin authored
Break up extension API bundle generation into two targets separate gn templates: generated_json_strings and function_registration. This simplifies the flow of control within the template, as well as the number of bespoke arguments that the template needs to be invoked with. With this, each of the json_schema_api generating actions are now separate. Bug: 864576 Change-Id: I126e2f746137b89ac879e35252a16667f2f4367d Reviewed-on: https://chromium-review.googlesource.com/1170427Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584947}
-
Yi Gu authored
Previously we have to force compositing the animated target for worklet animations. Given that the target with worklet animations has been composited automatically after crrev.com/c/930128, there is no need to keep the force composition in the test. Change-Id: I5effd169844e0c08a3578b35ccacf886965fce37 Reviewed-on: https://chromium-review.googlesource.com/1167988Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584946}
-
Ken MacKay authored
Bug: internal b/112780630 Test: on device Change-Id: I5b9b3a603214e65d3f59ede534858fe11cd6a8ae Reviewed-on: https://chromium-review.googlesource.com/1184208Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#584945}
-
Kevin Marshall authored
Adds support for Reload()ing a chromium::web::Frame. * Browser test added to verify the resulting navigation event and network request. * Minor cleanup in context_impl_browsertest.cc Bug: 852145 Change-Id: Ie7893b49e0872bb4b1a4c57b972d9c5f75a2ee34 Reviewed-on: https://chromium-review.googlesource.com/1180519Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584944}
-
Ryan Hansberry authored
Only move forward with the SetFeatureEnabled() and SetHostDevice() methods if a valid AuthToken is provided. Bug: 870122 Change-Id: I5367490cc28a51ee38161d23ca900b52f9793afc Reviewed-on: https://chromium-review.googlesource.com/1178567 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584943}
-
wutao authored
Settings' window is not registered with MultiUserWindowManager, so it is not handled automatically in multiple users case. This patch registers it to MultiUserWindowManager and handle the shelf icon change. Bug: 872380 Test: manual. Change-Id: I9d451a27099da77c1c36560c608040684018eeb8 Reviewed-on: https://chromium-review.googlesource.com/1184037 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584942}
-
Eugene But authored
This DCHECK will help to diagnose possible URL spoofing bugs in Slim Navigation feature. _documentURL is used as proxy for legacy navigation manager URL, which is generally reliable and almost always match last committed URL. Bug: 1182320 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib3773ac80e85ca8d08680d319b0441f44a22cb72 Reviewed-on: https://chromium-review.googlesource.com/1184158Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#584941}
-
erikchen authored
Previously, compare_build_artifacts.py only compared certain executables in the output directories. This CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1180706 makes deterministic builder use .isolate files to compare both data files and the appropriate executables. With this change, we've discovered that the data files included in this CL are also not deterministic. Bug: 870731, 330263 Change-Id: Ia02c3f99d35ab690f5a709c0adb987d2820201b5 Reviewed-on: https://chromium-review.googlesource.com/1183999Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584940}
-
erikchen authored
If files are specified by a .isolate and missing, this should be handled like any other error in compare_build_artifacts. It should not throw an exception. Bug: 870731 Change-Id: If29a180539ffa148d5788ac2ecd626205e2eb090 Reviewed-on: https://chromium-review.googlesource.com/1183998Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584939}
-
Mao Huang authored
Original CL: - https://chromiumcodereview.appspot.com/9212025 Support use of third party time function for about:profiler This uses TCMalloc to provide a time function, allowing us to see how much memory was allocated on a single thread during the running of a task. The alternate time function is put in place only when a specific environment variable is detected during TCMalloc startup. This change currently is activated only in Windows/Linux, as it is based on changes TCMalloc (not used on Mac). We also create an infrastructure for using any alternate timer, to replace the "wall clock time," on a per-thread basis, in the about:profiler infrastructure. That interface may be used on other platforms, including scenarios where we have a per-thread-CPU-time function to replace the wall-clock timer. In all cases, when this alternate timer is activated, we lose the ability to calculated queueing time. Queueing time is based on a time snapshot taken on a second thread, and hence is not comparable to the alternate timer (when the alternate timer is engaged). r=rtenneti BUG=103321 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122180 BUG=724399,b:70905156 Change-Id: If2edfa25da30dc05c9ec7f8abf47017d8fce9464 Reviewed-on: https://chromium-review.googlesource.com/1130788Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#584938}
-
Thoren Paulson authored
We used to tear down CastWebContentsActivity when we stop because the user left. This is needed because sometimes we can leave the activity without tearing down, leaving the receiver running without the user seeing it. Bug: internal b/112775688 Test: cast_shell_junit_tests Change-Id: If234a52facb9ea310b8899db0a9bda1a67439cd5 Reviewed-on: https://chromium-review.googlesource.com/1184044 Commit-Queue: Thoren Paulson <thoren@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584937}
-
Daniel Erat authored
Now that ChromeFeaturesServiceProvider lives in //chrome/browser/chromeos/dbus, it no longer needs a Delegate interface. Bug: 843392 Change-Id: Ia4b4a737e8cde0b517f6975994238dc8f03fec1a Reviewed-on: https://chromium-review.googlesource.com/1184168Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584936}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Idac6a13a32465359102228499e05238da53a5e97 Reviewed-on: https://chromium-review.googlesource.com/1111468 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584935}
-
Anand K. Mistry authored
BUG=845393 Change-Id: I5c2f1cb68810596ade3c780658fddfcde2d9578b Reviewed-on: https://chromium-review.googlesource.com/1182915Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#584934}
-
Sky Malice authored
Bug: 876449 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib42fb716d79f95370f060af0a43fca7cb3288900 Reviewed-on: https://chromium-review.googlesource.com/1184141Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584933}
-
Hans Wennborg authored
It contains 'tail' in addition to the contents of gnuwin-7, to be able to run some tests that were updated in r339475. NOTRY=true Bug: 876139 Change-Id: I447d79591b01de309b258a54a37cb5603599201b Reviewed-on: https://chromium-review.googlesource.com/1183909 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584932}
-
Daniel Erat authored
Now that VmApplicationsServiceProvider lives in //chrome/browser/chromeos/dbus, it no longer needs a Delegate interface. Bug: 843392 Change-Id: I1c9a0cf0a251d12bf3a0c33a58b0d6e177859618 Reviewed-on: https://chromium-review.googlesource.com/1184142Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584931}
-
Alexander Alekseev authored
This CL splits CreateOobeUIDataSource into several smaller functions. Bug: 864686 Change-Id: I6843595bf66a9584778fa5ebbff8167a0ce605d2 Reviewed-on: https://chromium-review.googlesource.com/1182608 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584930}
-
Sky Malice authored
This reverts commit d184f073. Reason for revert: Speculative revert to fix net_unittests BUG: 876563 Original change's description: > Add NetLog events for cookie blocking by NetworkDelegate > > Cookies setting and getting can be blocked by a NetworkDelegate. > This CL adds NetLog events so they can aid in the investigation of cookies bugs. > > Bug: 875849 > Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7 > Reviewed-on: https://chromium-review.googlesource.com/1181244 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584809} TBR=mmenke@chromium.org,xunjieli@chromium.org Change-Id: Ifbfcf98ec819cda47cb04e4c87e6274db0e93579 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875849 Reviewed-on: https://chromium-review.googlesource.com/1184274Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584929}
-
- 21 Aug, 2018 6 commits
-
-
Tom Anderson authored
BUG=876451 R=pkasting Change-Id: I2be8079b64ef0f05fbb740dc99562f44a1734fab Reviewed-on: https://chromium-review.googlesource.com/1184045 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584928}
-
Sam McNally authored
Bug: 172187 Change-Id: I0e42fe87ed76a44bff4c2a34065255e9440870a2 Reviewed-on: https://chromium-review.googlesource.com/1180822Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#584927}
-
Adam Langley authored
(Webauthn will need to parse an extension out of the token attestation certificate.) Change-Id: I24c3bc63bd190e6bfc4faeb02b8acf7fd0883b74 Reviewed-on: https://chromium-review.googlesource.com/1179231Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#584926}
-
Cole Winstanley authored
This reverts commit 1ffe88a7. Reason for revert: Causing ChromeDriver waterfall issues Original change's description: > [ChromeDriver] Add replay end-to-end tests to run_all_tests.py > > This change adds the end-to-end tests for the client replay component > of ChromeDriver to the ChromeDriver waterfall by incorporating them > into the existing run_all_tests.py. This will extend the waterfall > coverage to include the ChromeDriver log-replay component. > > Bug: chromedriver:2501 > Change-Id: I6e35675d2598a2a33c67340e0ee73e05201c3439 > Reviewed-on: https://chromium-review.googlesource.com/1174894 > Commit-Queue: Cole Winstanley <cwinstanley@google.com> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584518} TBR=crouleau@chromium.org,johnchen@chromium.org,cwinstanley@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:2501 Change-Id: I6f0eec4d77b0608a38b9ccc4efcacd1b948c8c46 Reviewed-on: https://chromium-review.googlesource.com/1183827Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#584925}
-
Bailey Forrest authored
Bug: internal b/112773799 Test: cast_bluetooth_unittests Change-Id: I988345b574ddbc9ba8f7afc821aac90f56779985 Reviewed-on: https://chromium-review.googlesource.com/1182301Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#584924}
-
Mike Wasserman authored
Bug: 722496 Change-Id: I797582085ebaf0c3f63b0eb4ec60d605342c5129 Reviewed-on: https://chromium-review.googlesource.com/1183584Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584923}
-