GitLab

BUG=490047
TBR=pfeldman

Review URL: https://codereview.chromium.org/1217833002

git-svn-id: svn://svn.chromium.org/blink/trunk@197997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dgozman
NOTRY=true

Review URL: https://codereview.chromium.org/1212153003

git-svn-id: svn://svn.chromium.org/blink/trunk@197996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504412
TBR=pfeldman

Review URL: https://codereview.chromium.org/1218853002

git-svn-id: svn://svn.chromium.org/blink/trunk@197995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=503887
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1213693006

git-svn-id: svn://svn.chromium.org/blink/trunk@197994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=488371
TBR=pfeldman

Review URL: https://codereview.chromium.org/1217863002.

git-svn-id: svn://svn.chromium.org/blink/trunk@197993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=505395

Review URL: https://codereview.chromium.org/1214173002

git-svn-id: svn://svn.chromium.org/blink/trunk@197992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=alph
BUG=502186

Review URL: https://codereview.chromium.org/1219693002

git-svn-id: svn://svn.chromium.org/blink/trunk@197991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While transitioning Blink to Oilpan, there will be LifecycleNotifier<>s
not on the Oilpan heap, but with some of their LifecycleObserver<>s being
on the heap.

Should a GC strike while such a notifier iterates over its observer set,
dead observers may remove themselves (eagerly) while being finalized
during that GC. This will mutate the notifier set, which isn't currently
assumed nor supported.

There's no need to support this when fully transitioned, Oilpan will
handle GCs across such iterations gracefully, but in the meantime we will
have to support this by snapshot'ing the observer set and explicitly
checking for liveness. Like already done over ContextLifecycleNotifier,
where such dynamic unregistrations are supported.

Notice that this issue isn't tied to lazy sweeping; indeed, lazy sweeping
without eager finalization of lifecycle observers will potentially make this
bug rarer.

R=haraken
BUG=480837

Review URL: https://codereview.chromium.org/1214963002

git-svn-id: svn://svn.chromium.org/blink/trunk@197990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The width and height should be valid, but add a size check while
we figure out the root cause of issue 504690.

BUG=504690

Review URL: https://codereview.chromium.org/1212333005

git-svn-id: svn://svn.chromium.org/blink/trunk@197989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman
BUG=495202

Review URL: https://codereview.chromium.org/1214973002

git-svn-id: svn://svn.chromium.org/blink/trunk@197988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, when dumping blink_gc (Oilpan) memory, both the heap pages
and the freelists are scanned. Both of them report free bytes/objects.
At current state, this causes a dump of the following form:
blink_gc/thread_X/heaps/HeapName
blink_gc/thread_X/heaps/HeapName/pages    free_size=1M
blink_gc/thread_X/heaps/HeapName/buckets  free_size=1M

which causes the UI to infer the /HeapName has free_size=2M, which is
incorrect. This change forces the /HeapName dump to override the
free_{size,count} attributes in order to match the HeapName/pages dump.

BUG=490087

Review URL: https://codereview.chromium.org/1217793002

git-svn-id: svn://svn.chromium.org/blink/trunk@197987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=aboxhall
NOTRY=true

Review URL: https://codereview.chromium.org/1214993002

git-svn-id: svn://svn.chromium.org/blink/trunk@197986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=497167

Review URL: https://codereview.chromium.org/1165393002

git-svn-id: svn://svn.chromium.org/blink/trunk@197985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Considering V8DOMWrapper::createWrapper invokes v8::FunctionTemplate::GetFunction
and v8::Function::NewInstance, it may run an arbitrary script and reenter to
ScriptWrappable::wrap with the same object.

This CL supports such a case and consistently uses the wrapper that is created
and associated first.

BUG=477425,389445

Review URL: https://codereview.chromium.org/1210083004

git-svn-id: svn://svn.chromium.org/blink/trunk@197984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent may dispatch
multiple events: a deferred progress event and the given ready state change.
Multiple dispatching may lead to a use-after-free bug.

This CL adds a protection for the event target. In addition to that,
XMLHttpRequestProgressEventThrottle stops dispatching the latter event when
dispatching the former event changes the readyState.

BUG=505362

Review URL: https://codereview.chromium.org/1217803002

git-svn-id: svn://svn.chromium.org/blink/trunk@197983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some WebDataConsumerHandle subclasses use on-heap objects and Oilpan requires
the followings:

- Non-oilpan threads must not touch on-heap objects.
- Objects must not outlive the thread that created the objects. For example, it
is invalid to keep holding a Persistent handle to an object that was created by
a thread already detached.

As a result, such WebDataConsumerHandle subclasses cannot be used
in non-oilpan threads.
We hope we will get rid of this restriction in the future.

BUG=480746

Review URL: https://codereview.chromium.org/1214613003

git-svn-id: svn://svn.chromium.org/blink/trunk@197982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As this is not a part of the specification https://w3c.github.io/webappsec/specs/credentialmanagement/#credentialcontainer

This patch is a part of a two-sided patchset:
Blink: https://codereview.chromium.org/1217463002/ <-- this patch
Chromium: https://codereview.chromium.org/1215653003/

BUG=494880

Review URL: https://codereview.chromium.org/1217463002

git-svn-id: svn://svn.chromium.org/blink/trunk@197981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=505411
TBR=aboxhall,fmalita
NOTRY=true

Review URL: https://codereview.chromium.org/1213143002

git-svn-id: svn://svn.chromium.org/blink/trunk@197980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dgozman
NOTRY=true

Review URL: https://codereview.chromium.org/1220713003

git-svn-id: svn://svn.chromium.org/blink/trunk@197979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implement getComputedStyle(e).quotes

BUG=472963

Review URL: https://codereview.chromium.org/1206793002

git-svn-id: svn://svn.chromium.org/blink/trunk@197978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This replaces the Document it previously took. It allows Internals to
contain objects which depend on ScriptState, like ScriptPromise or (in
the future) ReadableStream.

BUG=
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1215953003

git-svn-id: svn://svn.chromium.org/blink/trunk@197977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As explained here
http://lists.w3.org/Archives/Public/www-style/2014Mar/0512.html we sometimes
need to consider that some tracks are infinitely growable even when they are
really not, in order to produce more "natural" results.

For example the following case:
    grid-template-columns: auto auto;

    item 1 in column 1 with min-content = max-content = 10px;
    item 2 in columns 1-2 with min-content = 30, max-content = 100px;

will outcome (45px, 55px) without this patch. But considering the second
column as infinitely growable the result is (10px, 90px), a more "natural"
result because column 1 just needs to be 10px to accommodate item 1.

From now on we can flag GridTracks so that they can infinitely grow even
when the growth limit is finite. In order to completely support the feature
some changes were required:
  * m_plannedIncrease became m_plannedSize because we need to store both the
old and new values of the track size in order to decide if a track should be
considered infinitely growable. Consequently m_increaseDuringDistribution
became m_sizeDuringDistribution.
  * distributeSpaceToTracks() is now unconditionally called even though the
extra space is 0. That's because it computes the plannedSize value.
  * a new templatized function called markAsInfinitelyGrowableForTrackSizeComputationPhase()
marks/unmarks tracks as infinitely growable only during the max functions resolution.

Apart from that all the GridTrack's public attributes were made private so
that accessors are now provided for getting/setting their values. Also
AccumulatorSetterFunction was removed as it is no longer needed.

BUG=455724

Review URL: https://codereview.chromium.org/1010213002

git-svn-id: svn://svn.chromium.org/blink/trunk@197976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/overflow-scroll-rtl.html as failing on win

BUG=505387
TBR=wangxianzhu,aboxhall
NOTRY=true

Review URL: https://codereview.chromium.org/1211323003

git-svn-id: svn://svn.chromium.org/blink/trunk@197975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This's the first CL to make Chrome side CL build.

BUG=498596

Review URL: https://codereview.chromium.org/1143543002

git-svn-id: svn://svn.chromium.org/blink/trunk@197974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=358074

Review URL: https://codereview.chromium.org/1212853002

git-svn-id: svn://svn.chromium.org/blink/trunk@197973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup CLs will add additional items to the sidebar.

BUG=503167

Review URL: https://codereview.chromium.org/1215493002

git-svn-id: svn://svn.chromium.org/blink/trunk@197972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In LayoutTests/platform/android, as a follow-up to https://codereview.chromium.org/1160283002.

BUG=494880

Review URL: https://codereview.chromium.org/1212383003

git-svn-id: svn://svn.chromium.org/blink/trunk@197971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=fmalita@chromium.org,reed@chromium.org

Review URL: https://codereview.chromium.org/1220693002

git-svn-id: svn://svn.chromium.org/blink/trunk@197970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The "promise" keeps the "reason" alive anyway

BUG=495801
R=haraken@chromium.org,domenic@chromium.org

Review URL: https://codereview.chromium.org/1212773003

git-svn-id: svn://svn.chromium.org/blink/trunk@197969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=495801
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1218733003

git-svn-id: svn://svn.chromium.org/blink/trunk@197968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=reed,fmalita
NOTRY=true
BUG=504972

Review URL: https://codereview.chromium.org/1221623002

git-svn-id: svn://svn.chromium.org/blink/trunk@197967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1210073004

git-svn-id: svn://svn.chromium.org/blink/trunk@197966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=437696
NOTRY=true

Review URL: https://codereview.chromium.org/1217683004

git-svn-id: svn://svn.chromium.org/blink/trunk@197965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

very artificial to render all Unicode code points.

imported/csswg-test/css-writing-modes-3/text-orientation-script-001k.html
imported/csswg-test/css-writing-modes-3/text-orientation-script-001m.html

BUG=496848

Review URL: https://codereview.chromium.org/1207243003

git-svn-id: svn://svn.chromium.org/blink/trunk@197964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This changes AnimationValue from a struct on the stack to being an
object on the heap. This simplifies the implementation of AnimationValue
as it no longer needs to reimplement nullptr behaviours and makes
future use of this class simpler by reusing the move operations
provided by OwnPtr.

This change makes FlipPrimitiveInterpolation::Side redundant and removes it.

BUG=437696

Review URL: https://codereview.chromium.org/1214593003

git-svn-id: svn://svn.chromium.org/blink/trunk@197963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=427652
NOTRY=true

Review URL: https://codereview.chromium.org/1214103002

git-svn-id: svn://svn.chromium.org/blink/trunk@197962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- binding templates update is to suppress global constructor warning reported by clang/win.

BUG=358074
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1212123003

git-svn-id: svn://svn.chromium.org/blink/trunk@197961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Neutral keyframes represent the underlying CSS value. This can be
implemented internally by adding zero to the underlying value.
This test should avoid using zero for an underlying value to ensure
the "add zero" neutral keyframe implementation is not accidentally
replacing with zero.

BUG=437696

Review URL: https://codereview.chromium.org/1214083002

git-svn-id: svn://svn.chromium.org/blink/trunk@197960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add AnimatableValues for Translate, Rotate and Scale using AnimatableTransform and
Interpolation for Translate and Scale.

This patch does not attempt to put their animations on the compositor. However,
extra code still needs to be added into KeyframeEffect so that compositor
animation on CSSPropertyTransform is cancelled when the independent properties
are added.

Design Doc :

https://docs.google.com/document/d/1Rbwj36VVhGuI7C3PQGuoEqJ2U9nAfzKXjwBV2N41JlQ/edit?usp=sharing

Link to Intent to implement:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/-GfE73tlLX8/hv7Qitys6j8J

Link to w3c specifications:

http://dev.w3.org/csswg/css-transforms-2/

BUG=496550

Review URL: https://codereview.chromium.org/1196913005

git-svn-id: svn://svn.chromium.org/blink/trunk@197959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL enables Cache::putImpl to receive multiple requests and responses for
supporting addAll() in a subsequent CL. This should not change behavior of put()
and add().

BUG=427652

Review URL: https://codereview.chromium.org/1210873004

git-svn-id: svn://svn.chromium.org/blink/trunk@197958 bbb929c8-8fbe-4397-9dbb-9b2b20218538