- 21 Aug, 2019 40 commits
-
-
Fritz Koenig authored
Left over from when DRM platform was switched to using a separate thread. BUG=none TEST=compile Change-Id: I017eb07494c957fdb88d4858f8edf5c139450362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762992 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#688999}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4aa6251e..880b6f75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I760155e79fc50090403d6a09db48c0d74bc5b943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763871Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688998}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d4aa37b83f64..a62c380dea04 git log d4aa37b83f64..a62c380dea04 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 nicomazz@google.com Merge "Add adb controller and adb interfaces." Created with: gclient setdep -r src/third_party/perfetto@a62c380dea04 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I35ee7fe96e4d243e203b2bfad929754d707414fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763937Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688997}
-
Niels Möller authored
On MacOS, the policy::GetMachineName function in cloud_policy_util.cc calls SCDynamicStoreCopyComputerName, and hence needs to link with SystemConfiguration.framework. Add to the corresponding build target, to not rely on unrelated build targets to import this framework. Intended to enable reland of webrtc cl https://webrtc-review.googlesource.com/c/src/+/148531, which drops this library dependency from the rtc_base target. Bug: webrtc:10857 Change-Id: Ifb1861348f1ecc480fb0f456f76597434900c9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762071 Commit-Queue: Niels Möller <nisse@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Auto-Submit: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#688996}
-
arthursonzogni authored
As it name implies, RenderViewHost::PostRenderViewReady() posts a task to the UI thread. So it should be able to reorder this instruction easily. On the other side, RenderViewHost::SetMainFrameRoutingId() isn't posting tasks to the UI thread. I don't see any good reasons not to reorder the two instructions. Reordering allow a slight simplification of RenderFrameHostManager::CommitPending(); Bug: 936696 Change-Id: I7730a5943a69aa3266cc79704775a95664a3354a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702411 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688995}
-
Dave Tapuska authored
Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Cibo-GNPs7Y/RznlX7WKDAAJ Spec: https://github.com/whatwg/html/pull/4606 BUG=961448 Change-Id: I3c2ff129a71a8ccb5a0015661770adc7ff22d14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726055 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688994}
-
Matt Menke authored
Previous work to add NetworkIsolationKey support to HttpServerProperties didn't update the canonical suffix logic to correct take into account NetworkIsolationKeys. This CL fixes that. Bug: 969890 Change-Id: I6d0cd2161640c22ff162b45dc9a3097ab8075d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756836 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688993}
-
Lowell Manners authored
By requiring all subframes to have loaded, we don't have to worry about race conditions where a subframe was navigating at the time the document was put into the cache. Change-Id: Iecc4b4db8ccc961b70e9440053ee1a6b9352beba Bug: 986742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741671 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#688992}
-
Rayan Kanso authored
Bug: 973844 Change-Id: I91146ae6a3bfd05d62583fa259313766ba98cf4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763750 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#688991}
-
Khushal authored
If the same texture is used for read/write access, we'd issue a redundant command to delete the write texture. R=fserb@chromium.org Bug: 994563 Change-Id: Ibc5cb178fe15334aa340285bab3b8327e4cf1e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762658 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#688990}
-
Wei-Yin Chen (陳威尹) authored
This amends https://crrev.com/c/1740169. Bug: 982018 Change-Id: Id87a65a89a5f9be24fa6c465635f60048984ffde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762948Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#688989}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/795a3ae59002..3d4b95548ef4 git log 795a3ae59002..3d4b95548ef4 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 rsmoore@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@3d4b95548ef4 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Bug: None Change-Id: I0d8f538a889385164d271447e1be09d5c4e29760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763935Reviewed-by:
-
Ovidio Henriquez authored
This change implements the getAvailability() method for navigator.bluetooth as defined in the specification. Bug: 707640 Change-Id: I9e9b3e7f8ea7f259e975f71cb6d9570e5f04b479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651516Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#688987}
-
Mark Cogan authored
WebStateList has a mutation lock to catch code paths where a mutation (web state insert, close, etc) is executed inside an observer callback from another mutation. Per crbug.com/384263, such recursive calls can result in crashes from inconsistent state being advertised to observers. The bug for this CL is such a case, where under iOS13 in some circumstances when the pop-up blocker is enabled, a web state can load another web state that closes itself, activating the first web state which, as it appears, loads a third web state. Usually the underlying JS for this executes asynchronously, but it seems that in some cases under iOS13, WKWebView may call the WKUIDelegate callbacks synchronously. In that case, the web state delegate (which is the BVC) will insert a new web state into the web state list which is still mutating from the web state closing. This CL makes the simplest possible fix for this situation: it ignores the request to create a new tab if the WebStateList is mutating. It seems unlikely that any legitimate web site will induce this behavior, and the mitigation mimics the effects of the pop-up blocker in any case, so there's not much room for a poor user experience. Bug: 988504 Change-Id: Ib1edf56f44b8f8b288f66cd909e7a0448072ce48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742167 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#688986}
-
Jan Wilken Dörrie authored
This change implements a small documentation update to the proto used to talk to the leak detection API endpoint. Bug: 986298 Change-Id: If768bf0cef0913b74603da684a20fcb7d2d61fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763422Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#688985}
-
Eric Lawrence authored
The XSS Auditor has been removed from Chromium. Remove further references to the Auditor. Bug: 968591 Change-Id: I6bd0052a364d8387e2263f9ed9041383c4f9d463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758431Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688984}
-
Fredrik Söderquist authored
Performing the instance element mapping/unmapping in AttachLayoutTree/DetachLayoutTree means we don't map element that don't get attached/a LayoutObject. This means that any mutation of such an element can leave the tree in an inconsistent state causing mayhem at a later time. Perform the mapping directly after the shadow tree has been built instead with the corresponding unmapping being performed when the shadow tree is torn down. Introduce a new method DetachShadowTree for the detach operation and rename BuildShadowAndInstanceTree to AttachShadowTree for the symmetric attach operation. CloneNonMarkupEventListeners gets renamed to PostProcessInstanceTree and gets to host the actual mapping. Relocate/rename SVGElementTest (to SVGUseElementTest) since all the tests are for shadow tree invalidation which is a SVGUseElement thing. Bug: 953263, 986114 Change-Id: I009d9c10549eee489c722c13bdcf91adffa5f5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755912 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688983}
-
Bill Budge authored
- Uses mojo_base::BigBuffer instead of std::vector to avoid unintentional copies of cache metadata. These copies can be slow. Bug: chromium:992991 Change-Id: I2cd3a7716e7141f263927dac17b50aa990716119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759683Reviewed-by:
-
Adithya Srinivasan authored
InvalidateFrameOwnerElement normally gets called after a navigation commits or if WebFrame::Swap is called, both of which don't happen when we adopt a portal. Bug: 994271 Change-Id: I412db2c78bf49c9784589a765292642165e3c953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757877Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#688981}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82fe763e130f..a622f6d5b9ae Created with: gclient setdep -r src-internal@a622f6d5b9ae The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I854bb55654c54c8d9f52ed64435ba215db580848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763933Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688980}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/362a1e0fab59..80bff5b3a2d7 git log 362a1e0fab59..80bff5b3a2d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 robertphillips@google.com Remove GrProxyPendingIO Created with: gclient setdep -r src/third_party/skia@80bff5b3a2d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I5959fca9b09f719546e7fe11d43e28ac11f2bf96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763932Reviewed-by:
-
Vadym Doroshenko authored
1.Removing function IsElementAutocompletable. 2.Using range-based for. Bug: 875768 Change-Id: I5d6ac8dbd554d79bce6c92480722ac4a1c14a3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752832 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688978}
-
Alex Turner authored
Modifies OnDidLoadResourceFromMemoryCache to use a NetworkIsolationKey (NIK) from the browser instead of a top-frame origin from the renderer. Additionally modifies NotifyExternalCacheHit's signature to use a NIK. Bug: 992923 Change-Id: Ifd8ffb9b1d3197bd7f8ee8b9783c8d192be22a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756162Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#688977}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to serial.mojom in //third_party/blink/public/mojom/serial/serial.mojom. - Replace SerialServicePtr with mojo::Remote - Replace mojo::Binging with mojo::Receiver - Apply device.mojom.SerialPort to pending_receiver<> in GetPort of SerialService interface Following CL will continue migrating serial.mojom and related classes to the new Mojo types. Bug: 955171 Change-Id: I05c50c63f6e270f3f54b0c3b34a34eec455d0380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757987Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#688976}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b27516ba774..d4aa37b83f64 git log 3b27516ba774..d4aa37b83f64 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 primiano@google.com Roll clang + fix run_android_test Created with: gclient setdep -r src/third_party/perfetto@d4aa37b83f64 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ida7ae10f73e7d585874b2c40eaf68fb3d067d976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763930Reviewed-by:
-
Javier Ernesto Flores Robles authored
Remove ios/chrome/browser/ui/autofill/autofill_edit_accessory_view.h which was a simpler version of form_input_accessory Isolates a pure UI target for form_input_accessory, which can be reused with other controllers. Notable UX changes: - iPad will now have a close button. - A11y labels will read "Field" after "Previous" / "Next". Bug: 976675 Change-Id: Ieaad289a7b7b6af208a0c9f43eb285925f136f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760919 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#688974}
-
Rafał Godlewski authored
Implements credential leak desktop dialogs for all possible scenarios defined in mocks. Bug: 986317 Change-Id: I25cfbd8a7cee7661196ef25a895ae2f47762195c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760221 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
-
Yann Dago authored
Bug: 995950 Change-Id: Ic7303f74f612efcbce0993dc098a1f138441ebac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762340Reviewed-by:
-
Mugdha Lakhani authored
to note whether or not any relevant sync events were fired as a result of waking up Chrome. Bug: 995795 Change-Id: I2e0da8c3df47c3e558264314a1c3aec22f451cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762237 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688971}
-
Maksim Moskvitin authored
Instead of passing Cryptographer to Directory during its initialization and storing the pointer to it forever, we now forward calls of GetCryptographer() from Directory to NigoriHandler. GetCryptographerUnsafe() was removed from SyncEncryptionHandler, but we still needs its analogue in testing code. Bug: 922900 Change-Id: I9ad8e3defd2cddbe759b4706f2f5cb64161dd0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763688 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688970}
-
Yaron Friedman authored
We've dropped support a few milestones ago. BUG=923477 Change-Id: Icba4c86f6fceece575bfb83ee0615c3ff8ca8e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761225Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688969}
-
Stepan Khapugin authored
It seems like the gesture recognizer was used to have a "button with a hole" on the site info's background. This worked, but was not accessible to voiceover. Probably a button was impossible to use in the past. This CL replaces the gesture recognizer with a regular button, and the "hole" is made by setting userInteractionEnabled to YES on the actual content. Also adds support for the a11y escape gesture. Bug: 979789 Change-Id: Ib29318232ef216c1134f16e69c1e0e39cf5a099a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763417 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#688968}
-
David Jean authored
Make sure openTabWithContentOfDistantTab isn't called while in incognito. Bug: 989487 Change-Id: I5bb06dc3ad9b386a9f1b4c31790062dd356bf6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732102Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Vladislav Kuzkokov authored
Replaced ' with " in test data and removed that replacing from NormalizeJson(). Removed NormalizeJson() calls that are now unneeded. Also, Replaced base::JSONReader::ReadDeprecated() with base::JSONReader::Read(). Change-Id: Ia42395c168e454d0f4bc07817df1c69fe86f6463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753830 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#688966}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/73ab90bd..4aa6251e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I38934a90242331dc89df42336f3b0ab3c049322b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763868Reviewed-by:
-
Ramin Halavati authored
The comment for Profile::IsOffTheRecord is cleared up to make it more clear that IsOffTheRecord covers both incognito and guest modes. Bug: 3333 Change-Id: I939df26324913eb82d3f9ee7cd5c878cebed2dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763415Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#688964}
-
Tanisha Mandre authored
- Implement Credit card scanner view & view controller as a subclass of QRScanner. Bug:986275 Change-Id: I88f66712f7fde049f582d4fc513906949d29888c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712879 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#688963}
-
Thomas Tangl authored
Bug: 966388 Change-Id: I626ea81498c8b3b2751da06996f510f4557cd1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757932Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#688962}
-
Yasmin authored
"Update" method will be reused by Shared Clipboard later. Bug: 988461 Change-Id: I5e1d6e04a682b28186683db74783839dc1ace5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762226 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18868b8f3d5f..82fe763e130f Created with: gclient setdep -r src-internal@82fe763e130f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I0dbb485892eb0e1033c3d860273c673d1910b97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763330Reviewed-by:
-
