- 25 Nov, 2019 40 commits
-
-
Xiaocheng Hu authored
This reverts commit f6953a5e. Reason for revert: Manually destroyed the dummy page to ensure no leak Original change's description: > Revert "Sanitize style elements in clipboard markup" > > This reverts commit d96236b5. > > Reason for revert: This may cause "WebKit Linux Leak" failure > First failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/7276 > > Original change's description: > > Sanitize style elements in clipboard markup > > > > This patch sanitizes clipboard markup before pasting it into document > > by removing all pasted style elements and serializing them onto > > elements as inline style. In this way, we stop stylesheets in clipboard > > markup from being applied to the original elements in the document. > > > > This patch follows the same approach as in WebKit [1]: > > - First create a dummy document to insert the markup > > - Then computes style and layout in the dummy document > > - Re-serialize the dummy document as the markup to be inserted. This > > reuses the code path that we serialize a selection range into > > clipboard, where we need to serialize element computed style into > > inline styles so that the element styles are preserved. > > - Make sure all style elements are removed before inserting markup > > into document > > > > This patch also adds a complete test to ensure that content pasted from > > Excel is still properly styled, which is the main reason we used to > > preserve style elements in clipboard markup [2]. > > > > [1] https://trac.webkit.org/changeset/223440 > > [2] http://crbug.com/121163 > > > > Bug: 1017871 > > Change-Id: I3bb5a4ae7530a3fdef5ba251975e004857c06f1e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922919 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718281} > > TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1017871, 1027386 > Change-Id: I1d500647d6227c9be3ae14d9604ba702e9c29834 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933452 > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718778} TBR=yosin@chromium.org,tkent@chromium.org,zmin@chromium.org,xiaochengh@chromium.org Cq-Include-Trybots=luci.chromium.try:layout_test_leak_detection Bug: 1017871, 1027386 Change-Id: Ia56ee941979cad71e2bac06998c7ac417b4731bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934650Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#718896}
-
Sahel Sharify authored
This cl enables web based payment handlers on Android to notify the merchant about shipping address/option changes and wait for updated payment details. Bug: 984694 Change-Id: I2dec41e5d3b8b2a8628c9fa22ee1feb5e5a161fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932894 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718895}
-
Tao Bai authored
Related downstream change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2172237 Binary-Size: all added code was from downstream, the size increase is expected. Bug: 951275 Change-Id: Ibf56135e2a7d2f437f167dc0cdb7761bce447e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922603Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#718894}
-
Ahmed Mehfooz authored
This change removes a previous feature which caused system priority notifications to pop back up even if the system tray was opened and closed. Bug: 1007031 Change-Id: Iddf1f233cd20c256db2a48adf025881bf511a717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929448 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718893}
-
Jay Harris authored
The Cinnamon Desktop Environment requires file handlers to specify a %F argument to specify where file arguments should be placed. Other DEs (such as Plasma) don't have this restriction. The fix is to (conditionally) append a '%F' argument to the command line of web apps with file handlers. If the argument is added unconditionally all web apps will show up as options in the 'Choose Another App' dialog, which is undesirable. Bug: 1027994 Change-Id: I89f882c0854b3ee313fce6eea1845052a884c173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933683 Commit-Queue: Jay Harris <harrisjay@google.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#718892}
-
Ben Goldberger authored
Bug: 1027273 Change-Id: I86bd7a8ea15197bf31ebbc163897c5455f8823de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929648 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718891}
-
nancy authored
Similar with AppServiceAppResult, AppServiceAppItem should use ChromeLauncherController's ActivateApp to activate apps, the same as ExtensionAppItem: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_item.cc?q=ActivateApp&l=155&dr=C BUG=1026730 Change-Id: I28fd19df903422092052c1a33cb42682bbcf6560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933856Reviewed-by:
-
Jonathan Ross authored
The root cause of the Intel AMD failures has been addressed. I'd like to try re-enabling this. TEST=context_lost tests ContextLost_WebGL2Blocked Bug: 1008125 Change-Id: I96ccdc26e0468a384810530e10c684738699a412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934689Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#718889}
-
Kevin McNee authored
Portal contents are restricted to http(s) schemes. Since the host contents may be adopted into a portal, it should be subject to this restriction as well. It may be that we end up allowing non-http(s) schemes to create portals, but have them be unadoptable, but for now it's simpler to use the same restriction. If we do weaken this restriction, we would still want to prevent portal creation in about:blank, since this is not useful and involves unnecessary complexity. Bug: 1008992 Change-Id: I297ec36341912247d0d96833c2a5b08bff9e255c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853905 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718888}
-
Jeremy Roman authored
We're consistent about this elsewhere in chromium, and indeed elsewhere in many of these browser test files. Change-Id: Id05ac63ef4ac1c3983e38fc16ef5072966690724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934393 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718887}
-
Erik Chen authored
The test suite takes 27 minutes to run with only 40 seconds overhead. It's the slowest test suite on linux_chromium_asan_rel_ng, which causes long cycle times. Bug: 1028289 Change-Id: Ib82100928d89e29747a8794f62eccc09cf27aae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932475 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#718886}
-
Wenbin Zhang authored
Currently no bot can be found for linux-perf-fyi builder. The reason is that the only one linux device in the pool has the OS version as 'Ubuntu-14.04' However, while there's no specific os dimension value defined in perf_data_generator.py, a default value 'Ubuntu-16.04' from the infra was used to look for a bot. As as fix, we now specify the os value 'Ubuntu-14.04' in perf_data_generator.py so that it will override the default and be used to look for the correct bot. Bug: chromium:1027147 Change-Id: Ib59d881c9aceecf6a4aa6e3710bc3219f07b990c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931144 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718885}
-
Jesse Schettler authored
Update IsColorModelSelected() to check for all color modes. Change-Id: I61b4922e1ddb6b9a3f906b9122b1ca4f29c8272e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901835Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#718884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e8f39ab95539..9f65850fd60b Created with: gclient setdep -r src-internal@9f65850fd60b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028032,chromium:None,chromium:None,chromium:1024586,chromium:1026286,chromium:None Tbr: jbudorick@google.com Change-Id: I365681c609fdbd9d133e249cabb07d065f6f56db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934690Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718883}
-
Tommy Li authored
This enables tabbing to the Remove Suggestion X button, and pressing Enter or Space to trigger it. This also shows the X for the selected row, in addition to any mouse-hovered rows. This also shows a blue focus ring for the X, when it gets the keyboard focus. That may not be the final UX design. Bug: 1205 Change-Id: I6e2e175841d293d81306cec86a11d60a77edfd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931581Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#718882}
-
Trent Apted authored
It had some layering workarounds in the past for cocoa, but it can now be a component for better code health. Bug: 828273 Change-Id: Iaa84cc4cdbb466ba696b7322e6f7f7d6ab914002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933827Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#718881}
-
Alex Newcomer authored
This CL disables a flag which controls a few features: - The shelf hotseat - Modular UI which shows in tablet mode, shows pinned and active apps. - In-app shelf - Smaller shelf in tablet mode. - Dense shelf in clamshell mode - Smaller shelf in clamshell mode for certain displays. Punting all of these feature to M-81! Bug: 1027343 Change-Id: I302523d7d1938c9166a0e61c07792d8d9c6a8439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929101 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#718880}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a9f2684b. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I48a228ec2adc830b3698931aa9ef622c35be7457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932093Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718879}
-
David Black authored
Extends ProactiveSuggestionsView as the implementation of the entry point that is shown when the new "show-rich-entry-point" feature param is enabled. Note that this view hosts embedded web content and is currently stubbed. Follow up CLs will: - Replace hard-coded HTML w/ server provided HTML. - Parameterize corner radius. - Handle navigation attempts. See bug for screenshots. Bug: b:145056104 Change-Id: I17be0951e707317b4903b185043c41f17deebe5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932463 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#718878}
-
Avi Drissman authored
This allows us to remove the use of a private API. Bug: 1027401 Change-Id: I1cd0e236fdb4ded2093a4120a0af326b57d9efd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929848 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#718877}
-
Daniel Murphy authored
This change does some renamings to match the terminology outlined here: https://chromium.googlesource.com/chromium/src/+/master/content/browser/indexed_db/docs/README.md It also adds more comments to the IndexedDBActiveBlobRegistry, and splits up the method MarkDeletedCheckIfUsed into: * MarkDatabaseDeletedAndCheckIfReferenced * MarkBlobInfoDeletedAndCheckIfReferenced and changes the following methods to be more accurate: * AddBlobRef -> MarkBlobActive * RemoveBlobRef -> MarkBlobInactive Future CLs will continue renaming parts of the system to match the new README. Work planning doc: https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?pli=1#heading=h.wwk24xdiduw5 R=enne@chromium.org Bug: 1027737, 1024966 Change-Id: I3f569bad802e64eee2ccf55cacafbb170f099d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912828 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718876}
-
Kevin Qin authored
XRVisibilityState is always visible when using the OpenXR backend. The visibility state from the runtime needs to be plumbed back to Blink/Javascript. Fixed: 1024032 Change-Id: I98bb2f3e5440b407dfff97a8799c3fecc15f7a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913578Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Zheng Qin <zheqi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718875}
-
Stuart Langley authored
Because the SMB provider does not react to prefs changes, the only way to test disabling Native SMB is to disable the pref and restart the browser test. To do this, introduce a derived FilesAppBrowserTest that uses PRE_ to support setting the SMB provider preference and then restart the browser for it to take effect. Bug: 1027966 Change-Id: I3e9199d4505be145de1eede0254bc1ecf0f8fe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933840Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#718874}
-
Owen Min authored
Disable the test because it's flaky on ChromeOS Bug: 1028319 Tbr: tbarzic@chromium.org Change-Id: I8f3abdd4ea0b2ed8cd485a31cd622e213aed4c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933204Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718873}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/34e5a96edc3e..8dfc2b05d987 git log 34e5a96edc3e..8dfc2b05d987 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 jmadill@chromium.org Update codegen presubmit error. 2019-11-25 lehoangq@gmail.com Metal: support ANGLE_instance_arrays/EXT_instance_arrays Created with: gclient setdep -r src/third_party/angle@8dfc2b05d987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I505408e60bb467eb193324bd7314f5ca76dc8e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718872}
-
Erik Chen authored
browser_tests has a runtime that varies from 12m to 18m, with overhead of 1m. By increasing sharding from 30->40, we're keeping overhead below 10%, which reducing runtime by ~5 minutes. content_browsertests has a runtime of 18 minutes, with overhead of 40s. Increasing sharding by 2x maintains an overhead of less than 10%, while reducing runtime by ~9 minutes. These changes, in addition to sharding improvements to sync_integration_tests [see https://chromium-review.googlesource.com/c/chromium/src/+/1932475] should yield a ~15 minute improvement to cycle time of the builder linux_chromium_asan_rel_ng with minimal impact on fleet capacity. Bug: 1028289 Change-Id: I11a212f6a349d9bc30c80ec45a22be54fb8f5d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934395 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0ab6a9f6e41a..5504dc6427fb git log 0ab6a9f6e41a..5504dc6427fb --date=short --first-parent --format='%ad %ae %s' 2019-11-25 ehmaldonado@chromium.org depot_tools: Add ehmaldonado@google.com to OWNERS. 2019-11-25 ehmaldonado@chromium.org depot_tools: Run roll_dep tests on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@5504dc6427fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1009816 Tbr: agable@chromium.org Change-Id: I02a114e3f6c1f3530703b573bdb5ed0e7ee2b402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934262Reviewed-by:
-
Karan Bhatia authored
Introduce RegexRulesMatcher which evaluates all regex rules within an extension ruleset. RulesetMatcher combines the results from ExtensionUrlPatternIndexMatcher and RegexRulesMatcher and is an abstraction over the complete ruleset. RegexRulesMatcher uses the FilteredRE2 class from the re2 library to achieve fast matching of a set of declarative regex rules against a request. BUG=974391 Doc=https://docs.google.com/document/d/1mRErUMII_gSSPaHmxyn31UOYWUaZLj0xOaezekxD2-Y/edit?usp=sharing (Internal only) Change-Id: I82d70fcf381aeec1d5a93af33a36db41e4704608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892132 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#718869}
-
Owen Min authored
Disable the test due to flaky. Bug: 1028336 Tbr: sky@chromium.org Change-Id: Ibef486c36b878b75a6708b1e567d4f64b1e0cd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934317Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7b29abfc486e..e7ce4e53915d git log 7b29abfc486e..e7ce4e53915d --date=short --first-parent --format='%ad %ae %s' 2019-11-25 cwallez@chromium.org Make GN builds produce an ICD JSON in the build dir 2019-11-25 chrisforbes@google.com Add missing vkCmdSetLineStippleEXT function Created with: gclient setdep -r src/third_party/swiftshader@e7ce4e53915d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/144183516 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9b50cfa7472122c874b301de66332e4173a0196d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934609Reviewed-by:
-
Ted Meyer authored
Stop displaying [Object object] in the log now that we're sending objects instead of strings. Bug: 794255 Change-Id: I4d64fb6e717db1660fac87afc343a1097b080768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934781Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#718866}
-
Taylor Bergquist authored
Bug: 999557 Change-Id: I8103c69044a8979f2debe1626646e41e3e616b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929975Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#718865}
-
W. James MacLean authored
Test if embedder WebContents has page focus when test fails. TBR=alexmos@chromium.org Bug: 1024672 Change-Id: Ieff2034984cd895336fa9978943c83f17cd27f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934828Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Change-Id: I5c65dd768291fd416d9b3537f76c61bc798fac6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931441 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#718863}
-
Tomasz Wiszkowski authored
Regular rich entity suggestions come with a description line (eg actor, movie etc), but Local entity suggestions may not include this detail, generating an odd-looking suggestion that reserves space for a line that is never filled in (eg. Starbucks). Bug: 1025342 Change-Id: Iff2d4ba7150deb0b29ccf4f4961f8eccb379615a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919733 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#718862}
-
Jonathan Ross authored
This reverts commit 0a8abb25. Reason for revert: Per crbug.com/1008567 we would like to confirm if this test still exhibits flakiness. We are re-enabling in order to find out. Original change's description: > Disable CrossSiteSubframe/DragAndDropBrowserTest.DropValidUrlFromOutside/0 on Linux > > CrossSiteSubframe/DragAndDropBrowserTest.DropValidUrlFromOutside/0 has begun > flaking on Linux with SkiaRenderer becoming enabled by default. This test has > previously flaked on Windows. > > I'm disabling it until the root cause of the flaking can be fixed > > TBR=lukasza@chromium.org > TEST=CrossSiteSubframe/DragAndDropBrowserTest.DropValidUrlFromOutside/0 > > Bug: 1008567 > Change-Id: I3d18c0b8a2f2fddfe6e383175f53638c78cf985a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828119 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700474} TBR=jonross@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008567 Change-Id: I02a71c2c23eabcf6e38a74611757336096f37f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934786Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#718861}
-
Andrew Luo authored
Bug: 1027813 Change-Id: I4791cbe2dd901edf3eace0777ef86f1d45c2c531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933889Reviewed-by:
-
David Black authored
ProactiveSuggestionsView will serve as the base class for both the new ProactiveSuggestionsSimpleView and a new ProactiveSuggestionsRichView (which will be added in a follow up CL), the latter of which will present a rich, content-forward entry point affordance (gated behind a feature param). The ProactiveSuggestionsSimpleView is essentially the same, simple entry point affordance that is currently in the code base with shared logic left in the base class. Bug: b:145056104 Change-Id: I0618c6cfa23d50ae9063117477e2879794545bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932879Reviewed-by:
-
Dominic Battre authored
Bug: 1028095 Change-Id: I795aacd5211a9ba94f325c007698538dfa56000e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934627Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Kent Tamura authored
from double to base::Optional<base::Time>. This CL also changes a double argument of File::CaptureSnapshot() to base::Optional<base::Time>. This CL has no behavior changes. Bug: 988343 Change-Id: Ida6d0d415cc8f72d2c965bfd242b584080570791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933668 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718857}
-
