- 14 Jan, 2021 40 commits
-
-
Stepan Khapugin authored
Also fixes a potential race condition in a BVC animation, just in case. Fixed: 1163905 Change-Id: I5d0f900512b4620dff1b6499bd211f4f100a2cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626391 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843626}
-
Dave Tapuska authored
There are a series of messages that are relayed to the IO thread of the browser process. Add a new interface to handle these messages. FrameHostMsg_DidCreateInProcessInstance message is the first message to be converted. BUG=1157519 Change-Id: I11441cddcff8a09e1514091d9e6042f2e2bf01e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626181Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#843625}
-
Will Cassella authored
This CL removes the `blink::features::kAVIF` flag, since that has been enabled by default for a while, and this allows some code to be cleaned up considerably. The `ENABLE_AV1_DECODER` build option is still kept, so that AV1 support can still be toggled at compile-time. Change-Id: Ic6cd3608eaa69305fa1fdafb6137f9662c4fcd94 Bug: 960620, 1117843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625510 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#843624}
-
Toni Baržić authored
This reverts commit 3d1384d2. Reason for revert: The CL effectively removed the delay between items getting added to holding space and their preview showing up in the tray icon, leaving less time for the preview icon to get generated, and causing some jank (flash of empty white icon) during the tray icon visibility animation. Original change's description: > Don't animate holding space previews on initial show > > Adds a way to update holding space icon preview layer without an > animation, and utilizes it when the icon previews are first being shown > (i.e. when the list of previews is updated from an empty list). In this > case, tray icon will have it's own visibility animation, so there's no > need for running a separate bounce in animation within the tray icon. > > Also, updates how tray icon updates are scheduled - instead of updating > the tray visibility synchronously, and then scheduling a previews > update, the logic is changed to update previews icon synchronously, too. > (the throttling became less important now that additions of multiple > items to the holding space are done in a batch, instead of one-by-one). > > BUG=1166014 > > Change-Id: I3211672072262e9fff75b04a3316c6049099c749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627169 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#843358} TBR=tbarzic@chromium.org,dmblack@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I9f7445104feac5cacc1bc27e9aebe7f4bef091cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628382Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843623}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..94ca9a9578a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7ac5dd4f316d9157dd8818aa38af083d8a454a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843622}
-
danakj authored
When making a frame from the browser we will call into blink to make the WebLocalFrame, which will also create the core LocalFrame, then on return we will initialize the RenderFrame. So we have - Create RenderFrame - Create WebLocalFrameImpl - Create LocalFrame - Initialize RenderFrame This means that RenderFrame observers are told about the RenderFrame after the initial about:blank document is already created, so they see the RenderFrame created with it, and do not receive a notification about the about:blank document being created. But when the renderer makes a child frame the order is currently different, the RenderFrame initialization is done before creating the LocalFrame, which means observers see different events for these child frames and need to work around them. This brings the child frame path into alignment with the browser-initiated path and adjusts expectations in tests. The SubresourceFilterAgent no longer needs special case code to handle the initial about:blank document, and it sends its mojom message immediately on creation now. Its unit tests are adjusted to allow creating the filter for what appears to be a main/child frame without requiring an instance of RenderFrame. It also always constructs a filter for child frames at creation time as it did when hearing about the initial blank document before, which would have been only for child frames though the code is not clear about that intention before. MetricsRenderFrameObserver skips the first document which was because it would hear about the about:blank creation in child frames, but that would also make it skip the first non-initial-blank-document in main frames too. This is removed now. TBR=dcheng@chromium.org Bug: 1158869 Change-Id: I57050b251eea53979d8c546c9942430346a5aa74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601063 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843621}
-
Stephen Roe authored
Move test parameters from script arguments to json file. The tryjob fuchsia-fyi-arm64-rel build failure is expected. It does not affect CQ or CI. Bug: 1126177 Change-Id: I3b2c3458afcf9b1b2614b0d5fa7d3653c0e5c232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617052 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843620}
-
Colin Blundell authored
This CL incorporates Chrome's adjustment of subresource filter page activation decisions based on content settings within WebLayer. To do so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle directly invoke the logic in question rather than having ChromeSubresourceFilterClient do so. That change necessitates some others, also made in this CL: - WebLayer brings up ProfileInteractionManager. - SubresourceFilterClient provides an accessor for ProfileInteractionManager. - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment logic via a new Delegate interface rather than doing so via SubresourceFilterClient. This interface is implemented by ProfileInteractionManager in production while allowing for porting of tests that provide custom (or nil) stub logic. We also add browsertests of this interaction in //weblayer. Note that this CL does not do any incorporation of the relevant *UI* for content/site settings of ad blocking in WebLayer; that will be followup work. This CL is a reland. The original CL was reverted due to the introduced tests failing on Win7. On inspection this turns out to be the issue tracked in crbug.com/1152429. I'm continuing to investigate that issue, but it's slow going so far. In the meantime this CL disables the newly-added tests on Windows with a reference to that bug (see diff between PS1, which is the original CL, and PS2). Bug: 1116095 Change-Id: I8dc8f3a2e08a58e91050cf9b484685ee4982f16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627166Reviewed-by:
-
Piotr Pawliczek authored
After last modifications, the information about number of print servers loaded from policies is not reported correctly. This patch fixes this. BUG=none TEST=tested on my kappa device Change-Id: I0bcbd3087393d48f958c8dba2cfaca301e9593a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628654 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#843618}
-
Hirokazu Honda authored
VABuffers are created for each bitstream in AV1Decoding. This CL applies the buffer reuse optimization (b/166646505) to av1 decoding though buffers for slice data are not reused due to b/177028692. Bug: b:166646505,b:175897723 Test: video.DecodeAccelVD.av1* video.DecodeCompliance.av1_test_vectors Test: video.Play.av1_hw* video.Seek.av1* video.MemSeek.av1* Change-Id: Id70b49bf3dd49d098b559286d0f01c2fe3a11ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615727Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843617}
-
Mathias Carlen authored
Bug: 1165010 Change-Id: Iaa5050cc6341e5319bc8b8391192139862455a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627163 Auto-Submit: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#843616}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6d32fb19b043..65c824b5adc9 2021-01-14 jacktfranklin@chromium.org Create Node version of devtools_paths.py 2021-01-14 janscheffler@chromium.org [Recorder] Keep focus on the inspected website 2021-01-14 janscheffler@chromium.org [JSDOC2TS]: Migrate changes 2021-01-14 tvanderlippe@chromium.org Move ordered merge and intersect into array utilities If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1158760,chromium:1166572 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I483798a02c5f434bb888ebf116e2d95e58815011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629667Reviewed-by:
-
James Cook authored
We have a large library of existing window frame tests that are currently skipped for lacros. Many of these tests have sections that exercise tablet mode. They will be easier to port to lacros if we provide a test API for tablet mode. Add a crosapi for entering and exiting tablet mode. Add a basic smoke test, which is basically a clone of the overview mode test. Bug: none Test: lacros_chrome_browsertests Change-Id: I04eb60db33b446df75a509836b2e408fc5018569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625815 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843614}
-
Jan Wilken Dörrie authored
This change adds a self check to ChromePasswordManagerClient::OnPaste before dereferencing members. Bug: 1161147 Change-Id: Ic36e5882d43bc3eae87c82e4d021cffca7ec8900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628950 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#843613}
-
Adithya Srinivasan authored
This reverts commit 7d29603f. Reason for revert: Causing test failures, see https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76551/overview for example Original change's description: > Expose NameProperty for listitems on UIA > > Elements with the listitem role should always expose their accessible > names with UIA. This was causing an issue with Narrator on Windows when > navigating by list item - Narrator would only announce "element x of N" > when it should actually announce "[listitem name], element x of N". > > This is per spec: https://docs.microsoft.com/en-us/dotnet/framework/ui-automation/ui-automation-support-for-the-listitem-control-type > > Bug: N/A > Change-Id: I4f2d1a999d00cc8f5b23989d3ade90c907764152 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610264 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#843553} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org,kschmi@microsoft.com,vicfei@microsoft.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,benjamin.beaudry@microsoft.com Change-Id: I2857f2e0621a9c6bef99ba14c5c2a7129c033660 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628066Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#843612}
-
Robert Ogden authored
Histograms that are also recorded in UKM are only made local for ease of continued testing. The other histograms are removed in code. Bug: 1165102 Change-Id: Ie2eefc8cfaea777a7b381b11f667c85dd694ab44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622429Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#843611}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/e59ae1af7571..4c6cbd7a1be7 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from cec658c11603 to b2cfc5d1ceca (1 revision) 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f5dea94f6f15 to 586c46b96b62 (1 revision) 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a3b988fa5588 to c86cec54abe6 (1 revision) 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04b58c5bea3a to f5dea94f6f15 (1 revision) 2021-01-13 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7bbe1a316419 to cec658c11603 (2 revisions) 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from be70e017bff5 to a3b988fa5588 (1 revision) 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 61a57c023e10 to 04b58c5bea3a (1 revision) 2021-01-12 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c32277c0ba0d to 7bbe1a316419 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a7825740f316 to be70e017bff5 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 645a15bbaa59 to 61a57c023e10 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 46237b593c3f to 645a15bbaa59 (1 revision) 2021-01-11 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f3ccb633dfd7 to c32277c0ba0d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com Change-Id: I74c13911ac522aaa480f8929bec7a8b0232d8fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628379Reviewed-by:
-
Robert Flack authored
Specifically extend: - Event.Latency.ScrollUpdate.Touch.AverageLagPresentation.PredictionNegative - Event.Latency.ScrollUpdate.Touch.AverageLagPresentation.PredictionPositive There is ongoing work to improve scrolling prediction which will benefit from having these heuristics to gauge improvements on. Bug: 1165055 Change-Id: Ia01705af79ea0566a2236f30c1b0e2657ecf2e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628136Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843609}
-
Tanya Gupta authored
Broke LongScreenshotsEntry into entry logic and bitmap generation logic for a cleaner separation. Also added logic to propagate errors. Bug: 1153969 Change-Id: Ie81a7ab8fc8c368f11127d219b37101d62ee61f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622055Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843608}
-
Marijn Kruisselbrink authored
This adds a (default enabled) feature AppCacheAlwaysFallbackToNetwork, when enabled chrome will behave as if every manifest file included a NETWORK: * line, indicating that all requests should fall back to the network. Bug: 1152226 Change-Id: I02f126a91d7061183274a66ad759cde58da533cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594235Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843607}
-
Christoph Schwering authored
This CL adds two features which, if enabled, suppress filling and form import. Bug: 1166660 Change-Id: Ia4e29345be0a1f638bb3650d7baf1bde9dc35fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627164 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#843606}
-
Alex Keng authored
This CL enables English typing for EditContext by redirecting inserted text in Editor::HandleEditingKeyboardEvent if EditContext is active. A test is also added in edit-context.html. Change-Id: I0c63371385556869ab71652d6857d18d985260d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626528Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843605}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: Ic40f0d0e22d59db4b6594f10dfb06b8853db3d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598741Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#843604}
-
Mila Green authored
Bug: 1144151 Change-Id: I3608831c649150220385d592f4b8185d6e94692f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627775 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843603}
-
Xianzhu Wang authored
This reverts commit edf0c2bf. Reason for revert: The CL that caused the failure has been reverted. Original change's description: > Disable failing background-attachment-local-scrolling.htm > > TBR=pdr@chromium.org,wangxianzhu@chromium.org > > Bug: 1166540,1046544 > Change-Id: I37ae96bb63da98c90fd85875742b5c76abf34e7b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628948 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843444} TBR=andypaicu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iad302719be50e7aaf3915a0816009cd0cf43fba3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166540 Bug: 1046544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628384Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843602}
-
Clark DuVall authored
This CL avoids loading the weblayer split in child processes, which should have a positive performance and memory impact in the field once isolated splits are enabled. This requires moving the child process code/aidl into the base module. Bug: 1146438 Change-Id: Ie79dcfb1e9fc39a4117ebf7cdd9b80f333009f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628649Reviewed-by:
-
David Bokan authored
Specifically, DidScalePage was expiring and is extended until M97 as this is likely to be useful related to some questions of Double-Tap zoom and Desktop vs. Mobile optimized pages. The other histograms are related and likely to be helpful in this context too so I extended them all to the same milestone. Bug: 1165202 Change-Id: I6425d9930371ec66d72b469544fae409cff4b77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627756 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I9e0a1e799c205728784e6dbfb1cc9c2bf67c8575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626782Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843599}
-
Ilya Nikolaevskiy authored
See discussion in crbug 1155426 for details. Changes: MediaStreamCaptureIndicator::UIDelegate: Ignore multiple calls to OnStarted(). TabSharingUIViews: Unconditionally execute clean-up tasks in destructor. MediaStreamUI and contents::MediaStreamUI: Now has SetStopCallback method which is used to remove the stop callback when MediaStreamUI is replaced on switching the tab source. Bug: 1155426, 1166260 Change-Id: I0482c82f921fdc2f20931ab83458deec2f2da30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629278 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843598}
-
Curt Clemens authored
In the contact visibility dialog with "Some Contacts" selected, the toggle list for picking individual contacts was missing aria labels for the cr-toggle-buttons. Those are now added so that tabbing through the list correctly announces what the toggles represent. In the device name dialog, the help text underneath the cr-input had low contrast. The color of that text is now darkened to google-grey-700 to push the contrast ratio up to ~6.5. Fixed: 1165926, 1165977 Change-Id: I6a8c985ac9e264c0a4249cd314d28cc5e63c5a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628076Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#843597}
-
Curt Clemens authored
The receive confirmation page uses <nearby-progress> with "progress=0" to show a device preview while hiding the progressbar. This mostly works, unless there is an error, in which case the progress bar is shown in red at 100%. This CL allows explicitly turning off progress so that is is not shown regardless of the error state. Use "--iron-icon-fill-color" in <nearby-progress> instead of "color" to set the device icon color, since the "color" property was getting overridden. Finally, grey out the <nearby-preview> on the receive confirmation page when there's an error to match the behavior on the send confirmation page. Screenshot: https://screenshot.googleplex.com/4Nxb6o9tThi3obQ.png Bug: b/163036847 Change-Id: Ibda918fb3fb5c54f7c9c98f9b31f5edaf083e16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622900Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94ca9a9578a7..320b6dfbe5e4 2021-01-14 fmayer@google.com Merge "Move CanProfile to src/profiling/common." 2021-01-14 fmayer@google.com Merge "Allow to start secondary heapprofd." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id042f389b359ecc429a95f61ce1bf025e1a35232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629647Reviewed-by:
-
Lutz Vahl authored
This is a roll-back to 8.9.255. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org,vahl@chromium.org,hablich@chromium.org Binary-Size: Increase is temporary. Change-Id: I80b1acc551a11483664699717635ad5c4790beca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627326 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Lutz Vahl <vahl@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#843594}
-
Monica Basta authored
The local profile name is strongly tied with |IsUsingDefaultName|, missing to update |IsUsingDefaultName| can lead to unexpected displayed profile name in the profile menu. Therefore this CL adds it as a parameter to |SetLocalProfileName|. This CL fixes the bug 1165914 except one corner case. The transition between a default local profile to a profile name equal to Gaia name does not lead to a change in the displayed name of the profile in the profile menu, as a result 'OnProfileNameChanged' won't be triggered. The profile state is then not updated on the picker, another observer needs to be added to fix this issue. Expectations for the profile menu after this CL: * If local profile name == Gaia name: 'Gaia name' * Otherwise (such as Work, email): 'Gaia name (Work)', 'Gaia name (email@user.com)'. Bug: 1165914 Change-Id: I296504fa015890d5933a399e3110da4546fba8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627396 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843593}
-
Xianzhu Wang authored
This reverts commit 6f895b07. Reason for revert: The reverted CL is supposed not to affect production, but it seems to cause crbug.com/1166540. Original change's description: > Add CullRect::ApplyPaintProperties() > > It will be called to map a cull rect from parent space to local space > in cull rect update during PrePaint. The purpose is to mark PaintLayers > needing repaint on cull rect changes before paint, instead of checking > interest rect / cull rect changes during paint, to avoid setting > PaintLayer needing repaint unnecessarily, especially for CAP during > composited scrolling. > > Besides the original features of CullRect::ApplyTransforms() which is > used in cull rect mapping for CompositeAfterPaint, it also implements > the following features to be on par with CompositedLayerMapping:: > ReComputeInterestRect(): > > - Considering clips in additional to scroll clips, > - Clipping expanded cull rect by scrolling contents rect for composited > scroll translations, > - Clamping extreme geometry values, > - Adaptive expansion distance for composited transforms. > > The next steps are: > 1. Add CullRectUpdater which updates cull rects during PrePaint when > runtime feature CullRectUpdate is enabled. > 2. Use the updated cull rect to replace interest rect in pre-CAP and > cull rect in CAP and pre-CAP, still behind the runtime feature. > 3. Enable CullRectUpdate for CAP > 4. Enable CullRectUpdate for pre-CAP. > 5. Remove old interest rect / cull rect code. > > Bug: 1046544 > Change-Id: I6e7e9f85bc0b4640e67de1732744e647b6f7e230 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620090 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843304} TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idc3374d3d426b9f571e417b1acbbc18227fdf274 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046544, 1166540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628021Reviewed-by:
-
Adithya Srinivasan authored
Looks like this wasn't disabled correctly the first time. Disabling for real (and also added OS_ANDROID due to large number of flakes there). Bug: 1156218 Change-Id: I2b308bf11505b1081ac9c3f88676bcc61e65fb38 Tbr: arthursonzogni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627716Reviewed-by:
-
Sophie Chang authored
This is a reland of 1a291df2 Original change's description: > Re-enable PredictionManager browser tests on Win/Mac/CrOS > > And fix init issue on ChromeOS for sign in profiles > > Change-Id: I26b87d58f2eae2afecf67685690312a8aed70c60 > Bug: 1146151 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625157 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843176} Bug: 1146151 Change-Id: Id9b0353b3f5e7d5ffc3d27f68aec612efad4e68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626985Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843590}
-
Alice Wang authored
This CL disables the flaky test FirstRunIntegrationTest#testExitFirstRunWithPolicy. Bug: 1166585 Change-Id: I83ce1d787b894fbfcb00d61b4cf4477729e461cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628953 Auto-Submit: Alice Wang <aliceywang@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843589}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d46475f87758..628b7f61f813 2021-01-14 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-14 saklein@chromium.org cbuildbot/commands.py: Fix for python3/encoding issue. 2021-01-14 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-14 inglorion@chromium.org cros_setup_toolchains: build post-cross packages after others 2021-01-13 pwang@chromium.org For *-borealis run suite:av-analysis_trace_per-build 2021-01-13 jwata@google.com Remove ISOLATESERVER from lib/constants.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2ec6cfc8434c5aef685ac0ddc6d67bb8a198dc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628601Reviewed-by:
-
Olivier Robin authored
Unittests trigger some shutdowns and SessionService is not built to handle multiple shutdowns correctly. Bug: 1166186 Change-Id: Ic3b1ca9b68af7d8b02eafed588b308f5f78c5610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627277Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843587}
-
