- 19 Sep, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7159b782fa4e..a77739404157 Created with: gclient setdep -r src-internal@a77739404157 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia153ab59bf5132f53b29d75e6048f34f5f99a58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812179Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697925}
-
Miyoung Shin authored
This CL converts TimeZoneMonitorRequest and InterfacePtrSet<TimeZoneMonitorClient> in services to the new Mojo type. Bug: 955171 Change-Id: I87cbe6f74289713e2113fc09eea4714ab3224a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810504Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697924}
-
Andrew Luo authored
Bug: 1000798 Test: testing/scripts/run_android_wpt.py --isolated-script-test-output output.json --product android_webview --list-tests Change-Id: Ic586943fbd56fa0bd7f30492f4aeab4545905bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808327 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697923}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2ad535693f0f..033994d4a3bf git log 2ad535693f0f..033994d4a3bf --date=short --no-merges --format='%ad %ae %s' 2019-09-19 rmhasan@google.com Reland "[Telemetry] Adds the --skip-typ-expectations-tags-validation" Created with: gclient setdep -r src/third_party/catapult@033994d4a3bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:999335 Change-Id: Ie209ee6a1b45f93591ad420f1fe92bb1d8129959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697922}
-
Fergus Dall authored
This reverts commit 75c556a2. Reason for revert: Broke the build. See https://ci.chromium.org/p/chrome/builders/ci/linux-builder-perf/112471 Original change's description: > vk: Fix virtual keyboard in guest mode. > > When crrev/1787601 landed, it removed some code that actually had a > side effect that caused the virtual keyboard to work correctly in > guest mode. Without the code, the virtual keyboard doesn't work anymore > so we are adding this code back temporarily as it is a high priority > issue. > > We need to investigate how things are meant to work (and how it managed > to work prior to the filesystems code). > > TBR=benwells,rhalavati,mek > > Bug: 1005083 > Change-Id: I0b393aa518299f5630582deb64f88d82e02ec0e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809033 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697917} TBR=benwells@chromium.org,mek@chromium.org,shend@chromium.org,rhalavati@chromium.org Change-Id: Ibce04c0db78b166fb7efd1a1149b7b272f172785 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810152Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697921}
-
Donn Denman authored
The top_round nine-patch has both a dark and light version. The dark version should automatically be used only for dark, but it's being applied to both light and dark. This CL moves the dark version to the correctly named directory in order to fix the automatic switching for night mode. BUG=1004958,1004907 Binary-Size: +19,628 bytes normalized apk size. Change-Id: I41b9fabd1c210448a7f74784e7c41b0e50351797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809997 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697920}
-
Maksim Sisov authored
It is not guaranteed that move/resize handler is set by a PlatformWindow. Thus, remove the DCHECK and add if (handler_) condition as part of the existing condition to dispatch move/resize requests. Bug: 990756 Change-Id: Ibfa1251f65af547382f04d44fdef28d620c0bdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807311Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#697919}
-
Timothy Loh authored
This CL adds engagement metrics for Plugin VM, using the engagement metrics logic that has been recently factored out of components/arc. The new metrics, PluginVm.EngagementTime.*, behave similarly to the existing Arc.EngagementTime.* metrics. Bug: 990252 Change-Id: Id4cee250146ce4af3626a970e91c1c623d915b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798075 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#697918}
-
Darren Shen authored
When crrev/1787601 landed, it removed some code that actually had a side effect that caused the virtual keyboard to work correctly in guest mode. Without the code, the virtual keyboard doesn't work anymore so we are adding this code back temporarily as it is a high priority issue. We need to investigate how things are meant to work (and how it managed to work prior to the filesystems code). TBR=benwells,rhalavati,mek Bug: 1005083 Change-Id: I0b393aa518299f5630582deb64f88d82e02ec0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809033Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#697917}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5c22372c471a..bb1e6a5282eb git log 5c22372c471a..bb1e6a5282eb --date=short --no-merges --format='%ad %ae %s' 2019-09-19 vapier@chromium.org paygen: avoid str decode/encode with non-utf-8 values 2019-09-19 vapier@chromium.org buildbucket_v2: fix comparison to None Created with: gclient setdep -r src/third_party/chromite@bb1e6a5282eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6dd54ac95e3b83daf26534f06ff7ac261db8d447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697916}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6dba771b596..7159b782fa4e Created with: gclient setdep -r src-internal@7159b782fa4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:996088,chromium:b/139510801 Change-Id: I5d16d4384304dca9518d8bbc4d8e3e4163c85b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812493Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697915}
-
nancy authored
Launch_util is used to wrap the ChromeLauncherController's LaunchApp function for AppService to launch apps. Now AppService can launch apps directly, and no longer depends on ChromeLauncherController, so launch_util can be removed. BUG=1002351 Change-Id: I411186e398f79f0e0cc13b25946e2feea5512d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810516Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#697914}
-
Luciano Pacheco authored
Manually migrated. Since this file has been donated to Files app and we're the only users I've removed AutocompleteListItem since we have it completely replaced in search_box.js thus wasn't been used. Test: Manually and browser_tests --gtest_filter="Search/FilesApp*" Bug: 778674 Change-Id: Ibcfbc9fc1439fdfe5d81c02b4294ef47aeea7b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807642 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697913}
-
Yang Guo authored
Until now, when debug_devtools=true, --custom-devtools-frontend can be used to specify a file path for requests to devtools://bundled/, or a URL for requests to devtools://custom/. When debug_devtools=false, only the latter works. This change allows --custom-devtools-frontend to specify a file path for requests to devtools://bundled/ while debug_devtools=false. Change-Id: I4672ce22b53ae6fa91852bb0463c11db50f5af3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791150Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e2a903e18b59..12f8680a1e73 git log e2a903e18b59..12f8680a1e73 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 mtklein@google.com fold srcover coverage with SkVMBlitter Created with: gclient setdep -r src/third_party/skia@12f8680a1e73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ife04adebd47037a30962be8e6043de7c81941933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697911}
-
Wei Lee authored
This CL adds IsTabletMode() so that CCA could handle different behaviors under clamshell/tablet mode accordingly. In addition, this CL also moves CameraAppHelperImpl into components/chromeos_camera since it has nothing to do with video capture logic. Bug: b:140273786 Test: Manually tested and CCA works expectedly Change-Id: Ief04ea06ec93584d9140e9fa4e385f300e3f4419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787485Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#697910}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/86314cfb5dc0..bd2426079126 git log 86314cfb5dc0..bd2426079126 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision eae7ecf7..afdb2e7a (697744:697871) 2019-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 65274319..eae7ecf7 (697640:697744) 2019-09-18 srte@webrtc.org Using struct for bitrate allocation limits. 2019-09-18 srte@webrtc.org Only handle each RTCP once. 2019-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2bd75c72..65274319 (697505:697640) 2019-09-18 nisse@webrtc.org Delete almost all default methods on PeerConnectionInterface 2019-09-18 philipel@webrtc.org Removed unused include from PacketBuffer. 2019-09-18 danilchap@webrtc.org Introduce integer division helpers with non-default rounding 2019-09-18 eshr@google.com Revert "Fix minor regression caused by a8336d3" 2019-09-18 mbonadei@webrtc.org Remove webrtc::MinPositive from api/. 2019-09-18 kron@webrtc.org Add max/min encode bitrates to video config of peer connection tests 2019-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 51a08089..2bd75c72 (697405:697505) 2019-09-18 mbonadei@webrtc.org Remove api/bitrate_constraints.h. 2019-09-18 mbonadei@webrtc.org Update style guide for absl::make_unique. 2019-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 31d9542a..51a08089 (697288:697405) 2019-09-17 srte@webrtc.org Replacing local closure classes with C++14 moving capture lambdas. 2019-09-17 srte@webrtc.org Reusing MediaStreamAllocationConfig struct in ObserverConfig. Created with: gclient setdep -r src/third_party/webrtc@bd2426079126 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:1002875,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I0395a7f4e571c89a03c73d90ca8730becd6cd53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697909}
-
Alex Danilo authored
If we don't store the expand/collapsed state of the summary panel, new progress panels may be hidden when they're added to the display panel parent (see bug). Changes the summary panel expand/collapse button to remember its setting between destruction and re-creation of the summary panel. Creates the progress panels detached from the DOM and attaches them to the DOM after the attach timer fires, replacing the use of 'hidden' which caused the CSS :only-child selectors to fail to match when panels were hidden. Added unit test for persistence of expanded state. Bug: 994967, 998183 Tests: browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Change-Id: I814a8a0e429c46b07c5225d73b3c9828c1e21115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802898Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697908}
-
Xiaohan Wang authored
When unexpected failure happens, we expect the service to stay in a valid state. Bug: 1004730 Test: Manually tested Change-Id: Ib35035705e4604b9aa8cf5212de07bc1069e73d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810846 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#697907}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I7dd093f807336779d2dd25eae16ab8b1843f5136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802895 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#697906}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/550e29b59884..5c22372c471a git log 550e29b59884..5c22372c471a --date=short --no-merges --format='%ad %ae %s' 2019-09-19 vapier@chromium.org cros_build_lib: drop unused GetChromeosVersion Created with: gclient setdep -r src/third_party/chromite@5c22372c471a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I5778ab753c72940734abeb553ab3c1974f8a7ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697905}
-
Koji Ishii authored
These tests fail because there's no active plan to implement to force `direction: ltr` if `text-orientation: upright` is specified. TBR=eae@chromium.org NOTRY=true Bug: 1005518 Change-Id: I86e74072923e09b8c473d5accfb7546146a43297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809007Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#697904}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1473a36d23f9fdd756b2ae25a63e3e4697b636e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697903}
-
Noel Gordon authored
Remove "TODO(crbug.com/868747): Find a better solution for demo mode", since 1) the better solution is unknown and 2) the current solution is working fine. Comment-only change. No-try: true Bug: 868747 Change-Id: I315fe8d9f5cba4ae35ebae35638ddac182732540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809026Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#697902}
-
Miyoung Shin authored
This CL converts PowerMonitor{Ptr, Request} in services and content to the new Mojo type. Bug: 955171 Change-Id: I189523bfe34393600577718972bab686ead60312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808629 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#697901}
-
Wei Lee authored
This CL does the following changes: 1. Makes DeviceOperator a singleton instead of passing MojoConnector 2. Removes the MojoConnector 3. Checks if the device support DeviceOperator on a separate method 4. Gets CameraAppDevice upon usage rather than when initialization Hopefully, having these changes, CCA could: 1. Don't need to reset the connection actively when the stream is off 2. Don't need to pass MojoConnector to the components who need to use mojo 3. Don't need to handle plug/unplug events for mojo connections To avoid crashing the camera tests, the corresponding tast changes should be merged before this CL: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1788772 Bug: 979104 Test: Run CCA and it works normally Change-Id: Ic38d8dd4ce4733153d1edc8240015396a733034e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787022Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#697900}
-
Klaus Weidner authored
This reverts commit b5a76458. Reason for revert: blamed for performance regression: https://crbug.com/1005368 The graphs look fairly unambiguous that this CL is at fault. Original change's description: > Ensure that detached GraphicsLayers trigger invalidation > > GraphicsLayers in this state will not have GraphicsLayer::Paint called on them, > and Paint updates the GraphicsLayer's display item's references back to the > layout tree. > > Bug: 991747 > Change-Id: I468c0b691fdc8c85414e56dcc6c8a733e666ccc3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802823 > Commit-Queue: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696449} TBR=pdr@chromium.org,klausw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 991747 Change-Id: I3af1ffa4db9f7b83d20503b63c3df31d1ea159e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810455 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#697899}
-
Alexandre Courbot authored
Currently the accelerated video decoding capabilities are only probed once, during the GPU process early startup. This effectively prevents any decoder device that spawns after to be considered for accelerated decoding, as can happen when the decoder driver is built as a module, or takes some time to complete probe. Fix this by probing the capabilities each time GetDecoderCapabilities() is called, until a valid result is returned. This is not the optimal solution (that would be re-scanning capabilities when udev events signal us that a decoder device has been added/removed), but works well for most purposes and does not introduce any extra overhead after the decoder devices have appeared. Furthermore this is only relevant for V4L2 devices and won't affect VAAPI platforms. Bug: 948147 Bug: 1000149 Test: Accelerated video decoding working upon booting veyron-minnie_kernelnext. Change-Id: I40c395186ddd4c7201ec7a28ec0b97cea8ca6149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782179Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#697898}
-
Trent Apted authored
Per the line in src-internal/DEPS which says # When adding a new dependency, please update ../src/.gitignore to list the # dependency's destination directory. src-internal/DEPS change coming in http://crrev.com/i/1646974 Bug: 996088 Change-Id: I4f48926c95a2a3c4ef2cd0e0f52c1f590c43049d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812517 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Auto-Submit: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#697897}
-
Kent Tamura authored
This is a reland of 52d70a63 Difference from the original CL: Add *.mojom-blink.h to 10 *.cc files. It seems the original Cl collided with another CL. Original change's description: > Remove *.mojom-shared.h from web_url_response.h > > This CL reduce the estimated pre-processed size of web_url_response.h > from 2.42MB to 0.91MB. > > Bug: 242216 > Change-Id: Ia95b04b7ef33e9a961a69522fb566c0649a4b7a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810119 > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697833} Tbr: jrummell@chromium.org Bug: 242216 Change-Id: I11c28e6bce2ea935b706235d3e268e1c3f4d7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812518Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697896}
-
Miyoung Shin authored
This CL converts SerialPortManager{Ptr, Request} in services, chrome and extensions to the new Mojo type. Bug: 955171 Change-Id: I548c09f2e0b28fea23ac83ddf630a271c7554c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810439 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697895}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f2ea8b465ed..bf4268a3963b git log 2f2ea8b465ed..bf4268a3963b --date=short --no-merges --format='%ad %ae %s' 2019-09-18 aukinros@microsoft.com Fix misc VS2019 bool conversion warnings Created with: gclient setdep -r src/third_party/angle@bf4268a3963b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I888fa86ccdfcd87bddb29c42b9f572d0e2d88451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697894}
-
Zhenyao Mo authored
BUG=1005593 TEST=bot TBR=kbr@chromium.org Change-Id: I775dbee764c8dfb1327d72ad14b8a1d78b9c4e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812247Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697893}
-
Justin Cohen authored
Due to an unrelated issue, it's possible for about:// urls to be written as an empty url. Because an empty forward or backwards item will return an empty URL, it was possible to associate to a nil WKBackForwardItem and crash. Bug: 1005211 Change-Id: I2becd93a8d35cde0f1a68fc2ac3da6853c023392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810803 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#697892}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I8fb836bc8f693fa35db38d9d50cd2368711463f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812004Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697891}
-
Ionel Popescu authored
This CL introduces selected and today states for months. These states are similar with the existing ones for day cells. A new test is introduced to test the new UI: month-picker-appearance-highlight. Bug: 1003625 Change-Id: Ic4107a6bf8c2d1de14e16db75ea5c8273dd7025a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808427 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697890}
-
Xinghui Lu authored
Key events are not triggered through InputEvent on Android. Add ime_text_committed_observers_ so that string from soft keyboards can be captured. By capturing strings from ImeTextCommitted events, password reuse detector can combine these strings together, and compare them with saved passwords. Bug: 1004842 Change-Id: If63fb94d6ab2a72b41da6f92f08c15655530942c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808331 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697889}
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was incorrectly returning false from IsPlatformDecoder(). Change-Id: Ic845733de35a1e411ae54fe6379085c9581ddb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809981 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697888}
-
Ionel Popescu authored
This CL updates the in-page UI for input type="time" by adding a time icon which will be used in order to open the popup. The new UI is tested by: time-appearance-basic.html The popup support for input type="time" will be added in future CLs. Bug: 1004997 Change-Id: I5dcea5bfd75c2e815565b38d1fa51a73164cb673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810057 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697887}
-
Chih-Yu Huang authored
This CL adds a fieldtrial testing config for ChromeosVideoDecoder, that plans to turn on for all versions 79+. Bug: 984482 Change-Id: I729bb26bb719e9cc6112c89e363fd44c4b45a52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810510Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#697886}
-