- 30 May, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa9ffcc40fdf..2b04c2678004 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tguilbert@google.com Change-Id: I061a90de15f1044d605ea8e842f2bab1943b1b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223772Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773506}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3e3590bcab7eeb75c2c9cf3dd00316beceaadebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223812Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773505}
-
Rohit Rao authored
BUG=None Change-Id: Ief6a5d9bea6e82ddb470eeb5f0d99b338d73eecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219298Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773504}
-
Jian Li authored
Move it to a shared place in preparation for feed v2. Most changes are just cosmetic changes due to namespace change. Bug: 1044139 Change-Id: I5947303a8c4f231474bc9b847fef9cd5b42681e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220281 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#773503}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590810201-06f28a7be3de7d951c3b553f18cf609292097c94.profdata to chrome-mac-master-1590824392-39576eb011a69504935802629d3d0b8201ba913b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I0a3fc007dc460afc61304335716c2b9128ef17a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f87369803432..aa9ffcc40fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tguilbert@google.com Change-Id: I7a80fc02142aae3292fd9867c4a1d5db98a14a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223533Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b77b1e7be85a..f87369803432 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tguilbert@google.com Change-Id: Ie0c4f760ef2a1bcfe2625127f3042dca0e24322f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222833Reviewed-by:
-
Dominic Battre authored
The matcher for gift cards only applied to labels and names of <input type="text"> elements. This CL expands the matching to number and telephone fields as these may be used to enter gift card numbers. Bug: 1087428 Change-Id: I2b3026d5ebcea3c9d8b9253e74c22e2e4309425d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220089Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#773499}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/821dfc87..f3c6b81d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iade85d21e1797e8ee4512e591d177dc827340487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222149Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773498}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0c3936fdaa36..00cba8379e76 2020-05-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3cb62c9229cf4f82bf5d06ac36457f02189c6921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223490Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a34aff3e6a2..25a8404bd150 2020-05-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I074ab5b9dcc2fc92ba018811ff2b5a5f52fad51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223486Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590796250-b3461b249708d33828770ae0c197f87c91907bdc.profdata to chrome-win64-master-1590810201-d72791d9a5aaf97e5ddaed6b09ba65d38c7bcdf5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idf4bcd7788ba71db447d60ab7e8ccdb10971165e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223483Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/998524a08e08..85b288b0ff85 2020-05-30 jianj@google.com av1: enable error resilient, set max intra rate and disable order hint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I136058935396d05f721267c31eb33b450dc0796b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223482Reviewed-by:
-
Daniel Hosseinian authored
Revival of crrev.com/c/1931439 by tsepez@. Init() is only called on newly created instances, so there's no way for |engine_| to be created before Init() is called. Instead of conditionalizing the creation of |engine_|, assert that it hasn't been created yet. Bug: 852273 Change-Id: Id919a9fc9bcf23ee8d66e81fbfd745c164da87cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207740 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773493}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590796250-74b228909d9af360d9feacdaef5abc93a2fb2bb4.profdata to chrome-mac-master-1590810201-06f28a7be3de7d951c3b553f18cf609292097c94.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idbebf2c6398f1ef9edec85e48df22dc2bc07dad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223480Reviewed-by:
-
Daniel Hosseinian authored
Use a feature flag to allow for runtime switching between the existing and new behaviors. When |chrome_pdf::features::kPdfHonorJsContentSettings| is disabled, JavaScript will be allowed to execute regardless of the content settings. Bug: 696650 Change-Id: Ifc45058e8dffd579952added95ac0c4630cbf350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202973 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/835bc1e24cab..b77b1e7be85a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tguilbert@google.com Change-Id: I5d89ac82d91e85a1be477e1691f59943bd2ee465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223476Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c4ceefd..821dfc87 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id2eb80953ff40ca634c410001f09d93555ee9177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222983Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/adf56e58b7f6..c3c996848cca 2020-05-30 dberris@chromium.org auto-triage: Re-intruduce projectId in body 2020-05-30 dberris@chromium.org auto-triage: Fix handling of empty project If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1088150 Tbr: nuskos@google.com Change-Id: I9cde6e1179072757fe64933799fbd0ae001a8304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223479Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/808557b0b09e..0c3936fdaa36 2020-05-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I23b7aea92560f90dc246b5cb03c6cc471bc6c48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223475Reviewed-by:
-
Daniel Hosseinian authored
JavaScript content settings in PDFs can be verified by testing whether the JavaScript in a PDF can successfully "beep." Add tests that are able to record a "beep" regardless of the content settings. In doing so, re-enable PDFExtensionJSTest.NoBeep as PDFExtensionContentSettingJSTest.NoBeep with the incorrect behavior. Create parameterized tests that are able to enable/disable the feature flag that controls whether JS content settings are honored in PDFs. The current behavior of the tests should not be impacted by the parameter. Two of the tests try to alter the content settings between the initialization of two same-origin PDFs. Bug: 696650 Change-Id: Ie62abc66cc2ba671f250f98bde7aa9b2fb132980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202972 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I847a6476812ebd6df5af740304f2340a60990c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223478Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9c6f6bf031b4..7a34aff3e6a2 2020-05-30 bsalomon@google.com Fix older chromeos tuple constructor deduction error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I785fb592a192d115330a01f006b522ebf9bb4d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223474Reviewed-by:
-
Peter Kotwicz authored
This CL: - Merges CustomTabActivityComponent and WebappActivityComponent into BaseCustomTabActivityComponent - Merges CustomTabActivityModule into BaseCustomTabActivityModule - Moves ChromeActivity#createComponent() implement to BaseCustomTabActivity. BUG=985328 Change-Id: I6c12a63ba405d055804262d904b5cd331cd26996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217859 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#773483}
-
Daniel Hosseinian authored
Add |chrome_pdf::features::kPdfHonorJsContentSettings| and the corresponding UI in chrome://flags for enabling whether JavaScript content settings get honored in PDFs. The flag does not do anything yet. Bug: 696650 Change-Id: Icaf97474617ad56ebc93c2e419e90b12c5385aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203480 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b41a5cec3d7c..99044852de36 2020-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Id6b0bb53a94f50e8f2739937d1a61d633f54d5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223473Reviewed-by:
-
Wan-Teh Chang authored
Remove the comment for the ImageDecoder::FilenameExtension() method that I added in commit 8d8bd398. Change-Id: I1f64e14d06bb934af1c5b8822212158d5db0b4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219593Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773480}
-
Sammie Quon authored
This reverts commit 3abaa7f0. Reason for revert: Causing crash in some builders. See https://bugs.chromium.org/p/chromium/issues/detail?id=1088169. Original change's description: > wm: Improve cross fade animation. > > *Destroy old layer when new layer animation is aborted. > *Only log histograms once after animation. > > The old layer is owned by a observer which does not know when the new > layer is being aborted. Change this so that the observer observers the > new layer and destroys the old layer accordingly. > > The pass animations reporter will be used for every LayerAnimationElement, > for cross fade, we animate opacity in addition to transform when the old > bounds is wider than the new bounds. This results in double counting, > which skews the smoothness numbers as animating two properties should be > slower. > > Test: manual, ash_unittests WindowAnimationsTest.CrossFadeHistograms > Bug: 868170, 1087460 > Change-Id: I3bc5b597e8109a3e87f432f6aa352ba94860f8ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218557 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773397} TBR=oshima@chromium.org,sammiequon@chromium.org Change-Id: I405285224a5e314db90a07c23f12e87d4da3fafc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868170, 1087460, 1088169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223375Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#773479}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9a675a8cf9c..835bc1e24cab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tguilbert@google.com Change-Id: Ib89841e36323f5fb4245010615d26892178cce50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223117Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4b9f3369fd901d5b5209858ab291f360d93c684a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223125Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590767663-bfa6fb46c573202b6713bcacc5afb7fbf40f8033.profdata to chrome-win64-master-1590796250-b3461b249708d33828770ae0c197f87c91907bdc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I986f6c9dd91509d147ec850a368bfaaa0662c18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223114Reviewed-by:
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/3478eafd05e3..b5399f70d477 Also, update RecoverModuleTest integer expectations for sqlite v3.32.1. This behavior changed between sqlite v.3.31.1 and v3.32.1. $ git log 3478eafd0..b5399f70d --date=short --no-merges --format='%ad %ae %s' 2020-05-28 huangdarwin Amalgamations for release 3.32.1 2020-05-25 drh Version 3.32.1 2020-05-25 drh Extra assert() statements in the printf() logic. 2020-05-25 drh Defensive code that tries to prevent a recurrence of problems like the one described in ticket [7a5279a25c57adf1] 2020-05-25 drh Fix minor compile issues with optional extensions. 2020-05-25 drh Make sure variable declarations are at start of scope even when SQLITE_ENABLE_SNAPSHOT is used. 2020-05-24 drh Version number to 3.32.1. 2020-05-24 drh When rewriting a query for window functions, if the rewrite changes the depth of TK_AGG_FUNCTION nodes, be sure to adjust the Expr.op2 field appropriately. Fix for ticket [7a5279a25c57adf1] 2020-05-24 drh Move some utility Walker callbacks into the walker.c source file, as they seem to belong there better. 2020-05-24 drh Improvements to parse-tree tracing logic. No changes in deliverable code. 2020-05-24 drh Minor fix to a comment. No code changes. 2020-05-23 drh Limit the "precision" of floating-point to text conversions in the printf() function to 100,000,000. Fix for ticket [23439ea582241138]. 2020-05-23 drh Improved bytecode comment. 2020-05-22 drh Version 3.32.0 2020-05-21 drh Change a NEVER macro into a NO_TEST comment, as the conditional is reachable, but only when compiling for Windows 32-bit. 2020-05-21 dan Avoid another potential OOB read in sqlite3expert.c. 2020-05-20 drh Back out the change from [7fab1393c2b22b1f] that tries to convert invalid surrogate characters in UTF16 into the replacement character 0xfffd, as we find that this breaks some software. 2020-05-19 drh Add compiler hints to disable TSAN for the routines that access the -shm file header in WAL mode using a double-read with memory barrier. 2020-05-19 dan In os_win.c, avoid calling sqlite3_uri_boolean() on anything other than a main-db filename. 2020-05-19 drh User-suggested improvement to the README.txt for the ICU extension. 2020-05-19 drh In wal.c, improved comments on concurrency issues. More use of AtomicLoad() and AtomicStore(). 2020-05-18 dan Add vdbevtab.lo to build of libsqlite3.lib in Makefile.msc. 2020-05-17 drh Avoid harmless UB in memcpy() in the JSON extension. 2020-05-17 drh Use the sqlite3Realloc() interface internally, rather than the public sqlite3_realloc64() equivalent, to avoid unnecessary calls to sqlite3_initialize(). 2020-05-16 drh Performance optimization for the sqlite3FindTable() subroutine. 2020-05-16 drh The OP_RealAffinity opcode is not necessary after reading values from a virtual table (such as rtree). It is harmless, but it does use CPU cycles. Might as well leave it off. 2020-05-16 dan Fix a use-after-free bug in the fts3 snippet() function. 2020-05-16 drh Extra memory barrier during initialization. 2020-05-16 dan Add sqlite3BeginBenignMalloc() and EndBenignMalloc() calls to debugging function sqlite3VdbePrintOp(). 2020-05-15 dan Update code in sqlite3expert.c to account for the fact that "-- TRIGGER xyz" VM comments are now omitted for some builds. 2020-05-15 dan Fix another build problem for SQLITE_OMIT_VIRTUALTABLE builds. 2020-05-15 drh Fix a documentation typo. No changes to code. 2020-05-15 drh Adjust some requirement marks. No changes to code. 2020-05-15 dan Update test file e_fkey.test to account for the fact that new columns with REFERENCE clauses and non-NULL default values may now be added using ALTER TABLE if the table is empty. 2020-05-15 dan Fix SQLITE_OMIT_VIRTUALTABLE testfixture builds. 2020-05-15 dan Test script changes to account for the fact that the "p5" column in the EXPLAIN output is now an integer, not a text values containing a 2-digit hex value. 2020-05-15 mistachkin Enhancements to long-path support in the Win32 VFS. 2020-05-15 drh Move some new test cases from fts3snippet.test into fts3snippet2.test. 2020-05-15 drh Add the SQLITE_ENABLE_FTS3_PARENTHESIS option to fuzzcheck. Add a new test case that uses that option. 2020-05-14 drh Fix a null pointer deference that can occur on a strange matchinfo() query. 2020-05-14 drh Do not allow a virtual table to be renamed into the name of one of its shadows. 2020-05-13 drh Implement the IIF(x,y,z) SQL function that is short-hand for "CASE WHEN x THEN y ELSE z END". For compatibility with SQL Server. 2020-05-13 drh Remove unused constant SQLITE_FUNC_COALESCE. 2020-05-13 dan Use AtomicStore() and AtomicLoad() in a few more places to avoid a theoretically undefined behaviour. This is not actually problem on any known hardware. 2020-05-11 drh New test case in test/fuzzdata8.db. 2020-05-11 dan Fix a problem handling constant integer expressions with collation sequences in PARTITION BY clauses. 2020-05-08 drh Release some restrictions on columns added by ALTER TABLE so that they only apply if the table contains one or more rows. 2020-05-08 drh Fix the count-optimization so that it honors the NOT INDEXED clause. 2020-05-08 drh New test cases added to test/fuzzdata8.db. 2020-05-08 drh Do not retry on a failed realloc() unless SQLITE_ENABLE_MEMORY_MANAGEMENT is available, meaning that the retry has some possibility of success. (...) 2020-02-24 drh Disable the new analyzeG.test module if not building with STAT4. 2020-02-23 drh Fix a problem with ALTER TABLE for views that have a nested FROM clause. Ticket [f50af3e8a565776b]. 2020-02-22 drh Do not activate the truthProb adjustment mechanism if the truth probability is less than the heuristic value, as there could be correlations unknown to stat4. Also add additional tracing output to make truthProb adjustments more visible. 2020-02-22 dan Add new test file analyzeG.test, containing a test for the change on this branch. 2020-02-22 drh When stat4 information is available, try to use it to improve the truth probability of WHERE clause terms that do not participate in the index. 2020-02-22 drh In the OP_Column opcode, if the cursor is marked NullRow (due to being the right table of a LEFT JOIN that does not match) and the cursor is the table cursor for an OR-optimization with a covering index, then do not substitute the covering index cursor, since the covering index cursor does not have the NullRow flag set. Ticket [aa4378693018aa99] 2020-02-20 dan Add test case for previous commit. 2020-02-20 drh Early-out on the INTERSECT query processing following an error. 2020-02-19 drh Fix a potential NULL pointer dereference following OOM. Problem discovered by dbsqlfuzz. Test case in TH3. 2020-02-18 drh Remove a NEVER() macro and add a test case to cause its argument to be true. 2020-02-18 drh Add the new sqlite3_create_filename() and sqlite3_free_filename() interfaces for use by Shims. Use these interfaces inside the multiplexor. 2020-02-17 drh Convert invalid surrogates to 0xfffd when translating UTF. 2020-02-17 drh A better (smaller and faster) solution to ticket [4374860b29383380]. 2020-02-17 drh Take care when checking the table of a TK_COLUMN expression node to see if the table is a virtual table to first ensure that the Expr.y.pTab pointer is not null due to generated column optimizations. Ticket [4374860b29383380]. 2020-02-16 drh Avoid an infinite recursion on an illegal recursive definition of an fts5vocab table. 2020-02-13 drh Fix problems in the constant propagation optimization that were introduced by check-in [1c3e5c20a9e6f501]. Fix for ticket [1dcb4d44964846ad] 2020-02-13 drh Disallow the skip-scan optimization in the absence of sqlite_stat1 data. 2020-02-13 drh Omit O_NOFOLLOW from the open() call when opening /dev/null, since /dev/null is a symlink on Solaris, we are told. 2020-02-13 drh Fix an incorrect assert() statement that was added yesterday. Tickets [41c1456a6e61c0e7] and [fb8c538a8f57ae2a]. 2020-02-12 drh Increase the default upper bound on the number of parameters in a single SQL statement to 32766 (from 999). 2020-02-12 dan When determining whether an == or IS constraint in a WHERE clause makes an ORDER BY term redundant, consider the collation sequence used by the == or IS comparison, not the collation sequence of the comparison expression itself. Possible fix for [fb8c538a8f]. 2020-02-10 drh Mark the sha1() extension function as SQLITE_DETERMINISTIC. 2020-02-10 drh Fix the build for when SQLITE_VDBE_COVERAGE is used. 2020-02-07 drh During byte-code generation, strive to avoid jumps that merely jump to the following instruction. 2020-02-07 drh Simplify the code by removing the unsupported and undocumented SQLITE_HAS_CODEC compile-time option 2020-02-06 drh There is no need to keep track of the number of changed rows or of the last-insert-rowid while running VACUUM. 2020-02-06 drh Unroll the comparison loop inside keywordCode() for to avoid unnecessary comparisions and thus help that routine run faster. 2020-02-06 drh Separate OP_IdxInsert and OP_SorterInsert into completely separate opcodes, helping each one to run a little faster. 2020-02-06 drh Remove dead code from the sqlite3_filename_database() function. 2020-02-06 dan Fix some fts3 problems found by usan. 2020-02-05 drh Small size reduction and performance improvement in the sqlite3VdbeMemFromBtree() interface used to pull content out of the b-tree and into an sqlite3_value object. 2020-02-04 dan Enable more detailed log messages in SQLITE_ENABLE_CORRUPT_PGNO builds if database corruption is encountered. 2020-02-04 drh Extend the OP_Copy-coalesce optimization fix of check-in [b36126c1889e323c] so that it is also correctly disabled by the CASE operator. Ticket [9d3666754ac37d5a]. 2020-02-04 drh Fix a problem with the byte-code decompiler that was inserted by the enhancements at [4248980a356f659b] 2020-02-03 drh Cosmetic change to the xfer-optimization to put the OP_RowData opcode closer to the corresponding OP_Insert opcode. This makes it slightly easier to read and understand the code. 2020-02-03 drh Increase the version number to 3.32.0. 2020-02-01 drh On an INSERT or UPDATE, perform affinity conversions on new data prior to running CHECK constraints. Ticket [86ba67afafded936]. 2020-02-01 drh Fix the comment display for the OP_Function opcode. And at the same time, improve the comment generating logic to make use of the newer sqlite3_str_appendf() interface. 2020-02-01 drh Fix a problem in sqlite3CodecQueryParameters() that was introduced by the query parameter encoding changes for the 3.31.1 release. 2020-01-31 drh Fix a minor typo in a comment in the btreeinfo extension. 2020-01-29 dan Fix a problem with the processing of IN(...) constraints handled by virtual table implementations that do not set the "omit" flag when the virtual table column contains at least one NULL value. 2020-01-29 dan Add a test case for commit [ffd8bb93]. 2020-01-29 drh Remove a NEVER() that is in fact reachable. Test cases in dbsqlfuzz and TH3. 2020-01-29 drh Add new memory barriers during initialization. 2020-01-29 drh Modify a couple of FTS test cases so that they work on big-endian platforms. 2020-01-28 drh Faster decoding of 32-bit variable-length integers in cases were we do not need to know the number of bytes in the encoding. 2020-01-28 drh Small performance improvement to the key-comparision routine for strings. 2020-01-28 drh Reinstate the optimization of converting "a IN (C)" into "a=C" but only if C is a constant. If the RHS is a table column, the complications of managing affinity and collations become too involved to mess with. 2020-01-28 dan Fix a 4 byte OOB read in test_multiplex.c. 2020-01-28 drh Minor change for compatibility with the s390 architecture. Created with: roll-dep src/third_party/sqlite/src Bug: 1087629 Change-Id: Ic27525b0b6d4011b77b096651a318358c5df14cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222913 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773475}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590753475-bbc6db949b849f1149739200ccf06d1d537d4988.profdata to chrome-win32-master-1590796250-568423888065d5ed151769ff6455cd6ccf5d0427.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibd4bacc0cecbbfa9e09f5e87e6f10df12c19c5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223366Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3e1e10875278..b947498bee02 2020-05-29 jmadill@chromium.org Vulkan: Clean up VMA wrapper classes. 2020-05-29 jmadill@chromium.org Vulkan: Pass vk::Context to BufferHelper::init. 2020-05-29 lehoangq@gmail.com Metal: draw 1 triangle instead of 2 for fullscreen shaders. 2020-05-29 jmadill@chromium.org Set gl::Buffer to zero size when allocations fail. 2020-05-29 lehoangq@gmail.com Metal: Use bit fields for state descriptor caching. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1086532 Tbr: ynovikov@google.com Change-Id: I4b1394b6043d86b2d04b68ef1da098802ffb5529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222794Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773473}
-
rbpotter authored
- Set feature enabled values in the toolbar directly, when strings are set, rather than doing this from the viewer. - Simplify/clean up styles in the dropdown to match them to the menu being added - Cleanups in viewer-pdf-toolbar.html Bug: 1078543 Change-Id: I4146ff642d2ea482f343149a52c00253844ed3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223153 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL changes WebappActivityTestRule#startWebappActivity() to wait till the page is loaded (as opposed to the tab not loading which also occurs prior to the tab starting loading) BUG=1081847 Change-Id: Ic49b39e49aa83428c05d9d5570076e2ec7f6bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209614 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I7472cfaf456f251a69e173a379b0f6d9f03cf856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223126Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773470}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0fc89ef94f168637c9c924c1c6dd6b39880666a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223262Reviewed-by:
-
siashah authored
Screenshots Before: https://screenshot.googleplex.com/vW68y0sfN1w After: https://screenshot.googleplex.com/b14u5Df70m2 Bug: 1082013 Change-Id: I9e177d9d7b3aef4961d11ac51db1f2c40ba78cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220557Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#773468}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b19e1213cf6f..b41a5cec3d7c 2020-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I51d4550d1ad4077ec60b9eb42f10b0db7a3e3371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223162Reviewed-by:
-
